linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Hillf Danton <hdanton@sina.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: mingo@kernel.org, vincent.guittot@linaro.org,
	linux-kernel@vger.kernel.org, rostedt@goodmis.org,
	bsegall@google.com, mgorman@suse.de, bristot@redhat.com,
	corbet@lwn.net, qyousef@layalina.io, pavel@ucw.cz,
	qperret@google.com, tim.c.chen@linux.intel.com,
	joshdon@google.com, timj@gnu.org, kprateek.nayak@amd.com,
	yu.c.chen@intel.com, youssefesmat@chromium.org,
	linux-mm@kvack.org, joel@joelfernandes.org, efault@gmx.de
Subject: Re: [PATCH 08/17] sched/fair: Implement an EEVDF like policy
Date: Thu, 30 Mar 2023 19:02:51 +0800	[thread overview]
Message-ID: <20230330110251.2947-1-hdanton@sina.com> (raw)
In-Reply-To: <20230328110354.141543852@infradead.org>

On 28 Mar 2023 11:26:30 +0200 Peter Zijlstra <peterz@infradead.org>
> 
>  check_preempt_tick(struct cfs_rq *cfs_rq, struct sched_entity *curr)
>  {
> -	unsigned long ideal_runtime, delta_exec;
> +	unsigned long delta_exec;
>  	struct sched_entity *se;
>  	s64 delta;
>  
> -	/*
> -	 * When many tasks blow up the sched_period; it is possible that
> -	 * sched_slice() reports unusually large results (when many tasks are
> -	 * very light for example). Therefore impose a maximum.
> -	 */
> -	ideal_runtime = min_t(u64, sched_slice(cfs_rq, curr), sysctl_sched_latency);
> +	if (sched_feat(EEVDF)) {
> +		if (pick_eevdf(cfs_rq) != curr)
> +			goto preempt;
> +
> +		return;
> +	}

Given deadline, the tick preempt can be replaced with a timer expiring at the EDL.


  parent reply	other threads:[~2023-03-30 11:03 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20230328092622.062917921@infradead.org>
     [not found] ` <20230328110354.641979416@infradead.org>
2023-03-30  7:53   ` [PATCH 15/17] [RFC] sched/eevdf: Sleeper bonus Hillf Danton
     [not found] ` <20230328110354.141543852@infradead.org>
2023-03-30 11:02   ` Hillf Danton [this message]
     [not found] ` <20230328110354.562078801@infradead.org>
     [not found]   ` <CAKfTPtAkFBw5zt0+WK7dWBUE9OrbOOExG8ueUE6ogdCEQZhpXQ@mail.gmail.com>
2023-04-01 23:23     ` [PATCH 14/17] sched/eevdf: Better handle mixed slice length Hillf Danton
2023-04-02  2:40       ` Mike Galbraith
2023-04-02  6:28         ` Hillf Danton
     [not found] ` <20230410031350.GA49280@maniforge>
2023-04-10  8:23   ` [PATCH 00/17] sched: EEVDF using latency-nice Hillf Danton
2023-04-11 10:15     ` Mike Galbraith
2023-04-11 13:33       ` Hillf Danton
2023-04-11 14:56         ` Mike Galbraith
     [not found]         ` <20230412025042.1413-1-hdanton@sina.com>
2023-04-12  4:05           ` Mike Galbraith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230330110251.2947-1-hdanton@sina.com \
    --to=hdanton@sina.com \
    --cc=bristot@redhat.com \
    --cc=bsegall@google.com \
    --cc=corbet@lwn.net \
    --cc=efault@gmx.de \
    --cc=joel@joelfernandes.org \
    --cc=joshdon@google.com \
    --cc=kprateek.nayak@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    --cc=mingo@kernel.org \
    --cc=pavel@ucw.cz \
    --cc=peterz@infradead.org \
    --cc=qperret@google.com \
    --cc=qyousef@layalina.io \
    --cc=rostedt@goodmis.org \
    --cc=tim.c.chen@linux.intel.com \
    --cc=timj@gnu.org \
    --cc=vincent.guittot@linaro.org \
    --cc=youssefesmat@chromium.org \
    --cc=yu.c.chen@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox