From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5B44C6FD18 for ; Wed, 29 Mar 2023 16:13:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3B04F900002; Wed, 29 Mar 2023 12:13:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 360876B0080; Wed, 29 Mar 2023 12:13:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2289B900002; Wed, 29 Mar 2023 12:13:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 133C56B007E for ; Wed, 29 Mar 2023 12:13:23 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A1DAD120659 for ; Wed, 29 Mar 2023 16:13:22 +0000 (UTC) X-FDA: 80622430644.26.E5CBF2E Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by imf14.hostedemail.com (Postfix) with ESMTP id 62B68100025 for ; Wed, 29 Mar 2023 16:13:19 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=PhNo6oG1; spf=pass (imf14.hostedemail.com: domain of lkp@intel.com designates 192.55.52.115 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680106400; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ImhKd9wl46GPQfmOSw+PHyuUGQBs429QV8QUicTagbo=; b=HXn8f1DhvIg0l77sAswexOR2YDVj/BjFcWrRPqsIOTuJpvrIKtk2RDy6eRO7fFCEl2pAQp 3TLY8PU05giMEBsNZGAtvk0MjV0rNyy5iIn6sF3wjnCp/9j8B1lFWzpTxBo+qQUfQ+/acT kC9GsL//IKgomWEPAu0WhsID+gLNhwA= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=PhNo6oG1; spf=pass (imf14.hostedemail.com: domain of lkp@intel.com designates 192.55.52.115 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680106400; a=rsa-sha256; cv=none; b=xshMdxxzgB7AgoIquIrKPSsawirdAGBKJndH8ldmLVBQS3/AJiraWPBQcWh3JyPlCM2ez6 Wbq8ds1cl1fsx2ypKhrNkZP99ig+YYh3Mn44U2/vG2G9GhFCEHQER3OT1D8OHAMddBnQho I/vDRLMauhqa479Ajpk8zl5etX4dls4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1680106399; x=1711642399; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Hps5jsYWZuWMPz8GSp0n187O/lBhXc5uhNP4MtLz8+s=; b=PhNo6oG1BLYylzdm5hCtg8t8UZ9DpoI2kcYXQXJswv+IevNIaY3e7A3z BPxnnpxlIY9OF/v2cghduCNZFV1OTbwzAbj/r3eCwzOZaIPh+BmSGokDw T7CZ/oXpyjaDufqDb7IZoFWMB+ZkGADOnnb/+KG87GeyV8YkMhQXvz95t HUqZrKMyz0fiQljJxYjTfYAJoQxg9dRoXgzPmKNeLTGpGC8+/7Z6lBSJ3 Ips3WUykiwkDJ8fu+jzJgUW2VgfkbDHDQQzn3Ran66xyTsSVu2N2BHRKv 3DiYp6J12OCWak/Ae4nXKtvhgCQdsreNgEhyEl3y6iyVE05e+9BaYN6a0 w==; X-IronPort-AV: E=McAfee;i="6600,9927,10664"; a="340947592" X-IronPort-AV: E=Sophos;i="5.98,301,1673942400"; d="scan'208";a="340947592" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Mar 2023 09:12:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10664"; a="748828855" X-IronPort-AV: E=Sophos;i="5.98,301,1673942400"; d="scan'208";a="748828855" Received: from lkp-server01.sh.intel.com (HELO b613635ddfff) ([10.239.97.150]) by fmsmga008.fm.intel.com with ESMTP; 29 Mar 2023 09:12:01 -0700 Received: from kbuild by b613635ddfff with local (Exim 4.96) (envelope-from ) id 1phYP2-000Jhk-0j; Wed, 29 Mar 2023 16:12:00 +0000 Date: Thu, 30 Mar 2023 00:11:57 +0800 From: kernel test robot To: Zi Yan , "Matthew Wilcox (Oracle)" , Yang Shi , Yu Zhao , linux-mm@kvack.org Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Zi Yan , "Kirill A . Shutemov" , Ryan Roberts , Michal =?iso-8859-1?Q?Koutn=FD?= , Roman Gushchin , Zach O'Keefe , Andrew Morton , Linux Memory Management List , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v2 4/7] mm: page_owner: add support for splitting to any order in split page_owner. Message-ID: <202303300056.N12iGUqy-lkp@intel.com> References: <20230329011712.3242298-5-zi.yan@sent.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230329011712.3242298-5-zi.yan@sent.com> X-Rspamd-Queue-Id: 62B68100025 X-Stat-Signature: h3bxks7unqey6y63wcq37zmpf19xkdow X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1680106399-401497 X-HE-Meta: U2FsdGVkX19laxyoKG4hI3O2MOHqIan+XUmm4P1PYyfYU4i3vLiyU1LYI2ukqqR2N7jK0Z2se1tepxQ2r28Af7pF8obSXGdCOArkWnkpOswyPjkA6w5EBq096SdmUfJ9qtYPw1ujGFAhzBNGfXCbAamxBaX//oymSk/iSeRMhMp7cpgx8LwNzKyOaykV8rB+XFQMUPcUzYzAmSxdHmhx4h1KxerP34czYfxb3dArHYaK5sUxhtehzuLwqw+VaTxixAHb016Jxn9n+im2j+S0BbRmx+SO3eqSBX/IwSDMdLkVCevS9iLdHda3H+OjEluyqK4lBrZw1QrrXNXXAe1zIlGiPruKZ5MkAmggD2Zhf1c5SpWRnwyL0HwGJtk9dEEe9O2RZfjoEuHNsotfUfopyY/NrZmoBSrpXzhShQmupzRSdCk00pZAdVj5VKehmsvYLKYSBC/tW6z7dEdP5m11OH/CiFE3bRvJbN2R65ZnFO2zWC+c/GW0Z9JL2xU4AxZGHAhL9PRhnavXbUhM/BzH3Dc5HAXYlyKQsvwM9WoS/pdDvn+/gSC+plyvLkU9w7NOz8fbnjeowwy/sGsEOz/+F9e/nNohM+pQtYAVm79od081OPzsbIrrYUFqTxKk8wKwv1FFZC8w8MRMJUeWtGv/7kbocQrlvRux3CPJRMErXEpPxVdJpoGaUwZ4jy2JbK4lunwjHSO7jtVqP0KuyCPwlTbTpmLIuObBRYaBqdsB0CedwLBzgCVOGcM2BPqiLz5lndJftfx2G9eIqPL9B7+RwciNFQwPBKSdoJ55mXRJnvlUNh5v5T1GbySZzaTNk37S2QgHeP1BfXRCZmdJCe0e8pT+e7vjfyL1FzWy9vacwcfvCHkez0PfigzXJPJC+MqXDcr3VI3Ox2gP6TrIBDjE5sI/Y1o8qCon5q9mabsQuh8nNQ/xIkFmJOnJG+qPrg9ZRp+DxuJkUAGrcUdUvye 3j9V3+zG D1G4TksZdPm66Mw5PEveekV/Ig3F2sY5tFZ2z+tCOx1d9ppk8GorktEH3/P/Bx4jd/JXrjLZ2ZBSfzDygJi4nNgilcENkVcG1Zex/WKs61yOpKSwQibdce/dXFdSXgl93Yjo/lPbFRY255vFEZlpcXfSx7iHsO2R7SSvytB8NZaSlMDDUMbrJE1iQ+PrG6ZauC2+ADTE+5UsCTtoAP0uPcuhoP4euqdF4YViD1laGSZ4TY4p1hUSLJEetkZVMX4wkFNPIScZ08ltX4OpLfdsVnRhyT7Z7XOniz9zB1XoHpwwWUeN70ZSPWduiO8y9oFNS4b4tDLSFdqfBGE6yOHiaTWh45+yphLz3p98L2dLTATYR/Hpkc2tYeHqaBBrleMfWjmVMGMZtXBn7WgXqFxANP4EjAkxxJxvyPe5b8lO0cvXI/iXu1RuIQRDBLJX6CsxThyh661I1Glg6grX1HvMCzv+CS6N0vx9wTIk84lMPLRDDm7MlRt9qZwToH2sIO2m0xX7+Msoc3tfYbYT2yyuKR1mqyIm4tNaHdvsMmsX007z1j0FvJAMBx4OFCrHKqpub8TOD2pHD8M+APu34tTq65ak5AoN+MtRnBbiEO7DcCJCEExk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Zi, Thank you for the patch! Yet something to improve: [auto build test ERROR on akpm-mm/mm-everything] [also build test ERROR on linus/master v6.3-rc4 next-20230329] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Zi-Yan/mm-memcg-use-order-instead-of-nr-in-split_page_memcg/20230329-091809 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything patch link: https://lore.kernel.org/r/20230329011712.3242298-5-zi.yan%40sent.com patch subject: [PATCH v2 4/7] mm: page_owner: add support for splitting to any order in split page_owner. config: riscv-buildonly-randconfig-r006-20230329 (https://download.01.org/0day-ci/archive/20230330/202303300056.N12iGUqy-lkp@intel.com/config) compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project 67409911353323ca5edf2049ef0df54132fa1ca7) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install riscv cross compiling tool for clang build # apt-get install binutils-riscv64-linux-gnu # https://github.com/intel-lab-lkp/linux/commit/6d1831c0e01a1a742e026454fe6e5643e08c5985 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Zi-Yan/mm-memcg-use-order-instead-of-nr-in-split_page_memcg/20230329-091809 git checkout 6d1831c0e01a1a742e026454fe6e5643e08c5985 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=riscv olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot | Link: https://lore.kernel.org/oe-kbuild-all/202303300056.N12iGUqy-lkp@intel.com/ All errors (new ones prefixed by >>): >> mm/page_owner.c:226:14: error: call to undeclared function 'lookup_page_ext'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] page_ext = lookup_page_ext(page + i); ^ >> mm/page_owner.c:226:12: error: incompatible integer to pointer conversion assigning to 'struct page_ext *' from 'int' [-Wint-conversion] page_ext = lookup_page_ext(page + i); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~ 2 errors generated. vim +/lookup_page_ext +226 mm/page_owner.c 213 214 void __split_page_owner(struct page *page, int old_order, int new_order) 215 { 216 int i; 217 struct page_ext *page_ext = page_ext_get(page); 218 struct page_owner *page_owner; 219 unsigned int old_nr = 1 << old_order; 220 unsigned int new_nr = 1 << new_order; 221 222 if (unlikely(!page_ext)) 223 return; 224 225 for (i = 0; i < old_nr; i += new_nr) { > 226 page_ext = lookup_page_ext(page + i); 227 page_owner = get_page_owner(page_ext); 228 page_owner->order = new_order; 229 } 230 page_ext_put(page_ext); 231 } 232 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests