From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7A1AC77B62 for ; Wed, 29 Mar 2023 23:53:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2C4706B0072; Wed, 29 Mar 2023 19:53:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 275316B0074; Wed, 29 Mar 2023 19:53:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 18A6E6B0078; Wed, 29 Mar 2023 19:53:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 085366B0072 for ; Wed, 29 Mar 2023 19:53:30 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id C7C1B160F73 for ; Wed, 29 Mar 2023 23:53:29 +0000 (UTC) X-FDA: 80623590138.26.4AA17EB Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf26.hostedemail.com (Postfix) with ESMTP id AECC6140008 for ; Wed, 29 Mar 2023 23:53:27 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=none; spf=none (imf26.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680134008; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gEoRfunyWkfn8UDHjcKiB32JdiqdiH8r0lrFok40HYM=; b=AFguNTnYjiZR0Ed1+R/mZp8EZZ49ah8i7HgzJhBdVVJiGlYKJa6UhA6WPIuNCvapFUrMxR pAljB5I3p/hn1/Vl9s7KcgEj0l/T29yH/ZkakBUn3u+MXLThdNPXjnGBOX+3ZTTS7HL8Om /JbZd8Vi6b2QABa5xqL2nC2QqLi4mUs= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=none; spf=none (imf26.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680134008; a=rsa-sha256; cv=none; b=ocSJ8/zDkARNk8z5ZrpbQDMbHgvlTEJZGnMqhwg+PCIIoGZGy7CnuzHgIbgWXfwOTFqEju tXxq9FJb+YC9fzwIGw+WOF7sKNp5MRCdjAf4XfhjZTjmy5o5QJLqm3h6XY391zpa9xChJY Q/LLn8+U6bnZLLM9txLsxt93JVBRALA= Received: by verein.lst.de (Postfix, from userid 2407) id EB2DC68C7B; Thu, 30 Mar 2023 01:53:22 +0200 (CEST) Date: Thu, 30 Mar 2023 01:53:22 +0200 From: Christoph Hellwig To: Pankaj Raghav Cc: Matthew Wilcox , Christoph Hellwig , martin@omnibond.com, axboe@kernel.dk, minchan@kernel.org, akpm@linux-foundation.org, hubcap@omnibond.com, viro@zeniv.linux.org.uk, senozhatsky@chromium.org, brauner@kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, mcgrof@kernel.org, linux-block@vger.kernel.org, gost.dev@samsung.com, linux-mm@kvack.org, devel@lists.orangefs.org Subject: Re: [PATCH 1/5] zram: remove the call to page_endio in the bio end_io handler Message-ID: <20230329235322.GA1891@lst.de> References: <20230328112716.50120-1-p.raghav@samsung.com> <20230328112716.50120-2-p.raghav@samsung.com> <5865a840-cb5e-ead1-f168-100869081f84@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5865a840-cb5e-ead1-f168-100869081f84@samsung.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: 5s73zqppdxyxr61rc38o3n4yaeqeucfx X-Rspamd-Queue-Id: AECC6140008 X-HE-Tag: 1680134007-543105 X-HE-Meta: U2FsdGVkX1+TADo9GDVqGdW3qE6B4XIp/JJ7sgoeYtdfl7Pz1STF30+IJHjBehrhK3XPdP4PM83kXWHraAJnCubqGikgYsxZGcwQW1KpXXCwqG9HaJQ0zcEavRjJ4vyWOZZUlRyL76wTB72RD+aSPGunOxJI1Cw6mYb3YW8nYl/tPCUX1g5g+RkA8hrMkZ8TmBSUWTxzMWEpSGjqO3lJEWyB4f5DnM/FMwnNL/AFCY+C0/N/8BjGfaTBxB42hAismHt8a7UQoKZM0e+9YvlNko402LFOdW3l+tpQvDutluEF3CrjHCcfuZlIH0udZY98vIK+jk+P59AXWhrGsJCAhlEvQnV8ylnGTY/8jWnAx/KSiMvSvHE035JJmkwajRvY1Qf6EBlbKaabvQQIA9Xe/mo0A4Dfz64S8G2+sNB9UyXnhGJTDuB4hnGXivjEm34vE34A8gONPURRLGvmpkj6foThSPtphA8P+MJCfxPZsoDELFM3ELDVwNPiuI9IxSvfjvaNiLJ4bVt/ogFgHdm7szSVr+A9g5SlibeH7Q3OW06MQ/V7KrBSFeBvJ5fSne8BhoYr9eks9qNJW3p7xBxXgKfYZZsfErywuqBFy9ZNS9sz9JFtcq63wXskrY01Ov1zJZ71Lpeqnu3srUCyts/rOBFvV5hE3Y10ZnG187oJJHnjTwcsW89yLXMocm1oUXdJ/44SILLj6rWmVE8zz3gBGHaGvIzJ0gzATngCp4xET3h2zrOfwCWf81QLyhfcMm5g+M6tIDe/BWDxIVluAfa8Q8ezm3kT2rzygl+9wvLUII0EKXvKAEehjI0CZL8nw6x+5Jp9otdoC8rNyFtpCGKETmDyH3CFTs8GTd39VLwPS4Y4Df7FrOa69kvDuBAR+TuMD3nMRyo7M6mZIWdTDbgP30ca5V+zNEcNZISh3ZcSzExgJAEWba/8RfluR5DKzX6Vs/deiIyN7WSNhBdxjGU WGI0x9y5 BJkJ/14wzCXZ9hW2uLwukLuygz0vKhvUtu1Sqg3sSn3qkW01uUGW9ffoY+YMojUH/RKgH5+XF5fwDd7D4mZRyHEZcHkzKpihbtXWoeUmLHHrPqUaiQPag96wwBQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 28, 2023 at 06:17:11PM +0200, Pankaj Raghav wrote: > >> if (!parent) > >> - bio->bi_end_io = zram_page_end_io; > >> + bio->bi_end_io = zram_read_end_io; > > > > Can we just do: > > > > if (!parent) > > bio->bi_end_io = bio_put; > > > > Looks neat. I will wait for Christoph to comment whether just a bio_put() call > is enough in this case for non-chained bios before making this change for the > next version. It is enough in the sense of keeping the previous behavior there. It is not enough in the sense that the code is still broken as the callers is never notified of the read completion. So I think for the purpose of your series we're fine and can go ahead with this version for now. > > Thanks. ---end quoted text---