From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88DE9C6FD18 for ; Wed, 29 Mar 2023 14:49:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C8730900003; Wed, 29 Mar 2023 10:49:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C3882900002; Wed, 29 Mar 2023 10:49:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AFFBE900003; Wed, 29 Mar 2023 10:49:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A2BB9900002 for ; Wed, 29 Mar 2023 10:49:13 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 6F4D81C6133 for ; Wed, 29 Mar 2023 14:49:13 +0000 (UTC) X-FDA: 80622218586.13.A5DD733 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by imf29.hostedemail.com (Postfix) with ESMTP id 537B7120021 for ; Wed, 29 Mar 2023 14:49:10 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=G3OzEnXr; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf29.hostedemail.com: domain of lkp@intel.com designates 192.55.52.115 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680101351; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sPkMWTgk5c0QZd3KfT8hPlM2XTWInDu7ffwcWOMtKYo=; b=gVBDjm7YirH0BRglD1xHnf6DSeSlvdm71H48gCzmKyS7ltWtvuu/K887EEI0ARS3oxwp7Y V+OnaNEUSh0Vs+a+6NYBpErICP1c9YrNBlbffvx7x0eJ+RjgKxVahnDhCMHqq7gRHrkje0 wDU09i59/uGI5NdV7Gg59K7HRmYWTq0= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=G3OzEnXr; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf29.hostedemail.com: domain of lkp@intel.com designates 192.55.52.115 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680101351; a=rsa-sha256; cv=none; b=sEBVt9CLD2C04hOM6WX9b8wGmkx4MyB5M1MQwdu4REK141ZCjTOYsLPXmO5WQw6flQcMd8 4D/MPvfQDOdgpFPQe6XHlWD5unnRmt9Mx6QVrk8Jj4OwNT5jhyMEnf/BJvrDM2G2G71eoy f9sIpGzf9fnkHBIvDaQwJ9g99mOBgrk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1680101350; x=1711637350; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=/JwzapEZeOEBEAVO2IFsUIdXBxnyulcntsu8vKQEY0I=; b=G3OzEnXrCC/7BQD/Ue2hnRGIVrXYiVg9+ZshqqeSIVNSnzkwPVKiNlzI 4ndvnO8yugqMLD5UAIUoYYHNPgx8tdj4Wsq/fgBZDhvXaUzYV9r50gD6A Rg/iJnRpc+S2wFoLhMKrtclM/5IvPSHTrjF20XgvUmAcB1i0FTLEhhAnb DXpd+AWoHDx4eZOBX+EZMsbligmZcu6neOeL48x01N/ctiTpF0K71dRR6 XQ3dj2D6xQp17akzrU7tuIPgeE0PkR4lz2h8pNcTidCqN1sK0yiadz1Cg BDDPejQcsVDlGsf/w39gL4MNpeaMCyOvJO1pEm66hf3KPL1Hz/WQxQLXO g==; X-IronPort-AV: E=McAfee;i="6600,9927,10664"; a="340916873" X-IronPort-AV: E=Sophos;i="5.98,301,1673942400"; d="scan'208";a="340916873" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Mar 2023 07:49:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10664"; a="748798605" X-IronPort-AV: E=Sophos;i="5.98,301,1673942400"; d="scan'208";a="748798605" Received: from lkp-server01.sh.intel.com (HELO b613635ddfff) ([10.239.97.150]) by fmsmga008.fm.intel.com with ESMTP; 29 Mar 2023 07:48:56 -0700 Received: from kbuild by b613635ddfff with local (Exim 4.96) (envelope-from ) id 1phX6d-000Jdg-1Y; Wed, 29 Mar 2023 14:48:55 +0000 Date: Wed, 29 Mar 2023 22:48:41 +0800 From: kernel test robot To: Zi Yan , "Matthew Wilcox (Oracle)" , Yang Shi , Yu Zhao , linux-mm@kvack.org Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Zi Yan , "Kirill A . Shutemov" , Ryan Roberts , Michal =?iso-8859-1?Q?Koutn=FD?= , Roman Gushchin , Zach O'Keefe , Andrew Morton , Linux Memory Management List , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v2 4/7] mm: page_owner: add support for splitting to any order in split page_owner. Message-ID: <202303292237.pg39cTKv-lkp@intel.com> References: <20230329011712.3242298-5-zi.yan@sent.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230329011712.3242298-5-zi.yan@sent.com> X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 537B7120021 X-Stat-Signature: kc6gcijorggw6r5ycq39byeg6xr78qfz X-HE-Tag: 1680101350-516342 X-HE-Meta: U2FsdGVkX1/o3yk8RE3hC2M3ijiRJkmGljQEBjR5HTy5y5rK4u6yIwqf6K6UH3vO7MfuRy2jVd3kbB0LCE4dsn9ec7/9zfjrTLDNIOpICrmrEv1Cm59FsZQ6rPq8gwk7Wr1/kL7fKQf7WbYcowu9sf3tA9YFKsr4Y8KdySHufJ/pYLk7dlqXwEUEjTU+46gjJUx+8351DiXDy7m8H9QPui5ZvaYgsncrR76pOfEf7ai7sCjXWkb0RmoTYhzTp4de75yAH9ZY+En5On3nc22CHXZEPaBOH3A5bSO9lB1y9PH1tO+QSAjWo1eexwPRCdb+R3rAHohd5NA/lUqI2EyOHLrxO1+3J/uyJA7bxWKNOQlz3x9LFvrcLSoDdeSSmOWnAF/g7eDmELztpf0JtTuzsqSAvNk/0/fY4W3OsITV6GzzkgJBUpdotss9/lyGaWiXJ1KmBLP5ZOqyf9oCNPyiMzh6YGC2GtwM55FwaF29uPyg6f67JgTlGsodlIQWsN1opo1IW9Xr5AHm1rHGPftZ2sM5SBu+nlwxT6ijxGWkMAw+ALRvq21Sg+wHrnNf7rHu3SS/nGH3181YDIejLZnYY/2uHz6rRKCAXIyyXMYaI0KxR4/MWAkxuqL21tkjjCTSb+ov1MK9AFIWKV67cJpwvoUVl6IOj3bCV9mG8w4by/3Y4kERSjlU10v38uv7O93mfaVuESv9HPs55wEMmzAtZxHeRXbWlSplq+sAYIqedYUp7oa0DQitJ/7POyoAmee5vbJvBuzyt5gG8ESmLp8P41WnVWz7eANMMJ2VYkWJyywLjZBQlRbH/bU9b6GNCVTDRMbp9vyV72cSiHJf3pUUrrlvIV4b5aZOqQnXPm3RkkcOBNwPrXhpez25PQ2PoiPeUUce83lMgQrcwm+7CDRXL9zJW7w1QCBUfKKWHKKFziqQmm2+7rvzLzPygNZQIr7fsTXGdEgBDAZrEy4wFGg jQzfwA4w /pIRSvmgbQCer9ApjDYER8vqRvtRkuZsKk8oS1WPUArPHQScisZDPT2PsVIZNI7oJN3+cE+iJ7qB4waJJ0wHtoMHVTOCGImPf2BgtiMiuzUMcEWgTaOAYIhQs2kG2P9vz47StxdxVnlPljZOEYRY4Z2+wjCdKSvCzRCyWfiX0+0uzM1o6E1NaWQwCEveDukqLU+IMqttBuMNZeoUrPsKzWE08TkggVdvDw3reg0xohL8AvJBvgLId4pXD9KL3PZ8SuhjTSfHXLtm/+9WYUlEYbWvBg/H4izpyRzhoApYQ11RSioBzMNgkRVtV03X8PdkftJKD67XfS9oI2VNBxIRsBSOSZaSEl/2IgXiQRH6L5qgDf5NQDuzka3VCugrILxuTNHF2scQ7D4Y173RCxq509cCShHLDebVS40wpDpEUh+XK7LzQ8K0Wh31QNNvspu5Jb7Zsq2ZryOlz9aTSd3Z6Ryxd0nbcXpMNE4HKTn9cbRAG6gP7MaLVARrXnfR8yDLeaxSaSU1ELPE5mAwfdv0+9VcSvH74GitBuBFiGiTe/73b4buDJfrHgkHDSq32h0vDvRveWEfS378crHB8oETrJ0SnR4eU6oJzL3zO2Y0lvpGZ54Y= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Zi, Thank you for the patch! Yet something to improve: [auto build test ERROR on akpm-mm/mm-everything] [also build test ERROR on linus/master v6.3-rc4 next-20230329] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Zi-Yan/mm-memcg-use-order-instead-of-nr-in-split_page_memcg/20230329-091809 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything patch link: https://lore.kernel.org/r/20230329011712.3242298-5-zi.yan%40sent.com patch subject: [PATCH v2 4/7] mm: page_owner: add support for splitting to any order in split page_owner. config: x86_64-randconfig-a016 (https://download.01.org/0day-ci/archive/20230329/202303292237.pg39cTKv-lkp@intel.com/config) compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/6d1831c0e01a1a742e026454fe6e5643e08c5985 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Zi-Yan/mm-memcg-use-order-instead-of-nr-in-split_page_memcg/20230329-091809 git checkout 6d1831c0e01a1a742e026454fe6e5643e08c5985 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot | Link: https://lore.kernel.org/oe-kbuild-all/202303292237.pg39cTKv-lkp@intel.com/ All error/warnings (new ones prefixed by >>): >> mm/page_owner.c:226:14: error: implicit declaration of function 'lookup_page_ext' is invalid in C99 [-Werror,-Wimplicit-function-declaration] page_ext = lookup_page_ext(page + i); ^ >> mm/page_owner.c:226:12: warning: incompatible integer to pointer conversion assigning to 'struct page_ext *' from 'int' [-Wint-conversion] page_ext = lookup_page_ext(page + i); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~ 1 warning and 1 error generated. vim +/lookup_page_ext +226 mm/page_owner.c 213 214 void __split_page_owner(struct page *page, int old_order, int new_order) 215 { 216 int i; 217 struct page_ext *page_ext = page_ext_get(page); 218 struct page_owner *page_owner; 219 unsigned int old_nr = 1 << old_order; 220 unsigned int new_nr = 1 << new_order; 221 222 if (unlikely(!page_ext)) 223 return; 224 225 for (i = 0; i < old_nr; i += new_nr) { > 226 page_ext = lookup_page_ext(page + i); 227 page_owner = get_page_owner(page_ext); 228 page_owner->order = new_order; 229 } 230 page_ext_put(page_ext); 231 } 232 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests