From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D90E3C6FD18 for ; Wed, 29 Mar 2023 09:59:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3B32E6B0072; Wed, 29 Mar 2023 05:59:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 33C356B0074; Wed, 29 Mar 2023 05:59:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1B6016B0075; Wed, 29 Mar 2023 05:59:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 05F7D6B0072 for ; Wed, 29 Mar 2023 05:59:09 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id D04F1C07EC for ; Wed, 29 Mar 2023 09:59:08 +0000 (UTC) X-FDA: 80621487576.28.8FCD09B Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by imf18.hostedemail.com (Postfix) with ESMTP id 51AC21C000D for ; Wed, 29 Mar 2023 09:59:06 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="E4llTPp/"; spf=pass (imf18.hostedemail.com: domain of lkp@intel.com designates 192.55.52.120 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680083947; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QlSupYe6/oG+WGCpGwsUjPRN2DwD3L/rKdfM0Eitoqk=; b=YUi1P1wcU82/T7vk7XAwtZ9UYqXCFdUsGEpjjLCnRoKU18Al2/N1q/SUZaplxC4WT4t1Qy K5e1HDcFT6RfWW8jKlKSYEyFxTbQjz9txlMxe8WdaS37IqThuGdM7PExG3DQGinZ/gGT+H ncGuzJUrzs0U9vAG4MaQqRfOCdJvkh8= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="E4llTPp/"; spf=pass (imf18.hostedemail.com: domain of lkp@intel.com designates 192.55.52.120 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680083947; a=rsa-sha256; cv=none; b=4GQ1lS79SJsd7sxeB0QFf0+eU20YkgM+NIGqiUhNWLLXDyOb7bveTyxR0gwtQD8WZ4QjZY MXjoRXbRgI4jhNsq3byNv0yBiCyaWBljRglFayCm11M6hlD3WYkVzfcy0JSHCuxfcKGqIV vyMXT7FM3QlQmSd0lcu9rc9kKj2gQtg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1680083946; x=1711619946; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=L329AyF3OgVN9WsY0kOL7oj+CaQXmNshjdDst3A4NC8=; b=E4llTPp/E/gicTvXDHeYFyh0mP99Vd4i6p8Y+QsOHIAT5+Es1vFuoKjC XB6kInVn8l+lbS71lvVhmXbGrU8F3gJ3euHrS1OhDWOibLGNuj4n7uUQ0 ffukG+PjgZajzzJ+hyspZ5vebTBys+7hGKL5uMoBGM8G1C8INxyXnepie Wq8cPEAX/W303r6VIJYP1xx9YNMzX8FIdRNa+D6ROu5R6U83D79KGhzdi Tswo9UNxANFfMBd/nnOZbV2qKn3sI6Vtb4KU28gAzxduRAeF3nRWweTPA UENwZ9Co4f3OhjCTr59XRHIhoTnIrZRtqg9lcwYAzDMuzuFw/g+xuVLb1 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10663"; a="339557869" X-IronPort-AV: E=Sophos;i="5.98,300,1673942400"; d="scan'208";a="339557869" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Mar 2023 02:58:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10663"; a="634415819" X-IronPort-AV: E=Sophos;i="5.98,300,1673942400"; d="scan'208";a="634415819" Received: from lkp-server01.sh.intel.com (HELO b613635ddfff) ([10.239.97.150]) by orsmga003.jf.intel.com with ESMTP; 29 Mar 2023 02:58:51 -0700 Received: from kbuild by b613635ddfff with local (Exim 4.96) (envelope-from ) id 1phSZp-000JQ8-0v; Wed, 29 Mar 2023 09:58:45 +0000 Date: Wed, 29 Mar 2023 17:58:44 +0800 From: kernel test robot To: Zi Yan , "Matthew Wilcox (Oracle)" , Yang Shi , Yu Zhao , linux-mm@kvack.org Cc: oe-kbuild-all@lists.linux.dev, Zi Yan , "Kirill A . Shutemov" , Ryan Roberts , Michal =?iso-8859-1?Q?Koutn=FD?= , Roman Gushchin , Zach O'Keefe , Andrew Morton , Linux Memory Management List , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v2 4/7] mm: page_owner: add support for splitting to any order in split page_owner. Message-ID: <202303291732.7OqWI96E-lkp@intel.com> References: <20230329011712.3242298-5-zi.yan@sent.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230329011712.3242298-5-zi.yan@sent.com> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 51AC21C000D X-Stat-Signature: ue759cf76gmojb1iakgarb1kqnwhucj9 X-HE-Tag: 1680083946-516032 X-HE-Meta: U2FsdGVkX19Fwd8EWc1pNXb0vTHpOQzOnkzwcFABuQ+zf1WGiRhs+ynh8tLCPeXRV65UnO8j4pdFP1rmsLG59RndnNJQgJNIE17e2oJGHjnfpYbtaxCj2/VfnNdUrWKhEK6eYfKMl+keXu2HfEo3bJyABSf/5fNW57+WIkmegbjQBHEXaTrjNuZ+ZFw+qfVjPfyrn2D/uJJ/cPfGyfQjNlFsNU5cnEUsgkBAFTQlhrgjHkq2qmZ40Qm+cfwlHp6oJlVml29wY9GM9u+fru8TdemMl1AXksBWxObbw3sX/KqDgKyGe5EMWG9U5THxgTovBmYkfAjjeJcGUKQNJiLxeC6uLnHehIU2PiokFTuVE4Fh3oxzDJgAr5JKEkA/RIJmCFDCMBXNskXZMAAyD01jueWuLQxj+I3boT5D8L76V3/aAZtHfarzl6Dn+S8M/FMQQtIqMB2u9EPr1CNqtQs9SLPKBoVDS3ay4j0ULAhDcLhY74uVtZHQfqkNbJwyxqnqWnv5mAsJIsx7jE9eleEy07WqZchf5XJ45xJ4k2dB1lINSEeUK++XYWiFV28VSWWFpuMcRYTVYel2md1rqpWEF6qDcrPL37mX7TumyC7Qc1wJ4b6pQBynVngwdmaEOT/mb6sVzY0cTzVz9U+8m/3Lkm1qXTAmRRcySl+MIhVAgESt4IrNqqbp41Eei8Wz5g+yopp+dS1a0AmQQitKXOPlm8Bcb4w2aaS5RoC4xK+Mh8OvlSFkFIdKHElWFrQONWr4KGmqBX9hB8Dj33/r6eGQHi01ctDJc6fG5WkpahN1a35Onja7OLM1+oR2FZ1wV/pDk22j2bk2+oSUuijz9swZsD0zmNfGuxG92DPCeSxYNcmLtwzR1ichPv249DdzmFM0n5HZxRxw34275GALKLeQTiPUHZgOiZSl39aezj/qGsvkJx50Pbs2SxYdy0N9p3nWiNnFqGCSolti3D3YZdw 3B53w/fC 7QbA/m4znE0eFxhJsW4/8G8MotfQhz4M67aqjrwgtesOPlax6iLWdCO0kZOZFHr7brVcgRstR/HCSeD4E/TWc6B5BaH2nTqyPHdj3d6BuTP2LGZXskamXs1Wi2ykkanR5CIkfZuPbUhuQ8FE2vIluYICL7MpRiPx+5eQNGGGVixnZYjogOQDk5rOlckW3b7wC7gsREB97QBToApM6vHtWMmoXhLnGQQL6YA1prYkYv5CF1YfDGSt2Bj0AMHXV+VHm5jxLWJ4A8VPrek5WeZB+BN63YZBERnGaeq7nkwJF2AZIYIBgdL3r627L8lP8Hih9C3NbBaJwCvR/SlSUU45lfHmg1YIo6l8LqSNmF2Fyd2T3u4gjlmGVBgJyMwUpl1V4FZEVNqKWCQFKbX6n8yg7mf9134jjyy3h99voev4hOhAEOQqaw8TwIqDek8ZeZnHFF7Y+QeFQej86m/BrBIARk6JgxTqO4c378kNKM3UTuJocFQLajQ9AFQrWGMAnncAGqrxocWBN9ee/RlfFggGotG7FC3XSRrNLayad2RhwxsQRX61nouau/9jdwg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Zi, Thank you for the patch! Yet something to improve: [auto build test ERROR on akpm-mm/mm-everything] [also build test ERROR on linus/master v6.3-rc4 next-20230329] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Zi-Yan/mm-memcg-use-order-instead-of-nr-in-split_page_memcg/20230329-091809 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything patch link: https://lore.kernel.org/r/20230329011712.3242298-5-zi.yan%40sent.com patch subject: [PATCH v2 4/7] mm: page_owner: add support for splitting to any order in split page_owner. config: i386-randconfig-m021 (https://download.01.org/0day-ci/archive/20230329/202303291732.7OqWI96E-lkp@intel.com/config) compiler: gcc-11 (Debian 11.3.0-8) 11.3.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/6d1831c0e01a1a742e026454fe6e5643e08c5985 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Zi-Yan/mm-memcg-use-order-instead-of-nr-in-split_page_memcg/20230329-091809 git checkout 6d1831c0e01a1a742e026454fe6e5643e08c5985 # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=i386 olddefconfig make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot | Link: https://lore.kernel.org/oe-kbuild-all/202303291732.7OqWI96E-lkp@intel.com/ All errors (new ones prefixed by >>): mm/page_owner.c: In function '__split_page_owner': >> mm/page_owner.c:226:28: error: implicit declaration of function 'lookup_page_ext' [-Werror=implicit-function-declaration] 226 | page_ext = lookup_page_ext(page + i); | ^~~~~~~~~~~~~~~ mm/page_owner.c:226:26: warning: assignment to 'struct page_ext *' from 'int' makes pointer from integer without a cast [-Wint-conversion] 226 | page_ext = lookup_page_ext(page + i); | ^ cc1: some warnings being treated as errors vim +/lookup_page_ext +226 mm/page_owner.c 213 214 void __split_page_owner(struct page *page, int old_order, int new_order) 215 { 216 int i; 217 struct page_ext *page_ext = page_ext_get(page); 218 struct page_owner *page_owner; 219 unsigned int old_nr = 1 << old_order; 220 unsigned int new_nr = 1 << new_order; 221 222 if (unlikely(!page_ext)) 223 return; 224 225 for (i = 0; i < old_nr; i += new_nr) { > 226 page_ext = lookup_page_ext(page + i); 227 page_owner = get_page_owner(page_ext); 228 page_owner->order = new_order; 229 } 230 page_ext_put(page_ext); 231 } 232 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests