From: Luis Chamberlain <mcgrof@kernel.org>
To: david@redhat.com, patches@lists.linux.dev,
linux-modules@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, pmladek@suse.com,
petr.pavlu@suse.com, prarit@redhat.com,
torvalds@linux-foundation.org, gregkh@linuxfoundation.org,
rafael@kernel.org
Cc: christophe.leroy@csgroup.eu, tglx@linutronix.de,
peterz@infradead.org, song@kernel.org, rppt@kernel.org,
willy@infradead.org, vbabka@suse.cz, mhocko@suse.com,
dave.hansen@linux.intel.com, mcgrof@kernel.org
Subject: [PATCH 4/7] sempahore: add a helper for a concurrency limiter
Date: Tue, 28 Mar 2023 22:31:46 -0700 [thread overview]
Message-ID: <20230329053149.3976378-5-mcgrof@kernel.org> (raw)
In-Reply-To: <20230329053149.3976378-1-mcgrof@kernel.org>
While I looked at re-using the old kernel/kmod.c (now kernel/module/kmod.c)
concurrency delimiter methodology for another place in the kernel Linus
noted that this could be simply replaced with a sempahore [0].
So add that so we we don't re-invent the wheel and make it obvious to use.
[0] https://lore.kernel.org/all/CAHk-=whkj6=wyi201JXkw9iT_eTUTsSx+Yb9d4OgmZFjDJA18g@mail.gmail.com/
Suggested-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
---
include/linux/semaphore.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/linux/semaphore.h b/include/linux/semaphore.h
index 6694d0019a68..2ecdffdb9814 100644
--- a/include/linux/semaphore.h
+++ b/include/linux/semaphore.h
@@ -28,6 +28,9 @@ struct semaphore {
#define DEFINE_SEMAPHORE(name) \
struct semaphore name = __SEMAPHORE_INITIALIZER(name, 1)
+#define CONCURRENCY_LIMITER(name, n) \
+ struct semaphore name = __SEMAPHORE_INITIALIZER(name, n)
+
static inline void sema_init(struct semaphore *sem, int val)
{
static struct lock_class_key __key;
--
2.39.2
next prev parent reply other threads:[~2023-03-29 6:22 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-29 5:31 [PATCH 0/7] module: avoid userspace pressure on unwanted allocations Luis Chamberlain
2023-03-29 5:31 ` [PATCH 1/7] module: move finished_loading() Luis Chamberlain
2023-03-29 5:31 ` [PATCH 2/7] module: extract patient module check into helper Luis Chamberlain
2023-03-29 5:31 ` [PATCH 3/7] module: avoid allocation if module is already present and ready Luis Chamberlain
2023-03-29 5:31 ` Luis Chamberlain [this message]
2023-03-29 7:21 ` [PATCH 4/7] sempahore: add a helper for a concurrency limiter Peter Zijlstra
2023-03-29 7:51 ` Luis Chamberlain
2023-03-29 9:19 ` Peter Zijlstra
2023-03-29 9:49 ` Luis Chamberlain
2023-03-29 10:14 ` Peter Zijlstra
2023-03-29 16:50 ` Linus Torvalds
2023-03-30 11:56 ` Peter Zijlstra
2023-03-30 16:23 ` Linus Torvalds
2023-03-31 3:42 ` Sergey Senozhatsky
2023-03-31 8:05 ` Petr Mladek
2023-03-31 3:45 ` Luis Chamberlain
2023-03-31 4:06 ` Matthew Wilcox
2023-03-31 4:13 ` Luis Chamberlain
2023-03-31 4:11 ` Sergey Senozhatsky
2023-03-29 5:31 ` [PATCH 5/7] modules/kmod: replace implementation with a sempahore Luis Chamberlain
2023-03-29 5:31 ` [PATCH 6/7] debugfs: add debugfs_create_atomic64_t for atomic64_t Luis Chamberlain
2023-03-29 5:46 ` Greg KH
2023-03-29 5:31 ` [PATCH 7/7] module: add debug stats to help identify memory pressure Luis Chamberlain
2023-03-29 5:46 ` Greg KH
2023-03-29 6:04 ` Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230329053149.3976378-5-mcgrof@kernel.org \
--to=mcgrof@kernel.org \
--cc=christophe.leroy@csgroup.eu \
--cc=dave.hansen@linux.intel.com \
--cc=david@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-modules@vger.kernel.org \
--cc=mhocko@suse.com \
--cc=patches@lists.linux.dev \
--cc=peterz@infradead.org \
--cc=petr.pavlu@suse.com \
--cc=pmladek@suse.com \
--cc=prarit@redhat.com \
--cc=rafael@kernel.org \
--cc=rppt@kernel.org \
--cc=song@kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox