From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 970B0C6FD18 for ; Wed, 29 Mar 2023 02:46:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BFE616B0072; Tue, 28 Mar 2023 22:46:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BAE696B0074; Tue, 28 Mar 2023 22:46:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A4E7C6B0075; Tue, 28 Mar 2023 22:46:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 957A16B0072 for ; Tue, 28 Mar 2023 22:46:28 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 5994B140A5F for ; Wed, 29 Mar 2023 02:46:28 +0000 (UTC) X-FDA: 80620397256.17.2D07F33 Received: from mailout1.samsung.com (mailout1.samsung.com [203.254.224.24]) by imf28.hostedemail.com (Postfix) with ESMTP id 30F92C0011 for ; Wed, 29 Mar 2023 02:46:23 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=samsung.com header.s=mail20170921 header.b=KklhK7bE; spf=pass (imf28.hostedemail.com: domain of jaewon31.kim@samsung.com designates 203.254.224.24 as permitted sender) smtp.mailfrom=jaewon31.kim@samsung.com; dmarc=pass (policy=none) header.from=samsung.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680057985; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kjjYVEOGZcv9UX/THsps8c19Fgzn0ur8ENOOfxKfTu8=; b=kXwWuhDVDewTOxDV5lPCVdXvVj4fpFFSgzBJHq0KZFD4Dy/WtT+yzeVfTbOmG4dsBQzaPs rhk9HjJMGBSkpPDJl5FAUVbN7EX0WV78DlyjwehEBo1IGouFMxeg7KHLU5CGEzVygckXwe IkIsEF8MbPLVdNRsSxR/MScjPxRv9Sw= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=samsung.com header.s=mail20170921 header.b=KklhK7bE; spf=pass (imf28.hostedemail.com: domain of jaewon31.kim@samsung.com designates 203.254.224.24 as permitted sender) smtp.mailfrom=jaewon31.kim@samsung.com; dmarc=pass (policy=none) header.from=samsung.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680057985; a=rsa-sha256; cv=none; b=flGDeRK0VYX5212eNwjCcO0HLwh1/m15L6HHEgNa5H9LsEqlbrNYT2kxm3feXauZtiu0Rn IeRFVyQ5Aolov/B7QInHFVFRPGEn7g04DUBJiuVoenpbDaaJGqZA7m/eZyO9SzjwVCsCvi Ct6qt7tus7+SE87T82fcTCG3+r91h0Y= Received: from epcas1p1.samsung.com (unknown [182.195.41.45]) by mailout1.samsung.com (KnoxPortal) with ESMTP id 20230329024620epoutp019f7aeafa8f30231f075234edff43b8f4~Qw9ThIYV82288022880epoutp01C for ; Wed, 29 Mar 2023 02:46:20 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.samsung.com 20230329024620epoutp019f7aeafa8f30231f075234edff43b8f4~Qw9ThIYV82288022880epoutp01C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1680057980; bh=kjjYVEOGZcv9UX/THsps8c19Fgzn0ur8ENOOfxKfTu8=; h=Subject:Reply-To:From:To:CC:In-Reply-To:Date:References:From; b=KklhK7bE2lUsP/hW1UW9ftOzGWzTP2bPVSbmwqL12lKnjIlss2JDHj/+OVI6nnutk 8fQ21+rMTB1QOsg9sLxwsLfWjcrO/FTul2u1GboPh67srEz7i07PAaxppL3PKlrfI9 iFK2lP/9H9BHCn1daCP1v1qvtITYkjTQuOyTV35c= Received: from epsnrtp1.localdomain (unknown [182.195.42.162]) by epcas1p1.samsung.com (KnoxPortal) with ESMTP id 20230329024619epcas1p131e8aebec5086d0aefd050dec86cdd4c~Qw9TCt-4Y2296622966epcas1p1d; Wed, 29 Mar 2023 02:46:19 +0000 (GMT) Received: from epsmges1p5.samsung.com (unknown [182.195.38.249]) by epsnrtp1.localdomain (Postfix) with ESMTP id 4PmWCH1Vhsz4x9Ps; Wed, 29 Mar 2023 02:46:19 +0000 (GMT) X-AuditID: b6c32a39-29ffca800000d627-40-6423a67b6343 Received: from epcas1p2.samsung.com ( [182.195.41.46]) by epsmges1p5.samsung.com (Symantec Messaging Gateway) with SMTP id AF.4D.54823.B76A3246; Wed, 29 Mar 2023 11:46:19 +0900 (KST) Mime-Version: 1.0 Subject: RE: [PATCH] dma-buf/heaps: c9e8440eca61 staging: ion: Fix overflow and list bugs in system heap: Reply-To: jaewon31.kim@samsung.com From: =?UTF-8?B?6rmA7J6s7JuQ?= To: John Stultz CC: "tjmercier@google.com" , "sumit.semwal@linaro.org" , "daniel.vetter@ffwll.ch" , "akpm@linux-foundation.org" , "hannes@cmpxchg.org" , "mhocko@kernel.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "jaewon31.kim@gmail.com" X-Priority: 3 X-Content-Kind-Code: NORMAL In-Reply-To: X-Drm-Type: N,general X-Msg-Generator: Mail X-Msg-Type: PERSONAL X-Reply-Demand: N Message-ID: <20230329024618epcms1p7cfbe08918398104667ef0b7859a6ffa4@epcms1p7> Date: Wed, 29 Mar 2023 11:46:18 +0900 X-CMS-MailID: 20230329024618epcms1p7cfbe08918398104667ef0b7859a6ffa4 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" X-Sendblock-Type: SVC_REQ_APPROVE CMS-TYPE: 101P X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrEJsWRmVeSWpSXmKPExsWy7bCmnm71MuUUg58HWC3mrF/DZrHw4V1m i9WbfC26N89ktOh9/4rJ4s+JjWwWl3fNYbO4t+Y/q8Xrb8uYLU7d/cxu8W79FzYHbo/Db94z e+z9toDFY+esu+weCzaVemxa1cnmsenTJHaPO9f2sHmcmPGbxaNvyypGj8+b5AK4orJtMlIT U1KLFFLzkvNTMvPSbZW8g+Od403NDAx1DS0tzJUU8hJzU22VXHwCdN0yc4AuVlIoS8wpBQoF JBYXK+nb2RTll5akKmTkF5fYKqUWpOQUmBXoFSfmFpfmpevlpZZYGRoYGJkCFSZkZ7yc3sZe 8E2gYuWhSSwNjLd4uxg5OSQETCQ+nV/P2MXIxSEksINRYvGLTSxdjBwcvAKCEn93CIOYwgLZ EgtbU0DKhQSUJM7+uMIOYgsLWEvsXzSDCcRmE7CU2H5zIiOILSKgIvFw7k82kJHMAheZJV69 nc0MsYtXYkb7UxYIW1pi+/KtYA2cAoESJ28cYYSIi0rcXP2WHcZ+f2w+VFxEovXeWag5ghIP fu5mhJnz5/hzNgi7WGJZ5wMmCLtGYsW5VVBxc4mGtyvBbF4BX4lFF2aD1bAIqEo8u/YXqsZF oufQXrDbmAXkJba/ncMM8juzgKbE+l36ECWKEjt/z2WEKOGTePe1hxXmrR3znkCtVZNoefYV Ki4j8fffMyjbQ2L2tfOskGA+zSjx/GkP2wRGhVmIkJ6FZPMshM0LGJlXMYqlFhTnpqcWGxaY wiM3OT93EyM48WpZ7mCc/vaD3iFGJg7GQ4wSHMxKIry/rymlCPGmJFZWpRblxxeV5qQWH2I0 Bfp5IrOUaHI+MPXnlcQbmlgamJgZmVgYWxqbKYnzitueTBYSSE8sSc1OTS1ILYLpY+LglGpg Et4caHrmXpLIn/8lb8/Mv7yj6M9RqZAXEgqrH9yuWHW1uXfCfNVPuqu3+t/oTXZl+pf5NieT od24tCAsP6r7aLi61e3zHV92TDe83/InV2CuRnjWbsV/haffs/Bsuqwwae/SrfOmn2KXCeH+ ZLzhSKyPWUix5oZp9yYZW3+cr/pISObq5lqniCtOIY+sxJojNkz0+nhp/8JtFhVMh02ezbO+ YBjEbb9XnOu0ey/zfcVKrpnsZ5af2PSo1SU5d5VOgJiA3v6U8PAi2ehuxTrTHZeTIjIN98Zt 8d94aK9vfuY03lNdDJOUTqws+e+trOezT/jFSZMO+Zvuq21WP/BzW9O8yzHnaIfoz2XrDqrO UGIpzkg01GIuKk4EAIOUpixFBAAA DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20230328125807epcas1p1606c068a9043d6581a1fbdd30e7c53a2 References: <20230328125818.5574-1-jaewon31.kim@samsung.com> X-Rspamd-Queue-Id: 30F92C0011 X-Stat-Signature: 1ucoh1u9k85hp6pcnrbro1f7unarjqmu X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1680057983-869245 X-HE-Meta: U2FsdGVkX19uxglt/AR2w1lDi1aONU0A9i0sq6l3C9Li+Id1L0SiHrEoTR+g3xDYbosnKbnuNCmP3yXMJ/VnM25ovJKtVn6444f4B7IKNWBQYE8BmGxu+JPHk3/X0K7FPYZokmdbj3Ph6b8gePAok5iQGtF3sNNwqL7NMqdeq4TnTAsRDMq+eGHs6TS33iBSvBLtosn4u9+x/tHyovy+nrVBVuY2ejZE8kQaixvglQEjc1eD8TK4qqNsGCw/wNEKnHU79hVC/TAZaz+o2FlFOpUHyIoS49ObEKBnAyE1Hi+vw2vg9ciHwBXTLTvroDssyGhr9WgrgnTBJz3VYLwuCDB08aNSvtJY5AjjfzCbWay+/lr1V80Ab7FgbwuTIeAnaVnnPfumsD+csLpDfNSFw7r1ALHCnrHeYUtHxPxDZtwAGI3pgIXv/ro+PAxyO153eUDz6BOLhYsBhF0wJatVbOxhlirVlVBwwuBBnCXlnGzLJkmUudVXdHpWgSYZQ2RCa9KP4NbVQa4B2jS0sAwh34RsmwiXPgcfipC9jktfl39o0Dmv29Wr6SnrYU5bjTfKKMHjAptRWlbs0wjx9uzNN14fP6Za91zJY4PGAcDQ/2yC2DW4kZwGpcQx8YH/W288wmPSlyTHbntS4LShsLqWywBXNr51HGS+uJiIlMFUfjuctdQQZeJEVjo/UvOUL533MViyDOuZNCx8h1iEMf0qN0c0Fye2vTLEo+AHptGlvUB2jKR+JooSCmO9kIBolk6jk4kVNEOfhKhYf+LpOXxthfxJQhu7sNEnj3N3qYkyxGgQO7tuYBUFpZKzOSZcSyu3MlmfzmYwneR7GqBZgykBrBpg4MqHiStog3lHOJNCPMwi8BRrFQnpvYl2AnYKqX4K4wmqJNuBeZqoLHjvv106du4jupK219mRbJJctLGMnJhZpIrG6NWqcLupnd8zUxU1BwRc6zPb12xcDCsnVEd W/oknDzt itVmsi1Pd7frFhOWFCpWQ17IUYvAyRi1u+DHPbrGXpLzOQYY2gBJshlgmNq3lDzXRDNuDd1iVz3a2xBLz5wpIyFwTPvfg+MWrWHHwOgUrJ3RmHnYurd2G0DLrG/YSFNBqCp57QDGWy68vLvVWZjupGBD1zdObpTATEnQSHwhBtahlxmw6uyJo1FdiLJhzY+ag9W+htpHN1ut/8O4vpwF7dwJR077jgP87PXM/b7FEedl8T3YJBrW0RgFJkPm8KheiPpB53ThXTcUYWQQR1qLV9dmhO7GI533B4wxIs0e9gO0/u2TqrzhGTIP/xd9UfoVVSFuvy8r6EfWn+TAWbBvt2faTJopXDC2XfQ0G X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > > >--------- Original Message --------- >Sender : John Stultz >Date : 2023-03-29 03:26 (GMT+9) >Title : Re: [PATCH] dma-buf/heaps: c9e8440eca61 staging: ion: Fix overflow and list bugs in system heap: > >On Tue, Mar 28, 2023 at 5:58 AM Jaewon Kim wrote: >> >> Normal free:212600kB min:7664kB low:57100kB high:106536kB >> reserved_highatomic:4096KB active_anon:276kB inactive_anon:180kB >> active_file:1200kB inactive_file:0kB unevictable:2932kB >> writepending:0kB present:4109312kB managed:3689488kB mlocked:2932kB >> pagetables:13600kB bounce:0kB free_pcp:0kB local_pcp:0kB >> free_cma:200844kB >> Out of memory and no killable processes... >> Kernel panic - not syncing: System is deadlocked on memory >> >> An OoM panic was reported, there were only native processes which are >> non-killable as OOM_SCORE_ADJ_MIN. >> >> After looking into the dump, I've found the dma-buf system heap was >> trying to allocate a huge size. It seems to be a signed negative value. >> >> dma_heap_ioctl_allocate(inline) >> | heap_allocation = 0xFFFFFFC02247BD38 -> ( >> | len = 0xFFFFFFFFE7225100, >> >> Actually the old ion system heap had policy which does not allow that >> huge size with commit c9e8440eca61 ("staging: ion: Fix overflow and list >> bugs in system heap"). We need this change again. Single allocation >> should not be bigger than half of all memory. >> >> Signed-off-by: Jaewon Kim > >Hey, > Thanks so much for sending this out! Looks reasonable to me, the >only issue is the commit subject line could be a bit better. > >Maybe instead: > "dma-buf/heaps: system_heap: Avoid DoS by limiting single >allocations to half of all memory" > >Otherwise, >Acked-by: John Stultz > >thanks >-john > Hello John Thank you for your Acked. and the subject thing. Maybe I was in a hurry, I did not check it. I am going to take yours "dma-buf/heaps: system_heap: Avoid DoS by limiting single allocations to half of all memory" By the way let me talk with T.J. Thank you Jaewon Kim