From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D10BEC76196 for ; Tue, 28 Mar 2023 21:53:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5B2916B0072; Tue, 28 Mar 2023 17:53:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 562666B0074; Tue, 28 Mar 2023 17:53:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4538C6B0075; Tue, 28 Mar 2023 17:53:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 39A906B0072 for ; Tue, 28 Mar 2023 17:53:25 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 09DDCA0406 for ; Tue, 28 Mar 2023 21:53:25 +0000 (UTC) X-FDA: 80619658770.30.E49B2AC Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by imf02.hostedemail.com (Postfix) with ESMTP id 548BC80019 for ; Tue, 28 Mar 2023 21:53:23 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=linux.microsoft.com header.s=default header.b="U/RSAlul"; spf=pass (imf02.hostedemail.com: domain of beaub@linux.microsoft.com designates 13.77.154.182 as permitted sender) smtp.mailfrom=beaub@linux.microsoft.com; dmarc=pass (policy=none) header.from=linux.microsoft.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680040403; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vEFB1z2QmcpHdHshSNcrN3p3s6kuh7H1QAAI42oT64U=; b=1g4ZDqqwUGT6rR6tlitJwRH9p+JA+1dJXzJv0B557lADwPPdPA8EkOm+GWzf4fx4pE5wVo 9TQIhx6oHMPSCO5eooI8pBwlUYKUOG6Asd1U06U2AYsp/XpEORymw8tKeB+yHrCMK115+R kQzrwZHe4uSgf8ony4e3tc2bJPAJZok= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=linux.microsoft.com header.s=default header.b="U/RSAlul"; spf=pass (imf02.hostedemail.com: domain of beaub@linux.microsoft.com designates 13.77.154.182 as permitted sender) smtp.mailfrom=beaub@linux.microsoft.com; dmarc=pass (policy=none) header.from=linux.microsoft.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680040403; a=rsa-sha256; cv=none; b=mFlFOC3eQrs1OFZG8QNWfMZ6HNbWDH5RITID59rcEpbWc1q2v9WPTaZlz2GAPat25WW7Q2 YUrFR2dVOSSIt7xBj9K6ixal+eA3V1VrGGLi0AxwXIQaRk/nxGrAiFf6NYV8lr7n+az/Be co1fNYkMp5oHDhI6vbunJfK4g06fo+k= Received: from W11-BEAU-MD.localdomain (unknown [76.135.27.212]) by linux.microsoft.com (Postfix) with ESMTPSA id AB41220FDA92; Tue, 28 Mar 2023 14:53:21 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com AB41220FDA92 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1680040401; bh=vEFB1z2QmcpHdHshSNcrN3p3s6kuh7H1QAAI42oT64U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=U/RSAlulI4icbxrgBDeo+f/RSQbJtLtwI8T/AZ5uVvMsIPsQgysULDRy2l5h5IUr1 ySZOm2wZc1lkwmuLkwVJv/P8542h2ykT9HDwxLUzuavcC5aa/ik+GzllUAJstDgXJZ 8YRydOh/hsDz357idecBIBjOv6jYZaiZvb93kaIE= Date: Tue, 28 Mar 2023 14:53:15 -0700 From: Beau Belgrave To: Steven Rostedt Cc: mhiramat@kernel.org, mathieu.desnoyers@efficios.com, dcook@linux.microsoft.com, alanau@linux.microsoft.com, brauner@kernel.org, akpm@linux-foundation.org, ebiederm@xmission.com, keescook@chromium.org, tglx@linutronix.de, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCH v9 05/11] tracing/user_events: Add ioctl for disabling addresses Message-ID: <20230328215315.GA143@W11-BEAU-MD.localdomain> References: <20230324223028.172-1-beaub@linux.microsoft.com> <20230324223028.172-6-beaub@linux.microsoft.com> <20230328173200.22ac45dc@gandalf.local.home> <20230328173740.0595c953@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230328173740.0595c953@gandalf.local.home> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 548BC80019 X-Stat-Signature: xomu9n9849f6631m5okgbrxdzd16cnkn X-Rspam-User: X-HE-Tag: 1680040403-327732 X-HE-Meta: U2FsdGVkX1+CKBK1opU+2ycP6tNVGEabXHYqjble0BjUtlJR+eGOI/ReZ5vBd/Ysn8pxr0Z0pvgVOhKOIb1uOTu07iuwdePz01yteO4vjOYhaBk+jhh5lLXB/o6PTQ2Bp2JLMXwWTcdXM2lYstLwvwVa08t1baqwyfCavUv/0hY5CmLBKrayyalOg8UJA3lhtMeKY/dpdaiOXVCrOOz/GucypwiJi+XYuAvhP6oeKU4rnk9DgDTHkGtCwL6N3FW16mV14q5pVDISK7nQ3CmfwumBl0dLzYt70Hne/WTexcBKB9G4pqEZq/A/FUYDhACeQojN4DkftugTNEsKZoRBUAQK+vy12n0cmhxLbXHsfGd/8A9Z3FuvstsPkEwhkLBT8EXjc4+23PjDCBPzBGiYVr3IB+2+uYOLX5MsMkuXxwpTba2mNTgyZGGh4GuTy+4goJa9Q8JdduYm841I1BKJTJsnG/EYPZzy6UhjZWXcZ2KZtM7zfYHaP57LhDSTIpb7gSx2+wuZt7EqXdDigetMK9pcIbey90k1eV1PC54Gf6RUkKcgZvxhSPzBlTpREjxFh1Z409yYLRdT8pa38WlVc9ygB70fW2BYQvPmcPlVOVNZ1AMmkKrkpYma4/r3GQya5Y5K6hH8H89TaHRkCVlOcLqUT3/HQAS38RM7B6B8c9kdOa/57HjHn7icQuJ62AswpQ2k4hforiMVlT863K+a/GDoCQaQfT7nyXRps75zrmujtb2kYue+2dgsAcHBgIewhVk52HepGZn5U9GPBIDqLstxXdcFlfuuTw4UVAUt3itD/jjVH7KMwJLvxBoGknsHm483TBR2eK46HlVSq8AnrsxlYzBZCvTOFF+VPWVC9w4Do88f+niovK8kcG1nx60M2BiDZOzyPTJB2ekTQMO5/JWOvwSMT+wppYsSi+Eb0wesOIukUjwUH5jzLhIyy+vO5xAhLbDVrH2VXL4el2I jajpGUoJ b+5y19sEI2u7dUpndoikjEIfRVCDGoeQpLD1Pyd4U32whV0HVndT4gi4iUMNhleseDfWdCdWt6VJkDY6TTsoP8bAjKgS9GJ+P5vsxRLOp7XO5Mb91DViwxj3hnOVfzGAF1JVYSKP8cdZrmRuoM6Hjs41ugrAuKFImxYhQbw90hseF8ty4R4yTzHA5vz9gkmXnZeQW7QT301Y0y9E01Bi8V+ZIW1gLYDUfYxz8KS5HTqu4ueWrbLjBkQJ6UHNb83m0Ip8N/ZZYcvbcVXz878sUsQUHagkBC0BH+MfVHg8GD4iUFTrKkBaIZ97+qvAh3bb5q2z/O23YwRZwC5Kk8eaNzDO/Bw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 28, 2023 at 05:37:40PM -0400, Steven Rostedt wrote: > On Tue, 28 Mar 2023 17:32:00 -0400 > Steven Rostedt wrote: > > > > +static long user_events_ioctl_unreg(unsigned long uarg) > > > +{ > > > + struct user_unreg __user *ureg = (struct user_unreg __user *)uarg; > > > + struct user_event_mm *mm = current->user_event_mm; > > > + struct user_event_enabler *enabler, *next; > > > + struct user_unreg reg; > > > + long ret; > > > + > > > + ret = user_unreg_get(ureg, ®); > > > + > > > + if (ret) > > > + return ret; > > > + > > > + if (!mm) > > > + return -ENOENT; > > > + > > > + ret = -ENOENT; > > > > Probably should add: > > > > if (reg.__reserved || reg.__reserved2) > > return -EINVAL; > > > > here. Nice catch! Yes I'll add this. > > I finished my review. > > Can to send a v10 out with this update, and also update all the structs to > have the fields tabbed out for easier reading. > Yep will do, I will have the tabbed out changes in a isolated patch in the v10 series. Thanks, -Beau > Thanks! > > -- Steve