From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D962FC6FD18 for ; Tue, 28 Mar 2023 21:37:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6330D6B0074; Tue, 28 Mar 2023 17:37:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5BC946B0075; Tue, 28 Mar 2023 17:37:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 45C7A6B0078; Tue, 28 Mar 2023 17:37:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 321A16B0074 for ; Tue, 28 Mar 2023 17:37:49 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E9D2E120498 for ; Tue, 28 Mar 2023 21:37:48 +0000 (UTC) X-FDA: 80619619416.16.41C1428 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf26.hostedemail.com (Postfix) with ESMTP id 5539014000D for ; Tue, 28 Mar 2023 21:37:45 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf26.hostedemail.com: domain of "SRS0=rtO5=7U=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=rtO5=7U=goodmis.org=rostedt@kernel.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680039465; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mL/NfZvB3ZuxCvR1SEpcuolFmpH9UQcqGALGKFvIiVo=; b=faAJnD4mu1Ay0C1JyD97lU2TxV5/upS5q1QkN09KQBC6y9te3r+AA3TNXR0L2PqXs2aKLY yf3wZKq39tvG9/+0I4v5e8GAHgtSo6uEsx+R/pLdu15C2XptZV9gMyWshNgtzTiFhS4CBd 3cE0oVTRSGBlS2bjN4dvpUval8VhxMg= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf26.hostedemail.com: domain of "SRS0=rtO5=7U=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=rtO5=7U=goodmis.org=rostedt@kernel.org" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680039465; a=rsa-sha256; cv=none; b=dPBBSTGLD+TD/X3/MVMwXomwHJMR+FCXrI0LJGp3fjplpfTP0bqfhsVtmQwa72JWIhaqTA oXnajIRzUHRZ2UZPtv+Iu7PqRmq/y7y3KrFrs9YdNQvKo2YD3zW1198Ra2RW42nsUXg7yu k6nPkCZjeTJB0mOjBOvYtBWreKLaSqc= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5755C61985; Tue, 28 Mar 2023 21:37:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5671CC433D2; Tue, 28 Mar 2023 21:37:42 +0000 (UTC) Date: Tue, 28 Mar 2023 17:37:40 -0400 From: Steven Rostedt To: Beau Belgrave Cc: mhiramat@kernel.org, mathieu.desnoyers@efficios.com, dcook@linux.microsoft.com, alanau@linux.microsoft.com, brauner@kernel.org, akpm@linux-foundation.org, ebiederm@xmission.com, keescook@chromium.org, tglx@linutronix.de, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCH v9 05/11] tracing/user_events: Add ioctl for disabling addresses Message-ID: <20230328173740.0595c953@gandalf.local.home> In-Reply-To: <20230328173200.22ac45dc@gandalf.local.home> References: <20230324223028.172-1-beaub@linux.microsoft.com> <20230324223028.172-6-beaub@linux.microsoft.com> <20230328173200.22ac45dc@gandalf.local.home> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 5539014000D X-Stat-Signature: hanc18puqmdgngokjbuz9gzx774znjnt X-HE-Tag: 1680039465-392057 X-HE-Meta: U2FsdGVkX18uqf1jzFiBJYQ5tWHEDVy3hU5QnO9ihbEkEJ3+fLKeQE705B9hAACpGtG67F6TqERlel1+J+nTqtl0IjwGqj5/JRyo97TkCW6f1Xhy+LMu7DXC46mAG+tcwmuQk9xTftkazG60qfb898ClDgpHvaQU3MDT4ZWFtCoiYIl1mI5k1ITVq3WYijtU68drRRpScsjsXf+D8sx3JQyGbKACuhYlMkMfo4QN6KWCmdslo+bFcV23i6qC6/rjbGAGzTB+FGDLRI8dfhkN2SKVVXX15sYAXdAgPX//fIaQRoGhDun74JtqvSUwxOAlM1lQUKGoQkOsbqyRmKKWzHuCeSVbmocWmF+JuTw4ONRlWTwGP2m1lbKZlUlzs5r/fdewtgCt0dzM2KOaeNgTnML1m4upXTJddC81rz0PAq80RZhRkrfhANzlO7F2ommO+4Gc+XaMheOrAzYwyz62fEYnTrR/iFlBYmY8V4k/g5NZ1IFk+eyFLXWOYDAg/vqrTsKFH5+HDmhGan3RMzYSM3ZN95mStswWGe5zig5VkwBRgX0IWEbcUOl9ZnWsIY+VzY6I47kcjif+hD56VW8vuxvACn2SzmCwXscZl+Jikw69jHpl3YONT1M5Mp1f4kEjO9uI0vk2NlIgUEsZR+B5njxX4EZzHj46FqVmgiq+Au50bs5jgLF3i/a31hoaOMuTnAeKxraqk69vCVSD+wGYd5pSJzTJUcUhGjw34LGPR4/ZDzxuCHTKdPyQh5WdWlD/cLZbH34j/2+qKYYVyfhfLcxc6asO6VPb0Pej+FzhktQxkc/ViP1SPMWeldecyQWjsDUcrRl0/bYJ+5pAzNm819++1q7n2G0sSWriRkU16O4rIaXpHBnDY9m1+9tdouvwzWNCp0bkRrvLS7MVtWlvDaYMtk84mFTMdwiX2ltrZzFLizXpV0aK1KAjnp9GBqx8rwoBOoZHUDsoyFecUAP jyaXdtcJ DQQar2rk4h0XR85U80y+4DNgrnaSF6yZUxpcDuCcLMoIFfqVgBbeDdH+5pIsd15Rbbl8V0eTGYDNxkjZEloSajFVI+s5mUB8CMtMSeVDshtGy4DRd0NpQrgW4NomKh1E7K7p21I5P2o9YcWq8GQK99gPEjUqjRp+C2uG0dLxynjt3ls2Dg7Y8WyEdGb8wiTcmwVxT1yHJ74MZqOzoI0xafGBklvF/M96+UkMZ00PYv7qij+e2AfXZHcZGZWauMGXbQWPKItwAaLYGGMfLT95f4Yk6aqbX+VquYIjaEuocJaHg5excmKOAhnEzjEVIR7W2RlD5/4IFm6olWtflXDjoJaquXtMzElcZ4nKHqLMdV1rhnZBDizg9Nz/zzih13Vv5J8Nc/q9tfIjlJ97weJcr7UxtujV1vx3Fkpue1H2OjA6jfhy2jKsDXzkqTHZS74f8furmljvgr8BEewXgPvbMCyCuoKZO2JY7+jOi X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 28 Mar 2023 17:32:00 -0400 Steven Rostedt wrote: > > +static long user_events_ioctl_unreg(unsigned long uarg) > > +{ > > + struct user_unreg __user *ureg = (struct user_unreg __user *)uarg; > > + struct user_event_mm *mm = current->user_event_mm; > > + struct user_event_enabler *enabler, *next; > > + struct user_unreg reg; > > + long ret; > > + > > + ret = user_unreg_get(ureg, ®); > > + > > + if (ret) > > + return ret; > > + > > + if (!mm) > > + return -ENOENT; > > + > > + ret = -ENOENT; > > Probably should add: > > if (reg.__reserved || reg.__reserved2) > return -EINVAL; > > here. I finished my review. Can to send a v10 out with this update, and also update all the structs to have the fields tabbed out for easier reading. Thanks! -- Steve