From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BB57C76195 for ; Tue, 28 Mar 2023 12:21:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E0F186B0072; Tue, 28 Mar 2023 08:21:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DBF806B0074; Tue, 28 Mar 2023 08:21:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C86FD6B0075; Tue, 28 Mar 2023 08:21:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B58B36B0072 for ; Tue, 28 Mar 2023 08:21:49 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 8914FC0821 for ; Tue, 28 Mar 2023 12:21:49 +0000 (UTC) X-FDA: 80618218338.24.F1A488B Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf09.hostedemail.com (Postfix) with ESMTP id 83F55140016 for ; Tue, 28 Mar 2023 12:21:47 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="X/yYa1sR"; spf=pass (imf09.hostedemail.com: domain of will@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=will@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680006107; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=15MxBqWKtrLmDrt5L5dnRqeUtTwV+z1z5sSNAkkoiqA=; b=zhKY2a2pFhveLf+Q3KLOogqeeFjAwzbu/J/mLS5CnqJBWx14vk7vSdutTYBTbr29jx5t5o jUEjAiSYAZemHnritTzYwNtQAdpcFZ4eBwCDO1XXDuB9ZOtEKgC1OtRqPWYmYScucV36er IwrRGPFK3EcPB3cXq9v0GDQD6IFd6PU= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="X/yYa1sR"; spf=pass (imf09.hostedemail.com: domain of will@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=will@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680006107; a=rsa-sha256; cv=none; b=KcSC+VD3q85O57ndMzMiEKYlCqo29lL2mtWA/N4Lou3mKUJaeUvajkWjrcKyQSe0birHNq xpSRAGzd2xsksGkYNYf6nsVSymjHwgYFHel3s2saYrSSSDri4QbDXBhrM3DyTD1dQ7awG2 1fPb0kgZrbBJtd6rYnbKUr+WJUZfizQ= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 59628B81CA4; Tue, 28 Mar 2023 12:21:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B378AC433EF; Tue, 28 Mar 2023 12:21:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680006104; bh=fW2128x5Fp5fkpxJkAfHDZrmykXA979A6ajR0DCHjMk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=X/yYa1sRpQes6VuvqnFMruQaUvX+vpkTOb5DbEG2NHcCLWr0MVAxIKlCEFCAgHjV8 flspzLqw4tHv5TQ7irCiUxuMcNUgcMvTr/u695okMAh/b2APdfMnxEjszOiUtLDKFo G1l2cfv4zatu7uG2d/1BBldfK9GQMPfz8+rLwbnWs7ZYd6vpnUsVi7b06lkyoOLHc1 +s3tsg8sSrfg8IVChFp3PevImRcr//PkI3NUt/g86eUPYO67cpOOeEHLb/q5CYD4JC 6D345Ug4vC947/zv7KDbTlFnrM4eGhRHh0mg8drHI45UoesTLYS57/G3bDPT4jOse/ 4j6JZ5LD3zRVA== Date: Tue, 28 Mar 2023 13:21:38 +0100 From: Will Deacon To: kernel test robot Cc: Marc Zyngier , llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Zaid Al-Bassam Subject: Re: [linux-next:master 6577/7309] drivers/perf/arm_pmuv3.c:44:2: error: use of undeclared identifier 'PERF_MAP_ALL_UNSUPPORTED' Message-ID: <20230328122138.GA1275@willie-the-truck> References: <202303281539.zzI4vpw1-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202303281539.zzI4vpw1-lkp@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Queue-Id: 83F55140016 X-Stat-Signature: m3q9i9wne1p5b91jtdjxqrxwh5mys4fd X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1680006107-605634 X-HE-Meta: U2FsdGVkX18AdrmlADih6w7PAf+SDbOKpupbTbcnr20ghsWjSbrRpk1T53UI98d74fpeNBaQo/1NRe92QfWkn8+Dll1nUQ7Q4GyGhpkRVD888yW1GgEveZQyZh4NtexjyXkpNb4iFJg1ui1Hwq7AOYTIIAeQ2agpQKwzh5Da+X4gnc/E0c2IyeFdjWkW54TnrKWg9Ck2yKmFOCYbbujElAOVEGb4gCtgzlwmLQ+aiJmsujyvm9s15CqkBfss0DsHLh7i4CLvfbPLd2cwjQoPiY/wAWydJSkMuhfW5Lfh0rwGDWKhZve6YdTTdkFvDQS7ikJp9f3cnijnmmlJDQ0CpzEAl8Q4kPwGN0+d19ahg//R/h80Ai/NNQ25IfevR4zAW/Sw9J2PBtf2NdiyFg57a6ZWkEJkGPENFMVAjGLP+hHnYZgM/hdV02NGM/NGffWdqJq/EnPmvcctg4LgeN4ygh7f188/JDHLPm7PbNygcbxH1sGmPsTx8RvGGhcshaPZHAEBhrutldNCp00L7DNG76WqmhUwyQ/cULMPDxLakXl3qSCbrr2O0JHpgAsRMc8JWUrzBOZxxd20pbzf3UeTDueKWoAfZgnkmWR1Dq7aw2WHWf6rb0UiEJsR7DvvgkrqQ2I5SQMMXvYrL9O5QPg/8pZFyWSufAjmlBO0rE645hlRHlFCpGr198yH7mbhwiAgyeOKDeSk1JdGX2QAS+0XhKTOL8NMQv5E31zwUf2PuNuze8XK3pGlFpW2bUUvo3a+a64oYEG7MEONMLN92uD9sjWhZ7AERPMg1Pm+yz1oEqxDWOVgjqWsR7pQ+Fa7gH3TBSuXXFsmH9FM5Qm3TLz6wJSNW5RbKPhZVQDPAHomfkoSKgCYViQDWBpcrMr60E3EkDTAX8yXGsNMNJTh3hGHBBitOjF/TMKEfmxtL6V6ttJ8LQCcj8V3BCr4NmIvpjuf9g2bNL5XEAbJQ5Eg082 pJCYgi3H 0JIFQEn49NuIw9p9vMqtCC/ZGN0iyXmR0A17S6FGRxEKb+AWxibIaoGkZvY2XGStBdmVUJnydJjfxsVWumrXqk6MANiOjHtWRtslU0WOcss8pQyywYigoPIYBrmUdruzw05xr+jy7VCLF8o2at8Av5bCxjokZj3oBcJKupcfG6wGEk4LLnSkqSmokpAAvm2UUUiN8AcqmNJRzjukQwjhKz+fo7YOU3eSBpPlMkjCaYsypjPsd0YmTb1H5sg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 28, 2023 at 04:01:49PM +0800, kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: a6faf7ea9fcb7267d06116d4188947f26e00e57e > commit: 3b16f6268e660f15aed0bb97aefe87e893eb8882 [6577/7309] ARM: mach-virt: Select PMUv3 driver by default > config: arm-randconfig-r024-20230326 (https://download.01.org/0day-ci/archive/20230328/202303281539.zzI4vpw1-lkp@intel.com/config) > compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project 67409911353323ca5edf2049ef0df54132fa1ca7) > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # install arm cross compiling tool for clang build > # apt-get install binutils-arm-linux-gnueabi > # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=3b16f6268e660f15aed0bb97aefe87e893eb8882 > git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git > git fetch --no-tags linux-next master > git checkout 3b16f6268e660f15aed0bb97aefe87e893eb8882 > # save the config file > mkdir build_dir && cp config build_dir/.config > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm olddefconfig > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash drivers/perf/ > > If you fix the issue, kindly add following tag where applicable > | Reported-by: kernel test robot > | Link: https://lore.kernel.org/oe-kbuild-all/202303281539.zzI4vpw1-lkp@intel.com/ > > All errors (new ones prefixed by >>): > > >> drivers/perf/arm_pmuv3.c:44:2: error: use of undeclared identifier 'PERF_MAP_ALL_UNSUPPORTED' > PERF_MAP_ALL_UNSUPPORTED, > ^ > >> drivers/perf/arm_pmuv3.c:59:2: error: use of undeclared identifier 'PERF_CACHE_MAP_ALL_UNSUPPORTED' > PERF_CACHE_MAP_ALL_UNSUPPORTED, > ^ I think the Kconfig warning is relevant here: > Kconfig warnings: (for reference only) > WARNING: unmet direct dependencies detected for ARM_PMUV3 > Depends on [n]: PERF_EVENTS [=y] && HW_PERF_EVENTS [=n] && (ARM [=y] && CPU_V7 [=y] || ARM64) > Selected by [y]: > - ARCH_VIRT [=y] && ARCH_MULTI_V7 [=y] && PERF_EVENTS [=y] Since we're selecting an option which has its own dependencies. I think the easiest bet is to invert the linkage so that PMUV3 has a dependency on ARCH_VIRT for 32-bit Arm (diff below). Marc, Zaid -- what do you think? Cheers, Will --->8 diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index a5e5c0b09ff2..e24a9820e12f 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -401,7 +401,6 @@ config ARCH_VIRT select ARM_GIC_V3 select ARM_GIC_V3_ITS if PCI select ARM_PSCI - select ARM_PMUV3 if PERF_EVENTS select HAVE_ARM_ARCH_TIMER config ARCH_AIROHA diff --git a/drivers/perf/Kconfig b/drivers/perf/Kconfig index 711f82400086..cf1559581fbc 100644 --- a/drivers/perf/Kconfig +++ b/drivers/perf/Kconfig @@ -103,7 +103,7 @@ config ARM_SMMU_V3_PMU config ARM_PMUV3 depends on HW_PERF_EVENTS && ((ARM && CPU_V7) || ARM64) bool "ARM PMUv3 support" if !ARM64 - default ARM64 + default ARM64 || (ARM && ARCH_VIRT) help Say y if you want to use the ARM performance monitor unit (PMU) version 3. The PMUv3 is the CPU performance monitors on ARMv8