From: Muchun Song <songmuchun@bytedance.com>
To: glider@google.com, elver@google.com, dvyukov@google.com,
akpm@linux-foundation.org, jannh@google.com, sjpark@amazon.de,
muchun.song@linux.dev
Cc: kasan-dev@googlegroups.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org,
Muchun Song <songmuchun@bytedance.com>
Subject: [PATCH 2/6] mm: kfence: check kfence pool size at building time
Date: Tue, 28 Mar 2023 17:58:03 +0800 [thread overview]
Message-ID: <20230328095807.7014-3-songmuchun@bytedance.com> (raw)
In-Reply-To: <20230328095807.7014-1-songmuchun@bytedance.com>
Check kfence pool size at building time to expose problem ASAP.
Signed-off-by: Muchun Song <songmuchun@bytedance.com>
---
mm/kfence/core.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/mm/kfence/core.c b/mm/kfence/core.c
index de62a84d4830..6781af1dfa66 100644
--- a/mm/kfence/core.c
+++ b/mm/kfence/core.c
@@ -841,10 +841,9 @@ static int kfence_init_late(void)
return -ENOMEM;
__kfence_pool = page_to_virt(pages);
#else
- if (nr_pages > MAX_ORDER_NR_PAGES) {
- pr_warn("KFENCE_NUM_OBJECTS too large for buddy allocator\n");
- return -EINVAL;
- }
+ BUILD_BUG_ON_MSG(get_order(KFENCE_POOL_SIZE) > MAX_ORDER,
+ "CONFIG_KFENCE_NUM_OBJECTS is too large for buddy allocator");
+
__kfence_pool = alloc_pages_exact(KFENCE_POOL_SIZE, GFP_KERNEL);
if (!__kfence_pool)
return -ENOMEM;
--
2.11.0
next prev parent reply other threads:[~2023-03-28 9:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-28 9:58 [PATCH 0/6] Simplify kfence code Muchun Song
2023-03-28 9:58 ` [PATCH 1/6] mm: kfence: simplify kfence pool initialization Muchun Song
2023-03-28 11:55 ` Marco Elver
2023-03-28 12:05 ` Marco Elver
2023-03-28 12:53 ` Muchun Song
2023-03-28 9:58 ` Muchun Song [this message]
2023-03-28 10:14 ` [PATCH 2/6] mm: kfence: check kfence pool size at building time Marco Elver
2023-03-28 13:03 ` Muchun Song
2023-03-28 9:58 ` [PATCH 3/6] mm: kfence: make kfence_protect_page() void Muchun Song
2023-03-28 10:32 ` Marco Elver
2023-03-28 13:04 ` Muchun Song
2023-03-28 9:58 ` [PATCH 4/6] mm: kfence: remove useless check for CONFIG_KFENCE_NUM_OBJECTS Muchun Song
2023-04-03 8:59 ` Alexander Potapenko
2023-03-28 9:58 ` [PATCH 5/6] mm: kfence: change kfence pool page layout Muchun Song
2023-03-28 12:59 ` Marco Elver
2023-03-28 13:32 ` Muchun Song
2023-03-28 14:12 ` Marco Elver
2023-03-28 9:58 ` [PATCH 6/6] mm: kfence: replace ALIGN_DOWN(x, PAGE_SIZE) with PAGE_ALIGN_DOWN(x) Muchun Song
2023-03-28 11:55 ` Marco Elver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230328095807.7014-3-songmuchun@bytedance.com \
--to=songmuchun@bytedance.com \
--cc=akpm@linux-foundation.org \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=jannh@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=muchun.song@linux.dev \
--cc=sjpark@amazon.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox