From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44311C76195 for ; Tue, 28 Mar 2023 02:53:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7A6EA6B0072; Mon, 27 Mar 2023 22:53:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7572A6B0074; Mon, 27 Mar 2023 22:53:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5F70B900002; Mon, 27 Mar 2023 22:53:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 4CC4A6B0072 for ; Mon, 27 Mar 2023 22:53:34 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 1C7E01C5EE5 for ; Tue, 28 Mar 2023 02:53:34 +0000 (UTC) X-FDA: 80616786348.13.FD06B80 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by imf13.hostedemail.com (Postfix) with ESMTP id 2F66A20004 for ; Tue, 28 Mar 2023 02:53:32 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=fromorbit-com.20210112.gappssmtp.com header.s=20210112 header.b=N0B1misA; spf=pass (imf13.hostedemail.com: domain of david@fromorbit.com designates 209.85.216.43 as permitted sender) smtp.mailfrom=david@fromorbit.com; dmarc=pass (policy=quarantine) header.from=fromorbit.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679972012; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lWYTBx2VZ6h71XcB6iH3aK5E1JWkHx/k2gKbXvik2bo=; b=OjgL1wJ3H/ppGm2YqvmQmhzVP2q3u7wyt27B8p7MHUBox/zzc85Kef5kdT5PEDm6F4nHIM ye/T02xGzCa3HWqiyYGFaOXtZDzh28+PZfDh+PWWc32eKgv4H86EjMkvRQeFz9MluPcgv3 YjIK5hAyO3E9J/LI7iOW1+tbhJocucw= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=fromorbit-com.20210112.gappssmtp.com header.s=20210112 header.b=N0B1misA; spf=pass (imf13.hostedemail.com: domain of david@fromorbit.com designates 209.85.216.43 as permitted sender) smtp.mailfrom=david@fromorbit.com; dmarc=pass (policy=quarantine) header.from=fromorbit.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679972012; a=rsa-sha256; cv=none; b=qAYHuHpt5cFloMde6NxYDibQWeWaipajAIBKFo5NgijPdyW7c9PSvSkcnCF9c9r1KqrlJ+ l+zFvjV6bhGifBhBZhk6HGy2ct4Zf2h2EAFdKrcPcRfEh8gB1UjvoMANb26GgzoUWbbF1K AGclOnzimd9D21kXb+E2r7o0f8atrPA= Received: by mail-pj1-f43.google.com with SMTP id f6-20020a17090ac28600b0023b9bf9eb63so11061457pjt.5 for ; Mon, 27 Mar 2023 19:53:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20210112.gappssmtp.com; s=20210112; t=1679972011; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=lWYTBx2VZ6h71XcB6iH3aK5E1JWkHx/k2gKbXvik2bo=; b=N0B1misASakytjT3U6HWfwjK7TnGyvBOU1hSRBFekqJBvXuuYgEgZr3oywZehRUqSY r6xJkpQnhBXpoiIERUOnR17ot0i6ekYp7QKoU5b+ny//OXTf/u3IjjLcc3AVUM6IiHnu yGpo+pIqcyIV84FL57vU3VmbM4zWQEA93ts7zeVf7tNsIx9g+w8uVmRrcsOUL3BWHO0T C3IDOlZ5YYsUx6RRBRbF8qpZ0suvkx+r13FGHA9FHG7SU/Hzil4SxmqAgg/6Hxcudyqw awqnfY4yXMNAnzDVermXFJyWwEhGy2bh3B5WNUaKSHGo/nL/va41TlAWwL09K70fwBME t1VA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679972011; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lWYTBx2VZ6h71XcB6iH3aK5E1JWkHx/k2gKbXvik2bo=; b=cmpqgxqG6pmAI2L9GRbBQXQU3SKafBs8QVskwPruUeeOELrIMn7J0ECZXqMIm3zc9C a8nGY3kQ+5TDDrVyX4koPREgMFvZf7ScXSNMYlj5pRF6ekuPyWSnHr1m/mwrGXQ1YV67 X/L60usx9/FVkYVCSzQAt/JvaKlvFC/src6bWAWHyZbS/QjBom4YJOXsFW7FYextw5IO Un11v4E7WquXzkKVq75ap9w5ejON0zzNbx6bspQYcyHM9Umx7rDXEFSyMwTuLMbh7gsS w/hqy0jQIybBgyZQSKeA9YcCq/mrLMOQGjfTPsuJqVg4QwMH3Vi9LjRg/Ga1xMm1+43s 0b7w== X-Gm-Message-State: AAQBX9c3HglXB1fKuu5+EiKnZcybHqhRjChbLnOJsy4dewEl0o8w8t2x GlRZxGujJ4218W+qL0Fv1mLgow== X-Google-Smtp-Source: AKy350byEc3xPciw99yzx3LG7BZcgX8rx3fuloOHYBrG7cPj7FynObI6wypzA54S/DK4tOoVGIQszA== X-Received: by 2002:a17:90b:1d11:b0:23d:1bf6:5c74 with SMTP id on17-20020a17090b1d1100b0023d1bf65c74mr15002378pjb.41.1679972010979; Mon, 27 Mar 2023 19:53:30 -0700 (PDT) Received: from dread.disaster.area (pa49-181-91-157.pa.nsw.optusnet.com.au. [49.181.91.157]) by smtp.gmail.com with ESMTPSA id s19-20020a170902989300b00186cf82717fsm19877007plp.165.2023.03.27.19.53.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Mar 2023 19:53:30 -0700 (PDT) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1pgzSh-00E0io-6O; Tue, 28 Mar 2023 13:53:27 +1100 Date: Tue, 28 Mar 2023 13:53:27 +1100 From: Dave Chinner To: Uladzislau Rezki Cc: Lorenzo Stoakes , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Andrew Morton , Baoquan He , Matthew Wilcox , David Hildenbrand , Liu Shixin , Jiri Olsa Subject: Re: [PATCH v2 2/4] mm: vmalloc: use rwsem, mutex for vmap_area_lock and vmap_block->lock Message-ID: <20230328025327.GB3222767@dread.disaster.area> References: <6c7f1ac0aeb55faaa46a09108d3999e4595870d9.1679209395.git.lstoakes@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 2F66A20004 X-Stat-Signature: u8yo1ki4k964aswgj3q9wycabf88e5at X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1679972011-448650 X-HE-Meta: U2FsdGVkX18vWQZPRjBbWm3lA2DEaEq+8aVUPqaH0uQtiPUZPSDbcy7pkd99NDZny88z9ldvPiem9ODiUkNYwfLXuMlQTDZqkoxpvtWGtuy55Fnd4oN6YCx9My2LGVcQ8i0jgDYO8PjBFYkMr1bEvbqLccSq/5T0ANx0d0//++s6zF8HD1CjCmX8rdrniuWE+JMoUZMBBo1lCkr2ehkE+DpvA3ztiqDmqW0AImlL+xrYhcrpJ5YVmXz6Ym6ToyTpQy2mVoKlG/5jU5sEGGPxLIdCob66UeBCX+8znbhI5BMLoWuhj4wul+EKtoe3Niy330IPIUnv9cGNR1/esOmdqalcyyvVLqcCiuFVd9Z0p8pcz0nnWTqDwGmNJFI91pHUZ8G87uJzLqWK5ontgvfSe6UdvWIAukriJ5B/SN2+kEaYKPDGHipW+6qQNaKnqL7PP1KKlSJz2MZH+qls2unpdqN0cWa80Y4Kev5KsqRF6ghocxBTL8/B4PDheVlcJKxkAxTpYsSSteeZ39tuhPbOX07xeF1Gl9pniKeTxTYUYop4H5k/LNpg8Fc2s1hZ8d45xjF57xD1I94R84jRQj02pT2vAcKDG/s7RXeDSfAW9rGV7VGBTZRU6VPmCSQhKrwqJBhAurdohOPBGq78EUBa32CWXqi8GbM0PR1aEfkXxBLX4/5Eck0AeCCJXJk6hbcmO3fi3J/xr2h7YFRskUqwF0peYI8KhonH8lZNwCJ/nnXYR/wQndtR3dVSjaG2R0MufKi9MAeXRyMuy3Z7mMsir+U6IweyTjmSGqqh3LgyRnlDzdwnC+ZIXdfX64Os3gMl8leqBFkNGmrtnec9W0FT552mFyx79mi4tIewlQKceG6Ps+UPZl7nP4SVETdYz9zDPNqSXLr4RNMmrpWDBk6fjKAdEDxW+5Nnbfrh+VxFSaDxvsxom9bzE4cC5tUT4VDfW97MRZKbNIjaxNAYow5 TgPScn9H 2jMctw3bYgBH9YEfdIi5hdcNCm4TqwIySPsKJbnuShaz1dg/Y0OghZDYTAo2cZ0zlFape/XHw0r15Rdopek3cop9TkX2nWm3EIKL9GyhXJ+LOPTNV0CRZmqfNhxNsH7RKLlhMVJKwLy7CZBQY7QRsbi6MTIDmWN6orxthmgF/ze5jMY9uULZYfVumOd007xMzmqC9w8QiduEZFINpKBakIFODTUrcQbkw/cBM+Kmw/jFghtgrtVCZkgdkYcSqkkwidjiEoRxQ5u9puTUVIwwbEhR+McE9LHjpxnzt14y/oEyd310kZfw+9k5kzwXfTpIA8p4CMYkeeKh9UXH5ZPKB0cakSXi8cKcEmlf6uLRyF7f0+/yD4yUkOkK9i4pm/RHo5L7hwPnbxwLk3KmFP3yuGJ/opgYtAfLQ6jZTATJ0B0jp2dmzZb0BneC8sfa3s8Ts7QjbsHmkbfBsxDtpHWig6II2hQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Mar 27, 2023 at 07:22:44PM +0200, Uladzislau Rezki wrote: > > So, this patch open codes the kvmalloc() in the commit path to have > > the above described behaviour. The result is we more than halve the > > CPU time spend doing kvmalloc() in this path and transaction commits > > with 64kB objects in them more than doubles. i.e. we get ~5x > > reduction in CPU usage per costly-sized kvmalloc() invocation and > > the profile looks like this: > > > > - 37.60% xlog_cil_commit > > 16.01% memcpy_erms > > - 8.45% __kmalloc > > - 8.04% kmalloc_order_trace > > - 8.03% kmalloc_order > > - 7.93% alloc_pages > > - 7.90% __alloc_pages > > - 4.05% __alloc_pages_slowpath.constprop.0 > > - 2.18% get_page_from_freelist > > - 1.77% wake_all_kswapds > > .... > > - __wake_up_common_lock > > - 0.94% _raw_spin_lock_irqsave > > - 3.72% get_page_from_freelist > > - 2.43% _raw_spin_lock_irqsave > > - 5.72% vmalloc > > - 5.72% __vmalloc_node_range > > - 4.81% __get_vm_area_node.constprop.0 > > - 3.26% alloc_vmap_area > > - 2.52% _raw_spin_lock > > - 1.46% _raw_spin_lock > > 0.56% __alloc_pages_bulk > > - 4.66% kvfree > > - 3.25% vfree > OK, i see. I tried to use the fs_mark in different configurations. For > example: > > > time fs_mark -D 10000 -S0 -n 100000 -s 0 -L 32 -d ./scratch/0 -d ./scratch/1 -d ./scratch/2 \ > -d ./scratch/3 -d ./scratch/4 -d ./scratch/5 -d ./scratch/6 -d ./scratch/7 -d ./scratch/8 \ > -d ./scratch/9 -d ./scratch/10 -d ./scratch/11 -d ./scratch/12 -d ./scratch/13 \ > -d ./scratch/14 -d ./scratch/15 -t 64 -F > > > But i did not manage to trigger xlog_cil_commit() to fallback to vmalloc > code. I think i should reduce an amount of memory on my kvm-pc and > repeat the tests! Simple way of doing is to use directory blocks that are larger than page size: mkfs.xfs -n size=64k .... We can hit that path in other ways - large attributes will hit it in the attr buffer allocation path, enabling the new attribute intent-based logging mode will hit it in the xlog_cil_commit path as well. IIRC, the above profile comes from the latter case, creating lots of zero length files with 64kB xattrs attached via fsmark. -Dave. -- Dave Chinner david@fromorbit.com