From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6229C76195 for ; Mon, 27 Mar 2023 09:13:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 17013900002; Mon, 27 Mar 2023 05:13:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 121676B0072; Mon, 27 Mar 2023 05:13:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F02CE900002; Mon, 27 Mar 2023 05:13:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id E16B56B0071 for ; Mon, 27 Mar 2023 05:13:33 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id A0036A05EF for ; Mon, 27 Mar 2023 09:13:33 +0000 (UTC) X-FDA: 80614115106.12.EC74DC8 Received: from mail-qv1-f50.google.com (mail-qv1-f50.google.com [209.85.219.50]) by imf15.hostedemail.com (Postfix) with ESMTP id C69C4A0004 for ; Mon, 27 Mar 2023 09:13:31 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf15.hostedemail.com: domain of dcvernet@gmail.com designates 209.85.219.50 as permitted sender) smtp.mailfrom=dcvernet@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679908411; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Umb9hUbfu4RXL6KlGkF01LiyDptRngvjLvFGabW/70w=; b=7rCoWHrNBmq3hynYKFL+4CYbM+rvyrKfLVvm1aOdMcB+2oTPLd0Q3I0pq1y1662rLeNfnv hxJ3FcCIT8kzy3viZUsj0/XMkkAbilWV+sw/U+iKaOZ/qul26+AXLCsyG8KR9wMh9jGHfw qhaxNtro+0FhKDYWt4mKfYqf7C6DF9M= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf15.hostedemail.com: domain of dcvernet@gmail.com designates 209.85.219.50 as permitted sender) smtp.mailfrom=dcvernet@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679908411; a=rsa-sha256; cv=none; b=pr93ZstRzlT1JmJSeWq93y+8khel387n8MTg/oi8rmep7EP9ComcP7Er78EKfMgCx6GWIB PL6qwiTR5VqA4XdiRgit0Zkqsxvh7SxolEbRFo/PkoeK6BOD7KgytzQFS2hFJgn1R7T+VT BYAaRhXs4s4aOY4YwQKuutjCiv3zD9g= Received: by mail-qv1-f50.google.com with SMTP id l7so6246242qvh.5 for ; Mon, 27 Mar 2023 02:13:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679908411; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Umb9hUbfu4RXL6KlGkF01LiyDptRngvjLvFGabW/70w=; b=xutMhLc6B7sAyVDGTpSGkzebZOtUeGWkwzYQ0Go+c7ESqOoYQdlR9CH8pRMN1rUbjO J9OTyjGuvuEPqntPppgV85OJqZSPYbKvf86zs91X87VwZQVwBtJt5XkirQR80TQSzncB QDYp0WffFHN/9F1KgIrL/2Hg+kzi+GeDVcKnWPOSraGnbLBOChwOxMZbZnv4+7T9sKzB /xSgHloXJTIhyMbSIOxo1hNlfdfbOMhuQwURVwuJbfS2salprlfYouitonGakahvKvV6 ma7ZyS0VJk3hsOtwGxQ/bsgj7FtLdIIBnTw0IYe7V11G3WwAe9Tx8cD+93gue2TC1KVn RnFA== X-Gm-Message-State: AAQBX9eX+CqaJmLJ6Dh1QASjSX57N1RKQq7LTIUtrFgBzH3MlXcAhhOi +ZMqs7EajMv1xFWvzNq/lNg= X-Google-Smtp-Source: AKy350Y06rMs/401uxhflhl8CYmN7DqjbNmD9t0V5jGwKE6OwXPeDLRcEQJJWCwLvw2M9hVJch4zPw== X-Received: by 2002:ad4:5dc1:0:b0:5ad:e777:1fc2 with SMTP id m1-20020ad45dc1000000b005ade7771fc2mr14569629qvh.15.1679908410637; Mon, 27 Mar 2023 02:13:30 -0700 (PDT) Received: from maniforge ([24.1.27.177]) by smtp.gmail.com with ESMTPSA id t2-20020a374602000000b00746ac14e29asm6562753qka.5.2023.03.27.02.13.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Mar 2023 02:13:30 -0700 (PDT) Date: Mon, 27 Mar 2023 04:13:27 -0500 From: David Vernet To: Markus Elfring Cc: kernel-janitors@vger.kernel.org, linux-kselftest@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, Jay Kamat , Johannes Weiner , Michal Hocko , Muchun Song , Roman Gushchin , Shakeel Butt , Shuah Khan , Tejun Heo , Zefan Li , Lorenzo Stoakes , cocci@inria.fr, LKML Subject: Re: [PATCH] selftests: cgroup: Fix exception handling in test_memcg_oom_group_score_events() Message-ID: <20230327091327.GK363182@maniforge> References: <5b7921c9-ee5d-c372-b19b-2701bcf33148@web.de> <20230326213900.GJ363182@maniforge> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/2.2.9 (2022-11-12) X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: C69C4A0004 X-Stat-Signature: qu9xtjxa7ncab15u15ayw3n7wy14ptu1 X-HE-Tag: 1679908411-713489 X-HE-Meta: U2FsdGVkX1/m5Z5XPUL6n8dKp8l7b1am8hB3OCleySgV3T6Pn/dr8T8LgwNvMN+1zuwp0tI20k3pHH3sp3iPCu/8pUGi2JY0BW/xO96ACJ86b5JrxbuxlaxOEHf8lBnDRn45sDnCHi2jRRO2rEUZbz7znNzjyAK8Hs7/ddHY6u9eqrUTQ4n4bVMkmlX4RCGmkheKndFUhL6mRjnYTUIansmTV9O/2BiJ2t+PvC+DBcVmqt3dfmuO0WuDAb3JIpORZV/KUwDGgpNtC38pmLZWGIwXog0bAr84We3crkAh0KY5/cX+/Z7S6J223cikMtzhaOwavKVX4XTnqtjzTSFYUCRA2TGXV7f/bT8frE7tWT8tJ7VKJUyK5Crr3xVn3zE8eExlNraI66dKIRdLqVqFckR9v2Kj9p9KSYQArMNQzQhIUWZFnuKic2vrdD2IJVIbL3tSH4wkbIYIEcZ3cVd1CgINFVI2a5FoeijtkgPFk2LofVmcjvZ5PBOLXZYLRgV/+un/MUra8VCSP5rIE4YOd6z0feYAC2vXqImnrwy3mHTtvYK/pgadVRHlTkZuTozwMINYNCMocorYpQs03KLPoBwp180b4zebBAvNe8D9tlSAFtXsOxDkFEe9kyXs22EFJPalP6aFqIzbgvBfsYx/APd3KoN4uuvHYB2tiec4wvxPTG9bBsESd3RXztgU/d8rzvbpdfDbtR2xKybMaL0iHgXbLSFwTcmpxG6GaDWG2/+83T/jUaruu4WNeGcrnjghHiNhyUHWM6W+TrXaUiLcHPzzovjywuCh6eQ5OzjFNxYdFBjLDQPczfDPprd6/7H51+fD7hNyytKrIuF5Q7bOfp8pXvukL89RZ5yMC7+sD6FhDTi2z+YKYuVYsuoyv7qPkzi5PkC5dtBs0eEPNW3MoZ9mYo+yOcpgLcLvsfv44ikou4dnpLIl32FYrrlSRkVZsrJxmCknyFrmku6GvEx DuS4mQA2 brUj4X/t5Ln7EMtWWs/wRKjRlHD7oTvctz1e9ZZ19CX/jihOZryI0t0nSy5HSTyr3+D0WTJbnJMlvUhGdJVvdTuUktpKwqQdsJV/rEDg8CmjbJY1smYD1PdT4OKGv2rzoc6s+a/oY429AaESoaQIqtLDbEYPChATAhqO2HO+YumhNspn/gU+3pA/6k/ksUjBD/+KiDJTvSiAR/TN6eyeXwSmNL2MNsK9X9tH6c4Ayh8ryoDDjfoz8hPW6haGQ2k5eaAaGVORx0VhlaAiLk01uuZZ5qxLNIkp2RjEBgZPTpeBxDOCvcclqX0Xiivyb80b5q9+aBQIUnrc1QPukcVpP83NUZykpFLjhBSDvx57VR4X2wMjkXkMm4uSV1NWanL9UtcAJ5Xydcte1hRNKz1tAwsZN95jyCnwXdXiUcz2oj3G6wAMRv82T7DqnO75KEvVjJSU665hxcd1ZYPAUmsQTNG8LEjy9ZXL1AfRbJOLSSGyezNBP6/LCSROzOuOTkDgPZhdz X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Mar 27, 2023 at 07:56:03AM +0200, Markus Elfring wrote: > >> 2. Can a cg_destroy() call ever work as expected if a cg_create() call failed? > > > > Perhaps next time you can answer your own question by spending 30 > > seconds actually reading the code you're "fixing": > > > > int cg_destroy(const char *cgroup) > > { > … > > ret = rmdir(cgroup); > … > > if (ret && errno == ENOENT) <<< that case is explicitly handled here > > ret = 0; > > > > return ret; > > } > > Is it interesting somehow that a non-existing directory (which would occasionally > not be found) is tolerated so far? > https://elixir.bootlin.com/linux/v6.3-rc3/source/tools/testing/selftests/cgroup/cgroup_util.c#L285 > > Should such a function call be avoided because of a failed cg_create() call? The point is that (a) you were wrong that this is fixing anything, and (b) this patch is functionally useless. Sure, we could move some goto's around and subjectively improve "something". Why? What's the point? It's highly debatable that what you're doing is even an improvement, and I'm not interested in wasting time pontificating about the merits of a trivial "fix" for a test cleanup function that isn't even broken. Several people have already either advised or directly asked you to stop sending these patches. I'm not sure why you're choosing to ignore them, but I'll throw my hat in the ring regardless and do the same. Please stop sending these fake cleanup patches.