From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3925EC74A5B for ; Mon, 27 Mar 2023 02:49:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3A3FA6B0071; Sun, 26 Mar 2023 22:49:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 354316B0072; Sun, 26 Mar 2023 22:49:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 21AE36B0074; Sun, 26 Mar 2023 22:49:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 130156B0071 for ; Sun, 26 Mar 2023 22:49:48 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id C9AA1C0407 for ; Mon, 27 Mar 2023 02:49:47 +0000 (UTC) X-FDA: 80613148014.01.0AC5A66 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) by imf12.hostedemail.com (Postfix) with ESMTP id EDCD740003 for ; Mon, 27 Mar 2023 02:49:45 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=QWvKcHXF; spf=pass (imf12.hostedemail.com: domain of yexingchen116@gmail.com designates 209.85.216.49 as permitted sender) smtp.mailfrom=yexingchen116@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679885386; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lZcQsaKqPsYODcn7NEdpTeu2skOK0mYpDjHEOBZhZNI=; b=CoD8gMQ8FDoCKGm9h3vYpWR7slgh3JIzB4rNDQsntoyncMfcz42b0UN+U0tyT6wtYP3sD9 6n+a2nEF9Z2Jm/tLUPMDAExLX0t+Rfef1ZP25GOZH68iLrNinG1fxYam6bSmrZzkS8OL52 12kC3EKA0w96V55H0LFGlLRTMn8EcrU= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=QWvKcHXF; spf=pass (imf12.hostedemail.com: domain of yexingchen116@gmail.com designates 209.85.216.49 as permitted sender) smtp.mailfrom=yexingchen116@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679885386; a=rsa-sha256; cv=none; b=uGui7idtqeG4EYrVYhkJR13hF+lgW6GXKqZfVNbNc571VLTehAgeLt1TOh6THm+4ufAKbN HEHrmuR66AJQCuxmKpOdJm+MfAlQGlfw9/6hyyCpVSH2mp+NcHRLb3TsBdSPC+ZbCkSK3D OKzZAwa7dFkNmkht0+4YysA/0YYzsVw= Received: by mail-pj1-f49.google.com with SMTP id d13so6384290pjh.0 for ; Sun, 26 Mar 2023 19:49:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679885384; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lZcQsaKqPsYODcn7NEdpTeu2skOK0mYpDjHEOBZhZNI=; b=QWvKcHXFONWC/e5VNLgEPbSpnj/5r/olSwdrPKXsNpBcLpAxkzvQjL13+lxTSeSAfB Qn4vEg/F4y9vVnFM/MkxczLJq8ZocaI2b5V+QNo2QfyA8ppIYBzmID7T0h0lGYwu1PQo sUu5HXyYEH2NWK35b5HsE3a+8oG9UcbPvYH0NRzzv+KAp9EmLKeRnNOFBeFuBVGt3X5t Td4kWKUdnpOWs6/7HVHls9yPLjR66b3c4IH8AoRSG5ifhUEh7EnzqZ3okP2Xcj8p1hfN uII0hhoTLMGXAm+mY1DZpfhdI5bqJ6n97qG3oaagbLSs0/jPpeV0MQm6zDk7yWrQCc7C 9A7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679885384; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lZcQsaKqPsYODcn7NEdpTeu2skOK0mYpDjHEOBZhZNI=; b=BrvFYBvfYCzprc2RTKgnHZ1Wymu4Q/Rgd9TIybFfvPESUbgKiLQbkxq7ZVtsZhhTww I6kBvRc081pTqgRrBf6YocTjsL/x+FKPrwtsbrPhJ7KlojAjrdUE/EFhmpqqScsOmHZd sRTZFEZLNxre68SWC0wLDArRq+/s2A02QFtt3gNay5z6kHGynWSJmo28+NH2VT9aYIiH ItJp/jba66VmQaSAQZVtQhiAIPf4kELmxCfep3h8Vo7Sk2jpOop/UugATcM36hdigCAt vAiR1ZTppgamCGFFkzYE0CYblg/YuPx7MxbXZyytv0LGc54vo/CBs0vUK8XIcP+U2Ft2 BYWQ== X-Gm-Message-State: AO0yUKXbe8A+eWo0+2wcOovf/YgH/ieXEV5SZ8J3cZ5HEDyZJHeVryHx VINmNHfRR+NrRe9AcRguD0A= X-Google-Smtp-Source: AK7set+DNUMpkQrLkhUBJLlg15M2PTfMouOephHlqqbA7x5u77dluG62bi2bdlw4tnJhvrHSDmYRSA== X-Received: by 2002:a05:6a20:8009:b0:da:4be2:caff with SMTP id e9-20020a056a20800900b000da4be2caffmr8920064pza.56.1679885384570; Sun, 26 Mar 2023 19:49:44 -0700 (PDT) Received: from localhost.localdomain ([193.203.214.57]) by smtp.gmail.com with ESMTPSA id a17-20020a631a11000000b0051322ab5ccdsm4916477pga.28.2023.03.26.19.49.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Mar 2023 19:49:43 -0700 (PDT) From: ye xingchen X-Google-Original-From: ye xingchen To: mcgrof@kernel.org Cc: akpm@linux-foundation.org, chi.minghao@zte.com.cn, hch@infradead.org, keescook@chromium.org, linmiaohe@huawei.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, vbabka@suse.cz, willy@infradead.org, ye.xingchen@zte.com.cn, yexingchen116@gmail.com, yzaikin@google.com Subject: Re: [PATCH V5 1/2] mm: compaction: move compaction sysctl to its own file Date: Mon, 27 Mar 2023 02:49:39 +0000 Message-Id: <20230327024939.75976-1-ye.xingchen@zte.com.cn> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: EDCD740003 X-Rspam-User: X-Stat-Signature: f7uwqyhqbkhp1retxwej1khu6dwtpfzr X-HE-Tag: 1679885385-469884 X-HE-Meta: U2FsdGVkX1/rqUItZU0mSXJCVoAEddAe7aaUNZzgOqLGZiMJCousru9l4P2t7SwSdMw1YKDiZ3AsTNXVYyTuAtFnzrwFih6/2Zk9czpMv7xfeC0QNb6CYXrjRzLtcMKXm3nZMj/1fgYAdQTIgayJcIJBKu4vPIj/NrRt/tQl3BqZXvV1Gi1ILhxVwEPp1gvBqmcP6XCvae4bD1YCX/vkfF/GVnLBZ0GcYimBSQ+ALzR0Eb19UdAwt9xCXe0bSkLkBYsT0Bf2BqLTtd2vULDOvZYRAuzpS8DjTTyqkbGko+tmTItFlnnwmYrmYJgCyeqDfPc7etKUBVKztOF0RlzG/gJPCq2fYIw3drjRQxW1tjfLUkiRgk0m+bgRy0xavOqmfdURw6mGK6Sa0hPKBvyYv5E873xwrKGTCysJX+/dmxvO7ZiBa6Jh4yI4GCjUeuoaLfNlLc+9Osl8LFIbqbLcgwP2Pms8d9acUT3p/B/B6cBtOm6nwQpCoTMThS4q//J8upPyPY2WKUWagUJ/IBUnUQEQmUlXJ+rju5JBmzMm6gsq133rvUygs4lUekMNpceTS86e085NeriFdROmVbhBYF5WAIx5EIZDm46Un8vA4KwrMzffEmR3ODpF6Wdjwo2GWQ2tBPF4/pviMLuFUdzPfjoiuP2g4d5pR9OHBOyAACOvhlRmJU4z2OpHYrqPp8NqhSC98M89YaQv+X5IvgtghluXKtI0zmAosh3gwHqaMhzaFnrh3+O7CNcIX6jry7hoKfJWdLGa5F0VimpTvv/mWEf+T8SPy+jL7+6wHgpnDHEt2k12p7hmjcztPjoeJJW165TLdr6iLNQoSVX7jMa5LLNVuPEdE5o8CR8Q2CykPyj+M0BYxoeV4IyN20jKnG3w3Q5TMjOaFUDk6vRDyQBlYufDA/L9kghT/pIPwOP5Cbu0cRcJKXgQCOhnkPnwYGjGRQJpCII8BKCOuYMMVOv ptQkZGTG 5a95/L6iIgStm6ajbHIpamQwBoSAP4WDE3zzIUMvSlKnkdPoqxsLPzuKt8RtfjAGVKyCbI2qDqvZMDDkxg3ulc7igzmKoQmmQ9kenK3ew4k1UD3RXiWmK1yYqdnWuZkjCq18eCI+Th848ArsWxwjp1FpppvTFi+TM0UuM4cAY8hbw2r+evXm+o+i7gCjmBcnDFMGG6NKS7ldxeY2JHr7iDfO2tV/lfpGAtVixQjrpwF+xGUgNimkDfVLbm0I5BVj5N5/86e2jN0/6rqWIJmPnEd95dYVVyrhcWDWOLXXgfaibTwQvyGDt2crwgS5soP8CfMPMwpCiBZ6GpFxPdr5NMFYQ8bVynmEcLfvlbxzqfyqrpTWUQNADXWFH4zv13xyosAR73MflxlJKTAwiCpUNBbZQKQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: >> >$ ./scripts/bloat-o-meter vmlinux.old vmlinux >> >add/remove: 1/0 grow/shrink: 1/2 up/down: 346/-350 (-4) >> >Function old new delta >> >vm_compaction - 320 +320 >> >kcompactd_init 167 193 +26 >> >proc_dointvec_minmax_warn_RT_change 104 10 -94 >> >vm_table 2112 1856 -256 >> >Total: Before=19287558, After=19287554, chg -0.00% >> > >> >So I don't think we need to pause this move or others where are have savings. >> > >> >Minghao, can you fix the commit log, and explain how you are also saving >> >4 bytes as per the above bloat-o-meter results? >> >> $ ./scripts/bloat-o-meter vmlinux vmlinux.new >> add/remove: 1/0 grow/shrink: 1/1 up/down: 350/-256 (94) >> Function old new delta >> vm_compaction - 320 +320 >> kcompactd_init 180 210 +30 >> vm_table 2112 1856 -256 >> Total: Before=21104198, After=21104292, chg +0.00% >> >> In my environment, kcompactd_init increases by 30 instead of 26. >> And proc_dointvec_minmax_warn_RT_change No expansion. > >How about a defconfig + compaction enabled? Provide that information >and let Vlastimal ACK/NACK the patch. I use x86_defconfig and linux-next-20230327 branch $ make defconfig;make all -j120 CONFIG_COMPACTION=y add/remove: 1/0 grow/shrink: 1/1 up/down: 350/-256 (94) Function old new delta vm_compaction - 320 +320 kcompactd_init 180 210 +30 vm_table 2112 1856 -256 Total: Before=21119987, After=21120081, chg +0.00%