From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A95A4C74A5B for ; Sun, 26 Mar 2023 23:29:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 23E8A6B0074; Sun, 26 Mar 2023 19:29:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1EE176B0075; Sun, 26 Mar 2023 19:29:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0DD166B0078; Sun, 26 Mar 2023 19:29:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 023996B0074 for ; Sun, 26 Mar 2023 19:29:15 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id C3FAFC03DA for ; Sun, 26 Mar 2023 23:29:15 +0000 (UTC) X-FDA: 80612642670.27.E1FC05A Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf15.hostedemail.com (Postfix) with ESMTP id 10A67A000E for ; Sun, 26 Mar 2023 23:29:13 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=none; spf=none (imf15.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679873354; a=rsa-sha256; cv=none; b=QY4uLVpS/cTgqgTtb7pYLCFOD2TEYWzyJy0bYCKVXbYuNFi6NcJ080DeXahb5HH5FqXnnM hShJszNHW2OkkahSHHq0jHWI7Ev6dGlHwyuDADjL6bVlvzwPURxTamOUIir0PwBu31rCJk qGzwtYmBC3zcs48QJInFWvHsi52CbPY= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; spf=none (imf15.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679873354; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wEh1v7PHK+ZETJ6Q8RPQEIvDKmHW77CNRkNCzaWd2mI=; b=vSp0jamUZQ2KHxIDlFuuN3Iv0bmWsSxwKr3vLNksB1+E6RUDHNNnVcdieK3eTARw4mUORj RudKwlIizR93N2Kjpg85lWsyrepNxMAq+Yh2m2Patv6FDr/h6bunlGE0W5VmA5KJ6qoLRk TNj+BxM6D1BkjcDoLy/CH2QCQ5G0MKE= Received: by verein.lst.de (Postfix, from userid 2407) id B7DFB68B05; Mon, 27 Mar 2023 01:29:09 +0200 (CEST) Date: Mon, 27 Mar 2023 01:29:09 +0200 From: Christoph Hellwig To: Liu Shixin Cc: Seth Jennings , Dan Streetman , Vitaly Wool , Andrew Morton , Nathan Chancellor , Christoph Hellwig , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH -next v7 4/4] mm/zswap: delay the initializaton of zswap Message-ID: <20230326232909.GD19631@lst.de> References: <20230325071420.2246461-1-liushixin2@huawei.com> <20230325071420.2246461-5-liushixin2@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230325071420.2246461-5-liushixin2@huawei.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspam-User: X-Rspamd-Queue-Id: 10A67A000E X-Rspamd-Server: rspam01 X-Stat-Signature: u83ynnzj61meyi9qr978zmojsbo13tcg X-HE-Tag: 1679873353-41244 X-HE-Meta: U2FsdGVkX1/Faa8AqeXRC0HgpgrtH1ewIHGkhyVGr3S0xxurY5gUB0cOb90i6QcXqSew/FEE1RdRzrOWbDuPM9kZgeAm4vTNlbwSfDyRG/pBhaAA1kIjVYUSfeWcuDD7AKnxpbW/XD597QcK2WCwt1pHkEZfAjhji3lOBlsnAsJMRWMIWo75Yov/VC2TvC6Oi5f7JNPrDIpMct01EyRX5Tu9EQj2dYSMNBjebQV65iwpy4AKnNQfGQFFxio30vbjeR46QEk64OIpbVn+sTJ4Qr27PuUMRzEoYEE6oVSZ4dI/r15ro7k48I2cSTYPjYKNhDqmNSmO831MDujiYLh6qgwL6Z3cQ+3vWzZ3AaxeyZUDT2bTOZKrC9b6kOmKmexLFpsJsG1AdvwDXW2/OYYHPHwzGYNa7x0xce7htG8JmWrLbkuXsskmssC7eQBlRVI3ht8pKnIDZoL3G/Nc9iuATW2OZzdnL6N4mCMVbpJqqIKktF3vGBPA5NUNHtWg1Y0KJGZrrOBA51p67wXdWL3X5HoTvphw6gHE9VwXbqdtmTUNSbE/L8kmXINYm49utdYgNCpEZKesZMBltc4cqxQVmwP6+GiNVGEc7lnS8hXs1biLjHYTYyCKFwRSceDARc0ouI3HRDhgFxGNLC0PxJdRUPdkmK6Dl99T3XP4N6EJw+bs3aF9L644k7K8Dp5TAp+5Mm2tbFAvGHGNhrtyqQHJKc8gBJtYhPuk0mg/EZdqWh9sjvwEtahAqvoGtX1/C3+mjEI6gvKVfpsNFeuNo0pMRPAp//q2VXtYPjOcl45k1LUI3IWsADOC5rW0cMYSf2krGjwQiWnWRMotpI75RoOMXWLhBJOuTaXbAzZPNs5mn6a1YLIq4fdSz87lB0yZHRLOOdXbgMpFLe9GK734hkkASd9+T35qRlAoBvIaHJvwpRC12m0j31sRal7UW6drCQSrDgwMHtuJUiUVhlDcoeW naKn007X h3dlGyN3cLRv8lOmctaQxq7O8OWxluGKSDoEBOU8xrAO2Z7l7eCAs6fyBkDrZAYis4ikS X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > @@ -1480,11 +1500,14 @@ static int __init zswap_debugfs_init(void) > /********************************* > * module init and exit > **********************************/ > -static int __init init_zswap(void) > +static int zswap_setup(void) > { > struct zswap_pool *pool; > int ret; > > + if (zswap_init_state != ZSWAP_UNINIT) > + return 0; I feel like doing this in zswap_enabled_param_set would be a lot cleaner. With that we could do a switch on the possible enum values for zswap_init_state there, and that is a good way to explain the possible outcomes.