From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09266C74A5B for ; Sun, 26 Mar 2023 23:26:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9953F6B0074; Sun, 26 Mar 2023 19:26:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9441D6B0075; Sun, 26 Mar 2023 19:26:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 833486B0078; Sun, 26 Mar 2023 19:26:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 7545C6B0074 for ; Sun, 26 Mar 2023 19:26:30 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 4BD32A04ED for ; Sun, 26 Mar 2023 23:26:30 +0000 (UTC) X-FDA: 80612635740.05.5E9796D Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf13.hostedemail.com (Postfix) with ESMTP id 942252000B for ; Sun, 26 Mar 2023 23:26:28 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=none; dmarc=none; spf=none (imf13.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679873188; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cQoaEyS619AVeCjuoGdKJ3+8dFnE26McnA0VnrVDh7I=; b=uH/Z8t7ohf/i6JCo9JkLf3lcpoWX/yG0Ua1a3QBys9fzDMwi/r9UbbdOa9D9xtXsXav7Ii IFi8nJ3EdCNf2pcs9amWvZe3x8s1k1XzTR1Z2Lm7v2NQ/btruQdtFS4yENLzIBRqyLYmRs ejUAW8DZxZBu5K6H14H41BO2EVog60o= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=none; dmarc=none; spf=none (imf13.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679873188; a=rsa-sha256; cv=none; b=8opn0cVtPwWvI0IXnG1vWVai8qAFGl6mJRBt50o3eawLJx9eTj24zvNwXXaQtttAY0QaBn Hzf96JtzQE+2u6L6x6etp917pKT6cSyf9VdpoiCEOTZt9T2a4skl1cYRGHd6grGLhpbZBi oM0CJ21faCKnsE+0xlT8S8wOlDroLe0= Received: by verein.lst.de (Postfix, from userid 2407) id BB5CB68B05; Mon, 27 Mar 2023 01:26:25 +0200 (CEST) Date: Mon, 27 Mar 2023 01:26:25 +0200 From: Christoph Hellwig To: Liu Shixin Cc: Seth Jennings , Dan Streetman , Vitaly Wool , Andrew Morton , Nathan Chancellor , Christoph Hellwig , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH -next v7 3/4] mm/zswap: replace zswap_init_{started/failed} with zswap_init_state Message-ID: <20230326232625.GC19631@lst.de> References: <20230325071420.2246461-1-liushixin2@huawei.com> <20230325071420.2246461-4-liushixin2@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230325071420.2246461-4-liushixin2@huawei.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 942252000B X-Stat-Signature: apu5s3iy78sk5jsk9fuz15wup6rdyomf X-Rspam-User: X-HE-Tag: 1679873188-98355 X-HE-Meta: U2FsdGVkX19jIz36HGdhEDewmcAaAkBy0WOqKXBrBRMgCAbkGmzLZe26yEi49zrh2u28RZzN9uySidDmNDzRU7wSz0ndBL762YFxB5x+eT6owy+vucxoLkvnBxpfYcL/k+GKrlkg641MOsxFXkpCEa6dABDNdsPZfgAWPdHhZDlfzBii9s0aHak9PsVYkTrjH9r8JpzyxG9+JjRV7M4d+B3zBrvvuo/dYw2YCW+ILJ9myZo7uyDhpMeiViRV5AfcGZnSOoASpX5eqYWukDSx9KZVrh2h03aaZ6QBHELB5KthZ+yjrf/AH4mNgr1JmN9LHsZPtUEhr2NfG2uYEJJ0xk4rRcn4IG30Kf7OblXN9NpB8ADHKVwvqBf3pQEyQW/XDtAVk+CgPbCkDoTDsWn9w/UD0yArSLqkKpdzzJWWDNrrl1Ts1O9foCENKx1fUV7uuchmANfivJtsq+9FLGPi4ti08PMZ+zqxon/Rvt65rAYF8R3DM3uiDcuCMsIJnzv2IreUTrMBSBTLTT/nNyyLiLquetWHp5aMWdqM62wpHzEH7k08coAZOC5RfW6aKUVdWkYI74AjP9x4B2lEoc/7vBXCYHdLMeEueOb5AOItNpFmg0fNuaboFJrJY+ZNpMKofvc+6A3lZmxEBHKyk/jnbJ9rRNMslDu+nZZm2I1JycDXJ2imnzfeFj1la9ZglNqxu2AtLDJcWBmf2AIBI1E4vwknI9oKBEHlL0On6em+6f1F/PdXe3BPnbsPKOjIHIFwMafRP0fm94/zssotKpCEpirG3fCLVr4K4PgX1mtO5P2PwWpYPuD6hjgz8dV229MIikeAvtM3gLMXbUMB+uCyOMs1B60f47bx8UkPfNW2uiJxNC5iZAl5WPZFPTsIs4EVllGbvUfY8LsTz4Ri+Nw8gqx18tGlD4UtaT3jfyxc/jfNqCfWsSDh1Q9WohuO2sqzpgfakwS9UlFl+5g7xaI 4M5OE7cv RhYUHHViMEk3sk6oLAds2XijvaAayoCrL5ROj88I9NW7G+s53ZrWD2hlygV+tJUpGy81KvxxpuahMyNqVXg8yGyfSsG+7b2gpwo1OjWXbAc5FC7Eew1/r2mILeg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Mar 25, 2023 at 03:14:19PM +0800, Liu Shixin wrote: > -/* used by param callback function */ > -static bool zswap_init_started; > +#define ZSWAP_UNINIT 0x0 > +#define ZSWAP_INIT_SUCCEED 0x1 > +#define ZSWAP_INIT_FAILED 0x2 This should be a (named) enum.