From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E3B7C7619A for ; Sun, 26 Mar 2023 21:39:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7E9376B0072; Sun, 26 Mar 2023 17:39:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 798C06B0074; Sun, 26 Mar 2023 17:39:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 660476B0075; Sun, 26 Mar 2023 17:39:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 48DAF6B0072 for ; Sun, 26 Mar 2023 17:39:06 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 16D051204D3 for ; Sun, 26 Mar 2023 21:39:06 +0000 (UTC) X-FDA: 80612365092.29.51FC964 Received: from mail-qv1-f45.google.com (mail-qv1-f45.google.com [209.85.219.45]) by imf16.hostedemail.com (Postfix) with ESMTP id 3B3D5180006 for ; Sun, 26 Mar 2023 21:39:04 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf16.hostedemail.com: domain of dcvernet@gmail.com designates 209.85.219.45 as permitted sender) smtp.mailfrom=dcvernet@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679866744; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DIQ9eIlSpAA9+1gG0Uwa5651wmcDfg3GdDljDetIFiQ=; b=0pzXoGaovf1NSQEazGkNzh6zk2J894TW2VZdw+MOy7a867etEQPsSy8CPSwEI9UNRP8DUW ayKMSqYlfh8y8/jlaKtNWDyFOP2UZjZH0m4So0ewFKqGK7qkf1Jlu55xeFWYqKt39B8Xvx Xlv49pla0xKB3MN4fbftjpzEqcxQmtY= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf16.hostedemail.com: domain of dcvernet@gmail.com designates 209.85.219.45 as permitted sender) smtp.mailfrom=dcvernet@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679866744; a=rsa-sha256; cv=none; b=FawnqBXERt1hIYGPHran9aO4HPzTa3COwUKnE0M4pRUkk8KJfD3u5GO2whYjgAQOra27oD g0yxL74z9W0Igbd66ras1z9LjKlE+dGsCyl94PPkLUpuwNpFwclkSpuzYWnXKmLgUL8pWX JxWkxuTaAz0520Hz1VwVXIhRk02LQ0Q= Received: by mail-qv1-f45.google.com with SMTP id cu4so5599372qvb.3 for ; Sun, 26 Mar 2023 14:39:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679866743; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DIQ9eIlSpAA9+1gG0Uwa5651wmcDfg3GdDljDetIFiQ=; b=iA+ahQat5NPSLZgfLZpO+ldJwAoIVQXtewiXqewL8Ak354oCIZxzlzgqzIJCSA9VhG aSHk66RIvXMnkAiDxwV8BIgddL532vUDtBWFkf5D2hU3waVVf+irz79A78Isxj1WaAOR /ZuS1I4SQuTkLfoUawLZBzgE8oSs8Js9nBuinUEBbrNL8CWnkxqhY9YJeydzEkrlSwfh 5earuMfc6Kt+nJ6rWUPQ/5Pd5gZei2eUMUOKkiPzhoZaMdo0LprHAq/WEqaMOb2nBydB kWmIFOXaKxxhUyGSFBwNjCjMILYj14VbCVPnjqErfHnTGsOG5gDq5B6nAh8Nd6xh1YLE tNmA== X-Gm-Message-State: AAQBX9eRGJarp8a8XI70v7spOusG6HVMWNdg+fZgKshDWdM8zofiD9z+ HDBE+dpHhS0f3iM9nK/ZsIw= X-Google-Smtp-Source: AKy350Z7u9qMmrS9h4j5TqP1uMWZa6oiBm2m+vreuWKuQd9iOVloKRpZ6D+Ab5O3wvFzZz+hpT3GsQ== X-Received: by 2002:a05:6214:4114:b0:5aa:fd43:1fbe with SMTP id kc20-20020a056214411400b005aafd431fbemr16826372qvb.46.1679866743277; Sun, 26 Mar 2023 14:39:03 -0700 (PDT) Received: from maniforge ([24.1.27.177]) by smtp.gmail.com with ESMTPSA id 75-20020a370a4e000000b006ff8a122a1asm10659270qkk.78.2023.03.26.14.39.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Mar 2023 14:39:02 -0700 (PDT) Date: Sun, 26 Mar 2023 16:39:00 -0500 From: David Vernet To: Markus Elfring Cc: Lorenzo Stoakes , kernel-janitors@vger.kernel.org, linux-kselftest@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, Jay Kamat , Johannes Weiner , Michal Hocko , Muchun Song , Roman Gushchin , Shakeel Butt , Shuah Khan , Tejun Heo , Zefan Li , cocci@inria.fr, LKML Subject: Re: [PATCH] selftests: cgroup: Fix exception handling in test_memcg_oom_group_score_events() Message-ID: <20230326213900.GJ363182@maniforge> References: <5b7921c9-ee5d-c372-b19b-2701bcf33148@web.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5b7921c9-ee5d-c372-b19b-2701bcf33148@web.de> User-Agent: Mutt/2.2.9 (2022-11-12) X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 3B3D5180006 X-Stat-Signature: mq119obormwa48j577yxj9bcpcj7cr15 X-HE-Tag: 1679866744-240905 X-HE-Meta: U2FsdGVkX1/Bw3517eOffURayKVo8lyFRYp5d3E8lldbDRGYkXWDiTqYScNLJB0xAenU6SmMSUEPUwRPEI46ln5ZRLWOayNx0ijZhd0a1YioPFOZQ6+kKVYZbuVCkNW71GB2fZEMzyOqcFVeGRmobjNUy9pn/80a/qNUT83h9JUx5XkMU999x2gEXpeujnsLU571Befg/fbn0mynQY37gK89eL/sohoQkmtolVmEV6gUItzMwJD6iiGrW7lcwYudV+lFy/B/suM6Jegv/ILHCoZ+GYGpDDXbeL2tgAPEh0P9uVyALQOcS1yoYP+/eGpoAliKxIwERrfEBVyPorx6RKdN0rc6bUONzgFUIm3923MMIg1bptiP8OsUvRvhj7o1xZRnMY38pIorqAwfd4e1jPp5XFMpQqaKWK3O6qQ3vON2xjRB2bcK0pv9TH0hutXKU6nVoUkUNcqB2F2sAycc5/bJz2EZn5ELYlHmAuQcTNCpRwmSis/KOxT3SbyYZnFxAedad3A8zYNrIBgYcfs6PUhep9mDCgKL9RIYzFF2oCJH3QMqMiU7YG5tbVoBjuE4cCCdc6mzrXdNppI6Bt3A1UW8p83mC1Eetjw6C7CRKEMPNs5JawZmVsnuGnJdHrP9v8J1YE8WAqrjcOz4YRexCKtqWX2FDHHhVpmKgqnGJOZ9VfmKmORcRiB06ob6yEXjh3zwqM5awB+UgmsHKqvpEPU8ziXw7oCfqNpyjvbG2oX8eQ7/RIujlCCw7bLhDZWks00fuuunqdAGCaaZ/4/tZAwamk/Fh0zHipRt+/oDZzozGG/YCLXV0U2lpBflXq1leSxr3abozg8JZF/Sz563fDwP1kPb1pWjennCWBx8BdoV+juad7ECfJE8eBYvwR9wJhY6/VS4xCj7C+QFjqWhwUPbv2wtq/CeDyP419nS6050cw/o1r3mnU6JlYB1/MVrs8Kk062u+2vjoNKgpbu D9y4tVfJ hY72jx8VV8oL1iuJaWq4ZWAL5p+qq0nuYHtAHd8FRJJr/HYnzncWzHMj/VKGWHsY9NxiMq9q2V49C3788wYId4kEc1cJBYdZIczFHuue1kqZ9CyXpwNGoBtuOOoBPC/dG5VUGiMl+nL7opk4Gbc3eRjQUfhIEpk4fC3Yy9A6Ft375chR/dH4Dtuz/FSt9w0RcBJlcWRVXoO34ELhssVFqvu0rDFC+AZKn/xcp8bWKlfVW2FPyWFaavwZrKPnp8lMiTCoVkexM4NPKh2nPlHMTW8kn86r1QL2C10Q7a0RKdsZ4G3m1ulA/ozFOYizQXe+MNqOcC/XV6OgRBILeRUB85B76nfJiqyBgeQbhlCG1qgihj4ZzKdcSoG07o/F1IJ7vLWO/6zIo2fF/liSwfsd6PxqbI2P8wLe/aBhGbAnMpFjquQn05K3N3SgISFETDbjoqFvxupsDFgJlvmo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Mar 26, 2023 at 10:15:31AM +0200, Markus Elfring wrote: [...] > >> > >> Fixes: a987785dcd6c8ae2915460582aebd6481c81eb67 ("Add tests for memory.oom.group") > > > > Fixes what in the what now? > > 1. Check repetition (which can be undesirable) > > 2. Can a cg_destroy() call ever work as expected if a cg_create() call failed? Perhaps next time you can answer your own question by spending 30 seconds actually reading the code you're "fixing": int cg_destroy(const char *cgroup) { int ret; retry: ret = rmdir(cgroup); if (ret && errno == EBUSY) { cg_killall(cgroup); usleep(100); goto retry; } if (ret && errno == ENOENT) <<< that case is explicitly handled here ret = 0; return ret; }