From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CBB1C74A5B for ; Sun, 26 Mar 2023 04:53:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 31453900003; Sun, 26 Mar 2023 00:53:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 29D40900002; Sun, 26 Mar 2023 00:53:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 11828900003; Sun, 26 Mar 2023 00:53:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id F2F12900002 for ; Sun, 26 Mar 2023 00:53:36 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 80FD61203C2 for ; Sun, 26 Mar 2023 04:53:36 +0000 (UTC) X-FDA: 80609831232.05.B2F104B Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by imf18.hostedemail.com (Postfix) with ESMTP id 93DCD1C000D for ; Sun, 26 Mar 2023 04:53:34 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=IcxZxSEH; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf18.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.170 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679806414; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8QM1QHLHovDhJzAjlOXny2HDNK64Zjmklql6ekR44ec=; b=larSjp+jrIrG0g74vbDJ30tvvdmxJSwwXwoWK5GZU/BWBxdkBmuWgXU5bdGm2xEDt6ndAh Z/cfM2z//sSRIMbJVsS1/jkEkyOqLgzi7muPU+CdRp9/z7vZEMWKhJ1RCF8ZNy8baNaVlD wk5WAFiQoSjBnxPfqd3+pTACGpyXZF8= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=IcxZxSEH; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf18.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.170 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679806414; a=rsa-sha256; cv=none; b=j2STiPA3uoZ7Wzg8eUe0gi2vZNmZSOvtmj7Ynophtc8OMxJwkn7ENkupDv56KVFFGO72rP PaqMT3KtIKPsDfNClhw7UFdggERI/J8uHLH1d0GvKv2S1DWoa/CBvJ/z2xN1cmdpFr5c5x Q41icfKFKTqXAeI11TRW9IGfEE+58NA= Received: by mail-pl1-f170.google.com with SMTP id o11so5595345ple.1 for ; Sat, 25 Mar 2023 21:53:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1679806413; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=8QM1QHLHovDhJzAjlOXny2HDNK64Zjmklql6ekR44ec=; b=IcxZxSEHYLzyIPpHba6988UhJUOlViWxxsBecBnsuL8YEk7IOr6zBxV8En2Gn5XPVf qbvs9f7/6TVaV0SWoS/CM/yc6P8P9onTMCQ80z43nBhpoUtIAWIBln37NHnpcA/5mu+4 k2Y/Xd4RYb6lr7IjelqZIR9yFoHBBj5IY4RoA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679806413; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8QM1QHLHovDhJzAjlOXny2HDNK64Zjmklql6ekR44ec=; b=D4BzDMH7cgSei1acYp7mRU/pmsEGty1aeYEN/awI98wfdXdswCIvGhGc+j9vM5KBgE Pwko8I38SbcUJn5gZ5GOkTerWC/L7zufWrarCx7OdjwOT0s5w0KI+Y/ttF1McqJc6eNE mapQikc2qYY9Hs9CcsQzVKPqMTPekam8wJaFFYjzmQ9C7xP5Pe+OvRk6mi6V/tPLwqhU 1TKsHj3bPDAHHKcfxE9IntxYtROp4Nes2D+58wc1UFkw1a6FdJUwSQi1z1OqMayXuFIM RjPGyYK8PwBZtQ1gel+FgwS59hI/jgDNAmj2lRKNsqQdM8vMPZMdWM7ezEo6HTACoWK4 r2ow== X-Gm-Message-State: AO0yUKVk7buabFG4NTDvFAD56f5J2XXq27i97+m6JVsgMI88zmV3pIM6 0ZSeNaJ5XwQ5tpoQP/dA8TKRog== X-Google-Smtp-Source: AK7set+ujvoRYM+0LuG/siQmSb0xloLA4K5Y35QLXraN+IKqGx9DHvLNuKbNLWwmAGQcwy3OJ2wkbQ== X-Received: by 2002:a05:6a20:3f0c:b0:db:4c00:7918 with SMTP id az12-20020a056a203f0c00b000db4c007918mr7132697pzb.0.1679806413373; Sat, 25 Mar 2023 21:53:33 -0700 (PDT) Received: from google.com (KD124209188001.ppp-bb.dion.ne.jp. [124.209.188.1]) by smtp.gmail.com with ESMTPSA id bn10-20020a056a00324a00b005a8aab9ae7esm16467454pfb.216.2023.03.25.21.53.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Mar 2023 21:53:32 -0700 (PDT) Date: Sun, 26 Mar 2023 13:53:27 +0900 From: Sergey Senozhatsky To: Liu Shixin Cc: Seth Jennings , Dan Streetman , Vitaly Wool , Andrew Morton , Nathan Chancellor , Christoph Hellwig , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Sergey Senozhatsky Subject: Re: [PATCH -next v7 2/4] mm/zswap: skip invalid or unchanged parameter Message-ID: <20230326045327.GE3269998@google.com> References: <20230325071420.2246461-1-liushixin2@huawei.com> <20230325071420.2246461-3-liushixin2@huawei.com> <20230326031723.GD3269998@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230326031723.GD3269998@google.com> X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 93DCD1C000D X-Stat-Signature: 69um6g54x899nizsxjfydoh878rjon75 X-HE-Tag: 1679806414-879608 X-HE-Meta: U2FsdGVkX1/UMdE6KNnRWsCNRP+2R6tmec9RHB721u/dHPTb/HgyYuAiWFtveNSr2n/v1aL3UiYqtTM1YqUWTbXpcdJXDnYAca//6VyVGr7CoTSWos1B8PlJgpSyeuAn06JSxLLqrbBN3cZfCbTmh4R6w8QiUpTmEkYlknHDie8WrvmVtYCNHpRLqPEC51dtdCIvm2NfUjOQ1H0UmNYrKaoxEKFeq0VktdSX6yegjwK9tWhrLywmsYJzgYe7T0QBZ6XyjdnnVl13sjGns+m4xH+I73sFBECMINqatKcD0CnqDi8gZ1ebtjvMqYRt6j/NCY97PH5V2DbXiOzYdoaDMcNID/wwo+95dGKFTIKhsT73xqCwOt7mDfbEwOmfIA5XHXXE5vIfEAXu/Wu7gfOuk3B9y4GiAs4LfG2PJZCPWrtQgzopOJZebq/7mfnUguO0nReGag24i3BhPE1r0QPSiGhg8ubfO+jbcun3Dg2Xe0iGAvqBDK7F7jzZJtyj3hpeipE5Bp8LP+2apzu00XtBRosx9jz6lapKIXm1wJr3EhKe/+sDiYWMDjIXR92ANHqoWk58qhE1nPO9B7G9T1BDnzTBXmLPNgXI8MYAnARme0KHoiZw7RhSLnyPtOSjJPWwmWvlFNyvZbd5gA2rmMDpRFcJfBJeWOtuIE54xK57Ab+HYgBFuLtUhR16zXqygUJMY1txTMgpa25AZ7P7iopAHRHG15iw+566C19O6p4uIWxUdnMAKk6arm67cA4Pqsh8ZHNgGCU9PO1IoJAMjood0zyZDYSVTFamYiCfnoEh4wtzTWa9s/14HPKk5mDlHJ7tjn69l0kVo3rD3+jzpABBQxVLUnSkmzBZK2nFUvx9xFge9jQnw7ng6dnEewK75RlLcefsWTMIWvTpceqHxNUf9bxchPcF65aRwKaId7yRCmnAzvEf5Jn3upQbWYlxDy1P1+QM6LL92FOfhihM3/S Lv4R9a46 U1HoONjPBc2ryxu7Ati54YGscf3hhb52DOV6ijF0u48aGIa9RgcuMMw+yuLpYVSa5gkNThCSEwIRzsRF/pmhh/JUPYdw8A882RCaw9JWHnlNPlqR1w5RfdMEVkYS6/e10r5Ox+GEJqFLT/jrHQkyW4f2S3f3XxY3pkF84CN2DF/lPMjh+t5vVcA6i+Jxxhe/xFMgW0aqATw9IydjuqFIH5ojwLwH4mchJPri/cRHJwucRnR8L70b/QmdF7XUGX09xq8n7kWBJ369EOc5Jf/OOIwVS4F6uJwINoaGR+YUyFm5ettvkbccIB30SuRYil/AofgPtgBLstEjexo0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (23/03/26 12:17), Sergey Senozhatsky wrote: > On (23/03/25 15:14), Liu Shixin wrote: > > static int zswap_enabled_param_set(const char *val, > > const struct kernel_param *kp) > > { > > + bool res; > > + > > + if (kstrtobool(val, &res)) > > + return -EINVAL; > > + > > + /* no change required */ > > + if (res == *(bool *)kp->arg) > > + return 0; > > Bool kernel param can be any of these letters 'YyTt1NnFf0'. Doing things > to kp->arg outside of kernel/params.c is not going to be easy, let's not > even try. Please disregard my previous email. kp->arg is always true or false at this point. I'd still prefer to not do kp->arg in zswap.