From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B81F2C6FD1C for ; Sun, 26 Mar 2023 03:17:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 15FBB900003; Sat, 25 Mar 2023 23:17:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0E89A900002; Sat, 25 Mar 2023 23:17:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F194F900003; Sat, 25 Mar 2023 23:17:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E331A900002 for ; Sat, 25 Mar 2023 23:17:32 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 78A0B1C5B9C for ; Sun, 26 Mar 2023 03:17:32 +0000 (UTC) X-FDA: 80609589144.16.BFFCD8C Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by imf30.hostedemail.com (Postfix) with ESMTP id A226F80008 for ; Sun, 26 Mar 2023 03:17:30 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=cNEjgFA7; spf=pass (imf30.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.179 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679800650; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QJXwUATP+VDr4imGtf+OtzrCNdoqnl+qk6pd1rJAqno=; b=nePgpeqQSVoWnPNdGRae3ESbBxdeiTYWfIuuxcrWuSZ4qQTDuj2y7CgF7nVPJGEA6W41vD SAyTrA9eXcyOWwr+1HQ3glTV9sub0ky5wCeW8hBEvZZfI+H5DJnsiO3OgdyFp/rybIvUo9 +6sZGZFK+/7pH4fipD/7udMYvqzpF20= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=cNEjgFA7; spf=pass (imf30.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.179 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679800650; a=rsa-sha256; cv=none; b=IDXNTqChAhwiikAjIzSdAWdBOQTFcUNZ4kzaj3B1UaMdpTdTyBq6CyEluk3j3ydHm3qRq6 GnLvw0q31LvmEJGoIfBgVm846o8fAh6yYMhe2i+Vu96UINW22gfIb4MiLvz9zzxcnNYu2o E1WNIzXWu5Nmox3ChHfqGJjt24ygEwQ= Received: by mail-pl1-f179.google.com with SMTP id k2so5487394pll.8 for ; Sat, 25 Mar 2023 20:17:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1679800649; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=QJXwUATP+VDr4imGtf+OtzrCNdoqnl+qk6pd1rJAqno=; b=cNEjgFA7QXYvPrGtk62VaYUAPZRIvm45tGOhXJzFkYCmXlyP1JRo56u2Kj3pJwizZx t26m/Cq/4wp2CZPRHl9mCcpOu7ppiSj51l/2TTMztgZ+e9pvJvEDp8+duoXGbuJDWk4I 10PzKf65I3irFTHS0GlSdGasnugnFmWnQJPyc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679800649; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QJXwUATP+VDr4imGtf+OtzrCNdoqnl+qk6pd1rJAqno=; b=vvBwwtNuzxiH2erdaviu1054NyUz6Pkt23RTmjTk3RA9eBIYf7z+rZ8ZqopGUn5MNT MLdRAQYGDunvTic/G+dcOCWcXuPKBZZFbMpgZLXlyysJww++nt/+fdq7eQmy12szcYUl y4mi4a6gTINRzGgG+y73wM0vxMqrTsdqHnv1vV3oP4pkHwzT4ExhUa+wxPNiH+ujOdAG yxraaUCRuHNjmpEVGzwbH9xg/4Q46DzlSxhq9nfMhca4QREPKSTczNb+6+VWV2zS2xHx sHcpoAqkttnoaklUEY/i6G1u5dRghBuARy3rrO3JY94a7/mChMJqUrnXkemTS2zr72Cw Takg== X-Gm-Message-State: AAQBX9cKqD7Ycgq/As7se1QRtfqJsQGxrWuawAHcJ9QiRaOkEJPBQ4fZ aTjZMPH6en0Umx77/KN8tIiV7A== X-Google-Smtp-Source: AKy350ZH7rtLvVaOc1HldQaaxF16mP+v3mrXojdRrXmTmAJlKAg6UoD0ZNERjK0clBstXNNVpRYpuA== X-Received: by 2002:a17:90b:1b48:b0:23f:7770:9e75 with SMTP id nv8-20020a17090b1b4800b0023f77709e75mr8409217pjb.47.1679800649460; Sat, 25 Mar 2023 20:17:29 -0700 (PDT) Received: from google.com (KD124209188001.ppp-bb.dion.ne.jp. [124.209.188.1]) by smtp.gmail.com with ESMTPSA id d3-20020a170902728300b0019c32968271sm16548162pll.11.2023.03.25.20.17.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Mar 2023 20:17:28 -0700 (PDT) Date: Sun, 26 Mar 2023 12:17:23 +0900 From: Sergey Senozhatsky To: Liu Shixin Cc: Seth Jennings , Dan Streetman , Vitaly Wool , Andrew Morton , Nathan Chancellor , Christoph Hellwig , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH -next v7 2/4] mm/zswap: skip invalid or unchanged parameter Message-ID: <20230326031723.GD3269998@google.com> References: <20230325071420.2246461-1-liushixin2@huawei.com> <20230325071420.2246461-3-liushixin2@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230325071420.2246461-3-liushixin2@huawei.com> X-Rspamd-Queue-Id: A226F80008 X-Stat-Signature: munqaspkkwapcxayhtgubqtsbo4z955r X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1679800650-654220 X-HE-Meta: U2FsdGVkX1/RYDOYU2mbTKYq7hSvoBELoQMkmUyyj36vfrJmEaGCTqBKhMJhfEWlZ2onzZD2LQnBGbq9xhf0O4JN5ch+eh+ZQk0gb1FyZWUv19RybQ9UIdauXJtDa0R68DwGaFlUFv50S7YNNsa3cXsvNiurG9ghGRDGhU9R4epandaqKCn2RRIIcrNxV9mk2UgzM1cIvzHDqjeUM0ohEBd18cnUBTjBh2InlyjHH5EJyx9/iC/r9fznmm8A0bimt/01ffBvlahyfXtnpa9FsM9aIfXjpdAo9xiTdRjCidCYeXQ4b0uOxRK8te2u84W0ElbIq06e7OEwgbYPoICHmMNJV6beO5tbtJRtO6Ph/yxkqGIajzXJdU45xNn03xrvcU2NZdFeYysMiJKlSXvbBVUAbNAEFQ2igk1vwimvURMc0A3ezpbMIan9fpG0XhxrEoFl3VLnuwYPBRqz8qenJXbhjuSIr60Bj4N4tttYsum9XWJb+rc7XNAraBvuYvxmgNiz6p/h50Km/hnaCPZ7tLImZDcQ5LsY0ncPEFCVwqbi/3quic/f+mO2cfTMk8LG1YRD36Ji+x4h+a8o+cWvYzZckbW44XJT1nyJk6tf+UfvUergStf6ZkYex8jkgnU5+INdkm8BLUN75ARb7WYuMcsgQnBFpZmB0ZSaT2o5t2iVOsQ+SZZmsV9S3+jSv4l5dbYQCTL7hmWivUyEss66IGYG6obbs/RN1d7nT6diHArwFwUvGsKgzkfPoJJ7F5B/MeELf5iKYBfvwvP1T9Y3JbmO2zwHxoKST4jGJy8aKlzMLwMcVM240szEreeC8/VZQELmP4gLump3qfMUCukvEPHdnriXWTJV4vFrkHIULnyNtcAw4onXM6/O4elmzAOdfmy6Xtzux49qVrAAhOSUjFCeX02Ck6L7Hv1J29Djs3OSkkspmrOngepAJTX50pA5gI88Ihojk5p/aW+ZrT+ PbzZX1MX hPr9yDUrpZk+ot1VRR7H/3GqLEYxV/jooxCGgzkLPrxJW8Xi6W/UzbZzbqqqy58oIK3wY1/LqzR4aXkh8tB6ZwsuhMtWgHTIHsxfdvfEnbdQulnZX1/Gg5yX8vI7arPJW60gdkXUAPhqt3DXzYIeH039oH3vgzOWBS5qO+3a4Ij/b4+6jRDB9qarxHC6V4vJxrxD842IPchkyn9z9kNRKIB8U0DwEfkOVhvWT/5mkCBWjFv1RlyWb0CrFmgRT7cYdrmp3KEjdXvvWkPV9FjHA8/sog+5DRU5tWcQNxrHZkcXv9viS/MvhfAhq+NAocyo/3WswxEzL5Rlk4Wc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.012057, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (23/03/25 15:14), Liu Shixin wrote: > static int zswap_enabled_param_set(const char *val, > const struct kernel_param *kp) > { > + bool res; > + > + if (kstrtobool(val, &res)) > + return -EINVAL; > + > + /* no change required */ > + if (res == *(bool *)kp->arg) > + return 0; Bool kernel param can be any of these letters 'YyTt1NnFf0'. Doing things to kp->arg outside of kernel/params.c is not going to be easy, let's not even try.