From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E478EC6FD1C for ; Sun, 26 Mar 2023 03:08:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1DBE8900003; Sat, 25 Mar 2023 23:08:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 18AF2900002; Sat, 25 Mar 2023 23:08:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0A14B900003; Sat, 25 Mar 2023 23:08:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id F1E5C900002 for ; Sat, 25 Mar 2023 23:08:18 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id B0569A0370 for ; Sun, 26 Mar 2023 03:08:18 +0000 (UTC) X-FDA: 80609565876.24.4C93D0E Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) by imf11.hostedemail.com (Postfix) with ESMTP id CFD6040005 for ; Sun, 26 Mar 2023 03:08:16 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=OzELbhN3; spf=pass (imf11.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.216.46 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679800096; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=haiHSIXyTrgs+nuMuGJ9uAsYLTzypzPClX75p2zdkII=; b=t0934aLRjaAl4piHLdF5nhzS7dgrOQOogGJX1eq7e9Y/GtDl6opcQonESeYSmBUprXCrz0 jhWUrcWqoGE/9AASraXb6JqvatdSdBQgOWDtoFqyPsiwZT+8SDbm1fG+Dbik2Gfl3aWcYd G6HXFwMJiQMm4JOp2Q7e+WMDAEDnfdU= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=OzELbhN3; spf=pass (imf11.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.216.46 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679800096; a=rsa-sha256; cv=none; b=2qz3qQqp2uOhOr98tGiWE0Y1g7ZzZRfMv35iliJFze0AeT9hryQto5Kr2kBG+i+UL9Fj3p 5PsxGTWCShs3orwUdZllAtVCFli5F9FubXGAUjKKh762boXAJRnZ6lcpgRn+aDUzH6xfzR S4mJhMRj5e6n+kY1GHNuyL/yAUDx6i8= Received: by mail-pj1-f46.google.com with SMTP id p3-20020a17090a74c300b0023f69bc7a68so5459148pjl.4 for ; Sat, 25 Mar 2023 20:08:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1679800095; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=haiHSIXyTrgs+nuMuGJ9uAsYLTzypzPClX75p2zdkII=; b=OzELbhN3X+YAej5ML0RVHSfuCdukvlLnpP0NlS1Cpbe3GvmV0qwE9FCZ1wEY3HfcFE bJPdtr4L+1YQmA63TEJq592M+mqxrw34NpadrLIDdPgsdxy68US2kIgzsTspnwG2bOcj nDa8PNpfTn7uqznhso9JlD8l6c3oATx1SXIcs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679800095; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=haiHSIXyTrgs+nuMuGJ9uAsYLTzypzPClX75p2zdkII=; b=z+6fHZ6r1MU/A33cwCrG0sDpZMEpdLtB+VhgTeO2/J8n05kCIr9qbESUXtT5L05XUc CqMIEU1+niCeot5tyQI6ptmkkAfdfkZBPv5gV5AGeORyMfEdEBYEtDGWIC6S9/MKthiz dL0Y/QpfwWIEyS+VkXvKyjjR2IZn0//hgHvLzUWPjH3QHxRFwvb/IRYenfKyXJtgp05t Iu4x4pU/fUod+ZuoYYvSbi56ZJ2XGq4WEs3j/IKsAUH6hkabryqHG05bdDJ/4jNJpXou vk/kgGefRtRXk/PHgrxYw+PVAxcjm+mmVHfVh3Jz1t1I0LZ+jQa5GhMtp5zDDAdFE0lF q2YA== X-Gm-Message-State: AAQBX9ctcmpZ1iqt7Xyl5uluDehMIoS2e6x3f6LtL/O7BX8AN+Kn4d6w LWXX3vPd0rYW/CduWpudU9Vi9g== X-Google-Smtp-Source: AKy350YD0Fczy/2vkTKdMdzOk7dPmf/iPpSLqWljQuyjHcAbRs+8LJkVFeTMQJ2VGaM78e3s+ZydiQ== X-Received: by 2002:a17:902:f0cb:b0:1a1:aa68:7e61 with SMTP id v11-20020a170902f0cb00b001a1aa687e61mr6827103pla.33.1679800095682; Sat, 25 Mar 2023 20:08:15 -0700 (PDT) Received: from google.com (KD124209188001.ppp-bb.dion.ne.jp. [124.209.188.1]) by smtp.gmail.com with ESMTPSA id jk17-20020a170903331100b0019e88453492sm16730366plb.4.2023.03.25.20.08.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Mar 2023 20:08:15 -0700 (PDT) Date: Sun, 26 Mar 2023 12:08:10 +0900 From: Sergey Senozhatsky To: Liu Shixin Cc: Seth Jennings , Dan Streetman , Vitaly Wool , Andrew Morton , Nathan Chancellor , Christoph Hellwig , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH -next v7 2/4] mm/zswap: skip invalid or unchanged parameter Message-ID: <20230326030810.GC3269998@google.com> References: <20230325071420.2246461-1-liushixin2@huawei.com> <20230325071420.2246461-3-liushixin2@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230325071420.2246461-3-liushixin2@huawei.com> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: CFD6040005 X-Stat-Signature: fzard87bt5q5hmegfiwi7gtc61ahsxtp X-Rspam-User: X-HE-Tag: 1679800096-50248 X-HE-Meta: U2FsdGVkX1+3S5yoj8XJ4vLhlw1CPDRm0BIhieynEaQpaanxTxHKa4M/VlDmjN29A6BBmoot/tAgHTL3lsMDwdesDJvo3pPR9VnemLIfepWTknt2VzaiLIrC+z07vP+cEpByAf2Wf0ZPBixhbhfirGQE6NA1DSc4rRy+SIcN/twvKEDCsavzVZRAFzI8faeg67X3mSSIFvmBq3nLVizY1ibxBF3F90SE+pdocftVHu5p6lpgDf7vYERRJR/QjVd2QDX2ZqqW2+KPuZCq2Vj1wZvTkRdzT2wtAenmK4UCqXBhkXpNY2iEUaYrTtCd/TfujA7N9tOj8vqIUWbb0PhHU6CgnbG45cPZ9E6NUfLtj028c4JCnZZBEqmcbUgzdsYzECqan6KXZv6PIkwTthyHKtW35dv0RA8sIMJGk4qfKTDM9vJsviIe0hCDJSncdoiZX38qa0h9twgKvp0VbLVVjBR9JUhill800A7VRPWVKT4OsCkEpGfl1GxsV7hNguYyVhUSWcAr2dFzP+8wF/7x5Ye/5CBdheClvqYjmkRI899B2pLSJnpFgitcnVhjFDpUmtWpzlMRQxb90ELN+uj9GExZY1Sgg4B1W9Z7OgePhnK5CVhB2VMYX+UxECmDknkJyz25L29+bjFOb+CKvFxRrAhfU6zpxKrFomBBokkulV7Iy+vdgEB2Odwv8KNaoyiOQ0ftbooE3KkeAxrOpy8gOv8y7lR1E11ZOsLsL7T6vyprJJMaCJfWukN625WOGcOHPSX+WgBZK/ukbz7/d8SQaY8W74BvdgYoEF3W5U9lOgfJWeh8QFjzczcKmU5U5qmjSRkqzdBSuYjPDPVlO20K336F7zbds9t0d9XlPKOAdZHoVun0m+9d4hFrhwp698ll2jp/QYIio1YVacCYB6pTZS5Iv7KnFyvmPbr+R1qhtUekqRHmtXkuOsqzlh+a8PacnfbrohaxO9cHigq9zdo KIgZZJDO pD6xO3kezCOXx3b8bcg56qwfR/zboBRat2E37xtwJVpiZmUKIpDZJ7UsuRrGMwjRQcMs0NYNYDyPGmyBXQZ4CmTFSsdKRN9oNmC+s5D/ktY8FJxjasN32tEeMwDXD3aW+Xrr57yMThDI6Vr4HbDTGG4+7kYRLQHeIhLncl+trzSyyLOKstVS0RxNXXE5bDYGMYPbgBZAzWNrAo/nrXJkmLyKlqh5/AtDwGRnnVzBXuND93ODV5q3LI8GgaF3waUTqHmcsLe9NJH5Yoka31QKqdsqfbqcDu1vQEb7inVu2Ed+445Ok2OtADbQNeAcEmTP/uBTImaYrRjrIV8c= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (23/03/25 15:14), Liu Shixin wrote: > +++ b/mm/zswap.c > @@ -761,15 +761,15 @@ static int __zswap_param_set(const char *val, const struct kernel_param *kp, > char *s = strstrip((char *)val); > int ret; > > + /* no change required */ > + if (!strcmp(s, *(char **)kp->arg) && zswap_has_pool) > + return 0; > + > if (zswap_init_failed) { > pr_err("can't set param, initialization failed\n"); > return -ENODEV; > } > > - /* no change required */ > - if (!strcmp(s, *(char **)kp->arg) && zswap_has_pool) > - return 0; I probably would suggest to simply remove `*(char **)kp->arg` from zswap code entirely, it doesn't solve any real problem (as far as I can tell).