From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACC22C761A6 for ; Thu, 30 Mar 2023 00:10:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C54216B0074; Wed, 29 Mar 2023 20:10:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C03BD6B0075; Wed, 29 Mar 2023 20:10:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ACB526B0078; Wed, 29 Mar 2023 20:10:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 9F11D6B0074 for ; Wed, 29 Mar 2023 20:10:37 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 4D46CC0D33 for ; Thu, 30 Mar 2023 00:10:37 +0000 (UTC) X-FDA: 80623633314.01.99C7AD5 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf16.hostedemail.com (Postfix) with ESMTP id 475BA180006 for ; Thu, 30 Mar 2023 00:10:35 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=VYrIzViU; spf=pass (imf16.hostedemail.com: domain of broonie@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=broonie@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680135035; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nQnSNejNxO3/mijX3W3id9G7IlXi3raY3edSBW2FUuc=; b=Y2p6ABshh5aUPzjkHc8A6B2BnHolIeZ811y5WIu8r3aQrjOwC0vkTAOPrWojIu8bnKZiIc yvqLyq6f5VARl3oSwAFWf2FBf6GPGkjpVvWaO0enCUOIOZysJH0w9dn3Sxb1EKo8JB1AYU t3kpSa+8vnUhi1StYJgpf7itTJ9CCeI= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=VYrIzViU; spf=pass (imf16.hostedemail.com: domain of broonie@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=broonie@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680135035; a=rsa-sha256; cv=none; b=ktaq53Zg5EUXbk7NSOULgz1kAuzio221hym7yxI7z2YbzdFuKgW0V/QEW5M8DGyvd5/aQ+ 0F5dHZ95SeWDvAkrEn4VR0vX1ZxkwsDfuvx5YvSawoLVfPQkFIUS2uk+sesfqDpnfI2lcR YIrdtGyKMEPOy8asXjPpmfdpmzM6uLQ= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 335E461E96; Thu, 30 Mar 2023 00:10:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 67081C4339C; Thu, 30 Mar 2023 00:10:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680135033; bh=QomJxmHFHEg1D6+6n5cFYGToSzAqlNRqVQNvQ76f0pE=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=VYrIzViUDhkCXh0s4reRK+ILASouwRvLkS+lo+OwpqLf5qDlm5HeyqYEb7VTPjblq ITunRr5Xqxv0pNaw1swr1mWO2+61uIxKM7mpjb3ugSrYdenqQoYvOzs9RMnoXY+7+/ 1ctwK5SXwi9HkKqtEKmAJd7ebHMGNEtYK3c4mO4qui1koPWz21y4M7PKYKC55UPEyU rhraEWJ65KKSX0wFLuRGaz7xCx5a5e69xIkn+F7RrcmCzQZMe4/IbN7l0rweXtlA9V 1yAGVExyf7e/zT0ZOWJadQHeYge16xFOLikuCJsGauayTrt/EY6zKrsNjgXzYiXvtd 2OZX4khsi2+QA== From: Mark Brown Date: Thu, 30 Mar 2023 01:10:23 +0100 Subject: [PATCH v3 1/2] regmap: Factor out single value register syncing MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20230325-regcache-maple-v3-1-23e271f93dc7@kernel.org> References: <20230325-regcache-maple-v3-0-23e271f93dc7@kernel.org> In-Reply-To: <20230325-regcache-maple-v3-0-23e271f93dc7@kernel.org> To: "Liam R. Howlett" Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Mark Brown X-Mailer: b4 0.13-dev-2eb1a X-Developer-Signature: v=1; a=openpgp-sha256; l=2689; i=broonie@kernel.org; h=from:subject:message-id; bh=QomJxmHFHEg1D6+6n5cFYGToSzAqlNRqVQNvQ76f0pE=; b=owGbwMvMwMWocq27KDak/QLjabUkhhSVy8U+5oW63pf41jOds+HM+qDQu/CX+uabosuPxf79fG+q Nuv2TkZjFgZGLgZZMUWWtc8yVqWHS2yd/2j+K5hBrEwgUxi4OAVgIq+N2f/7H9NIbbAuuixX9D7vH1 sB5+y9bHqGKd9+KeuaT8w3rrew//dTRKLF1yDp/XXLXxlnO+dzbl7eFbnrTJvd0sPGtx+Jrxb6djdZ Wf1jaa7L7QPFlm+eScnHflv3p7Jd3jBzhdfea3mF939cUeR/lBKbWpuZLM46a14d74OPzmt35PzZeT 6td8mUIvXrP7Vz1bnZb+hyNzVph5jq93NvvO/ZOzskrkJtGpNY/Iacatdpdma1Leub1VgrvhyyM7+8 RGru1P8nXL9dM8rJ0o8MiUvosdvPwTL5/2TpbQ+CjExfe2hHKZvOmpRTI8zdIcjwT/A0t+4m3hW/by 2/05viu8pEaIq9kEnZxqDbwurcAA== X-Developer-Key: i=broonie@kernel.org; a=openpgp; fpr=3F2568AAC26998F9E813A1C5C3F436CA30F5D8EB X-Rspamd-Queue-Id: 475BA180006 X-Stat-Signature: ga7qzo58cs4rk6oe7h1mmrpfr5f8hkpr X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1680135035-683984 X-HE-Meta: U2FsdGVkX1+DgHPzg7PwAI/8WwAJ77WKWKRZSjunYilYZRAzF4dgsrHBl77Cc/NmRhYV1IjYhhej9B+Pjs6YYhc/wRaeyywkEFzScwHjFfCFv+sLCzANZ5yv/UTbaIy6S7qW1HrskqFtCwTQkjwpVlHkr4iAPR5P1QOBMATmqpU6Y01S59keiV+c+X0hLsrZcCr0b98v/38Aez2D7Hp7kQA9Y0BePrIW/cm6QwcE6QlOYfMaI/PdPLaxQiIbQyk8MbWOTpUjD+sDxBPsWs703vy6bUp4YyZVNlnc0IrWr+PsDKTy6R51L3JA4c4HrzSqLKRmc4kNDKUtjqem4qAs/jlnVb9k3tOJ4yoV5tK5wKQrqgJKKVOiFTRIs8MBSbGu4I85yXVybZmQnnST+aD+tkzSsAbzD7tiaggMOmtd3jFfdoNJMM67eVnb1oWA7sohRF9/KHztB0mqJq6Qfc41Z7fUIqVPX5xz3v/LBe+SeQQfE8USc8ONeJKovErSMdvmEtsPQrKsI9e9xa34xAFn9ENdSr3XhhSB20Qqk/5ITz/9A4K+qcPgUwIUH1Z4HgvTxlEOG+BL8W/39TwUqlkPI/KVn2GUzho7qr6lrCBN0RRfl5XYs3PuASU5pgW737NkKbuPSN8swCl7Y4eubi0eG/TcgUkBTTr/WQ5zQ8CX9Bv1LkJ9tXJouHQ+VWLwsIg9RE8hs4dvoC/fWU1bw6ANHjYrOzBVrWfSoHpuIC49kRf5BQwxIxL7+vM3gyvbpgfKUmCvNCPpaxRCbVAQzVG7fYQh1/J5dRIZ3QcwJiAVWU8BMr8+hehnBUWni0OS4wCA7Kqpxh5CTMLFDyJcjZsmSL9SnjATmiZYS/pKt8Pzfd85KO9xvqSBZsOkc4zw5aCk5WrioAbTEpN4m9l82eeohU4I0emiRsa3vMasYBy/OqZnmE3tV8HR1cG9IJppjbHoUary4id7ggAZW/kQBSz YS5GRW/F 63ofFaM3jK6OJX0o426rzzMM5bT7wpsChwseRv1iDyUUvqZ34ZFoR7bRQL8mTAHOc8QPjJYph0DQyk/tePGuy90Z6vyvM0cXSZEe1eNwARvIJvUybvhPrvmCaTposHLtCO5CwHg/lKNlWVxG4qUyQKWf9g+J3Wvs91SsIpEzSHrw4zfwj3tbVn4dbQw6+PQv/ZVh2ZTLuDtmRMD/bDrlADJYXVAeKwO+PN5/LyS471Lr2zDUtISR/8J4L2mikJ3yF6NoVKolSGqMftCij2kjkeENGTZZkYT2jaCWaFRkdCaOl93Zpm7PERP5OyrsB5shHwcdaFtBP4alI+ZFPFrSoojD9EHssFuNpaBqZQonptkDnfkQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: In order to support sparse caches that don't store data in raw format factor out the parts of the raw block sync implementation that deal with writing a single register via _regmap_write(). Signed-off-by: Mark Brown --- drivers/base/regmap/internal.h | 1 + drivers/base/regmap/regcache.c | 40 ++++++++++++++++++++++++++-------------- 2 files changed, 27 insertions(+), 14 deletions(-) diff --git a/drivers/base/regmap/internal.h b/drivers/base/regmap/internal.h index 10aca7119d33..7b9ef43bcea6 100644 --- a/drivers/base/regmap/internal.h +++ b/drivers/base/regmap/internal.h @@ -270,6 +270,7 @@ unsigned int regcache_get_val(struct regmap *map, const void *base, bool regcache_set_val(struct regmap *map, void *base, unsigned int idx, unsigned int val); int regcache_lookup_reg(struct regmap *map, unsigned int reg); +int regcache_sync_val(struct regmap *map, unsigned int reg, unsigned int val); int _regmap_raw_write(struct regmap *map, unsigned int reg, const void *val, size_t val_len, bool noinc); diff --git a/drivers/base/regmap/regcache.c b/drivers/base/regmap/regcache.c index d4877099e990..e5d6b535c002 100644 --- a/drivers/base/regmap/regcache.c +++ b/drivers/base/regmap/regcache.c @@ -669,6 +669,30 @@ static bool regcache_reg_present(unsigned long *cache_present, unsigned int idx) return test_bit(idx, cache_present); } +int regcache_sync_val(struct regmap *map, unsigned int reg, unsigned int val) +{ + int ret; + + if (!regcache_reg_needs_sync(map, reg, val)) + return 0; + + map->cache_bypass = true; + + ret = _regmap_write(map, reg, val); + + map->cache_bypass = false; + + if (ret != 0) { + dev_err(map->dev, "Unable to sync register %#x. %d\n", + reg, ret); + return ret; + } + dev_dbg(map->dev, "Synced register %#x, value %#x\n", + reg, val); + + return 0; +} + static int regcache_sync_block_single(struct regmap *map, void *block, unsigned long *cache_present, unsigned int block_base, @@ -685,21 +709,9 @@ static int regcache_sync_block_single(struct regmap *map, void *block, continue; val = regcache_get_val(map, block, i); - if (!regcache_reg_needs_sync(map, regtmp, val)) - continue; - - map->cache_bypass = true; - - ret = _regmap_write(map, regtmp, val); - - map->cache_bypass = false; - if (ret != 0) { - dev_err(map->dev, "Unable to sync register %#x. %d\n", - regtmp, ret); + ret = regcache_sync_val(map, regtmp, val); + if (ret != 0) return ret; - } - dev_dbg(map->dev, "Synced register %#x, value %#x\n", - regtmp, val); } return 0; -- 2.34.1