From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87EE2C761AF for ; Sat, 25 Mar 2023 21:53:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 00BA0900005; Sat, 25 Mar 2023 17:53:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EFE4F900002; Sat, 25 Mar 2023 17:53:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D9FC5900005; Sat, 25 Mar 2023 17:53:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id CD106900002 for ; Sat, 25 Mar 2023 17:53:52 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 7C3C91C5B6A for ; Sat, 25 Mar 2023 21:53:52 +0000 (UTC) X-FDA: 80608773504.24.9B0FC4D Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf17.hostedemail.com (Postfix) with ESMTP id 17A8440008 for ; Sat, 25 Mar 2023 21:53:49 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Dh2IlLmW; spf=pass (imf17.hostedemail.com: domain of broonie@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=broonie@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679781230; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nQnSNejNxO3/mijX3W3id9G7IlXi3raY3edSBW2FUuc=; b=z3Xd+Oen+e49PE4/4olfls2RylTpLyhIKviGlZ/Z+TqUvgwAtW0wVdaBOxG/Wj+ptO3Yt5 1d8bzLL1BiHnyL/KuHsqqhj2n4d4Sf71eGFrg7Pe8xtglBLr8yTWcP2xM4E+qocY+3sj81 3mZ2urLHXk1SDtEhaTcdRtRa/ZYWMuo= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Dh2IlLmW; spf=pass (imf17.hostedemail.com: domain of broonie@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=broonie@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679781230; a=rsa-sha256; cv=none; b=w1Zw/xq9linLLvYvi6dHCeId1+QqiBRqfOy+x1T2IZC8uTZsfUUIt4JyGVFsHwcaZT/wA/ UIFQwld4Sy2rSAbInO6ebohfU5v3eKcgfXhUQouGud7iZeD02Cp4aqjkIvxn5pL9lcMqc2 bYIxOSJTtWlyPpSWR2DH3lzOjVIgdmg= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id B5E8CCE0B24; Sat, 25 Mar 2023 21:53:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1A901C4339C; Sat, 25 Mar 2023 21:53:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679781224; bh=QomJxmHFHEg1D6+6n5cFYGToSzAqlNRqVQNvQ76f0pE=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=Dh2IlLmWH955tScYqLVsAsnSiQguX+CE/smY4OktavTm1FfOcktpWIT51ZQ8Ywvnj ItNriwZ5cHhOpGWWG9R+WgSm3l8yOJRNrforVn6XeL8Rnhb4dOpcW2WYh1YzHqp07/ fWWr+6d/QYUGk9bdx5JPf3BW+NUa8xlgdLrMTMBzTuG0rYbYkl2VuKtGSN0iVZ4W0t An3BQ0Ge4v3qNOpd62gmvaE+a+OABtjVhAKcNCVPFGYMI+UjWKooIBZcynXpI2PNBv nfXp56xsoyY0HkBMmqtbArkpXdy6+QVbHePKk+b072mfeuT1W0z0UvftBCZc6SHUJy zB2HbDOAw+/qA== From: Mark Brown Date: Sat, 25 Mar 2023 21:52:58 +0000 Subject: [PATCH 1/2] regmap: Factor out single value register syncing MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20230325-regcache-maple-v1-1-1c76916359fb@kernel.org> References: <20230325-regcache-maple-v1-0-1c76916359fb@kernel.org> In-Reply-To: <20230325-regcache-maple-v1-0-1c76916359fb@kernel.org> To: "Liam R. Howlett" Cc: linux-mm@kvack.org, Mark Brown X-Mailer: b4 0.13-dev-2eb1a X-Developer-Signature: v=1; a=openpgp-sha256; l=2689; i=broonie@kernel.org; h=from:subject:message-id; bh=QomJxmHFHEg1D6+6n5cFYGToSzAqlNRqVQNvQ76f0pE=; b=owEBbQGS/pANAwAKASTWi3JdVIfQAcsmYgBkH21k9QhR+Pb0b2ARSgwVGzlKDuKlxTig55I/lU6T ktC4Co+JATMEAAEKAB0WIQSt5miqZ1cYtZ/in+ok1otyXVSH0AUCZB9tZAAKCRAk1otyXVSH0CPyCA CCRxU9bxG7O2HiahcTjSmTZP2kjGNzo1UsaOxvwdvsDRiAHSxE72AYaodTBQ2cwE7hjR2F7YigJj9J Kgd4rmQfLJD+3Li1BIvdmOpVR6aR4DdrNTzxacbxbJSlFXJoxWtjp0WXmEhbTrAYjimHqtUhfQmHjE nto2GmsnmDeXLnWBWV3uvqmXYnbIYwtJvayn+Jmx+4vlT/mRb7Ps7mGjEuaZHgjEt46woZA6oZKqZD 02gASMo/pyPAocjHl1s1dwrlQCwi/YYDA6b+n3hBrCZMR1/bkuEzWCML7Qt/ChDuzD+8RCktTaGSF7 D845ud77xsk4G7uIH0gjkrQxpr2oRb X-Developer-Key: i=broonie@kernel.org; a=openpgp; fpr=3F2568AAC26998F9E813A1C5C3F436CA30F5D8EB X-Stat-Signature: rqd6s7ywxufw567ku6krdchuytmdjy15 X-Rspam-User: X-Rspamd-Queue-Id: 17A8440008 X-Rspamd-Server: rspam06 X-HE-Tag: 1679781229-892489 X-HE-Meta: U2FsdGVkX18F1VnulKExD77oK1zwR+M7wlJjATdRVbBIampHOLBZsFaK1zcc850f/0cWz8e9Icjxu6AWA1/vpelu1EEX25ofh4JMpRMe3PLEOsHX5pTJcovPGoKB6M5Ub0+Xog+ACyawUgrZ8mxPcYxvimE5Dfk4vB2LBcGIYFti6N1wITIxE+RdM3pPaTuQ+U996rD4LKW05UV5p3kum2aUB86thZh6k0lx35eeGY8DLqM2xWLhdZ6W6hc//hzADzVKp9ftZfqnlP1uT4FzHcNJbhFyIIaj4gKQMyZX0Sgz67E3CULbJ2vWhgVnPl7Ze3+yVFv0z3ufnQoVuhJSqT3ulCWIZWWczik13IRPiRhugL7Ga6D+CkaEaeWVdQptTHIgA2OFRlDKtNyiAUprGf1OhwwBz/OgctNGYC3nQEDpXNt+ZVq73Jy3VLzNMvD1baX3OCS7iJRHHjNT5TIvCPFQ1HszBbVpNVgkxMLY71pH59l+X9TlLD7NSnDEHGpqgONo4jC0Fr/zm/LoyevpXztG6nuE1eFU5lX3RJd/fXojogV7Qtis3I3tn8Q4UCpUuSAP0h8GaMmSV0/A0IxLSrOCgWP8hGAaoYe2nCHRnOz7NTQMd+Rczmg099E5E5vQPLABpA2mTs5PWhPzr35j3vnkl3mBVH43KYjDGr3EWjIEdfNtP4ix0pPmAAiovP4hV++lQl3Rlv58OaVyslqW0UTn8fcFPYfRQ90yZJitlm3rGf5sUUaDD0SfFByvpCt+oIeaQcHvF+MMC320amWQn6tz0GeBiCbBh7kW7nPph5I1TSRPfP14WJ6d9s/CbXqhVKV09BlHx+rFPDxqi0zv6pz2O9NDISCsLxA66Tpouf+O3LphvBZkiRxOZ7UCmKrtP6WKWsgtBKPSkoqwKCKPKC1I/6kL0hMcYZao8QY8FbWc/9G/LRWMlaTYoFt/5IqKFand+jg7ZuY/ypJESC6 9zfIMBG4 Q5wOXjkHojutnPViRLzhNyoW/nV3p74AMJT5VR6y6bdQHEy55Yev6LQ4KDiQb1MyN2DMOc0RzaKh/OMhAk1bb+wNJOpCxKZ3dur3jSWVrsoYGEd+QwDePvsn0eZUohnRJnUuY5Jxo4V6dq68fU04/lm/FmXSLgenjo43p0cnWV2qd+/gMV5x4RdNp13cx8UAnuOK86UngWLhN+i6Gzy632xYLaovyRbm5tr/+kHqW5llwQ4wC4/mNiu14hdWCx71d6GX2UOOkcPduSUEf4Y5FCndBf3lluyfAd0r7u10HRpAkkuNDRk63ISU335NeTtmptHnZDnNvWq6j6UKUITNCbqoql8hwBXHdZGR6vo35CICxkqk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: In order to support sparse caches that don't store data in raw format factor out the parts of the raw block sync implementation that deal with writing a single register via _regmap_write(). Signed-off-by: Mark Brown --- drivers/base/regmap/internal.h | 1 + drivers/base/regmap/regcache.c | 40 ++++++++++++++++++++++++++-------------- 2 files changed, 27 insertions(+), 14 deletions(-) diff --git a/drivers/base/regmap/internal.h b/drivers/base/regmap/internal.h index 10aca7119d33..7b9ef43bcea6 100644 --- a/drivers/base/regmap/internal.h +++ b/drivers/base/regmap/internal.h @@ -270,6 +270,7 @@ unsigned int regcache_get_val(struct regmap *map, const void *base, bool regcache_set_val(struct regmap *map, void *base, unsigned int idx, unsigned int val); int regcache_lookup_reg(struct regmap *map, unsigned int reg); +int regcache_sync_val(struct regmap *map, unsigned int reg, unsigned int val); int _regmap_raw_write(struct regmap *map, unsigned int reg, const void *val, size_t val_len, bool noinc); diff --git a/drivers/base/regmap/regcache.c b/drivers/base/regmap/regcache.c index d4877099e990..e5d6b535c002 100644 --- a/drivers/base/regmap/regcache.c +++ b/drivers/base/regmap/regcache.c @@ -669,6 +669,30 @@ static bool regcache_reg_present(unsigned long *cache_present, unsigned int idx) return test_bit(idx, cache_present); } +int regcache_sync_val(struct regmap *map, unsigned int reg, unsigned int val) +{ + int ret; + + if (!regcache_reg_needs_sync(map, reg, val)) + return 0; + + map->cache_bypass = true; + + ret = _regmap_write(map, reg, val); + + map->cache_bypass = false; + + if (ret != 0) { + dev_err(map->dev, "Unable to sync register %#x. %d\n", + reg, ret); + return ret; + } + dev_dbg(map->dev, "Synced register %#x, value %#x\n", + reg, val); + + return 0; +} + static int regcache_sync_block_single(struct regmap *map, void *block, unsigned long *cache_present, unsigned int block_base, @@ -685,21 +709,9 @@ static int regcache_sync_block_single(struct regmap *map, void *block, continue; val = regcache_get_val(map, block, i); - if (!regcache_reg_needs_sync(map, regtmp, val)) - continue; - - map->cache_bypass = true; - - ret = _regmap_write(map, regtmp, val); - - map->cache_bypass = false; - if (ret != 0) { - dev_err(map->dev, "Unable to sync register %#x. %d\n", - regtmp, ret); + ret = regcache_sync_val(map, regtmp, val); + if (ret != 0) return ret; - } - dev_dbg(map->dev, "Synced register %#x, value %#x\n", - regtmp, val); } return 0; -- 2.34.1