From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE1B6C6FD20 for ; Fri, 24 Mar 2023 17:11:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7AC6B6B007B; Fri, 24 Mar 2023 13:11:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 75CA76B007D; Fri, 24 Mar 2023 13:11:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 625606B007E; Fri, 24 Mar 2023 13:11:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 558176B007B for ; Fri, 24 Mar 2023 13:11:22 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 1B8EB80789 for ; Fri, 24 Mar 2023 17:11:22 +0000 (UTC) X-FDA: 80604432804.07.377C30A Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf08.hostedemail.com (Postfix) with ESMTP id B0B81160002 for ; Fri, 24 Mar 2023 17:11:18 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=Eku5Ernz; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf08.hostedemail.com: domain of mkoutny@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mkoutny@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679677878; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tWmn6S5YIs367DkBrcliyowrdz09FT4jicvN67WVd1Q=; b=Z++04hEslCtfCujNYz7oVr711ecQx6Mt/f+wg2jEwpjWrn58jiBzL7p3DA607czn9LPvXu 0uKP1sovXO3Pa1UOxHgnkTya3BQs+uvfl3PJOh/gqRwDZtYbm8dB5s6pNk5uTJH5Ar3lpm fnsd1tRGnQQSoFkxrAq7DItjEHYeB0k= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=Eku5Ernz; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf08.hostedemail.com: domain of mkoutny@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mkoutny@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679677878; a=rsa-sha256; cv=none; b=yZ+MBvBKDjGSRh/6SGi2yVzo8q9v8fLLU6I6e4nsOZCJ1Dpv6EEv9Ct53eT/LQOxhn3o6m skr5yXPm+I0+PlQIuiXnY7boCMDGAjbf1dYyujj3YGUgXehJWweZU3ecNPdRvYh7oZN5xx ffLp+MUSpdqRcUzy5OVjRujltFI2358= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 3AB011FF94; Fri, 24 Mar 2023 17:11:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1679677876; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tWmn6S5YIs367DkBrcliyowrdz09FT4jicvN67WVd1Q=; b=Eku5Ernzy7mmNguDiowGGaJXYc7ZQ2vU1KA46inl7ZfH1RKMVqbk8gnL3KMsKyAYqEMkRf 2Om7zsa2zVwanBak0bzaUtO90jxztxVY5c1O9xoFBMa4ej1q6pdLlSZYzj4RAjiYcBxMmD v7hqcgJV90Eh9vjW41I6rIxVrngWD6Q= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E0157138ED; Fri, 24 Mar 2023 17:11:15 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id HW2INbPZHWQwJAAAMHmgww (envelope-from ); Fri, 24 Mar 2023 17:11:15 +0000 Date: Fri, 24 Mar 2023 18:11:14 +0100 From: Michal =?utf-8?Q?Koutn=C3=BD?= To: Cai Xinchen Cc: songmuchun@bytedance.com, akpm@linux-foundation.org, hannes@cmpxchg.org, longman@redhat.com, mhocko@kernel.org, roman.gushchin@linux.dev, shakeelb@google.com, cgroups@vger.kernel.org, duanxiongchun@bytedance.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, yosryahmed@google.com, mpenttil@redhat.com Subject: Re: [PATCH 1/1] mm: memcontrol: fix vmstats_percpu state incorrect subtraction after reparent Message-ID: <20230324171114.32oru5sdubfsfvgi@blackpad> References: <20230320030648.50663-1-caixinchen1@huawei.com> <20230320030648.50663-2-caixinchen1@huawei.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="zdhfeu2yhc5s3ooc" Content-Disposition: inline In-Reply-To: <20230320030648.50663-2-caixinchen1@huawei.com> X-Rspamd-Queue-Id: B0B81160002 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: ma8hnodoxdndwpo5o8t64un96y7ws8ma X-HE-Tag: 1679677878-568444 X-HE-Meta: U2FsdGVkX1/jQ96c3E4cPk96wwVoVJJ+Vk/ce4BzVp6xHjtAM0Uyf4KNXQyTpsG5pOh17iH78i/YWaeLGC6YCR4KrAoxK7tembzY+uyVsBdVEvEX9PcwyehoxzSL5zTU59lHrOwDZwxcq8GFhGOGxy+t6MtkhKkKFARV0+MXkMGSkoSBWp9f4Hm1zU+ThutsdXSVs5Z3Djh2mGNSEYXy2KWb1UAK6a5fTmJz5ihMsFHR0uLFg4TZ1nWOrfXfAOHVG/2MvD4bFJ4bfNdt7B7xNVge6lOQ/ZHVc6mb2qE7WJGMqxjb7YqBhsShsRq4XcSgLN8tKzljAeSFFOjg/5dI8eTeMWTejuok1ioatZfJGTGhNNOmgtF7VxLMlqb1gRBDgK22ZMfoUvgd8AtHs+rkTFKE3ySIoNBU8KnHjlXF+BR8O5/fWJ85o2qqQlCWvs5fWjBC7QM4q/ufzt12RQdGlTQev2X8JS0J81LSmh4VUygtmrMvo14WyWApvvgR5egdcPbI/NwVqf2g85u/OSq2sHejsNQcvQcd2981XxN9N9bInWRUFz7c/FEXVsFp3QoBtb6xlYWPY/oQ587BKpm3XqCYZgQFvsYkaYI0xVexxXm/Y/TBTPuImxWfVnoa/BOPPj7ga0QoRnhiRaXpGc0+M5yf2Wbd+NGYRm48D4yF8QT8iToI2TwOC+Hn9aVVTrOrbbZpds3KrR2B9tyf8E5vVnv0kNcyk33rgvtLslWisy6rT9T8xVz3GIx6WwMQwDziXz8fg9yLUC9Q/LLB0UPR1YNcO4cSiv4NS1aE0hMoq1M50riklACuKljViZCsSdtfBcMImTNVY5Lhs0FxWf5gom859pR5reqDqsFVdKZr7woMaXlsHcGvf70vwdsk+32lSGmIb4Aa0ILcf4b8ziF8cCwnNpgea6j9QjChrOfpak9ui82jeA6BuZZs/tSjcMafwOcYUHxlOuWfu12esQO hozrWGxU YM0bM9ec9vp0v8t3XLbAbRbG3gYxhSdWk7WdV+HidBRBGbsCwQWQaeT49QBtXIyBY/olwI0m7Vdo6IjOZlDjnOUtK+QhTHn0aNdsHoheC8l8RIdeZmkW1H/85Nc8XgyDn/jBubkRAzx/o2ho+ubtrvPGibqnPUQ0oM1C2VHYJR1Ttwlt+pqddfJjeX/DGKtPS03guWZT8G4hyDiz+S7TEUa5JhDJbukNbr3E0+plLTP883UlqmlS2+zca2KmJO9hBad6EhQz2YTbt8bgiOHphcKEscSwN8GL/bpdB7zb+ek0DrP7LadWdy/8Gi2pdTy1erzokNrq7HLrhDz0c38npt0Dwop7bZXiNCeQ14dFrTuSzOAoNIUHy0L93vvn+9A4qKnulLkJJ7ZWwhFPd9XGBtmqLLA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --zdhfeu2yhc5s3ooc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hello. On Mon, Mar 20, 2023 at 03:06:48AM +0000, Cai Xinchen wrote: > When memcg C is offllined, its pages are reparented to memcg P, > so far P->vmstats (hierarchical) have those pages, and > P->vmstats_percpu (non-hierarchical) don't. When those pages get > uncharged, P->vmstats (hierachical) decreases, which is correct, > but P->vmstats_percpu (non-hierarchical) also decreases, which > is wrong, as those stats were never added to P->vmstats_percpu to > begin with. I was wondering why ->vmstats_percpu matters (in the end all is summed in ->vmstats) -- do you mean this is a cgroup v1 only issue? As only that exposes the non-hieararchical stats. Thanks, Michal --zdhfeu2yhc5s3ooc Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTrXXag4J0QvXXBmkMkDQmsBEOquQUCZB3ZsAAKCRAkDQmsBEOq ubgvAP0S0+i6gFMj+uLkO7p+vwL0oN12X2x0vhGGOkGva271GAD/RP/Nz+EJ6cb5 hc9lBjB3CbP+EKpYGdVof3rKoyv4Wws= =uY3T -----END PGP SIGNATURE----- --zdhfeu2yhc5s3ooc--