From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4482FC6FD1C for ; Fri, 24 Mar 2023 16:32:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 559EA6B0072; Fri, 24 Mar 2023 12:32:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4E25F6B0074; Fri, 24 Mar 2023 12:32:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 383146B0075; Fri, 24 Mar 2023 12:32:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 286226B0072 for ; Fri, 24 Mar 2023 12:32:11 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E0185C09A9 for ; Fri, 24 Mar 2023 16:32:10 +0000 (UTC) X-FDA: 80604334020.23.7AAC8FF Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf29.hostedemail.com (Postfix) with ESMTP id 32F84120022 for ; Fri, 24 Mar 2023 16:32:08 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=P0WpNtnp; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf29.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679675529; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=q4fWVKUQx5n8bQI1VGGVH6TnCQpqPiW0MSEh446FJxc=; b=yTWOVr2+C/KyolMwJiiG90TkF5dUbVbaEO6lZ3XUcZo0qCrbKdf+2uB8Qr+k8kkidvIg3+ 17ATHVsxW9MpswDCb3rwlQdS0jMr25ThaEODMN5W3nf9ICVgVt9sudvTBRSdPciHDyIh3o CN4ZzT35xCI+/V/WU/bTy+nc5vQLaZg= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=P0WpNtnp; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf29.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679675529; a=rsa-sha256; cv=none; b=mPpzMCY7qT0uJfa0rLjUytwhCSNSxq7EOp5EnkEDq1ElFIrXkC1rZuqwlyCYs3fENEdzHq bqqvKybtxvKTKiiRGmBsv2o54gbImhdKr4k+uJgPyzTOhtxxXakV1QHq1Fgue+b1sJoPDf AhoEk7KFl7hKVEitKv94g/CLqrw1PQY= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 20F0C62BD2; Fri, 24 Mar 2023 16:32:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 12C7FC433EF; Fri, 24 Mar 2023 16:32:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679675527; bh=3PNX/74+gO354UCpwGADQlXhZg6ETuvttetxAJdAwJM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=P0WpNtnpJMAZoEKPRE9qYxgAzboyL6KYBJl/kiLSZfdRyb5QKxMQaHd1+6nbqsaro 6lGu7JnxcTAU+F45eMpy4xfUzde82hmH3iun38YGfNOjfyxPxCgIg8YIcvYzVZEYKe G9H3Em5GY2TqMoSAt3rpACK693gKLpxLu0kmpDt8LsXGNVi4wJd174EYtU0SjG6GbP TmttDpoLg8ltbXfM2wUa54mJW13RN1PiOrtvy7HQZQeAyhes4/xDrVMgayULUAZ0BS dgSHP+YxXzVjdP3kS1+l3rjXEpvs6msE5XTcAR3Fe9GgoYKdJvYPfzNijbX7VrQSr2 0OqXK8pBNdVrA== From: SeongJae Park To: =?UTF-8?q?Thomas=20Wei=C3=9Fschuh?= Cc: SeongJae Park , Andrew Morton , damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/damon/sysfs: make more kobj_type structures constant Date: Fri, 24 Mar 2023 16:32:02 +0000 Message-Id: <20230324163202.47254-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230324-b4-kobj_type-damon2-v1-1-48ddbf1c8fcf@weissschuh.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 32F84120022 X-Stat-Signature: g8whdhae48qrtftkge7mb86s5sor9kzf X-HE-Tag: 1679675528-446105 X-HE-Meta: U2FsdGVkX18KNOOMlS6ZEcD8UZ02btL+JzqYmnKLAtv6arRecxD0HN5oxD0///mfWYSjPxNusuaQOI77nLiPV3rRzkmVg2OdKaWfYZn3Buf2jGDQLbayr6wDXdLUNQchsIeCJPpXUvxq4DGXYflqxC68Ro+lTwZjUzE1W1A/7R+zct9SIkVXXC6sr48ivvSzVnsapraKedDMQRj8Sy1DNFUxQiRXF4dKsxbzqQaA9wJ71Y54Gron/P0CNcWmxlJ6MGhGvuzGeuNMDknytRDbkmckF0I47KNFE61QIWt80h56KLstNe4XbgpMV9VUHa7XifmpslmvFYcA/QfC1z3suofKRbdLEEV/VgM1NBFEWG30/4OHcIjxUGZoCdDCIOqZaZu9XJVN5CWnIS+LaKrRT0IU4v0BnG1MO53nv82MRXG5IRolrl/Cm2GJa629eh1rQ/AbIuQWyGI8IlrVZnU64x72K+hXFMV1LxPMZNEiVF++ur5oPBOZRiDl0yAQsWBhGKYA/sluTzWAts4/ZV5e9qQRm5GycY3s19bgByh9W4/glHFnXGYzgRVzWdYPU/iwsAbgSU/iZRghCjs5yD+MvYvt8ZSH7EcxuVM3c1boaucydkYoqtT7kSeZFG2QXk28P8i/za3UpiX1XRk/nW61HMTzUNpF2CmFIHXHwegS2yOdXkDkyOcrw3urLdzHXMwv0b3/DQ1gHVplAG/PQ3GAcuz4T+rlxzFO9gfCDlKCHKrGaFsfAclJv/7syXzor6JTACNqDbe6OJTUews6B1gs1KsfTrC30R30GEqdQJvyP955K5hQNm6VeSbfhOOSztEd9n66agXU5scZlcp57z2paBibjuq4ZsaQxOWRwoeanX9fwPm7dNBWR0ekLUA0Fcf61LN6WAnEmxMsS55Zh7wuRsf1wy2ZKheV132+3G52nvPMAiJseTzv3e/v0GpgXf1WJ47v5wkKjYPpXo6kuU2 SO8AwjpB kOKsxZsXl1LysPI4XUI38lwf6hrhFFF8Cb4mAlhcDFZB+WbH5lTEppyWCoaOMXrA9337Y1IczSHrBmGZzfjvfY9Jo5A+POSJ0S+jkcAPCEYyq1r2LiibxwnV2uSx+pNq5vwzsUcY4pmBVzUwHBmP7d54expQWZi9yPAKyEc7mLJmARL8AjyiE7xygI7eFAGEb29dSoVvb8pflrR3hEOkJ1iSrftrjNAwgBS9uqkTst6cqPqoJE9CX0l9Od2B1fMp/3s72x1fz4QDuI7UE779xld3RgWsCQqqvKUhQTe2RyRUoIwdyBF3hGSkpDBsmDe4JJpvMNG2wBocftb0PDVfta2JmDzNzr9tJzFni/e4+BpLASAH+/AaYE1cFooPSMbTk2dB16RIYBZR/+Kf1jqn5Qm1aakp7UvxPEc9CDJ5aUtBY0c7aL34f/GhrMpAu0iIXHdqgIcSZgQFZsA1YWNaSTmPcTQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Thomas, On Fri, 24 Mar 2023 15:35:27 +0000 "Thomas Weißschuh" wrote: > Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.") > the driver core allows the usage of const struct kobj_type. > > Take advantage of this to constify the structure definition to prevent > modification at runtime. > > These structures were not constified in > commit e56397e8c40d ("mm/damon/sysfs: make kobj_type structures constant") > as they didn't exist when that patch was written. Thank you for catching this! > > Signed-off-by: Thomas Weißschuh Reviewed-by: SeongJae Park Thanks, SJ > --- > mm/damon/sysfs-schemes.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/damon/sysfs-schemes.c b/mm/damon/sysfs-schemes.c > index 3cdad5a7f936..50cf89dcd898 100644 > --- a/mm/damon/sysfs-schemes.c > +++ b/mm/damon/sysfs-schemes.c > @@ -384,7 +384,7 @@ static struct attribute *damon_sysfs_scheme_filter_attrs[] = { > }; > ATTRIBUTE_GROUPS(damon_sysfs_scheme_filter); > > -static struct kobj_type damon_sysfs_scheme_filter_ktype = { > +static const struct kobj_type damon_sysfs_scheme_filter_ktype = { > .release = damon_sysfs_scheme_filter_release, > .sysfs_ops = &kobj_sysfs_ops, > .default_groups = damon_sysfs_scheme_filter_groups, > @@ -503,7 +503,7 @@ static struct attribute *damon_sysfs_scheme_filters_attrs[] = { > }; > ATTRIBUTE_GROUPS(damon_sysfs_scheme_filters); > > -static struct kobj_type damon_sysfs_scheme_filters_ktype = { > +static const struct kobj_type damon_sysfs_scheme_filters_ktype = { > .release = damon_sysfs_scheme_filters_release, > .sysfs_ops = &kobj_sysfs_ops, > .default_groups = damon_sysfs_scheme_filters_groups, > > --- > base-commit: 1e760fa3596e8c7f08412712c168288b79670d78 > change-id: 20230324-b4-kobj_type-damon2-0238ee9e8d8c > > Best regards, > -- > Thomas Weißschuh