From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8B78C77B60 for ; Fri, 24 Mar 2023 15:21:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5187B6B0072; Fri, 24 Mar 2023 11:21:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4C8336B0074; Fri, 24 Mar 2023 11:21:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3DF1F6B007B; Fri, 24 Mar 2023 11:21:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 302926B0072 for ; Fri, 24 Mar 2023 11:21:26 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id C3DF81C5E16 for ; Fri, 24 Mar 2023 15:21:25 +0000 (UTC) X-FDA: 80604155730.22.72E9CE6 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf20.hostedemail.com (Postfix) with ESMTP id EBB501C0018 for ; Fri, 24 Mar 2023 15:21:22 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=fYn5+NeZ; spf=pass (imf20.hostedemail.com: domain of will@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=will@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679671283; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oisnA9cYnE1zu4OFEZZshctqP8rmeG6KLx22az7DwXU=; b=WwrtCB+Z/yvuRBch4R8snpFvgnEv4uZddwbV9sH4+t0TiUYYcoYjFJINpAfkwYVwTVsajY T0yduOc1BK6vMpmB0mKah0uPnXi+nOqOE/gSWL1LmbGO0wbQE8iOHcj3WFFUxYtKzAU+c3 LHD4FMe6zoaS0wjLTVJdiIsVwBw3JnA= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=fYn5+NeZ; spf=pass (imf20.hostedemail.com: domain of will@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=will@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679671283; a=rsa-sha256; cv=none; b=7HNTAGNK5/BjlPdeoQY1gSy4bGhkQtEb4orE2ISBSjp7Uk8znXc3yT4qHYvohEEOZb/OCC mlr3gYcdaHCxCLM8+4sOuBzz3FJEinl67w3NZ9tbnrurFkDdoGQL1Nj+MyKR9cvHfUmg9P dIPf/ueQ9E+eAEmMXu7PV9ohK2HYglc= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E4E7DB822E8; Fri, 24 Mar 2023 15:21:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C4A70C433A8; Fri, 24 Mar 2023 15:21:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679671279; bh=02GM7K6r27KRYha6EteRpwwTUBbmpkVxG9OyijKlG3g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fYn5+NeZtpXWi3nVp/4LLy8DH0H0ymzl9ykR3HGhR56lH3c2NdLc7Vq9e+nz6yGLM th3lEHNjAcHCBgVNwpsDAEfKQW4MaCEZmWtunHGlBnrfdjyrj6dtyckAVr4AytNWP5 YoHlcyh9EHZLpMUfNtTxyT/IdQV32XFdbRz500HJrCQ7B2f3DEU8EIcFjArKBTNnl5 ITOUHbY65mucoIZhCnBong68mCzbzpAFuGBESgTkskfci1G2VXWa9Q9j1pHIxiB916 XgrZ1tXUn9nCbsGi93+pKgYS81I77gF95DX3iMV+WeX4Qo/HnMj3ISRhs917M91OiX +DMCYejfbkXNw== Date: Fri, 24 Mar 2023 15:21:13 +0000 From: Will Deacon To: Alexandre Ghiti Cc: Catalin Marinas , Paul Walmsley , Palmer Dabbelt , Albert Ou , Rob Herring , Frank Rowand , Mike Rapoport , Andrew Morton , Anup Patel , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v8 3/4] arm64: Make use of memblock_isolate_memory for the linear mapping Message-ID: <20230324152112.GD27199@willie-the-truck> References: <20230316131711.1284451-1-alexghiti@rivosinc.com> <20230316131711.1284451-4-alexghiti@rivosinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230316131711.1284451-4-alexghiti@rivosinc.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: EBB501C0018 X-Stat-Signature: b6srbn1jaconmfiwardydz5o7jzkqb76 X-HE-Tag: 1679671282-560352 X-HE-Meta: U2FsdGVkX1+Jr8Wl8C6ikmJcCyZ2V3Z547LX0aKfkO7yZQnRYRqgOOsmTkwdjx3xziZ8G0cK96m/Os0v5/0Mmx+JN5petyrmArl78PjHe9VpRTrdZmJLQd39dy9ag1Jretx2gkFEpelHrZhflUC/zkEab+a69mf/K2REbuMYQoAVehg3zJZJ+SqNWKWp7vtSO0GwUelCSi20mXyUilMIlp62cDluwBUOe8Sqx1n21ngtdRG6+snah4U2tLNB1ZNFuYROixfnJ4aaUvYgZ4/SWazyYC2u7q1cg/5+FTYLCviN5IY3Luz88twmKIyH9XXioAas+oxhlmAfnnQ7EycpB8c9W8auoW7L4kjBZYE1tlAEBOsi6TaIjG1Z/Ohp2Bh2FOXx+avyU3hklFkJ6wSKeP4HcoIIH2XquuCb2M/N8XGdrh9+yd+1LleDldn0jgE6rHWyLM1UBwGoDwYq+LBmJvLbygOTRJOc40IhAzy+q6q9L6ezKKb7WAI2KJ/09Slmdd4WFQDHU2jNOXZNCiTRmjwZigbmPGsrE6hoOTSp2lhXZzKERJyS49WYVQRCRxT0UBJRh7LJsmR/W9mZAFIRVFLNFGeG6M3b2zTpjvLR3+2tWqH6f2RyqAjUYGJ24G5VNigBBkovTn5k9zWYMukYmwjJDV8x7S06UfzjdFV9vVAbuhMTv0+yoDtRTyD9aDIHnOdJYLh7t1Ksb1GrAdR93h2znjlgkpkSiQLO6wcvHzGnYAhZqZ0bt2jJC3XdK5/4po4YUySstX0Ai0J4gk5ZDYsLvqTX+pWm7MRX7twAAooY0DNBZjMgG9HBCx+SxmOOFiyILgHgwi8i+nJXiClbbK1hl7X9zffCBcj8PgiOc9TmLdt6Pos7UgJSwsJ+QY5rZWPb5EhUEYeM+4K8YtztqMR09UuLO1CJV9Q1dlZaIA2m8zB1VGwfIcu2GOZyVJBONIthBuq0gNag6YjDe1h JI0JutHf uz3vQhJ1FIQ2CG/WdOd3fZNmKPmxbg5KWLg4YGjfvdcdX2iBovpWFO/oTfcltJoQx3lBbP7NP/DwrKZmZlGXRbKZDRAwzBIdDRHhGiQzeZ+7LW5fErsfaMbnpG1uS2TLg2vRiwwHbNY90uhywIrXc/a4UF6Eg1p3kwREX6uMMnE0ZjZTs9+frQ+DyEHLe3c/MSRbYxEOptz7fRahPrXHYteHfomRQp4osDCrYFOjJQP4U6v/suAeha63FjNak3JIG+VkTOeXKQMvIsR0clYzdt2BoSSWmkprBPTQbm8mZw1XHXw1WRerYbiflZSiJoZarMXnX X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 16, 2023 at 02:17:10PM +0100, Alexandre Ghiti wrote: > In order to isolate the kernel text mapping and the crash kernel > region, we used some sort of hack to isolate thoses ranges which consisted > in marking them as not mappable with memblock_mark_nomap. > > Simply use the newly introduced memblock_isolate_memory function which does > exactly the same but does not uselessly mark the region as not mappable. But that's not what this patch does -- it's also adding special-case code for kexec and, honestly, I'm struggling to see why this is improving anything. Can we leave the code like it is, or is there something else going on? Will > Signed-off-by: Alexandre Ghiti > --- > arch/arm64/mm/mmu.c | 25 ++++++++++++++++--------- > 1 file changed, 16 insertions(+), 9 deletions(-) > > diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c > index 6f9d8898a025..387c2a065a09 100644 > --- a/arch/arm64/mm/mmu.c > +++ b/arch/arm64/mm/mmu.c > @@ -548,19 +548,18 @@ static void __init map_mem(pgd_t *pgdp) > > /* > * Take care not to create a writable alias for the > - * read-only text and rodata sections of the kernel image. > - * So temporarily mark them as NOMAP to skip mappings in > - * the following for-loop > + * read-only text and rodata sections of the kernel image so isolate > + * those regions and map them after the for loop. > */ > - memblock_mark_nomap(kernel_start, kernel_end - kernel_start); > + memblock_isolate_memory(kernel_start, kernel_end - kernel_start); > > #ifdef CONFIG_KEXEC_CORE > if (crash_mem_map) { > if (defer_reserve_crashkernel()) > flags |= NO_BLOCK_MAPPINGS | NO_CONT_MAPPINGS; > else if (crashk_res.end) > - memblock_mark_nomap(crashk_res.start, > - resource_size(&crashk_res)); > + memblock_isolate_memory(crashk_res.start, > + resource_size(&crashk_res)); > } > #endif > > @@ -568,6 +567,17 @@ static void __init map_mem(pgd_t *pgdp) > for_each_mem_range(i, &start, &end) { > if (start >= end) > break; > + > + if (start == kernel_start) > + continue; > + > +#ifdef CONFIG_KEXEC_CORE > + if (start == crashk_res.start && > + crash_mem_map && !defer_reserve_crashkernel() && > + crashk_res.end) > + continue; > +#endif > + > /* > * The linear map must allow allocation tags reading/writing > * if MTE is present. Otherwise, it has the same attributes as > @@ -589,7 +599,6 @@ static void __init map_mem(pgd_t *pgdp) > */ > __map_memblock(pgdp, kernel_start, kernel_end, > PAGE_KERNEL, NO_CONT_MAPPINGS); > - memblock_clear_nomap(kernel_start, kernel_end - kernel_start); > > /* > * Use page-level mappings here so that we can shrink the region > @@ -603,8 +612,6 @@ static void __init map_mem(pgd_t *pgdp) > crashk_res.end + 1, > PAGE_KERNEL, > NO_BLOCK_MAPPINGS | NO_CONT_MAPPINGS); > - memblock_clear_nomap(crashk_res.start, > - resource_size(&crashk_res)); > } > } > #endif > -- > 2.37.2 >