From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25099C761AF for ; Fri, 24 Mar 2023 15:17:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 62C576B0072; Fri, 24 Mar 2023 11:17:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5DCD66B0074; Fri, 24 Mar 2023 11:17:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4A4E56B007B; Fri, 24 Mar 2023 11:17:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 371F36B0072 for ; Fri, 24 Mar 2023 11:17:23 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 0F1B680AC8 for ; Fri, 24 Mar 2023 15:17:23 +0000 (UTC) X-FDA: 80604145566.02.D21E388 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf06.hostedemail.com (Postfix) with ESMTP id 3CB2218000A for ; Fri, 24 Mar 2023 15:17:19 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=TgmwsbLl; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf06.hostedemail.com: domain of mkoutny@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mkoutny@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679671040; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bwervvL2VqoJp7Lysjwx0FFEhlsKTjSqVYYrPqe2D7Q=; b=tbu/i2c5AArgBMcr6rs8MYJOBOV1qOe4+2zNGQIdt6AqCiEfH9+GtML7bDcm++7X5yawOQ GmCM+qFPW3AoF5bSxD0UyaXHFoj3uZ0Z9DWABlpcEHXkjTI5a0XXIdYcHa0tPi0D/08DNb h6jhmj8Q1VScgJUyaJbsNv//ENhT87Q= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=TgmwsbLl; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf06.hostedemail.com: domain of mkoutny@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mkoutny@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679671040; a=rsa-sha256; cv=none; b=NA6XJUsGCXFTiEnc00JiI/+G5V1ZzMbJy4SVS2Pwd7XlXNhy6s9Mcg6wAHVfOBT76+pHxY 7Zq1GkptxYbuF//YdcUY7lz/4r2xm9HFCSqvNi98YHlMOL87Zvj514kfjeq8J2GmilftD0 161rF/suXSbHbUxmpmJIH8aW0RR6svE= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D912D1FEF6; Fri, 24 Mar 2023 15:17:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1679671038; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bwervvL2VqoJp7Lysjwx0FFEhlsKTjSqVYYrPqe2D7Q=; b=TgmwsbLl+DA5Nt70AmZzlhUhFnz2I8NZtHoXA9KZt0n0xrFCGQ/YcA+FBZzx5Gd9YKiOCI bHaGK3KdSJtjWhbFYpt8xp9g3zTgsEdqgjVpEmsD/3IKuaTKEB23gX1Z7Zdt3DkXUwoRe5 7mksq3ezMiaJva+j+TCZ+oYN/uUqCH0= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7BAF4138ED; Fri, 24 Mar 2023 15:17:18 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id EG8sHf6+HWQUZwAAMHmgww (envelope-from ); Fri, 24 Mar 2023 15:17:18 +0000 Date: Fri, 24 Mar 2023 16:17:17 +0100 From: Michal =?utf-8?Q?Koutn=C3=BD?= To: Zi Yan Cc: "Matthew Wilcox (Oracle)" , Yang Shi , Yu Zhao , linux-mm@kvack.org, Andrew Morton , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH 2/5] mm: page_owner: add support for splitting to any order in split page_owner. Message-ID: <20230324151717.hawuy5gs6cnxql55@blackpad> References: <20230321004829.2012847-1-zi.yan@sent.com> <20230321004829.2012847-3-zi.yan@sent.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="exvxtogrhnfaw26c" Content-Disposition: inline In-Reply-To: <20230321004829.2012847-3-zi.yan@sent.com> X-Rspamd-Queue-Id: 3CB2218000A X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: 76pzgqtc1wqkpcy9zjocs7n9ewmf9pxj X-HE-Tag: 1679671039-460966 X-HE-Meta: U2FsdGVkX19aamEmpZLDXR8r8Zli7zkaVe7deDEUaedr0W73jVyOwD71UdZ/6CWa0zKW5hPOg3+bKoFbYH45SuUnCrA574aiCPQreNbmVANVa+dk2O9ws/lQUHT3G/Z73+5xHv+LpPBHO7mWPEv/pXmAg6nLAr79+UTuyMMILaanvs8PXDj/hcIfRZkog/geglQuFPADSyLMxisXGMvbFfdYXrwksKctmX2Au4Y6vTTsc4+LEs+Smfej1j6t+UHstCHnC5INqbuva+Mow+B2R8YGPOoznjoqjnNJ2g+C2T/iY9l4cyUegAq2xM9AxtlzYq9Wk8C2uoXQVoorPH8FAvdveR/m017WfDvRugDHPvpL2SiY1CiCGTyfmqhTzBSEgk5HtEbJHe1QBsmkNTnG5ojTo4WeqeuTu3bzCwE7TLcQA55VUroPwb/nT4fGNRxFeEoWp6g8v0vwaHCqeLRwSmoKNsmwblPI8Pd6RnexkH90nPDER7aAk+VpmoOqvddI6PBtxcr59Nn5/51xLjAQ2Aiq52yzjgVVhAOnwqDFCIoHWXFrg71/qOxXYqlfc6Np0Pk1YinXuBCe0MIVo4eoXYFosh0xdUFcs0Jw1jPv8B1opGurqZ1FU/jB3Tj9RuOKo7xK7tePrAT/Vjk7EaH7G0IsA9CpeUdc/8lwszav+pIbcj7uE6EzG8Y/lOHRS/pkloAGWO+Lb7d1xZulWTjMNOznSMXrGML1jrWw8YOShAz+lP2WCB6jzU9qgXEKcutF3yOxAgHTbegZ1D8cm+u1UVkFtrqwglvfQxyBeYULKlZNUfIWTpDqVPUWOeVB6Ivi5cghoEUg4afyg37x3JPQH/c8wXywPH9ZVA9JUI+Wvw/XUNzu9Lcfxw/3Ipg+XRBvbxqmM9HK07vLS+eaC8SQzKTVQ5y6TshDxyWfAAT/EuTAW9gy9R5t/kO/cASTeOo7lM4LGqp5Dp8RzDJL4+H my35jlgK Pw2u6wWAHv+4uS0IiUADW56htbJkhbPZ0iiskiwebHwADEIm2c/eSUE4bTiLMdS0D3WraCK35BeemkxyHb5ARBlGE1nkUmvFjs4dT4nyEIp3OOI+hmgZrNbgHiDRc3N20IMe6Yangl1MSNWynohEdC6b/KRNXtVWDaWEAIGnyrwUBcUw7IMglU0057gadCS7DX7Jx7vb7hNwzmQRm40p67AkGk8dDeAqGfcaMSmGPfG62/N8dO0757X6TzOvp0EWHfGMki8IaMGU59wyt41UR0ypgHnYvE9kZ16JlTQ1qw5SVqFp2U//G6NVh/gui+rEaokJvQ9PeA91ezZ+paR26MWOtTJBBuIGmiyRw5Q+nPxNn78DMV20Zs5p4+hGxHunrDAfVgBgMqw6sfwhOuuhpuXDdMPc3I7ELca8Bv3Nsi5l4LJYjXNnHiwVdka7qaV6L2P0iVub3e5LsIaJGk0vEmd6DjSbNrRwGD8YGD86wLF5+jVy6YBg8gpiBBA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --exvxtogrhnfaw26c Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello. On Mon, Mar 20, 2023 at 08:48:26PM -0400, Zi Yan wrote: > @@ -5746,8 +5746,8 @@ static void *make_alloc_exact(unsigned long addr, u= nsigned int order, > struct page *page =3D virt_to_page((void *)addr); > struct page *last =3D page + nr; > =20 > - split_page_owner(page, 1 << order); > - split_page_memcg(page, 1 << order); > + split_page_owner(page, 1 << order, 1); > + split_page_memcg(page, 1 << order, 1); I think here should be > + split_page_owner(page, order, 0); > + split_page_memcg(page, 1 << order, 1); because I was wondering why split_page_memcg() doesn't use orders too? (E.g. it wouldn't work well if nr % new_new !=3D 0). Thanks, Michal --exvxtogrhnfaw26c Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTrXXag4J0QvXXBmkMkDQmsBEOquQUCZB2++wAKCRAkDQmsBEOq uZYWAQCFTMigwoG6hG2bxKjAJtYDo8OWh0BZq1aPs9LM+QVdBwEAvayit0OXGxQ2 MDrtNVNB0nXobbi8EK0m4EAaSr9tCQA= =FNxP -----END PGP SIGNATURE----- --exvxtogrhnfaw26c--