From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A20C2C6FD20 for ; Fri, 24 Mar 2023 14:58:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1A6A16B0075; Fri, 24 Mar 2023 10:58:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 156FB6B0078; Fri, 24 Mar 2023 10:58:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 01DE46B007B; Fri, 24 Mar 2023 10:58:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id E408D6B0075 for ; Fri, 24 Mar 2023 10:58:38 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B42AA40829 for ; Fri, 24 Mar 2023 14:58:38 +0000 (UTC) X-FDA: 80604098316.30.F555E87 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf22.hostedemail.com (Postfix) with ESMTP id 0E8FCC0014 for ; Fri, 24 Mar 2023 14:58:35 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=jT3AM6bf; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf22.hostedemail.com: domain of will@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=will@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679669916; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lVVMX7BXgivZOLY93kaKnv2NrK9gNiAzfwsFPIWVYek=; b=WZogK6dX2Kpa4kFGtRxzcrCzKmW1SX3llGV3Xybw2XixLSbO6nRn+jsetApD4mytdDdBg1 eb4iC/7Uvf0mlm1oqZDDspnEkzX52Cp8o/Bs8AhAG23U3ToLNStBdTqkofjma+0mHKF2qH BHCLH4IwqkRCsqbXmWFQclpaMLUBivo= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=jT3AM6bf; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf22.hostedemail.com: domain of will@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=will@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679669916; a=rsa-sha256; cv=none; b=V/OUb/9a+Rm8/MwMRFU5FfZW4F+FxHS3WInmyjPcdxEPlnOVUEKOUz+CILyDxV2dRoAb2H xr9udySt3o83eoy1kMYanTOiyBwxya2qjRLjZOw/Ihzx5jh2ciQMMW/BXmm2YkFLJu2cOF I3NdYDDW53Oa5c+pf1yNfSlBHu/wD1Q= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E4AAC62B5C; Fri, 24 Mar 2023 14:58:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 34A12C433D2; Fri, 24 Mar 2023 14:58:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679669914; bh=IPP98xkEGCS26RS7zBBVCYa/If1hBwvykU9UME9Sd7k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jT3AM6bfW/hZrebKexLOI2EXvMKsrwnQPoq4KUl14cM/kv9AkBq0fFB4PPIOnNJ+1 +iabW6SWEMiee5ThCRpLvZjILgEf6M0UqONHrcE8FluvoTBACt6nxjsrr47wBCB3D3 gemJQlLCSDzmfTSKyzzL9X8li2Cwa34DFjL0LqUllttmolWbF0WcPD4+P3b5lm5Qxe OeQpJfXCFU2kkQPSpnurx43pKm3PSEYs75ffRlLZQ16XD0VIfAaqrBLUyEt6mgzAPu 66mDPfyUXV2xEWnfsBTSYlmpwQMBmlrBL/K85qAq9lxs4muYYtn1hkJ7jsAFRjFDDt /OjAXMJuNBNqw== Date: Fri, 24 Mar 2023 14:58:29 +0000 From: Will Deacon To: "Yin, Fengwei" Cc: Ryan Roberts , Matthew Wilcox , linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 35/36] mm: Convert do_set_pte() to set_pte_range() Message-ID: <20230324145828.GB27199@willie-the-truck> References: <20230315051444.3229621-36-willy@infradead.org> <6dd5cdf8-400e-8378-22be-994f0ada5cc2@arm.com> <2fa5a911-8432-2fce-c6e1-de4e592219d8@arm.com> <12d7564f-5b33-bdcc-1a06-504ad8487aca@intel.com> <25bf8e75-cc2e-7d08-dbba-41c53ab751b0@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Queue-Id: 0E8FCC0014 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: mkjww93qwrtejighjdujzu4ednekox4c X-HE-Tag: 1679669915-764522 X-HE-Meta: U2FsdGVkX1/nVA86vUaW36Dd7YzmxRomFTzSPgRWSYboU0q5qFLe1fUSJ7JgRhMjUsLA9GVoD07/pRO0FpEka9wYtctGHPLkrOICxYUQFZDESFgU8RwKQAhRYdLjJMA8xvzNIYMCS3P7ysA14p7ei/+Exwe1LiCw5FWEGc6F95XRDDa3rw6G9jWcuUHQzPdtLycISJ6WPXc+TAEB9MK1lqTc97bd6LGHt5xj0HKTG+k3xXJ1JBpBSb4ogs5yY0+/7qNyJQOnniuUGPx8N/mJV2ifMqvn20AMN+313HEyALjHtkqpQjKEw+1gvXC5HPmxwyLoKUCyfIMRMvb/QwrZ6aQAzXdrkzgjPbcjmaC6vJar4syCVcMBnYqsZFPFK7MuPMjPWbXDc1OEfvf+DlIZEe4KZZkwEJLwK1rowDyXw7Lusu2pkcbZtFjmc3I0Pk8xRruRlwsLBPGGesgdkaTPJE3htx9vGwKxPXiTi9+11x11E97zQtevba7r3U1MJ/ZceqTMFglbrArdfiy34R5162fiZlSIrZDr2ymgR0PSjCmwd5s2V44hQ7QPknQaJktLrJPezQjDJHtpancoHB9ai53gsHThoF0e7N92D2oGppGoOo5KBTwGZKWEqUVdIjxAy9qVaqly6no+KxJQfuHJHe88AZZgFLSrSfqtWZyrv9EwdEFSiS8v8gycYXZ082VCyv4+6a3mszwoaAzRdH4wL+wT9lWndhyP43GmIn3MhUqpPjvUw6sygoSD5coZo6R3fRfR1baMarTcXu3QbeNGQe3Spk3/mcm5cJL8D7zEoU2zJvQiiXj0SfxDEjliuqetlO+dUU04HU686dBwMJrft1/55XiF6g6VWFmfpXhBquqPMfs4ZNaRqcEsv+xjDojVZk/pduv126bLIGeXAtNOUFypo37OEWHi2QJNx5wdoQOjoP/uMLGqLi2X1C1pdD704W6wmxHyKrlw7CFxk/u bXFj2mcr 2/jqv1TXjY/3XjOaeaOp07tHc1FkR8HzMFHFerfb1J5tmDBNorixl6Gj1r9T91Q0onZ5hpHWBEBX2711DoMEw35hZubs+guJt1sCKZQA1M5DoDH4hm9p+XQN/Ik/anIg133WbikxbfhuWFToU2ahTbTOKMIh2ymbPTgeyvnIulbGCAqAjAR0kH6vsGedHNeyTFoXOPm5EGniq9iiWnDCk/WhrN01sC3B7M6l7YKUqFivfJJGizgBqn8p+/KtXK/BTwQ2R+PbHu74B0TreKuJAdlEy9oQv5R2rGMZnVAoJnMuLKOWWfrHPqa7kSke8rimk5EHvPsYc/7BWHPOobNUI79rhosaDCFO9b9286b09RjHzikX7O4DgciqZhRjI8Hxy4So3wB9t+asF9rEJl/slQtIWmg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Mar 17, 2023 at 04:19:44PM +0800, Yin, Fengwei wrote: > > > On 3/17/2023 4:00 PM, Ryan Roberts wrote: > > On 17/03/2023 06:33, Yin, Fengwei wrote: > >> > >> > >> On 3/17/2023 11:44 AM, Matthew Wilcox wrote: > >>> On Fri, Mar 17, 2023 at 09:58:17AM +0800, Yin, Fengwei wrote: > >>>> > >>>> > >>>> On 3/17/2023 1:52 AM, Matthew Wilcox wrote: > >>>>> On Thu, Mar 16, 2023 at 04:38:58PM +0000, Ryan Roberts wrote: > >>>>>> On 16/03/2023 16:23, Yin, Fengwei wrote: > >>>>>>>> I think you are changing behavior here - is this intentional? Previously this > >>>>>>>> would be evaluated per page, now its evaluated once for the whole range. The > >>>>>>>> intention below is that directly faulted pages are mapped young and prefaulted > >>>>>>>> pages are mapped old. But now a whole range will be mapped the same. > >>>>>>> > >>>>>>> Yes. You are right here. > >>>>>>> > >>>>>>> Look at the prefault and cpu_has_hw_af for ARM64, it looks like we > >>>>>>> can avoid to handle vmf->address == addr specially. It's OK to > >>>>>>> drop prefault and change the logic here a little bit to: > >>>>>>> if (arch_wants_old_prefaulted_pte()) > >>>>>>> entry = pte_mkold(entry); > >>>>>>> else > >>>>>>> entry = pte_sw_mkyong(entry); > >>>>>>> > >>>>>>> It's not necessary to use pte_sw_mkyong for vmf->address == addr > >>>>>>> because HW will set the ACCESS bit in page table entry. > >>>>>>> > >>>>>>> Add Will Deacon in case I missed something here. Thanks. > >>>>>> > >>>>>> I'll defer to Will's response, but not all arm HW supports HW access flag > >>>>>> management. In that case it's done by SW, so I would imagine that by setting > >>>>>> this to old initially, we will get a second fault to set the access bit, which > >>>>>> will slow things down. I wonder if you will need to split this into (up to) 3 > >>>>>> calls to set_ptes()? > >>>>> > >>>>> I don't think we should do that. The limited information I have from > >>>>> various microarchitectures is that the PTEs must differ only in their > >>>>> PFN bits in order to use larger TLB entries. That includes the Accessed > >>>>> bit (or equivalent). So we should mkyoung all the PTEs in the same > >>>>> folio, at least initially. > >>>>> > >>>>> That said, we should still do this conditionally. We'll prefault some > >>>>> other folios too. So I think this should be: > >>>>> > >>>>> bool prefault = (addr > vmf->address) || ((addr + nr) < vmf->address); > >>>>> > >>>> According to commit 46bdb4277f98e70d0c91f4289897ade533fe9e80, if hardware access > >>>> flag is supported on ARM64, there is benefit if prefault PTEs is set as "old". > >>>> If we change prefault like above, the PTEs is set as "yong" which loose benefit > >>>> on ARM64 with hardware access flag. > >>>> > >>>> ITOH, if from "old" to "yong" is cheap, why not leave all PTEs of folio as "old" > >>>> and let hardware to update it to "yong"? > >>> > >>> Because we're tracking the entire folio as a single entity. So we're > >>> better off avoiding the extra pagefaults to update the accessed bit, > >>> which won't actually give us any information (vmscan needs to know "were > >>> any of the accessed bits set", not "how many of them were set"). > >> There is no extra pagefaults to update the accessed bit. There are three cases here: > >> 1. hardware support access flag and cheap from "old" to "yong" without extra fault > >> 2. hardware support access flag and expensive from "old" to "yong" without extra fault > >> 3. no hardware support access flag (extra pagefaults from "old" to "yong". Expensive) > >> > >> For #2 and #3, it's expensive from "old" to "yong", so we always set PTEs "yong" in > >> page fault. > >> For #1, It's cheap from "old" to "yong", so it's OK to set PTEs "old" in page fault. > >> And hardware will set it to "yong" when access memory. Actually, ARM64 with hardware > >> access bit requires to set PTEs "old". > > > > Your logic makes sense, but it doesn't take into account the HPA > > micro-architectural feature present in some ARM CPUs. HPA can transparently > > coalesce multiple pages into a single TLB entry when certain conditions are met > > (roughly; upto 4 pages physically and virtually contiguous and all within a > > 4-page natural alignment). But as Matthew says, this works out better when all > > pte attributes (including access and dirty) match. Given the reason for setting > > the prefault pages to old is so that vmscan can do a better job of finding cold > > pages, and given vmscan will now be looking for folios and not individual pages > > (I assume?), I agree with Matthew that we should make whole folios young or old. > > It will marginally increase our chances of the access and dirty bits being > > consistent across the whole 4-page block that the HW tries to coalesce. If we > > unconditionally make everything old, the hw will set accessed for the single > > page that faulted, and we therefore don't have consistency for that 4-page block. > My concern was that the benefit of "old" PTEs for ARM64 with hardware access bit > will be lost. The workloads (application launch latency and direct reclaim according > to commit 46bdb4277f98e70d0c91f4289897ade533fe9e80) can show regression with this > series. Thanks. Yes, please don't fault everything in as young as it has caused horrible vmscan behaviour leading to app-startup slowdown in the past: https://lore.kernel.org/all/20210111140149.GB7642@willie-the-truck/ If we have to use the same value for all the ptes, then just base them all on arch_wants_old_prefaulted_pte() as iirc hardware AF was pretty cheap in practice for us. Cheers, Will