From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88E43C76195 for ; Fri, 24 Mar 2023 06:24:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 834D16B0072; Fri, 24 Mar 2023 02:24:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7E3B76B0074; Fri, 24 Mar 2023 02:24:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6AADB6B0075; Fri, 24 Mar 2023 02:24:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 594216B0072 for ; Fri, 24 Mar 2023 02:24:16 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 320441606F2 for ; Fri, 24 Mar 2023 06:24:16 +0000 (UTC) X-FDA: 80602802112.17.A4E2AF4 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by imf09.hostedemail.com (Postfix) with ESMTP id 56B49140018 for ; Fri, 24 Mar 2023 06:24:14 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=YD7aApoa; spf=pass (imf09.hostedemail.com: domain of yexingchen116@gmail.com designates 209.85.214.175 as permitted sender) smtp.mailfrom=yexingchen116@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679639054; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+gg+Nsm6tcL5yVwisqqOCzwyC+QFvP6IJKg/xOEnEw4=; b=kBYFtViM6nr0CCUNA6XC+vTmGnEqD48hNLLVFAr8GAmy0u2kzyrBvxSIhnnW2TZC7YB4A/ C5L4Nwo3MDlutngvt+BNpJ2aHwifpiZMYN7LXUCnZvvIyh2LI9aYFYZ/SYsL7Co0J6KKoF YI1ug8ajlAhgwgKkYGeATal1KbOgieA= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=YD7aApoa; spf=pass (imf09.hostedemail.com: domain of yexingchen116@gmail.com designates 209.85.214.175 as permitted sender) smtp.mailfrom=yexingchen116@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679639054; a=rsa-sha256; cv=none; b=wz86/OxlQ1Ou8mlHE8RaoTTlNVM3iMvx0HubT1ClWbJ1hHcGmMYiFEd+KeNrxJ+t+SHGvN 7d/rvGn/FEwJW72VTbocrG3+M9uPzPRwbyLIgd/jsRV1S0K67/HAH13W71XSVxxTizx+Hy ozogxbqZ6Xw5BWzoU62ZwKE2mqqdLQo= Received: by mail-pl1-f175.google.com with SMTP id kq3so935616plb.13 for ; Thu, 23 Mar 2023 23:24:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679639053; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+gg+Nsm6tcL5yVwisqqOCzwyC+QFvP6IJKg/xOEnEw4=; b=YD7aApoa2wmPLKup872tCwpuexBHKmDDGYQKsA3sNhW8fTRn2XWhjUUTM4hhIgIekL bZCtAx+lzwY/pR96VwvieF+Okg3KahE6wMREF6HoZ0DTFlblDD0t7KFet5FZR5IhbH/N dk/2GigPG8p1fYvJ0aEt0nY8FNtK2klW6nuuRQZKzPYWKzCyvVCwDVEkmlAlJCqYMQkX //z3Z7RRpdWEcmU7iS1vzMA4tOhYGRqIF+al0ViJcANw6DF8MAklH68yOLYXcYRkjcw+ y7ESYFAKjUXKb2Lhh/v5kyPOSw6Yoh6Ya/F/5iP/NGtAXgKcXanoV2eV5apwsOZpxeje NF3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679639053; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+gg+Nsm6tcL5yVwisqqOCzwyC+QFvP6IJKg/xOEnEw4=; b=6I/HjElHqR212LLw+tLMXWXVfR7NqBdnOy30AqeHUh9dfKSMNz9y51Hx8Vr95nY8y1 OdvOeeOFI5dsh8lAeK5+VkTfcTORgINghlk4cRfdRNwdU+hHDLEg0Gs+asIvgwJmYjMG joMLuKYxcclKuUehu7GcgrtZbZCPW+OR9WWZG7dukgQ9AFFCt1k85leu5H8/0S6QOqIW CXPuBrWUc+j+ec2fgza2mC5QAq4AyDViwZn/mjJ6CMZYCMibvnZSU7JTlDEUSiv7fJmH w/cxIlbOAELN8vZMIBjhNgR5uuDZ68ImSpR4KdgFdBI+mKPSd8OsxTZ/BbKz/Y6StZhp oL+w== X-Gm-Message-State: AAQBX9dfWzl5aWIwao56q13YKHVQcnqtRCQsyKp8NyvXkKbt8r7XJEJI ug2tXr27o9BTyhOPQtwHa3o= X-Google-Smtp-Source: AKy350bCFPXGsMbPU6EZpUl/RFKFCBwPhD9fjkabLqNkx4Vdl5E7xLlzH1csUAZpy4+c7C5A2ksnBA== X-Received: by 2002:a17:90b:4b10:b0:23d:41:3582 with SMTP id lx16-20020a17090b4b1000b0023d00413582mr1729412pjb.8.1679639053020; Thu, 23 Mar 2023 23:24:13 -0700 (PDT) Received: from localhost.localdomain ([193.203.214.57]) by smtp.gmail.com with ESMTPSA id ay6-20020a1709028b8600b0019a997bca5csm13275036plb.121.2023.03.23.23.24.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Mar 2023 23:24:12 -0700 (PDT) From: ye xingchen X-Google-Original-From: ye xingchen To: mcgrof@kernel.org Cc: akpm@linux-foundation.org, chi.minghao@zte.com.cn, hch@infradead.org, keescook@chromium.org, linmiaohe@huawei.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, vbabka@suse.cz, willy@infradead.org, ye.xingchen@zte.com.cn, yzaikin@google.com Subject: Re: [PATCH V5 1/2] mm: compaction: move compaction sysctl to its own file Date: Fri, 24 Mar 2023 06:24:08 +0000 Message-Id: <20230324062408.49217-1-ye.xingchen@zte.com.cn> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 56B49140018 X-Rspam-User: X-Stat-Signature: 8t1qh8nu5wdfbe8bsjt79hs4jwpim1dc X-HE-Tag: 1679639054-197362 X-HE-Meta: U2FsdGVkX1+KuyCfrQA8WYmxpwH4vyqGPRxlS00FLyOKxFZh1RR61qu9O49LKoRnJpSScQ0utM7l6+mRkteBaWrjo+rxxMYSZ1c009s2qd+Yrnu2+s5gy9xOTetfnci5xOtM+ZJEDwWuvYq/2AUENkaOYREfSx1LqzabuKtYfNIujFpxPDP1Hsn117lWH+GxleWks4M+SKrzJ1+Bx1JYPWoIar5d2+0kUivQ9k0LT7v6w5AJq/bwoisyPgdfVFDEXaa5BdygQnZzr3cIzdF3L+Qfd3/s1xHfaD4FMfGmWTiuTroXSHziQ0+TdyMST9CmuGli/HfMh5Y+ZN7TRqotAZEC9FsOzleY0AgYRKbUh/KtlgVdcV81jArq94gseiOBDAjglOAvvWM8P/ynN3u40ejkOG6GhVeU0RxL6LhEE8B15I1db07O30NtJfOLI1t68eiLS1ncaRga0JSrvzHvqUrPP6eOLIfDZ8KrMSlPkXz61jajYqEMmf0j35CyDU6llEvx60lMajBV6JlZC+wqsj1S9emb7m5DHHWEjtC0eLVHypdQI3ZSKeRe7Yx3rJ7NGVDliik5H1hjjLSKcT96A6eXydp27lsFafuag/6Lk61Xi7/VGqnq0s7yLOkLYmfr6zGlXSTiQ4wq29N0d1z+EkUTaJqDEvwoteuSW3I53ygpLt7O+jhDC6ibw/cB5YN92hPakxFij3BnEjl1IFklq9xrNX4YeSpz7COByTNebN0VmKdMg3ciJyUdP8mAnvnxFv4jwfYC1E/CF83xWZUY/BGGkVpsFh0tl2gM1c1qptQ375W1IfDRUS+rMCzcc0L0NSH79TmtNRkJwici/O1WWN08jawakRoRmJtsrVwGV/Oup3u0u8EPyhFkZcvexBqV88pHOZns7x0Zjh/VzEtBU0wFk53xzbZ1GDZzPlfi1hmMCy5Y/+gWDOT8eud2n6xHl5XZta6POrd3GToXOgl PwLCPMT4 wudVZebb9ClRQIhHKTdl5KmFBNfvm0usy+OB5585obOTYtMj4OotERMPbrRj1NnlpsVpjKZRl315o2rpSGTYwRpJnMrqSagmsNA6E0V9CLw/tp1oGv6keyvj0swvW/ao0zAm/ZXFXJG5CJC+ZhDGAHs5WZSRyyICOtCP3Mvj+w2h3Iqh8iHAYW8CROj88y5+YnHrxOVsTN7AvNowlF89nHa8gFCQZYV1McpXQhKQNjYIpYOj+F8LDI3iXV2gOWMSx+zvMLTR+WnQqE+Zf9PSoUKIQIWnNPQbvm2PkiC87fs8CrSMdHuIf5yFlvNqcllJXoEC75lu0dhQhwvK8RwyL1YyrhasErihn09K3Uy6C/bBHayuphfw0B+4P754WaLUMzA3hkn3xIi1Vf8e7bEzu8FqpEA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: >$ ./scripts/bloat-o-meter vmlinux.old vmlinux >add/remove: 1/0 grow/shrink: 1/2 up/down: 346/-350 (-4) >Function old new delta >vm_compaction - 320 +320 >kcompactd_init 167 193 +26 >proc_dointvec_minmax_warn_RT_change 104 10 -94 >vm_table 2112 1856 -256 >Total: Before=19287558, After=19287554, chg -0.00% > >So I don't think we need to pause this move or others where are have savings. > >Minghao, can you fix the commit log, and explain how you are also saving >4 bytes as per the above bloat-o-meter results? $ ./scripts/bloat-o-meter vmlinux vmlinux.new add/remove: 1/0 grow/shrink: 1/1 up/down: 350/-256 (94) Function old new delta vm_compaction - 320 +320 kcompactd_init 180 210 +30 vm_table 2112 1856 -256 Total: Before=21104198, After=21104292, chg +0.00% In my environment, kcompactd_init increases by 30 instead of 26. And proc_dointvec_minmax_warn_RT_change No expansion. minghao