From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4FEBC6FD1C for ; Thu, 23 Mar 2023 11:12:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 12E386B0072; Thu, 23 Mar 2023 07:12:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0DF876B0074; Thu, 23 Mar 2023 07:12:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EEA036B0075; Thu, 23 Mar 2023 07:12:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E07F16B0072 for ; Thu, 23 Mar 2023 07:12:29 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 8C8FFC0706 for ; Thu, 23 Mar 2023 11:12:29 +0000 (UTC) X-FDA: 80599899618.09.E769BCB Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by imf19.hostedemail.com (Postfix) with ESMTP id 7EF991A0017 for ; Thu, 23 Mar 2023 11:12:26 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="gJZ/CJZE"; spf=pass (imf19.hostedemail.com: domain of lkp@intel.com designates 134.134.136.126 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679569946; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=2JU6IZed5ttnrrE3bOUKZKK5KFMnsq0fSOCHk8hNmYg=; b=SJWNya9wXrVusTJZvR99dv1DN5/TT1TiLYRVOhzZS7CZtRnDfM25qs39ikO+yo4TsSVuJj A6B/ZmqULRCb2N0tPMwAroJGYD2VeiibUAjufucpaNXjix0882jMMGWb4UyhTeTacY0c/l 42TP0fHPIS3D7D4/nj1WR/YypE7THFY= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="gJZ/CJZE"; spf=pass (imf19.hostedemail.com: domain of lkp@intel.com designates 134.134.136.126 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679569946; a=rsa-sha256; cv=none; b=uk1+E+BeC3whA5sFzC0DEW9DtMaHEYjEOxl95G5/t4o3BDrFzUROr4YmempFJgQRUgVKHA z27PTo5Jpyot43w9vNMpgkGqIFyLUwQYT5GCJgpt0EXYOS9PULTGMrIxWRJM1480nGb4R7 ebOsqU2+UOFWvziCnFeALEfQ0au70OQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1679569946; x=1711105946; h=date:from:to:cc:subject:message-id:mime-version; bh=7tCoFmaFTJ6z4X5B1ksmrYNk3RRt1TLljTh/VugzT2E=; b=gJZ/CJZES2YD1UmBEq3DLSR/MnINi5JfN4I+DQVVFnS9qArc34ke1VXI 09tTCyjAunZ+xbovruSkwJP0bpJuHCk+MDSUiZ/fgNpb3A4VU4IdOL41J YxsgQ+KPDjA8cSLdNaTnmw0NStfRqqXCvzxcwHc/5VHclsgWJl474mbNB Lf1RzqWTIYyHhPWBsU/To4f0s72ARajKXuBWVIt4JSZxvpQpz/J3R8RRI 0jWBrIvlRbNpO0DZ3DHSzsxSuzEmfSnBpoJKDfb+0OLY2v/g2a/x32MAh w2CCE0b3ZP37ybzB/ImenGBIterj7jTIhh7VKIV9P8tCTqp+0i31yMkLz A==; X-IronPort-AV: E=McAfee;i="6600,9927,10657"; a="323305282" X-IronPort-AV: E=Sophos;i="5.98,283,1673942400"; d="scan'208";a="323305282" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Mar 2023 04:12:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10657"; a="632357548" X-IronPort-AV: E=Sophos;i="5.98,283,1673942400"; d="scan'208";a="632357548" Received: from lkp-server01.sh.intel.com (HELO b613635ddfff) ([10.239.97.150]) by orsmga003.jf.intel.com with ESMTP; 23 Mar 2023 04:12:23 -0700 Received: from kbuild by b613635ddfff with local (Exim 4.96) (envelope-from ) id 1pfIrm-000EH8-27; Thu, 23 Mar 2023 11:12:22 +0000 Date: Thu, 23 Mar 2023 19:12:01 +0800 From: kernel test robot To: Zi Yan Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, Andrew Morton , Linux Memory Management List Subject: drivers/virtio/virtio_balloon.c:40:44: warning: left shift count is negative Message-ID: <202303231958.9lByNCPW-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Stat-Signature: 9wgrojuzhrsr6ss4ex1edqgg6q14km17 X-Rspam-User: X-Rspamd-Queue-Id: 7EF991A0017 X-Rspamd-Server: rspam06 X-HE-Tag: 1679569946-664836 X-HE-Meta: U2FsdGVkX1+k+LkaIWh4qv2AAsfxVOdqvN1rHmrpdVgFM02OvY78pN0sugqtJupCnKEM8FapR7mpDIU3k2Zkwm04ZwsWrvEwcwPH3wNPKuY0VzQgrtieeVr2+4D9c+Ea78X7NfYXDW3vsK+n35TTSHUR35ushbFc+Yt+Ox+bPwx/W2h2C8gHFzUQ4RaP4a2sUUjoAG8I/VJw2M+rfuUCErhlibN4fJNplHuI+Cnw/mXE3WRwHufwq/yr0h5pD5xZYzOnooUMZePEIRMwzPhXnQzc8n9+2C+DgyUyf0qRb6HUXQgeCrR07eXocJQV1ePt0572LtI5D8L/Qg3qwKEBfd6HIwGL38RG5tWFqWciaULd9VfzVezwsBYCAFq6GvVbpblRxCoDcB0XSF4flCcrv7NFeA9FauGoDd4DY4UgiVTvS9EtyDhy9x2dPxNvFLrO+8PCUGhgLlvrSXNNy/HdxSuTr7h06PjCJ2pxpWfBTV5ZNRwzrlOc6fRbcoQIXxOQ1wm08Ap84jDeTPoZGv4CcsDuqXsEHHSbNRQKDn53D7RIRGgxWo+I01sJDkkCsGCpVKl/xp3Wyhf8MRlt9OguTts/ZXJmv6whFI25+fWFaL+GCUBAOnTa83+xbQZj8gJLpN0IAQa6sO7o931Fwoj0Eqc/ijh78wY460EZ0+mC52WvrR86RoshZKKLU2U4ueFfzRNCyoY4a2gaIjWqnPBron5b5aW0LQX30dcfM1tYpABRXliV4L7OyVQKiZ1xiydIb0rQ4CLZ/cvQEXIJd4yJI6T25yuljPdJAZbt8z0G9SQ0F3/XJGj4pu0oSO1Bkikz8Znihbjd/iVowS5Cd426CFD1fH6uSN5qEgHNoCoj99KRAEM2tNG8GtKR0uBV9ZuU/ozmXRQC8gB3D2PTX0CsKsCqlfv3rjmxJJvtC70Ky2MsDqFX/51G95QT1hd9RDaELKhVbIh2+yH2TIcUi+L fUOrr9rY 45tRakt+0+mho8rv/c/8L89vAOyYMQBS00nkuJzTX0l+82nHvXgieMbHCthPsew3W8zp7rlC2EwIwtP9F4kk3EG3ZXi9wzVCMJElZzySDdBNVp2rFvIWgG/Dgt0ICKglOGeN2R2kzoR1wOQChP0KOonNlCeuMMS5RjxtmJgT+L7QcDbG9SghDJqu3K5D5+vqvhUSoeUlL/PTyxbDLgAtzIHGGh31VaMe1Jzc+l0tpCOsleh+ijQC2v1AcAiXlsbTBh6Jh4+xkdMwk1EemNYvktkMUbZ6pDilD4xkZvvpDXgef4BLCIieV/lkQfZWhyufxgd3CHEjY4niGYaAMzHeT4d3f0dFD5FbzaRHo75k3x6Itn+I8I+ZBjzTMhQs7QQZqDrvSofFqdgASKbEzKtlEub0xYCV+AvSSfzv5xWUPfSucc+d3yKMdQdZy5ICrMn15HCOg2oe6I5RyiOz4fS3gT6aqqwRx7CFQtuV5lI4vm2eNsrE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Zi, FYI, the error/warning was bisected to this commit, please ignore it if it's irrelevant. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: fff5a5e7f528b2ed2c335991399a766c2cf01103 commit: 0192445cb2f7ed1cd7a95a0fc8c7645480baba25 arch: mm: rename FORCE_MAX_ZONEORDER to ARCH_FORCE_MAX_ORDER date: 6 months ago config: sparc-randconfig-r005-20230322 (https://download.01.org/0day-ci/archive/20230323/202303231958.9lByNCPW-lkp@intel.com/config) compiler: sparc-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0192445cb2f7ed1cd7a95a0fc8c7645480baba25 git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git git fetch --no-tags linus master git checkout 0192445cb2f7ed1cd7a95a0fc8c7645480baba25 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sparc olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sparc SHELL=/bin/bash drivers/base/regmap/ drivers/virtio/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot | Link: https://lore.kernel.org/oe-kbuild-all/202303231958.9lByNCPW-lkp@intel.com/ All warnings (new ones prefixed by >>): In file included from include/linux/gfp.h:7, from include/linux/mm.h:7, from include/linux/scatterlist.h:8, from include/linux/virtio.h:7, from drivers/virtio/virtio_balloon.c:9: include/linux/mmzone.h:636:33: error: size of array 'free_area' is negative 636 | struct free_area free_area[MAX_ORDER]; | ^~~~~~~~~ In file included from include/linux/math64.h:6, from include/linux/time64.h:5, from include/linux/restart_block.h:10, from include/linux/thread_info.h:14, from include/asm-generic/preempt.h:5, from ./arch/sparc/include/generated/asm/preempt.h:1, from include/linux/preempt.h:78, from include/linux/spinlock.h:55, from include/linux/mmzone.h:8: drivers/virtio/virtio_balloon.c: In function 'shrink_free_pages': >> drivers/virtio/virtio_balloon.c:40:44: warning: left shift count is negative [-Wshift-count-negative] 40 | #define VIRTIO_BALLOON_HINT_BLOCK_PAGES (1 << VIRTIO_BALLOON_HINT_BLOCK_ORDER) | ^~ include/linux/math.h:15:46: note: in definition of macro '__round_mask' 15 | #define __round_mask(x, y) ((__typeof__(x))((y)-1)) | ^ drivers/virtio/virtio_balloon.c:808:25: note: in expansion of macro 'round_up' 808 | pages_to_free = round_up(pages_to_free, | ^~~~~~~~ drivers/virtio/virtio_balloon.c:809:34: note: in expansion of macro 'VIRTIO_BALLOON_HINT_BLOCK_PAGES' 809 | VIRTIO_BALLOON_HINT_BLOCK_PAGES); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> drivers/virtio/virtio_balloon.c:40:44: warning: left shift count is negative [-Wshift-count-negative] 40 | #define VIRTIO_BALLOON_HINT_BLOCK_PAGES (1 << VIRTIO_BALLOON_HINT_BLOCK_ORDER) | ^~ drivers/virtio/virtio_balloon.c:810:42: note: in expansion of macro 'VIRTIO_BALLOON_HINT_BLOCK_PAGES' 810 | blocks_to_free = pages_to_free / VIRTIO_BALLOON_HINT_BLOCK_PAGES; | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> drivers/virtio/virtio_balloon.c:40:44: warning: left shift count is negative [-Wshift-count-negative] 40 | #define VIRTIO_BALLOON_HINT_BLOCK_PAGES (1 << VIRTIO_BALLOON_HINT_BLOCK_ORDER) | ^~ drivers/virtio/virtio_balloon.c:813:31: note: in expansion of macro 'VIRTIO_BALLOON_HINT_BLOCK_PAGES' 813 | return blocks_freed * VIRTIO_BALLOON_HINT_BLOCK_PAGES; | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/virtio/virtio_balloon.c: In function 'virtio_balloon_shrinker_count': >> drivers/virtio/virtio_balloon.c:40:44: warning: left shift count is negative [-Wshift-count-negative] 40 | #define VIRTIO_BALLOON_HINT_BLOCK_PAGES (1 << VIRTIO_BALLOON_HINT_BLOCK_ORDER) | ^~ drivers/virtio/virtio_balloon.c:831:43: note: in expansion of macro 'VIRTIO_BALLOON_HINT_BLOCK_PAGES' 831 | return vb->num_free_page_blocks * VIRTIO_BALLOON_HINT_BLOCK_PAGES; | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ -- In file included from include/linux/gfp.h:7, from include/linux/slab.h:15, from drivers/base/regmap/regmap-debugfs.c:9: include/linux/mmzone.h:636:33: error: size of array 'free_area' is negative 636 | struct free_area free_area[MAX_ORDER]; | ^~~~~~~~~ drivers/base/regmap/regmap-debugfs.c: In function 'regmap_read_debugfs': >> drivers/base/regmap/regmap-debugfs.c:229:32: warning: left shift count is negative [-Wshift-count-negative] 229 | if (count > (PAGE_SIZE << (MAX_ORDER - 1))) | ^~ drivers/base/regmap/regmap-debugfs.c:230:35: warning: left shift count is negative [-Wshift-count-negative] 230 | count = PAGE_SIZE << (MAX_ORDER - 1); | ^~ drivers/base/regmap/regmap-debugfs.c: In function 'regmap_reg_ranges_read_file': drivers/base/regmap/regmap-debugfs.c:376:32: warning: left shift count is negative [-Wshift-count-negative] 376 | if (count > (PAGE_SIZE << (MAX_ORDER - 1))) | ^~ drivers/base/regmap/regmap-debugfs.c:377:35: warning: left shift count is negative [-Wshift-count-negative] 377 | count = PAGE_SIZE << (MAX_ORDER - 1); | ^~ vim +40 drivers/virtio/virtio_balloon.c 5a10b7dbf904bf Raushaniya Maksudova 2014-11-10 32 86a559787e6f5c Wei Wang 2018-08-27 33 #define VIRTIO_BALLOON_FREE_PAGE_ALLOC_FLAG (__GFP_NORETRY | __GFP_NOWARN | \ 86a559787e6f5c Wei Wang 2018-08-27 34 __GFP_NOMEMALLOC) 86a559787e6f5c Wei Wang 2018-08-27 35 /* The order of free page blocks to report to host */ 2a946fa1c8bc26 Michael S. Tsirkin 2019-11-19 36 #define VIRTIO_BALLOON_HINT_BLOCK_ORDER (MAX_ORDER - 1) 86a559787e6f5c Wei Wang 2018-08-27 37 /* The size of a free page block in bytes */ 2a946fa1c8bc26 Michael S. Tsirkin 2019-11-19 38 #define VIRTIO_BALLOON_HINT_BLOCK_BYTES \ 2a946fa1c8bc26 Michael S. Tsirkin 2019-11-19 39 (1 << (VIRTIO_BALLOON_HINT_BLOCK_ORDER + PAGE_SHIFT)) 63b9b80e9f5b2c Michael S. Tsirkin 2019-11-19 @40 #define VIRTIO_BALLOON_HINT_BLOCK_PAGES (1 << VIRTIO_BALLOON_HINT_BLOCK_ORDER) 86a559787e6f5c Wei Wang 2018-08-27 41 :::::: The code at line 40 was first introduced by commit :::::: 63b9b80e9f5b2c463d98d6e550e0d0e3ace66033 virtio_balloon: divide/multiply instead of shifts :::::: TO: Michael S. Tsirkin :::::: CC: Michael S. Tsirkin -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests