From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B624C6FD1D for ; Thu, 23 Mar 2023 11:14:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B3F2A6B0072; Thu, 23 Mar 2023 07:14:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AEE976B0074; Thu, 23 Mar 2023 07:14:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 98F196B0075; Thu, 23 Mar 2023 07:14:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 88E516B0072 for ; Thu, 23 Mar 2023 07:14:46 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 4E0541A06F2 for ; Thu, 23 Mar 2023 11:14:46 +0000 (UTC) X-FDA: 80599905372.03.1E57270 Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by imf14.hostedemail.com (Postfix) with ESMTP id 7ED08100005 for ; Thu, 23 Mar 2023 11:14:42 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=shutemov.name header.s=fm3 header.b="j 4AZy/s"; dkim=pass header.d=messagingengine.com header.s=fm2 header.b=aGvqLE1X; spf=pass (imf14.hostedemail.com: domain of kirill@shutemov.name designates 64.147.123.24 as permitted sender) smtp.mailfrom=kirill@shutemov.name; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679570082; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8NrkxqYFn1cmxiBC/AP5l36rNX2XShFZCWb/ANhJcJc=; b=t8T1R56zXuiEMeOcaKc/+Pi7KXSZjnhq9vaCYg/nlXaNrA8K5aT3eWEatGozOqLr9NU6+k un5Ga4Kky/CZDmexGeCc5U+UzOhFN1wvOo4ME3/uAbp6kjEbtX/a0rZW48mxJHRdl/SoPI KK3/tmNAuFNmeuI/r2WpNLDt6U59uL8= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=shutemov.name header.s=fm3 header.b="j 4AZy/s"; dkim=pass header.d=messagingengine.com header.s=fm2 header.b=aGvqLE1X; spf=pass (imf14.hostedemail.com: domain of kirill@shutemov.name designates 64.147.123.24 as permitted sender) smtp.mailfrom=kirill@shutemov.name; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679570082; a=rsa-sha256; cv=none; b=qwPEEPiJ8xDEWfdq8k8CQEpTzYke2YVN20Yz95c2msvTC/hGJ/vaxIq8ahlNQtGnU8nsfP 4AgwmopTgRIo5lnv11vp0YqwUN4Dt+wAhdiWdOBY0eG2N4bGxlIEE7HTUB2/YKloQFiZQ0 DowdZsOWbjm0oN9fbz3mPSGtExDCCJ4= Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 10D0632007E8; Thu, 23 Mar 2023 07:14:39 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Thu, 23 Mar 2023 07:14:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov.name; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1679570079; x= 1679656479; bh=8NrkxqYFn1cmxiBC/AP5l36rNX2XShFZCWb/ANhJcJc=; b=j 4AZy/sYpJyS0jeLawRXQBN3nDejIyCKw7+YPvm5sbZXe28DbJttLmt8Dr7MoubPd MczO7OQHmRTIaiDGzuQh7iqE+UxF8MquHJluhxOqxL71ffiR5UUznEo5pcaJjy8R J00fKj165ykVXOtnDKjJ4OYbUJb6wAsicfT0gkziBn6sLf+v6TzlGXWse8eOaT63 15rZVrErpoAAYHBXVkhrXj6esKIxYIdl6ylllc3IxVAXEv94ZhkvWjFmKkNeI/hA gNCG6G61sTOHN+J+PGAV43LdTJv+jjjn+hZkSiU2N12XTMimgP4xmjx4ACQXQKRm jeKGrRxgLLIrsPxLUwzxQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1679570079; x=1679656479; bh=8NrkxqYFn1cmx iBC/AP5l36rNX2XShFZCWb/ANhJcJc=; b=aGvqLE1XiTofOZnLpAYDtlJVNnUPW FOXKv6RWj29TPsPcsymfn2euI76PK51+3ziiuywNbPLFU93pqI3s447whMl7ie+c vpT5RYatyJiwyEO+yEV/o5gkbFS/S8LuKP5U/FIM0EiR0QIgEEnalQKThlDIaelo 7Nf5CeNLvMjFT1/dknBheyT3EtmdccTHco4LIJnPP2cnN6u0cRMQuY7geBhDpYL4 DCAMqhMlQWScYc79sevoX6sb2Q8/yWIPVqrL+lSkSs2Ce92PO2klQzgcH6ay8poW 11sQPQNsMU8Ze7Iu/K405GmuEj4VI4TnP/E8gmdZhP3G5OEe48+oLwYMg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdeggedgvdehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesthdttddttddtvdenucfhrhhomhepfdfmihhr ihhllhcutedrucfuhhhuthgvmhhovhdfuceokhhirhhilhhlsehshhhuthgvmhhovhdrnh grmhgvqeenucggtffrrghtthgvrhhnpefhieeghfdtfeehtdeftdehgfehuddtvdeuheet tddtheejueekjeegueeivdektdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmh epmhgrihhlfhhrohhmpehkihhrihhllhesshhhuhhtvghmohhvrdhnrghmvg X-ME-Proxy: Feedback-ID: ie3994620:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 23 Mar 2023 07:14:38 -0400 (EDT) Received: by box.shutemov.name (Postfix, from userid 1000) id 2230A109FCC; Thu, 23 Mar 2023 14:14:36 +0300 (+03) Date: Thu, 23 Mar 2023 14:14:36 +0300 From: "Kirill A. Shutemov" To: Chaitanya S Prakash Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , "Aneesh Kumar K . V" , "Kirill A . Shutemov" , Shuah Khan , linux-kselftest@vger.kernel.org Subject: Re: [PATCH 0/5] selftests/mm: Implement support for arm64 on va Message-ID: <20230323111436.mj2kbesfxfmvj5by@box.shutemov.name> References: <20230323105243.2807166-1-chaitanyas.prakash@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230323105243.2807166-1-chaitanyas.prakash@arm.com> X-Stat-Signature: 8ze8ocdbo3a4y6sq5hp1ddopzob49r4q X-Rspam-User: X-Rspamd-Queue-Id: 7ED08100005 X-Rspamd-Server: rspam06 X-HE-Tag: 1679570082-247206 X-HE-Meta: U2FsdGVkX18X8pqkEif83AcMmXoJMP1bQa4dspYzUQ1gZ984UzzrtKE6ReCpmw77fzqC6NWAk0EBEbbLfoWbCqaPPfAFIsUEOERTf5OXBoGbCuUpefK4mRtcX6j7KGpvKHYh+SqBuIYpZ0vMCLaXV4lw+NOighH20ltTHbElIlCIZu89j60tzYGHOprolijxcX4cDDyl5XBNeFxKwyZCXxnjXabC33tKQFiFlE/mCCyy8E62Tbq075z8OYG1UfgY5mjKLLnH4NaLOhfHUnAnz+Jl1NeBLAQi9nasBYHvVBxCnLGygjp0JXnwKgLb++oFsxNJaUQb/+Hvxr5A86y8yTkuWJHqv5DbJzabNQz/kdPSPULBoef1x5XVR1lyBu1OjREIIm4Wd31zOs2Iv3Kbgc65bpy8WUmbXefaqdzmzXs8zUubGmC5HFofZGtFdU7GqsllKtGZXmPxfvPWeTSdKzmlUPR8XnX7SSXU8vuOoPlVTVoD9qp0MD/8gNWP3XBYKnkICoSeIyQqnRQ4N+rziflDkyp8QBnbNi5NNTJ91pvDUqFdVON1adqIdVomzqt4Xz5+Mi1c2Q/+q5CsHHrMCfD8Fww9ghk4bcQ8JgvrP6URFODGwjxkZKGsPuG3yQjB77n5xoHsGfmTtqif2NLhFN1ZmicAHwMAr3hapnEOp5CY35pQHFleaQZo5eUFh/4bCu9N5Z4FqXy/9+f+8WD3p8ki8Srx94NaTViG4KzJRkauwWqtNw2dM1tuLdO3xtutMXgtGqfBEiqQy5kg8QN0S3VGVhjlU2r0+OZfqtMwntxed8r/js8ynGJu7ednCen9To+as/skl7VJ4vl4HkHx2uKj2tOPhSllKzsKZOWtn+Z9IVxHh/yOWT7ySafTHMXsBb0vVeIpVHrj2b36KhLp5SLKqI7E3D95hzOkpsNmDoLrEDZguC3URUKQmUr0h7TbldWua6aX59D2HOFywON 6+UQOIt2 1jCJpJEcfbedzjlmy8HxJ+Ett1UAOM93e4HPSPjrTAyOvwskF/tou8iCPvYF0XnpObaJgopC+eud6X61cLXCglP7wY6Ej6U4cI39SfyRpZJfQbhCn0yGu+x/RazzYK7bfaDZk0oLOnq9wmksnNxpKjYKtBtb9qjngbYSlaAEcnoLvxTxGnlznpSZYeK7POsMa7jevATJw29lzulhh5b7aNwg3nb1LhFRtNbP1X7GnzZW4VF5BTU5nQWRNzgsErew9eB5AzwWu9Zh7S23dKqbosiNGQJ+ORKKEqZ4cheJHVLS5EjSR3XkS/LgByoyOkn3sxd9GFVxOoFr7/swV1rtTbRirxbs44qNRdURJ5glzc0SO7GMEQcY/86uK9mI8gH8yLsrqzQslbWjnlA739Wof3KCosN+a2q2jKF1qKok2OqhYiCpmKeLTCnJMXM0t6h9LVPfcSwTckl5zIOROiIHHGn6rKi4CLyaOeXPw0q7m7xM4dow/WwIRpxFW1u1V2QJ696tIcuS+hTS6Ypw1B2DhOXpqvctQGDBppLY1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 23, 2023 at 04:22:38PM +0530, Chaitanya S Prakash wrote: > The va_128TBswitch selftest is designed and implemented for PowerPC and > x86 architectures which support a 128TB switch, up to 256TB of virtual > address space and hugepage sizes of 16MB and 2MB respectively. Arm64 > platforms on the other hand support a 256Tb switch, up to 4PB of virtual > address space and a default hugepage size of 512MB when 64k pagesize is > enabled. > > These architectural differences require introducing support for arm64 > platforms, after which a more generic naming convention is suggested. > The in code comments are amended to provide a more platform independent > explanation of the working of the code and nr_hugepages are configured > as required. Finally, the file running the testcase is modified in order > to prevent skipping of hugetlb testcases of va_high_addr_switch. > > This series has been tested on 6.3.0-rc3 kernel, both on arm64 and x86 > platforms. > > Cc: Andrew Morton > Cc: Aneesh Kumar K.V > Cc: Kirill A. Shutemov > Cc: Shuah Khan > Cc: linux-mm@kvack.org > Cc: linux-kselftest@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > > Chaitanya S Prakash (5): > selftests/mm: Add support for arm64 platform on va switch > selftests/mm: Rename va_128TBswitch to va_high_addr_switch > selftests/mm: Add platform independent in code comments > selftests/mm: Configure nr_hugepages for arm64 > selftests/mm: Run hugetlb testcases of va switch > > tools/testing/selftests/mm/Makefile | 4 +- > tools/testing/selftests/mm/run_vmtests.sh | 12 +++++- > ...va_128TBswitch.c => va_high_addr_switch.c} | 41 +++++++++++++++---- > ..._128TBswitch.sh => va_high_addr_switch.sh} | 6 ++- > 4 files changed, 49 insertions(+), 14 deletions(-) > rename tools/testing/selftests/mm/{va_128TBswitch.c => va_high_addr_switch.c} (86%) > rename tools/testing/selftests/mm/{va_128TBswitch.sh => va_high_addr_switch.sh} (89%) The patchset looks sane to me, but I have question: why arm64 has switch on 256TB. The reason we have the switch is to keep system backward compatible. Maybe it is better to make arm64 switch also on 128TB to make it compatible across architectures? -- Kiryl Shutsemau / Kirill A. Shutemov