From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50B47C6FD1D for ; Thu, 23 Mar 2023 10:53:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E5ADE6B007D; Thu, 23 Mar 2023 06:53:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DE4846B007E; Thu, 23 Mar 2023 06:53:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C85F66B0081; Thu, 23 Mar 2023 06:53:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B59E56B007D for ; Thu, 23 Mar 2023 06:53:07 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 872731606C0 for ; Thu, 23 Mar 2023 10:53:07 +0000 (UTC) X-FDA: 80599850814.21.86E9C13 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf12.hostedemail.com (Postfix) with ESMTP id DD91B4000A for ; Thu, 23 Mar 2023 10:53:05 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=none; spf=pass (imf12.hostedemail.com: domain of chaitanyas.prakash@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=chaitanyas.prakash@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679568786; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rkM65a3p31VcVjnzU8Rhd5s6D5VVzRAh4QYqKH3DFl8=; b=eFz7Tggyp+jpVAHIquAav4p1bABrgAL8fEDRkbnL1rH1lI52hrfEmuqY26sgVWknrC/r9o jxGzbcWm6DNeCWcY1QSA+XFLrMxjn5JAXXf2wE7QnOepOoLV5ppg24KQrz5bA3O0fqHD8b 92wbH6aWpiqn1yuimpu5UWsZ3OSX0RM= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=none; spf=pass (imf12.hostedemail.com: domain of chaitanyas.prakash@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=chaitanyas.prakash@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679568786; a=rsa-sha256; cv=none; b=CGBXc/VTv/6RPWZoUUfpWHXSNUYXbB1CRwsyxFExzOHbrp292mlKsmzZ9yorquFIsh5j0a bD0F2yXJbq2EqLqrhflskAzDrUb9n1gD90zJ9I2BzjjzrwCtSdJa0uhHkl16Mb6o/rwNYk LJw9JShvR2Tl3TCnrST0XhqLtIgqf50= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 176A94B3; Thu, 23 Mar 2023 03:53:49 -0700 (PDT) Received: from a077209.blr.arm.com (a077209.arm.com [10.162.40.145]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 8756B3F766; Thu, 23 Mar 2023 03:53:02 -0700 (PDT) From: Chaitanya S Prakash To: linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Chaitanya S Prakash , Andrew Morton , "Aneesh Kumar K . V" , "Kirill A . Shutemov" , Shuah Khan , linux-kselftest@vger.kernel.org Subject: [PATCH 3/5] selftests/mm: Add platform independent in code comments Date: Thu, 23 Mar 2023 16:22:41 +0530 Message-Id: <20230323105243.2807166-4-chaitanyas.prakash@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230323105243.2807166-1-chaitanyas.prakash@arm.com> References: <20230323105243.2807166-1-chaitanyas.prakash@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Stat-Signature: 7stt4rkufo5y3wh1cq4wx9erxbngtqdw X-Rspam-User: X-Rspamd-Queue-Id: DD91B4000A X-Rspamd-Server: rspam06 X-HE-Tag: 1679568785-853833 X-HE-Meta: U2FsdGVkX1+Eb1DC4rhGw2kgGBlYeg8enUULYkdy6UUr9PObVeLSokD50eSflsgHw5TKoYgUsDrvC/CY4FAA4wlqxx24ZCnd/AgLNTY7lU6wrgkllrjJPNRbm0k9T1oaeRdgJzVWGmhPWyeu7ugyUg4mLO+7ftrcKFG5++7cXacyf1dDvQ4UdCJPyNImDNgTXGfjKEhGIGAqLnkQTn7JynLm9EA2R+KwyJjAUpv/HbZQIYiI51+2Pe6yC1Y12Dkrb26toasFjxr2bGBfQ0enkeEs+AkQxZkpYVbniC2WtGzXmOVWb4yqqOQuPLKP9WM14NofoQVIoXPDw5VB9qEc40SgbEVOzaRZo6AfDZTM3+ggclMuiJ4Ht1Mc1rPuAltCdEiKKQfzQTTqpN0IHcajYzJJEyQQbNsdl1qp/w/18tsL0aKFZBS040ut3tigprmFF6WoTSTk/OZqDFGpeegt5NXV3RCHi5kFvK3XRTDtUMfwcJlVNwjtqMR5w0yoVzl/gic2f19e49GhOgzeHwEgtrly+8yOOkjLT4iZvdCFOjTZWe1t2TK5jfm+filEGSgSt/tjLpaVCfx66fyAAOA2evf/RwLEbo4rv4s3jIBKQWYlrwJ7IjQrrhX1TzR/nLg6FbqGBgm3ScIZbX+VqvAP6d5W9+Qp+bqoCXMyeQ/z+FQYpx34OeLDNXkq3fQuOQplCoFh4EhYZkE4nMeKK7AaU/hmmZiQddSYP6nHgnNwMqoQJ8SwFyxuM+ZICez/9XuQwj0xgTGaPhMFHAPFOD0ybDPebGhKwmNid7kxPC2/nOScz5FXt8C7jul+jAOkHe/tDxJX7rAOG8xTG04DAWLExeAWomUP6+MgAlAYB/gRoXk6c+eCOMAEGG3pS9T2MecKieVFP92wAIdRSgGRGrU5xBYXpzM2aXIFyzKtlOKloihmqqrRXsHxzpCZa6vQQSrj0ysQ56hJOhayko/I9or Nfl7BEpO tXdRbSJcPEni2aGLxpud4MuY9SL90LFhr4a+M2WeKN0sddgZYLlH3XeDXUDb3S6FBgDG6yWt7tg7HYMtOA3OzQ+aljbfpOrqAPOmvUPC+VdmWdvkP0f2LPLDnVjbnushq99+Guziqk7DSnq4dTfd9QbPFn610AGkxr6gH+j08/DhQ1Tl/p05UIphp4b2WQP8x8MLCienQxXT0Rr9849S2kTMaMLU1X3gOx3KcawVRkNsrVupDqHqrG3WC8p+EOl4sgWqcIlMnukinHLYpb3WyA83wfHco6IqwGTHSSkq5ZmpMv/atn650gwlgdpnpWOKITimb7Im68B9NL2EIoOYaYTalx+ZE5LNOnPag6E8/pmnxjx3SE28zk/NivTgbpzqGhJxNVZLECvb6wD8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The in code comments for the selftest were made on the basis of 128TB switch, an architecture feature specific to PowerPc and x86 platforms. Keeping in mind the support added for arm64 platforms which implements a 256TB switch, a more generic explanation has been provided. Cc: Andrew Morton Cc: Aneesh Kumar K.V Cc: Kirill A. Shutemov Cc: Shuah Khan Cc: linux-mm@kvack.org Cc: linux-kselftest@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Chaitanya S Prakash --- tools/testing/selftests/mm/va_high_addr_switch.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/tools/testing/selftests/mm/va_high_addr_switch.c b/tools/testing/selftests/mm/va_high_addr_switch.c index 6679213effed..7cfaf4a74c57 100644 --- a/tools/testing/selftests/mm/va_high_addr_switch.c +++ b/tools/testing/selftests/mm/va_high_addr_switch.c @@ -30,8 +30,8 @@ #endif /* - * >= 128TB is the hint addr value we used to select - * large address space. + * The hint addr value is used to allocate addresses + * beyond the high address switch boundary. */ #define ADDR_MARK_128TB (1UL << 47) @@ -73,9 +73,10 @@ static struct testcase testcases[] = { }, { /* - * We should never allocate at the requested address or above it - * The len cross the 128TB boundary. Without MAP_FIXED - * we will always search in the lower address space. + * Unless MAP_FIXED is specified, allocation based on hint + * addr is never at requested address or above it, which is + * beyond high address switch boundary in this case. Instead, + * a suitable allocation is found in lower address space. */ .addr = ((void *)(ADDR_SWITCH_HINT - PAGE_SIZE)), .size = 2 * PAGE_SIZE, @@ -85,8 +86,8 @@ static struct testcase testcases[] = { }, { /* - * Exact mapping at 128TB, the area is free we should get that - * even without MAP_FIXED. + * Exact mapping at high address switch boundary, should + * be obtained even without MAP_FIXED as area is free. */ .addr = ((void *)(ADDR_SWITCH_HINT)), .size = PAGE_SIZE, -- 2.30.2