* [PATCH] loongarch: drop ranges for definition of ARCH_FORCE_MAX_ORDER
@ 2023-03-22 8:17 Mike Rapoport
2023-03-22 10:03 ` Kirill A. Shutemov
2023-03-22 17:14 ` David Hildenbrand
0 siblings, 2 replies; 3+ messages in thread
From: Mike Rapoport @ 2023-03-22 8:17 UTC (permalink / raw)
To: Huacai Chen, WANG Xuerui
Cc: Andrew Morton, Kirill A. Shutemov, Kirill A. Shutemov,
Mike Rapoport, linux-kernel, linux-mm, linux-mips
From: "Mike Rapoport (IBM)" <rppt@kernel.org>
LoongArch defines insane ranges for ARCH_FORCE_MAX_ORDER allowing
MAX_ORDER up to 63, which implies maximal contiguous allocation size of
2^63 pages.
Drop bogus definitions of ranges for ARCH_FORCE_MAX_ORDER and leave it a
simple integer with sensible defaults.
Users that *really* need to change the value of ARCH_FORCE_MAX_ORDER
will be able to do so but they won't be mislead by the bogus ranges.
Signed-off-by: Mike Rapoport (IBM) <rppt@kernel.org>
---
This applies to akpm/mm-unstable tree
arch/loongarch/Kconfig | 3 ---
1 file changed, 3 deletions(-)
diff --git a/arch/loongarch/Kconfig b/arch/loongarch/Kconfig
index 272a3a12c98d..e1e3a3828962 100644
--- a/arch/loongarch/Kconfig
+++ b/arch/loongarch/Kconfig
@@ -420,11 +420,8 @@ config NODES_SHIFT
config ARCH_FORCE_MAX_ORDER
int "Maximum zone order"
- range 13 63 if PAGE_SIZE_64KB
default "13" if PAGE_SIZE_64KB
- range 11 63 if PAGE_SIZE_16KB
default "11" if PAGE_SIZE_16KB
- range 10 63
default "10"
help
The kernel memory allocator divides physically contiguous memory
--
2.35.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] loongarch: drop ranges for definition of ARCH_FORCE_MAX_ORDER
2023-03-22 8:17 [PATCH] loongarch: drop ranges for definition of ARCH_FORCE_MAX_ORDER Mike Rapoport
@ 2023-03-22 10:03 ` Kirill A. Shutemov
2023-03-22 17:14 ` David Hildenbrand
1 sibling, 0 replies; 3+ messages in thread
From: Kirill A. Shutemov @ 2023-03-22 10:03 UTC (permalink / raw)
To: Mike Rapoport
Cc: Huacai Chen, WANG Xuerui, Andrew Morton, Kirill A. Shutemov,
linux-kernel, linux-mm, linux-mips
On Wed, Mar 22, 2023 at 10:17:27AM +0200, Mike Rapoport wrote:
> From: "Mike Rapoport (IBM)" <rppt@kernel.org>
>
> LoongArch defines insane ranges for ARCH_FORCE_MAX_ORDER allowing
> MAX_ORDER up to 63, which implies maximal contiguous allocation size of
> 2^63 pages.
>
> Drop bogus definitions of ranges for ARCH_FORCE_MAX_ORDER and leave it a
> simple integer with sensible defaults.
>
> Users that *really* need to change the value of ARCH_FORCE_MAX_ORDER
> will be able to do so but they won't be mislead by the bogus ranges.
>
> Signed-off-by: Mike Rapoport (IBM) <rppt@kernel.org>
Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
--
Kiryl Shutsemau / Kirill A. Shutemov
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] loongarch: drop ranges for definition of ARCH_FORCE_MAX_ORDER
2023-03-22 8:17 [PATCH] loongarch: drop ranges for definition of ARCH_FORCE_MAX_ORDER Mike Rapoport
2023-03-22 10:03 ` Kirill A. Shutemov
@ 2023-03-22 17:14 ` David Hildenbrand
1 sibling, 0 replies; 3+ messages in thread
From: David Hildenbrand @ 2023-03-22 17:14 UTC (permalink / raw)
To: Mike Rapoport, Huacai Chen, WANG Xuerui
Cc: Andrew Morton, Kirill A. Shutemov, Kirill A. Shutemov,
linux-kernel, linux-mm, linux-mips
On 22.03.23 09:17, Mike Rapoport wrote:
> From: "Mike Rapoport (IBM)" <rppt@kernel.org>
>
> LoongArch defines insane ranges for ARCH_FORCE_MAX_ORDER allowing
> MAX_ORDER up to 63, which implies maximal contiguous allocation size of
> 2^63 pages.
>
> Drop bogus definitions of ranges for ARCH_FORCE_MAX_ORDER and leave it a
> simple integer with sensible defaults.
>
> Users that *really* need to change the value of ARCH_FORCE_MAX_ORDER
> will be able to do so but they won't be mislead by the bogus ranges.
>
> Signed-off-by: Mike Rapoport (IBM) <rppt@kernel.org>
> ---
>
> This applies to akpm/mm-unstable tree
>
> arch/loongarch/Kconfig | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/arch/loongarch/Kconfig b/arch/loongarch/Kconfig
> index 272a3a12c98d..e1e3a3828962 100644
> --- a/arch/loongarch/Kconfig
> +++ b/arch/loongarch/Kconfig
> @@ -420,11 +420,8 @@ config NODES_SHIFT
>
> config ARCH_FORCE_MAX_ORDER
> int "Maximum zone order"
> - range 13 63 if PAGE_SIZE_64KB
> default "13" if PAGE_SIZE_64KB
> - range 11 63 if PAGE_SIZE_16KB
> default "11" if PAGE_SIZE_16KB
> - range 10 63
> default "10"
> help
> The kernel memory allocator divides physically contiguous memory
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-03-22 17:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-22 8:17 [PATCH] loongarch: drop ranges for definition of ARCH_FORCE_MAX_ORDER Mike Rapoport
2023-03-22 10:03 ` Kirill A. Shutemov
2023-03-22 17:14 ` David Hildenbrand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox