From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D872C6FD1F for ; Wed, 22 Mar 2023 09:00:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E51746B0075; Wed, 22 Mar 2023 05:00:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DDC7D6B0078; Wed, 22 Mar 2023 05:00:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CA33D6B007B; Wed, 22 Mar 2023 05:00:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id BB1FC6B0075 for ; Wed, 22 Mar 2023 05:00:14 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 91DD8C039F for ; Wed, 22 Mar 2023 09:00:14 +0000 (UTC) X-FDA: 80595937548.02.59534EE Received: from elvis.franken.de (elvis.franken.de [193.175.24.41]) by imf19.hostedemail.com (Postfix) with ESMTP id 8D4A11A000E for ; Wed, 22 Mar 2023 09:00:11 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=none; spf=pass (imf19.hostedemail.com: domain of tsbogend@alpha.franken.de designates 193.175.24.41 as permitted sender) smtp.mailfrom=tsbogend@alpha.franken.de; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679475613; a=rsa-sha256; cv=none; b=1sGrDcl7ejHfl/dAmZNi8jIRzvroRC6JK8jybKvnEz6Wsivax8VnVZ4lp73UyceqlO/3hz OVZwsl+q96goUQP17MEEs/6XmXvh5xtXQcD5P75t9oEliQ51Hy6UTEL5HiM1JXFr5wGuzG WDq2Z0xFG1faHbkQskF67pcXbLWLmgI= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=none; spf=pass (imf19.hostedemail.com: domain of tsbogend@alpha.franken.de designates 193.175.24.41 as permitted sender) smtp.mailfrom=tsbogend@alpha.franken.de; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679475613; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yoez+GkpIqIne9UpwkUe2KjsMKBDPoyQBYMjl8pDQRA=; b=exS+wjS2orUrSzSfaBAnwYidTD29IoSxjZvj8yZ2Pi51diD13WN3zZDcZB6NDyJrjFrefO CoN+oGh1dNtaQTWcaXWNSN42wbMu9Z9vhZhwaCv7FB1S7rE1W8qFB2Aadk1pQOCPihQcPw Giys7COybWUkqDoyHfc+aUnG4tc4LL8= Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1peuKE-0004ZM-00; Wed, 22 Mar 2023 10:00:06 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id 540DCC1B28; Wed, 22 Mar 2023 09:59:53 +0100 (CET) Date: Wed, 22 Mar 2023 09:59:53 +0100 From: Thomas Bogendoerfer To: Mike Rapoport Cc: Andrew Morton , Huacai Chen , "Kirill A. Shutemov" , "Kirill A. Shutemov" , WANG Xuerui , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-mips@vger.kernel.org Subject: Re: [PATCH] mips: drop ranges for definition of ARCH_FORCE_MAX_ORDER Message-ID: <20230322085953.GA3910@alpha.franken.de> References: <20230322081520.2516226-1-rppt@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230322081520.2516226-1-rppt@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspam-User: X-Rspamd-Queue-Id: 8D4A11A000E X-Rspamd-Server: rspam01 X-Stat-Signature: 46fn4ac5tdzhtuqs6tsdgy38k7mnd3dq X-HE-Tag: 1679475611-542309 X-HE-Meta: U2FsdGVkX1/re40On2ko8l7UQ9Q3MrxU81wRHt6nWBOXwp/l9bmWu4RMkkE7XEGkBq8FIk2BjetZKJC8iTjXJux+kp0l6Fgo3ArVwY8HS09pjwbbtgYdnbE/PP8GnkKw9fvLw16RFsAAilLDjdhlJn5SQJCpiHmGbsNQr6cB69gJp7JemkbTJxzT4j2VQobsFcyGQDVXqNiUcGsJLzHPBqa9HrQRx/Xq5oxZ5O/1sL/lUV1Ze6pOIm7776sT71kMjINwlFpSOiJ2p9CoNNTIn/N7bRt0DfmZspZGt2b76WWATlVVB3ZXk8f3klfzwjWhWal8UhJ3oMfeGUHksqo0gxSoPhgvIfySX5+XrzOGBGcf6DokHJWLDLP0dyCMWOy7oO81bPwV02763QsCTC1F0PyvyWLMyVo3Zlbz4gcgDDEo7jMM43BRORLhQCUCchHtL5fb+J7rImUjXevMq9nm7QJBGMUpmUnpqKV54sp4uGLREkAoMs2UVgwpc7LN4ePw50MN/9+Xb3IlZ54tCQZSbrA+uIj0bfz2PHs++99zPAU3iZBdX6ZcMsH3bwCWdwtjrE7yaygEO82ktDrSIGE1duNxr43GeNE5PbIeV1BO/LjeXvbxDIeeuuObrbJMOrlpGpzBRvs6+c2eOnJMPsXtAgzr8u9zibo+B5mdQpKKqteKSLouAb2upUJvydBg1IHvY5pUoMKEAVWodWK++C7X3gGby16dnNGWN5GbltyZIBbgGb4C4V75F1AfmYCYEv7ZP1BPqDcjp8iF21GuEzzL2J53HtsxF5HTYfYsNx0WElgw1gubdg5mru5R7FfVmfEr6rBQfBFpSqUnaoZ6iaIcmVMxLUFmO0YHzTaxGVWaKyh51hL4UiHOSf13o96yd5zNTkAjG8PUYjZm3Lm+64/Y3npzGkZGKVVJK6KJOpN34Ci4p4vxUskwzo5op5EanlbeP4saHc5HMX6J9lchWpU kglTvSLt 6uueh6U3+ig1CGgfzCjmSToIAIZ288hqV2euaN2Ugj/EK7g3q0Dpic9d8QQU17USwovwWr2Iz0Ndaex1/pOWRMyvkHmT2r1/X79WTtjPfE0MRDr4L3UGW6tzZwRbsdCTnNMmtuoBT9942SatfQDPAs9TVzw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 22, 2023 at 10:15:20AM +0200, Mike Rapoport wrote: > From: "Mike Rapoport (IBM)" > > MIPS defines insane ranges for ARCH_FORCE_MAX_ORDER allowing MAX_ORDER > up to 63, which implies maximal contiguous allocation size of 2^63 > pages. > > Drop bogus definitions of ranges for ARCH_FORCE_MAX_ORDER and leave it a > simple integer with sensible defaults. > > Users that *really* need to change the value of ARCH_FORCE_MAX_ORDER > will be able to do so but they won't be mislead by the bogus ranges. > > Signed-off-by: Mike Rapoport (IBM) > --- > arch/mips/Kconfig | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig > index 3e8b765b8c7b..a0f6e9d0a561 100644 > --- a/arch/mips/Kconfig > +++ b/arch/mips/Kconfig > @@ -2137,13 +2137,9 @@ endchoice > > config ARCH_FORCE_MAX_ORDER > int "Maximum zone order" > - range 13 63 if MIPS_HUGE_TLB_SUPPORT && PAGE_SIZE_64KB > default "13" if MIPS_HUGE_TLB_SUPPORT && PAGE_SIZE_64KB > - range 12 63 if MIPS_HUGE_TLB_SUPPORT && PAGE_SIZE_32KB > default "12" if MIPS_HUGE_TLB_SUPPORT && PAGE_SIZE_32KB > - range 11 63 if MIPS_HUGE_TLB_SUPPORT && PAGE_SIZE_16KB > default "11" if MIPS_HUGE_TLB_SUPPORT && PAGE_SIZE_16KB > - range 0 63 > default "10" > help > The kernel memory allocator divides physically contiguous memory > -- > 2.35.1 Thank you for cleaning this up. Acked-by: Thomas Bogendoerfer -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]