From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAD3CC6FD1D for ; Tue, 21 Mar 2023 17:19:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4E8866B0074; Tue, 21 Mar 2023 13:19:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 497AD280002; Tue, 21 Mar 2023 13:19:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 387D0280001; Tue, 21 Mar 2023 13:19:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 289266B0074 for ; Tue, 21 Mar 2023 13:19:49 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id D6C44140261 for ; Tue, 21 Mar 2023 17:19:48 +0000 (UTC) X-FDA: 80593567656.20.C3BEFF7 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf02.hostedemail.com (Postfix) with ESMTP id 03EFB8001E for ; Tue, 21 Mar 2023 17:19:45 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=MD4O3cmB; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf02.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679419186; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iE+uld/+/1m8xLRTjaGBOsZqaFpmmcXuZ/YTdljtcL0=; b=3t1IdtGwm3aB59rlEowFNWRSANy4Sf6XO18qc1NHtuWv0eftU/G5WTxOVi8iimx6p7Z6FV fpLokCHaoEd6NWikvyMioIjen4cNNLH+6HXTKtiT9hcUFJsZIZTvJLQZitrEP1q6pO0uBj LC37b6f0QR9pZfXpsKeeDp/jBlPaJpc= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=MD4O3cmB; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf02.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679419186; a=rsa-sha256; cv=none; b=z7vxgpkjdVcTDCd09dPTnol8PoiLlX4x4XIJ4+SUpdHh9IP21WprJByWIWN19jwA2jC24k PWPDzpwGBlgMDye/wSfXIwUonWMiV4bXjl3WcmvxZ1R26SmJg8luNEnT/bneAl/ujPvyIn oKR7TsyyjsHoxohBuzgGvyBnTck+61E= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0FBA361D3B; Tue, 21 Mar 2023 17:19:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2BFA4C433EF; Tue, 21 Mar 2023 17:19:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679419184; bh=hvCgy/WFbjzmT9vviDRBBlhBz4fmojTYN1wTRwP7718=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MD4O3cmB+4/VQSR4jsZRfpRnQ01PJaSVnBusj8iA0wDmo6q8V6Ezagi2Tdswxx8Go ag1n6nLYEaqJAkFggk5PVwTM0lXuuaZ/eCXN3RyEtCPzTniWlHR2Ld7UcFDiN3PwA3 lLC4pbjHvGSbore2NRYLxSlk/y6hSp3qKsAm3dJ7ExU+TAU4j2OeB74n+fgAGSG0Yf Ub39gNk+ANNdrzzwsDIrIRvQSzEcWCG2nMX0nicBcCBzJm3ZzH/iTDFTxhaYbx8mlj vigTT7r6rsC34g0GSFZS2NncXbFA/MtAMaQEYZImmKfUSwMhftl0MjXlZdXMuX6DSZ w8ICsPBqFoLcA== Date: Tue, 21 Mar 2023 18:19:38 +0100 From: Christian Brauner To: Luis Chamberlain Cc: Yangtao Li , Alexander Viro , Andrew Morton , Kees Cook , Iurii Zaikin , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] fs/drop_caches: move drop_caches sysctls into its own file Message-ID: <20230321171938.z5seopfethaworsm@wittgenstein> References: <20230321130908.6972-1-frank.li@vivo.com> <20230321142836.l6pymt4ygg2qhfvn@wittgenstein> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 03EFB8001E X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: zn3jirpf9eno1jjanjkzu8a5iyjt4s4c X-HE-Tag: 1679419185-685534 X-HE-Meta: U2FsdGVkX1+EYJwcXOpC7EQppFpeb0AYHbDgUy9Ve50gKatD12xFtEBC8j4NBv0WyWY1xvMZLpJrBO0jval4P3RgHIDkwLpHP/Vw8E74kIYBerN2Zv2D6RyHRs1dl4qvRqpFwKWCfSKK60yUG82yLyE1I2Swh+l1XAoqeMIdTaF+hfpQqzh7y39dMyu5UXG/FgHoTfN61TDe71Z38SP2ThJB825fmPZYaiA4OWM8iMfLBmvp8naj+A13zFjxHJU/RpBtI+Gw7ut2tvXnTnutRNQkZkZQHIYiXNhztbdiYr2Zb1QCXHSKVf+m6sWTDgqszEeoI2fyzfLzNQlXQ5EGEgbevAEEOAWfdvNdS6xPeSVpVzB6DhAIaWvVyvzqDhVpZC5BKKCHU/i+JkzsjPYPAnirK2ht+sGrrPBTXe321IApe2TfqhfWVOSAXVPGnNXYzWspzRG01zPLiWu6QgjHb7UsTm4tutWMvGyZAEjbhaiXKqg9nWIUkIevq9v9UqZsrhXEZ80abWnIHwcgrAcNUm/RcKfTworwkiI6/6ZBD0KCRSMNBO1tkzbvVzwD0Vl4Rh6lWGcMQYoOp1VkwC9HzGQU/177byDa0IFMNRiWGIQ8degGksyMcqU/hp9+CeYWI9euXkkKjKHEoeE4qyZQ2KVhq+wcNTvYDHOfTIJyie0CIXHwPIZgasynXMlpu4Y0mCpWJ9JmRdGPUDzIUslymmecb5AlhOd9IsnDxSx8j4IpKUxzfhJQBB7ci2wcC7SgQsm+M7hYcWzmv4QXnNZ0f7Mt2ZVMWIWlzuGeWYYJ+zT2P+gMAc0UtGG+8/jmohWlusRxAn12gUPDjuAsfq6Nw9WUmR0iacvdV7hooiCeot/kkCmVq2Cxv+RwPX74EDIBJoguYs1AjCCgSaT/gm3K3KILVv1cMlpaEeyik0ACsHJyuolGTY5w77DjME1g9ToQqGPuy63RFJk0xgnew4M XKWjgny5 iGMZH2OmXjTOJ/aIwf7gsmWdMwKBE+Qs4FTuqKE2SP6Fjs9XE7/97w0suWrt0tmeNmX1yP2NSSlAnDYXuYk69gRvnn/MFHfiux5zaN+6vYmOcaK8lihryUwYcel1HBzC6S0jzpAUWsewx9NEtaqT/4pKtamQC8mxrXWl/MwQSK7GCtjMfyN/1CXvXoz7FR/xo/iHATsjZh0ZbydVaGxbI47F3HpfbTQ9DSgcWtgXWz4Vpw80w3ek+D8U/aS7dEvjr/KExIlIx5cN6ObVnBZT1W7/BZz4O7s82TGSwdIYKusqfeVQ+iXwjC7nF3pZDDowggcvwqBITq4BpQdP4bM0jLDHfZjQCF71vNANBKogABgnX125ATOv/wCO88n4obMOeEUi+MnLVfUGCTzRZjveWQE+dwA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 21, 2023 at 09:39:41AM -0700, Luis Chamberlain wrote: > On Tue, Mar 21, 2023 at 03:28:36PM +0100, Christian Brauner wrote: > > On Tue, Mar 21, 2023 at 09:09:07PM +0800, Yangtao Li wrote: > > > This moves the fs/drop_caches.c respective sysctls to its own file. > > > > > > Signed-off-by: Yangtao Li > > > --- > > > fs/drop_caches.c | 25 ++++++++++++++++++++++--- > > > include/linux/mm.h | 6 ------ > > > kernel/sysctl.c | 9 --------- > > > 3 files changed, 22 insertions(+), 18 deletions(-) > > > > > > diff --git a/fs/drop_caches.c b/fs/drop_caches.c > > > index e619c31b6bd9..3032b83ce6f2 100644 > > > --- a/fs/drop_caches.c > > > +++ b/fs/drop_caches.c > > > @@ -12,8 +12,7 @@ > > > #include > > > #include "internal.h" > > > > > > -/* A global variable is a bit ugly, but it keeps the code simple */ > > > -int sysctl_drop_caches; > > > +static int sysctl_drop_caches; > > > > > > static void drop_pagecache_sb(struct super_block *sb, void *unused) > > > { > > > @@ -47,7 +46,7 @@ static void drop_pagecache_sb(struct super_block *sb, void *unused) > > > iput(toput_inode); > > > } > > > > > > -int drop_caches_sysctl_handler(struct ctl_table *table, int write, > > > +static int drop_caches_sysctl_handler(struct ctl_table *table, int write, > > > void *buffer, size_t *length, loff_t *ppos) > > > { > > > int ret; > > > @@ -75,3 +74,23 @@ int drop_caches_sysctl_handler(struct ctl_table *table, int write, > > > } > > > return 0; > > > } > > > + > > > +static struct ctl_table drop_caches_table[] = { > > > + { > > > + .procname = "drop_caches", > > > + .data = &sysctl_drop_caches, > > > + .maxlen = sizeof(int), > > > + .mode = 0200, > > > + .proc_handler = drop_caches_sysctl_handler, > > > + .extra1 = SYSCTL_ONE, > > > + .extra2 = SYSCTL_FOUR, > > > + }, > > > + {} > > > +}; > > > + > > > +static int __init drop_cache_init(void) > > > +{ > > > + register_sysctl_init("vm", drop_caches_table); > > > > Does this belong under mm/ or fs/? > > To not break old userspace it must be kept under "vm" because the > patch author is moving it from the kernel/sysctl.c table which used > the "vm" table. > > Moving it to "fs" would be a highly functional change which should > require review from maintainers it would not break existing userspace > expecations. No, I was asking whether this belongs under the fs/ or mm/ directory. But I misread the patch. I thought at first, that the patch moved the file from the mm/ to the fs/ directory. But that's obviously not the case... So ignore me.