From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E85FC74A5B for ; Tue, 21 Mar 2023 16:38:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 83A7C6B0074; Tue, 21 Mar 2023 12:38:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7EADD6B0078; Tue, 21 Mar 2023 12:38:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6D95C6B007B; Tue, 21 Mar 2023 12:38:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 5EF1A6B0074 for ; Tue, 21 Mar 2023 12:38:53 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 0321FA0052 for ; Tue, 21 Mar 2023 16:38:52 +0000 (UTC) X-FDA: 80593464546.01.0F68FC3 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf22.hostedemail.com (Postfix) with ESMTP id 14050C0020 for ; Tue, 21 Mar 2023 16:38:50 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=y4le6YzD; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=FpxXnhJv; spf=pass (imf22.hostedemail.com: domain of mgorman@suse.de designates 195.135.220.28 as permitted sender) smtp.mailfrom=mgorman@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679416731; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fiTefNQv6KsfbR0rIRmrOlowqpZ0TrVJ2tfkNhbKTuc=; b=cPQQYgnguiDBuX+ary1HGOUnosX7B/7iXTk2mJVZoHvExziDcoYnONJQ5WbgQtAbHBGKVc p5k5I2Hf7wFSeL33nRbdvKZgN2E3y16854OVuZAkNvwEmnl9/zqDR/HExOMzQ05dYrEmF+ fGgZ3+Gmqeki8eakD5QbDA+3jWIEFok= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=y4le6YzD; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=FpxXnhJv; spf=pass (imf22.hostedemail.com: domain of mgorman@suse.de designates 195.135.220.28 as permitted sender) smtp.mailfrom=mgorman@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679416731; a=rsa-sha256; cv=none; b=soGZ+VW4lzsNvmTIiRxe1+fxvl6mtOpnf2CZ/233+4QQHODSyxMX71Qie5CVQsWamQTscN H0eoYENogiKzmKHoeof03W3/NfzNwJ/IiT1B7qaFH9Q87wy6Uqp98s6ILkCCBNLzS4p0JE ZyeLkre8AO/kaeTqN8z73lwSiFANwuM= Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 72A87221EB; Tue, 21 Mar 2023 16:38:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1679416729; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fiTefNQv6KsfbR0rIRmrOlowqpZ0TrVJ2tfkNhbKTuc=; b=y4le6YzDNKGZE7pDqi0XmbFhx354gB9++3ZENeDvEmXj9uk6SsyvriF60UJC68Ha6pTL10 gnJbfjsdq2N0lU9BmGAuoJuXdw4hZYBV4+yc8O7/EEBI+bd1MeI3beJcTQhEHi/F1ynwty gMKoN4TJhBY1xJYz2qm1CHnpTw1yxJ0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1679416729; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fiTefNQv6KsfbR0rIRmrOlowqpZ0TrVJ2tfkNhbKTuc=; b=FpxXnhJvxNNTJCYST9bbkjxUbzOG0FtybZGvJUmr7v93JA6g/mErZhWTr+fkstfxnETekm TBksnJvwfvPXiFDQ== Received: from suse.de (unknown [10.163.43.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 19E662C141; Tue, 21 Mar 2023 16:38:47 +0000 (UTC) Date: Tue, 21 Mar 2023 16:38:45 +0000 From: Mel Gorman To: "Kirill A. Shutemov" Cc: Andrew Morton , Vlastimil Babka , David Hildenbrand , linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 00/10] Fix confusion around MAX_ORDER Message-ID: <20230321163845.qpybxa5rlwclvko2@suse.de> References: <20230315113133.11326-1-kirill.shutemov@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20230315113133.11326-1-kirill.shutemov@linux.intel.com> X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: td9jdink17m4inxqsizb9iqerwdd73rk X-Rspamd-Queue-Id: 14050C0020 X-HE-Tag: 1679416730-848076 X-HE-Meta: U2FsdGVkX1/2NYNhvMbzOXhmMx0EXzgNR4l+oj8L2ngCiJX1KyTBjmZ42EWMLs9JtvuoX5wwiD1y/oNEccQWm6FGIdyVwqtKY35Gy8cxQgWfd3K7ksXN4Hij1bogeZ9i6P4fFOXfv6P8jlI4/RDyA6ofqSIPW2BPq1A0EtjGkE9uOZXspPn81EdxvfywgpWqc8Jvc+fQn5Q24Eer2gKEvkxCJ1z95v9cZ2EiKdapItJNuPmtMIEM5638pU87wOUI2fiqmQu9yKAyQkmub26MBqRiJjcuL4zsKM5CtBOBy+RDSpQsHOHTki/kU5DqsoPPTzwogsJ73syTeSFwabPYPE9LVh+lG/EWNIMYXAMAbXiBTzdiZKJ+wRku9cb/JuB28Y5ZicszwAANIfdvO/QZJTPSJq33eLIr4hgBShJfy8TSe/QUOaIvqhAE0eADB/p2dCYgDuW6EQPxB0ldJxy2oGLPP/t69LD3J0//6RB4K9yZq5QRIvKYisZ1JrTVHSgb7/F5IrXgEYn6SS9XxjMQECE8orgK1a8UaIGLAbJ3cKSRhdyXspg7Pvifv3MW7fNwcCRfqt22OQLiLjC5CA3+hDJNiYPYHh3bZ1BBKJWzPTAn80azd+AnrPT6GbO8v/RxAmCaMaxECF4I7fM1n0tANjw2mQbfQyUjAldrTpzs4DpTv0Kf4TFvo/QZIEfwkTO/E3oi8eBNptRCuJznsdlIFr9EeXOwTvG2TcH4sfX2NY5LgZtxdEOk9HCSwS5Nl+GeuXJ/64nOFVZd4B5AJ63X40gzKFZ5mmiS7yU7IE0gEweVx0wQmcN1I79xZ/lsmu2T38SoZd8EAyhcC0JEpalEDwrVK/NJhq5V0mLJ4kFvoDnnxFrty4EMnPDS0q5KWhYP3OPm+n2YWaQeEjCHLAIO3GbbiBp4PUjS/UFWwYhmIjqBjxxfPOI75DCVX2sv7q1cS9lCIgXMDAZojbZrJfn kp2XuCDk QAnkUovRQ2GQM8xDVDpSDn7yM2XG9f1zhUNZWHZS95b7U5CUAlBXW8VJbEvjNa1v2etvAnvDtFpq4yI6FN/sYtAIgIxk8GcAF1eKS+mVRv3tDAE/1czWlIm1MX9+css18rNtreYpsJ10p4pCzgAKJe4zs0KYngqxD6H5LUlCnq2rb/PuEgiunPVz9tDaOhsIseRbhOusOWVhDuMyCWfjjXLR0FcakzOfqS/ggtGCcPdf8CaIBv3zZGlqoLw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 15, 2023 at 02:31:23PM +0300, Kirill A. Shutemov wrote: > MAX_ORDER currently defined as number of orders page allocator supports: > user can ask buddy allocator for page order between 0 and MAX_ORDER-1. > > This definition is counter-intuitive and lead to number of bugs all over > the kernel. > > Fix the bugs and then change the definition of MAX_ORDER to be > inclusive: the range of orders user can ask from buddy allocator is > 0..MAX_ORDER now. > Acked-by: Mel Gorman Overall looks sane other than the fixups that need to be added as flagged by LKP. There is a mild risk for stable backports that reference MAX_ORDER but that's the responsibilty of who is doing the backport. There is a mild risk of muscle memory adding off-by-one errors for new code using MAX_ORDER but it's low. -- Mel Gorman SUSE Labs