From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAEA9C6FD1D for ; Tue, 21 Mar 2023 15:56:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0B8E06B0074; Tue, 21 Mar 2023 11:56:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0695C6B0078; Tue, 21 Mar 2023 11:56:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E72EE6B007B; Tue, 21 Mar 2023 11:56:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D88CA6B0074 for ; Tue, 21 Mar 2023 11:56:38 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 8BEF91A01C0 for ; Tue, 21 Mar 2023 15:56:38 +0000 (UTC) X-FDA: 80593358076.26.1276E53 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf29.hostedemail.com (Postfix) with ESMTP id 4E8CE120011 for ; Tue, 21 Mar 2023 15:56:34 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=CnsWLAmS; spf=pass (imf29.hostedemail.com: domain of nathan@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=nathan@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679414196; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pf28QcM9WowRNPCDoivDd05dt0WsNtoYZuCE8QOegnc=; b=zME3+tMX7EUNDGSxklW8WGfw+SWnXaKjQL2gvRL3BRbRI5k4Mrva5EcTyOxv8nLvATlzHX x2Tj65lUhLTjvop9cbCfSY32L5c6OWpQ9v+uQuNad4S1JXBu9ZHnSqiY6vKKf7a+K4Cxgj g1GP9Pmnn/EToXZIWJ6POJ1z6LVz+I0= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=CnsWLAmS; spf=pass (imf29.hostedemail.com: domain of nathan@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=nathan@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679414196; a=rsa-sha256; cv=none; b=1oUrzTO/axKNjLNYDcYR4zPy2S6EO+f4td6SALIPKxwuaV0gfH0OyxSBR8IUrEwjVhSSUt 6mOvtQCBJKrgijRLbvK2HZGIMLZn1wzZVoZ0+MbWFCHmQwq9XU1SA43gIHIfMS69/z/nPO 6+g4zNNFa9uQzm/LoO72VFA+3595/74= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 50E2BCE19E3; Tue, 21 Mar 2023 15:56:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EDF93C433D2; Tue, 21 Mar 2023 15:56:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679414188; bh=sV7yWhm3Wpc6nFVwU3vrMTTk99vkybjn2C9WDkFggrc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CnsWLAmSkFMbR0LuoyYJtoyF1Ta6jksja+T7KULFdiFB9ynKTKthvzoYLX+nehfVl ulZHzYQouqMU/ExfQs6vtclh56CrhDTiIRCJcs7fAarc3n7VxOXGS3I8mT/shIzKg0 yq0jWOhI+5b8jSPxjZYX2J0wgljtW9/4Mzev8/shWrbpItY4PQXewJ69TKl33/UmAU TOTAOmM8YHE7zkHY5cqvsdDJwWZ1iBOY7aphlle7huHcUD0n5azpXCjBDueKiTxnBB Kd36MUA00Hypdw+QXgYbD/nDBL27H6rv6PpbbOh84etN/p7uX5eMgkfBWvMPSFEEK7 1GsL9rzDhj2KA== Date: Tue, 21 Mar 2023 08:56:26 -0700 From: Nathan Chancellor To: Petr Mladek Cc: Luis Chamberlain , Naresh Kamboju , open list , Linux-Next Mailing List , lkft-triage@lists.linaro.org, linux-mm , Andrew Morton , Arnd Bergmann , Anders Roxell , Stephen Rothwell , Steven Rostedt , Naoya Horiguchi , Kefeng Wang Subject: Re: next-20230321: arm64: Unable to handle kernel paging request at virtual address Message-ID: <20230321155626.GA3765079@dev-arch.thelio-3990X> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 4E8CE120011 X-Stat-Signature: q5xzejzwc45xuoq3qqmqkxfcjz5ahtr5 X-Rspam-User: X-HE-Tag: 1679414194-477131 X-HE-Meta: U2FsdGVkX1/EcOHbUfXqJERO9dOFKnGnc85Xo10PHohn5KSK2mpv55NsHGsnfCynY3acZo1OcbvN4WQF+r7m1M7shZ2P0McEWMFuZYUWL/KWepNVIw9BEPEJjuMh9xYrzbmD7HNwbfwLGRSX5VKIaeuUaw1b5WIoTAJXUt1UrVWkvf8OP0mc55x3HPOrY0TRsn3TT9CPk7N7Ac+LYCCUt1g6mcNxxaCkyGG+la5l/PjBrvLH343BqrYz5aizZSGcqxyWnMG3US8rM2qG15k7b2SWDM6EPR7W6e7C6eImKo++cz0CHEaZAY5LwqyIeeBC1RmBvafaNb6az1k8V/b2xiTR7gC77iVjePpVluwCegJOaOWHDxaHdUD5z6+/46IHCiHDj97hggv1XleklwjgWeqvYQuMVo+R/a14Y9ZDCJ5DG9O/TvvNZdTguNsXWSjbDZABF8/Bgfpb/4W9Sz6xFclSsjPQFjBaC+KxYdoQfrEJk0oHEtCT+Zs2n9tnlUSvROCrFc/yFjLLhiNBM6BPtbBvGkGl9SzeAV52YLqmRgWFXEfBtzaDVDtve2sxUzbGjVUe2K4w0WwDv+tbaNZyW1wZjZzW74F8Bkfbf8z8/22K9QM+Ffi+AR3gOGBRIKhupXwU1QXEopxKBJi8osa5Fj1SuYc5TCFjiXAT5A4YHLJqqMpjuWjjTXYtygiHAjCp36RUl3t7VvdX77tMPDjFrLj44mFDrW5rWLUaTFdpxk6UJy18A8MbMMLvBN5KNK1N3Q1zLJZ/15d30Iz+xZyWCDvZAJ0wWTdfHn8w3DaYjiJUN3uvHEYM4Rao2ntJ+XxfC49B+AvD5aHGDK58iY1yHT7RNA0l8UQHxx5ouoHtzyHqfM2FjnrPxS9ppmBXIHOAYFdAuNSjRD0c6nEoTQKK2+UJOf5YDBv0yFyBRG7GtJslvc3QQ7ChAJ3GcXIhHPKBan9I9dEKL8zEs6DNmJl gfs2ws+j 6UafxfVDhwgRptvV+lnRP7+h/SbyzSOnx4IEquYk7+jZzKyRVcx8leLmiTCquKgQ3p/7/39HLfUv3X2Vl86bqdCAZut6L+N2A7k2SgoD4VehqRUvHc0R4dTcL/FZ7nIS9qPC0hjdM8R99r530PRVrjufo8XG1WYlDBVJ980mmDaANofF5EJozCc5nwxXzB2mzn8pynJXOmhbIrXcbhg6w5VVyd+YgzhdaCyfOHL8zvcpK7qyysu1HanMw0eZWyvbSHPJ1QFtf16o24RqQS5rz3nb9oViXRlJK31UvKofATXxjq+SkSGxubZDVxZCT0CMMsAC8xfpv4xpqCMdlTUYdYBsnqNSO9LCcOJBnk1z8T4j6yIg1GWdalLx0fWZdWmADHvag4d1bpo8l/4hrWn0oR2lLRfxQrS7k1rjmYILZWOHow46W6F4lEv5y6LVvO/NiD+REyU891nF0y1+0MpIMa6K/Lj29PuC+MyNC62BclcjLU01twn+hpzspy5YdmcI38uaojTvPU5e87rAGRNd0mZhkKBe4RePRI55A2bxDWyvQuag= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 21, 2023 at 10:27:02AM +0100, Petr Mladek wrote: > Hi, > > I add Luis into Cc. > > On Tue 2023-03-21 11:42:56, Naresh Kamboju wrote: > > The following kernel crash was noticed on arm64 Juno-r2 and Raspberry Pi 4 > > Model B on Linux next-20230321. > > > > Reported-by: Linux Kernel Functional Testing > > > > log: > > ---- > > [ 3.071500] Unable to handle kernel paging request at virtual > > address 0000000000001000 > > I guess that this is exactly PAGE_SIZE (4k). > > > [ 3.079432] Mem abort info: > > [ 3.082225] ESR = 0x0000000096000004 > > [ 3.085977] EC = 0x25: DABT (current EL), IL = 32 bits > > [ 3.091295] SET = 0, FnV = 0 > > [ 3.094350] EA = 0, S1PTW = 0 > > [ 3.097491] FSC = 0x04: level 0 translation fault > > [ 3.102373] Data abort info: > > [ 3.105252] ISV = 0, ISS = 0x00000004 > > [ 3.109089] CM = 0, WnR = 0 > > [ 3.112055] [0000000000001000] user address but active_mm is swapper > > [ 3.114230] usb 1-1: new high-speed USB device number 2 using ehci-platform > > [ 3.118418] Internal error: Oops: 0000000096000004 [#1] PREEMPT SMP > > [ 3.118426] Modules linked in: > > [ 3.134717] CPU: 1 PID: 1 Comm: swapper/0 Not tainted > > 6.3.0-rc3-next-20230321 #1 > > [ 3.142126] Hardware name: ARM Juno development board (r2) (DT) > > [ 3.148052] pstate: 000000c5 (nzcv daIF -PAN -UAO -TCO -DIT -SSBS BTYPE=--) > > [ 3.155027] pc : string (lib/vsprintf.c:644 lib/vsprintf.c:726) > > [ 3.158443] lr : vsnprintf (lib/vsprintf.c:2817) > > [ 3.162196] sp : ffff80000b34b8f0 > > [ 3.165511] x29: ffff80000b34b8f0 x28: ffff800009d7b1ca x27: ffff80000b34bab0 > > [ 3.172666] x26: ffff800009d7b1ca x25: 0000000000000020 x24: 0000000000000008 > > [ 3.179820] x23: 00000000ffffffd8 x22: ffff8000099858a0 x21: ffff80000b34bc30 > > [ 3.186973] x20: ffff80000b34ba90 x19: ffff80000b34ba98 x18: 000000003c98bfdd > > [ 3.194127] x17: 000000000000001c x16: 00000000eec48da2 x15: 00000000a9dbdd17 > > [ 3.201280] x14: ffff80000b0242e8 x13: 0000000057a049ef x12: 00000000cfa47237 > > [ 3.208433] x11: 0000000000000001 x10: 00000000bd5b8780 x9 : ffff80000812cbec > > [ 3.215586] x8 : 00000000ffffffff x7 : 0000000000000002 x6 : ffff80000b34ba98 > > [ 3.222739] x5 : ffffffffffffffff x4 : 0000000000000000 x3 : ffff0a00ffffff04 > > [ 3.229891] x2 : 0000000000001000 x1 : 0000000000000000 x0 : ffff80000b34bab0 > > [ 3.237044] Call trace: > > [ 3.239489] string (lib/vsprintf.c:644 lib/vsprintf.c:726) > > This is the line where vsprintf() reads a string to be printed: > > static char *string_nocheck(char *buf, char *end, const char *s, > struct printf_spec spec) > { > int len = 0; > int lim = spec.precision; > > while (lim--) { > ----> char c = *s++; > > > > [ 3.242551] vsnprintf (lib/vsprintf.c:2817) > > [ 3.245954] vprintk_store (kernel/printk/printk.c:2200) > > [ 3.249712] vprintk_emit (kernel/printk/printk.c:2297) > > [ 3.253381] vprintk_default (kernel/printk/printk.c:2328) > > [ 3.257137] vprintk (kernel/printk/printk_safe.c:50) > > [ 3.260198] _printk (kernel/printk/printk.c:2341) > > [ 3.263257] sysctl_err (fs/proc/proc_sysctl.c:1109) > > [ 3.266577] __register_sysctl_table (fs/proc/proc_sysctl.c:1140 > > fs/proc/proc_sysctl.c:1383) > > [ 3.271202] __register_sysctl_init (fs/proc/proc_sysctl.c:1462) > > The has been done some reractoring/modification of this code > by the patchset ("[PATCH 00/11] sysctl: deprecate > register_sysctl_paths()"), see > https://lore.kernel.org/lkml/20230302202826.776286-1-mcgrof@kernel.org/ > > Luis, does it trigger any bell, please? > Do you have an idea where this code could pass a pointer PAGE_SIZE > as string to printk("%s")? My bisect actually landed on commit cfe7e6ea5ee2 ("mm: memory-failure: Move memory failure sysctls to its own file"). The new sysctl table is missing a sentinel. The following diff resolves it for me. diff --git a/mm/memory-failure.c b/mm/memory-failure.c index 6367714af61d..b2377f12f062 100644 --- a/mm/memory-failure.c +++ b/mm/memory-failure.c @@ -143,6 +143,7 @@ static struct ctl_table memory_failure_table[] = { .extra1 = SYSCTL_ZERO, .extra2 = SYSCTL_ONE, }, + { } }; static int __init memory_failure_sysctl_init(void) Cheers, Nathan # bad: [f3594f0204b756638267242e26d9de611435c3ba] Add linux-next specific files for 20230321 # good: [7d31677bb7b1944ac89e9155110dc1b9acbb3895] gpu: host1x: fix uninitialized variable use git bisect start 'f3594f0204b756638267242e26d9de611435c3ba' '7d31677bb7b1944ac89e9155110dc1b9acbb3895' # good: [454faa8515d7c7b90b3e291bc7cc1a84697a23d9] Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git git bisect good 454faa8515d7c7b90b3e291bc7cc1a84697a23d9 # good: [9bfa51aa7b4f87fe6215a200cca280ebd1c111b4] Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git git bisect good 9bfa51aa7b4f87fe6215a200cca280ebd1c111b4 # good: [c637c9b5d4540e07ed95698a67770c5fd2241d7e] Merge branch 'next' of git://git.kernel.org/pub/scm/linux/kernel/git/phy/linux-phy.git git bisect good c637c9b5d4540e07ed95698a67770c5fd2241d7e # good: [f1fb10a55d81bc43b7c16e96122c8611e0131ca2] Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/andy/linux-gpio-intel.git git bisect good f1fb10a55d81bc43b7c16e96122c8611e0131ca2 # good: [d3294413e4518ef8b31ee46535c873ef0b8a1d1a] Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/livepatching/livepatching git bisect good d3294413e4518ef8b31ee46535c873ef0b8a1d1a # good: [009e0171be8db0a77624899623fadcb59fc40a12] Merge branch 'main' of git://git.infradead.org/users/willy/xarray.git git bisect good 009e0171be8db0a77624899623fadcb59fc40a12 # bad: [cfe7e6ea5ee2149cf2dfc69d3f8a220ab00cb65d] mm: memory-failure: Move memory failure sysctls to its own file git bisect bad cfe7e6ea5ee2149cf2dfc69d3f8a220ab00cb65d # good: [2e88a8303d02ff107fd6aa5041f9def177483956] proc_sysctl: enhance documentation git bisect good 2e88a8303d02ff107fd6aa5041f9def177483956 # good: [8869a82dcbbf6fbe584ffff16b620b68281b3180] ntfs: simplfy one-level sysctl registration for ntfs_sysctls git bisect good 8869a82dcbbf6fbe584ffff16b620b68281b3180 # good: [7385b7cb60e030f0041c8c83d17d3c63e598c77d] ppc: simplify one-level sysctl registration for nmi_wd_lpm_factor_ctl_table git bisect good 7385b7cb60e030f0041c8c83d17d3c63e598c77d # good: [36657db1c77c1539812cc1303119cf4ad2e8f34a] x86: simplify one-level sysctl registration for itmt_kern_table git bisect good 36657db1c77c1539812cc1303119cf4ad2e8f34a # good: [0234a6faf178985c74806e33bde8a9e3052d3555] arm: simplify two-level sysctl registration for ctl_isa_vars git bisect good 0234a6faf178985c74806e33bde8a9e3052d3555 # first bad commit: [cfe7e6ea5ee2149cf2dfc69d3f8a220ab00cb65d] mm: memory-failure: Move memory failure sysctls to its own file