From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7994BC6FD1D for ; Tue, 21 Mar 2023 14:28:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F03086B0075; Tue, 21 Mar 2023 10:28:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EB2FC6B0078; Tue, 21 Mar 2023 10:28:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DA25F6B007B; Tue, 21 Mar 2023 10:28:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id CB8696B0075 for ; Tue, 21 Mar 2023 10:28:45 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 66CC9ABB4F for ; Tue, 21 Mar 2023 14:28:45 +0000 (UTC) X-FDA: 80593136610.13.6E6027A Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf09.hostedemail.com (Postfix) with ESMTP id C3C36140012 for ; Tue, 21 Mar 2023 14:28:42 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=jyVymhlQ; spf=pass (imf09.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679408922; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rgWay7ky4KxZ9USl5q60t3+HJWMM/Eqp13IrcLZkmjc=; b=izFlBHO24Rzn/L+qWLvsyOFVeHGCFpJ9FCz1UhoryNTzPwrc8cbaw9Elut/jFkVDbpzVoT c2PiWCD+gUxOGCPDstQUiSUTBX8UNmJiJ9QpKPtyt64p5ZorsDvh5iM8I/uX6nOEsVFooJ 7ybPENiDS17BIEQ1m4KqzI+NzCbHl0c= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=jyVymhlQ; spf=pass (imf09.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679408922; a=rsa-sha256; cv=none; b=2lQUlohBirjF5GVY6Quj9pz2K/NCKUV/UV77iiRyffLuhYzJDhFabcY/K/w/SAizoT6t6r pcqqoRxPtCMKaufWg0SeQJMOO15VJ2/p8PW5FDi1jztgY/F6tXCi2bpcjWTh0q/QqF4UEG WcKc77R92RzqeUKIjW3ayIUuQkNdtAQ= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BD85161C83; Tue, 21 Mar 2023 14:28:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 420FAC433EF; Tue, 21 Mar 2023 14:28:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679408921; bh=C9tWPSPxpAovWG9pgJ3+pCfgaZCP6C07MisscEt1fvk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jyVymhlQyGqBhI29fgT4/tVju0gZrYCm68mUKlPik5mmh/VwR0d5fTsUkTbCkt0vH ynaGKo9KxTS/WcUHX9/F4uXU+74BemSnLwggXNxYdOk0ZAeGRLzSGD7wkiW3bR9H1X 4bTuIGmi/iuxr81ai1bhRd9Fj+R59emaPjd7SO1QJq4OW4YYbciIItP27MBD9mDCNQ ZdMRIu8lWgdZrhb0PpfPgqDWGyEibzsPde1zuSzxC6OLn5LJt4a2rj4YN91pX2TY2u zW7I8f7thd+sX43p16k7qM5uIlLD779WxaDwKmYhutosqNOmD6F+p95idgiQP+hCEP vYuO9pbcjcvOA== Date: Tue, 21 Mar 2023 15:28:36 +0100 From: Christian Brauner To: Yangtao Li , Luis Chamberlain Cc: Alexander Viro , Andrew Morton , Kees Cook , Iurii Zaikin , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] fs/drop_caches: move drop_caches sysctls into its own file Message-ID: <20230321142836.l6pymt4ygg2qhfvn@wittgenstein> References: <20230321130908.6972-1-frank.li@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230321130908.6972-1-frank.li@vivo.com> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: C3C36140012 X-Stat-Signature: b3wtii1ekf8komhdnbd6oyb6fy1mrdob X-HE-Tag: 1679408922-313372 X-HE-Meta: U2FsdGVkX18ngAqk3EoJGFhklliZ1JzdsYuHy7CH/CLuo+rSNjgK/wJl+seMb6NnuKSjRfDDDuhGc8Qk6fKxfTzEw3rrLKTE5Qs+yoBLrzcGi0CVy8cDLC6T2wT1YRWKMBLY33oJLGqdlDM2rfT9wM1R8tQd6bD+LPc7gPP5ko1WTDrPcDN5iNUGD6mJlm75ZWC20tpd04eDnDwK2VaSqaa6sJ1kVDn8eIlUeyxPK5m/DsRETifb7i/327ieiF0PHVx9t3FVgCimO11R33Iub4vxoWImkB1bvPHYyUR1CD7PS+GtL/qLkbC8SwIcPekMrDZvkc8yR0FtGvjOU0JD15UDd5/J2rSobV2ikV7ez8+w/pzidXM3NxdSZddS0mapxzapcpYMfVunuxZTMWWXsrOdm1pnM1kdxbTQCz5zT9BR3vNYF1Ys+AoyqtLfjld+HuJ3sdyNqOWdRmZg2OV6El7XS4MsyjW9tE7yjslEVSAr9Mf5wbBnrzVilkOMUtqGL52YDruHW3DuFdWR7p1zO4meRk4Cx94UBQAPNPwckH6DjxJZ9pjvx6isGX2Fiflp4B8p5bziNXzs1RptRZVzQ+4/eJ+zjYaDjWeCUz0vgzBBOEb3YGwJCkZiUHrl0/d6YMSzeHVs7y2GTDV1c2aHcjqM7ifijJWjJUSD/RkzLMlSeJ/Ff3tyoz5Q7ax6dusNTbyiyQOVYo6M7UgRtIkNms6CSJwPlXy47ThOf/h86ZEcTYxpqvrelpc1PWxujmIrmnz2wsonNkLhEASbDOORYcpOKkBnHBgZ8+GR6U6xo2Yvh1Imu8DXyGz4XJ3qjOiH6xixmWVh/LGxjHzqipQ4KNQ7XMtsNELMgI145c2b3sUBvteyw1g5u7jJvbvwaONFNLkksxIQTIYSg1GstTD7ga5VVjXO7wlOcxSEVWZeD/PPV4vL1rvmO/xM78NeLN3Wn8NpY8h2oM4mWDZOY3q iTEU401i Wf25dhVaurr7i/EpisU0J/TUv1Keqt1ZugOSPBZFJXbFe8FW8iYFfnc5a5NNXqrZK60jtrOewsuRoKbzkqTi5Usdxi/8IuyPixJVv6uhzgVX8tHQPP3o7nkEDlUnv5y0I7qOIN3p3hdpf9gY1KnzEWwCMbByw3QaJpeDPAZmMQAZUyA2rm2Y0YFK0owWrXVUU3KgUGOswZcmwveo2SGj6Iax1YnrfstEuG7bynVmLtpRz6hzMRLEqPF1KJyLMBuxmW3raF3+c1SuhQXyz8XGdWF408hTF0wMaXZFjwI8kVKHMXUlEH4+euI9T4X/ixiutXNMWBX9OMBivq7DSLgSu1CDmyY7rj/yX7ZsOYfQucFG7FdcIWbBAUXXrpta56OaVR6ffu8As4TTs0IPG+avpSbV4gg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 21, 2023 at 09:09:07PM +0800, Yangtao Li wrote: > This moves the fs/drop_caches.c respective sysctls to its own file. > > Signed-off-by: Yangtao Li > --- > fs/drop_caches.c | 25 ++++++++++++++++++++++--- > include/linux/mm.h | 6 ------ > kernel/sysctl.c | 9 --------- > 3 files changed, 22 insertions(+), 18 deletions(-) > > diff --git a/fs/drop_caches.c b/fs/drop_caches.c > index e619c31b6bd9..3032b83ce6f2 100644 > --- a/fs/drop_caches.c > +++ b/fs/drop_caches.c > @@ -12,8 +12,7 @@ > #include > #include "internal.h" > > -/* A global variable is a bit ugly, but it keeps the code simple */ > -int sysctl_drop_caches; > +static int sysctl_drop_caches; > > static void drop_pagecache_sb(struct super_block *sb, void *unused) > { > @@ -47,7 +46,7 @@ static void drop_pagecache_sb(struct super_block *sb, void *unused) > iput(toput_inode); > } > > -int drop_caches_sysctl_handler(struct ctl_table *table, int write, > +static int drop_caches_sysctl_handler(struct ctl_table *table, int write, > void *buffer, size_t *length, loff_t *ppos) > { > int ret; > @@ -75,3 +74,23 @@ int drop_caches_sysctl_handler(struct ctl_table *table, int write, > } > return 0; > } > + > +static struct ctl_table drop_caches_table[] = { > + { > + .procname = "drop_caches", > + .data = &sysctl_drop_caches, > + .maxlen = sizeof(int), > + .mode = 0200, > + .proc_handler = drop_caches_sysctl_handler, > + .extra1 = SYSCTL_ONE, > + .extra2 = SYSCTL_FOUR, > + }, > + {} > +}; > + > +static int __init drop_cache_init(void) > +{ > + register_sysctl_init("vm", drop_caches_table); Does this belong under mm/ or fs/? And is it intended to be moved into a completely separate file? Feels abit wasteful for 20 lines of code...