From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60FA1C6FD20 for ; Tue, 21 Mar 2023 20:02:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8D8A66B0074; Tue, 21 Mar 2023 16:02:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8883C6B0078; Tue, 21 Mar 2023 16:02:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 79E126B007B; Tue, 21 Mar 2023 16:02:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 6DCD06B0074 for ; Tue, 21 Mar 2023 16:02:00 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 2118540191 for ; Tue, 21 Mar 2023 20:02:00 +0000 (UTC) X-FDA: 80593976400.27.0469140 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf22.hostedemail.com (Postfix) with ESMTP id 51D3EC0017 for ; Tue, 21 Mar 2023 20:01:58 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=IRYYlsqm; dmarc=none; spf=pass (imf22.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679428918; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/OXgoUnRV+Bp3MvjlPaR5vC+pySdzygZESSrVh7y3QE=; b=1yRplED76e4zMJPJKqMPzn/mZX2x6t+qt1o+d6GLwihrLfJK5o0uEjSVM3rU10jmpbm776 wNsTe7Qfl/MAb3G6cXxlM5kz4a50A6kPj+ljmS3MokR2XEBZpuULdd+cRj8w5noixTZQz2 fnigadDGN4W0QHB0L2X/dtRyilHfz1A= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=IRYYlsqm; dmarc=none; spf=pass (imf22.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679428918; a=rsa-sha256; cv=none; b=SkxBG/3VQg88dcJ36fmPoQut8ONQSjoaxy9mVn9wwdlAr/j0NP6d+ZRoheMcs6mHG39hrq JCgXJAeIwE6s4QFWadfAt88zVvaIQhK0GN21AMBJg5dkLey3ybgcO3LMQ+eQx1WBqj7GPY QN8hoDvnHFlrmZsdIqdkfUsyO7//uZE= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4B4F461DAA; Tue, 21 Mar 2023 20:01:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 72C23C433D2; Tue, 21 Mar 2023 20:01:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1679428916; bh=aeUK7WkObcA3ioIoyAIxBv/4CKXxT3qJju3bQdYLKI8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=IRYYlsqmqMfoJLVwwCAGou+jMgXv9PDz1CcWZf1VxcrhpKKnu1N85CSsaTOzkayte UcpcPKHDOfZffrFpgsCkfH9JkJqsrP/Sw08dTWMLW8/o1P+xgnONwL91/8tQuXngTD IVOeId6AFJshplT8VEaGKGqCTpAcYRKQT+KAJ8Qs= Date: Tue, 21 Mar 2023 13:01:55 -0700 From: Andrew Morton To: Tomas Mudrunka Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, rppt@kernel.org, linux-doc@vger.kernel.org, corbet@lwn.net Subject: Re: [PATCH v2] Add results of early memtest to /proc/meminfo Message-Id: <20230321130155.dfd4ba94d093faa90213182b@linux-foundation.org> In-Reply-To: <20230321103430.7130-1-tomas.mudrunka@gmail.com> References: <20230317165637.6be5414a3eb05d751da7d19f@linux-foundation.org> <20230321103430.7130-1-tomas.mudrunka@gmail.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 51D3EC0017 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: n3sqctetwdynsse69f7cakamtdzs5ehu X-HE-Tag: 1679428918-168776 X-HE-Meta: U2FsdGVkX19E+9R8VmixRvEEEHWUqg2aBUc2wNvL2kENpXvySjj1hlr2VVAuYIhaIMo6xbqVYHiFZjxG/1qHIibllGu8YHDZVyW/bbDY4Ie1NpHUBif12erBlJwTAhV1U45FsOYzd10aAk7Y/Qhbw6VLGlNUJ2YApb781QhyZ3pPIvdDyyKTIOKf9RAK/UPugBHF+AmvxNl4jirmTp0mgtTBsK1nEWLVKvO0s30b6gkDjYMWUyNjJ4G0BBtsVTpUm/Ii05eOz+foyzjayuT1Eth1OeGmB01C9eQ4PE9k4BOobA+6dYAx4yuHuHdvlQftpTfVYwDhdrkdD9NdDnR9hn9LCoypkRvyuqcLd8vtkxg3BZ7iekJkhQ8bdQve9S7bfGH6GjpsrXCeAx/IzyCOxa6mgAMxGTWCvOx46NbuFoklhAlepkogy6EdvkyJ9bF9WzYxji++o1FI3KIUTs0w4OKnDIgZZTFB1TItNOko3YxP/BV5Bf+EY5v4TTts4BEvwaY+pNSUpA5+VFJnCLpV3PLXjkBcWohfE4N0s6gxori3x3GsGce3lhGwSDdFilpIVaUZUGpLi0Dt3JGKm1lZ3JuGJM7VN/JAouf3uAqmZdiRSkACi3crelhELQtyeskWxwq+9/TCdDK8L9pPT1qpz0p8w2Gued/fD5o/O75avXxGuTO6E9TAGJocSWEqvcwaKY2Hem/g+WQe0/FX5MDbtbuDb/5YkqEizayiUqm4Mup3YpGkqDx/b78KGj0RM0QramxsGmkTcXb3kRnZjTLX6r+RSk/aeLAw4bH4siv8pCx5Wm+gQZOaPMoERWMY4170q3np3iUjrsqooeC7fDYNwmmmyEXT9fZN5UJPi5Nwyzwx5yH75eiKL4nBcr5ofAwaJTNHE8Wkk5bQqbsiZsecGig3zIdyf6UwBMU6aLvkGY7or48+JKXPiYRw2K1DLuRnGglei3oWrkmlQ6HYO7V Y8bXZEZ6 BuoJgwbGCFcPjANucx+DElAebyrXcM2+cfT/KT6VOYP15oVFHsvW+XBYXoQatBUHsvd/l8xD2auH/4GsOaOPQqx8HbLD/z1JdFSMb95mzH1/JnUkz8fzUzmNh0nq2k6eEdZzaH1PIfpnL15YrwyY8KZtjujQxyOGdY3TTmjILkZAbToPupoGhi1qZVgfeFeFJl0auduRnZMSOqlBjWWarDZlEZM1qn2IQt0m9xGIi0p4Srnb4PBAD89thZnkQfUwHZ5eL4td3K//LdgAJYmV7ocdKayVvy0odPEnWK3lMne0SMvugpXCqspL7SA/OxKkkQ5dE9qSievOOySipgjXoJiar1e94sHauDrxQRW/ziWuNM2fwqFAWABSIE1APzceTBT+YvKh8o/A4/oB3quZ5kA7SVXDbbGsnTUinHrRUt3jps9tuI5oUPjdmWg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 21 Mar 2023 11:34:30 +0100 Tomas Mudrunka wrote: > Currently the memtest results were only presented in dmesg. > This adds /proc/meminfo entry which can be easily used by scripts. Looks good to me, thanks. But the changelog still doesn't explain why we should make this change. I grabbed that from your other email and used the below as the changelog: : Currently the memtest results were only presented in dmesg. : : When running a large fleet of devices without ECC RAM it's currently not : easy to do bulk monitoring for memory corruption. You have to parse : dmesg, but that's a ring buffer so the error might disappear after some : time. In general I do not consider dmesg to be a great API to query RAM : status. : : In several companies I've seen such errors remain undetected and cause : issues for way too long. So I think it makes sense to provide a monitoring : API, so that we can safely detect and act upon them. : : This adds /proc/meminfo entry which can be easily used by scripts.