From: Wupeng Ma <mawupeng1@huawei.com>
To: <akpm@linux-foundation.org>, <david@redhat.com>
Cc: <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
<mawupeng1@huawei.com>, <kuleshovmail@gmail.com>,
<aneesh.kumar@linux.ibm.com>
Subject: [PATCH v5 3/4] mm/mempolicy: return EINVAL if len overflows for mbind
Date: Tue, 21 Mar 2023 15:40:34 +0800 [thread overview]
Message-ID: <20230321074035.1526157-4-mawupeng1@huawei.com> (raw)
In-Reply-To: <20230321074035.1526157-1-mawupeng1@huawei.com>
From: Ma Wupeng <mawupeng1@huawei.com>
Check and return 0 if len == 0 at the beginning of the function.
Return -EINVAL if len overflows for mbind.
Signed-off-by: Ma Wupeng <mawupeng1@huawei.com>
---
mm/mempolicy.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/mm/mempolicy.c b/mm/mempolicy.c
index 0a596c6cbed9..134fdc1f6c87 100644
--- a/mm/mempolicy.c
+++ b/mm/mempolicy.c
@@ -1276,13 +1276,16 @@ static long do_mbind(unsigned long start, unsigned long len,
if (mode == MPOL_DEFAULT)
flags &= ~MPOL_MF_STRICT;
+ if (!len)
+ return 0;
+
len = PAGE_ALIGN(len);
- end = start + len;
+ if (!len)
+ return -EINVAL;
+ end = start + len;
if (end < start)
return -EINVAL;
- if (end == start)
- return 0;
new = mpol_new(mode, mode_flags, nmask);
if (IS_ERR(new))
--
2.25.1
next prev parent reply other threads:[~2023-03-21 7:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 7:40 [PATCH v5 0/4] Add overflow checks for several syscalls Wupeng Ma
2023-03-21 7:40 ` [PATCH v5 1/4] mm/mlock: return EINVAL if len overflows for mlock/munlock Wupeng Ma
2023-03-21 7:40 ` [PATCH v5 2/4] mm/mempolicy: return EINVAL for if len overflows for set_mempolicy_home_node Wupeng Ma
2023-03-21 7:40 ` Wupeng Ma [this message]
2023-03-21 7:40 ` [PATCH v5 4/4] mm/msync: return ENOMEM if len overflows for msync Wupeng Ma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230321074035.1526157-4-mawupeng1@huawei.com \
--to=mawupeng1@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=david@redhat.com \
--cc=kuleshovmail@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox