From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9BA1C6FD1D for ; Mon, 20 Mar 2023 21:30:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C3B516B0074; Mon, 20 Mar 2023 17:30:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BC50D6B0078; Mon, 20 Mar 2023 17:30:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A8C416B007B; Mon, 20 Mar 2023 17:30:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 9588F6B0074 for ; Mon, 20 Mar 2023 17:30:02 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 2EAAD140FA6 for ; Mon, 20 Mar 2023 21:30:02 +0000 (UTC) X-FDA: 80590569444.04.11F6037 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf20.hostedemail.com (Postfix) with ESMTP id D5C581C000D for ; Mon, 20 Mar 2023 21:29:58 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=qmJ2xFhN; dmarc=none; spf=pass (imf20.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679347799; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZznKLHPmLqzByHKs5cAsCEw7L6nMeJIsu2bjHffmCV0=; b=RunGCfzCUcZalN8smn2HKN6AKgoMOh95HHaRvbtBfF54BRshTMr+obPsVNewoJumMT8f84 VYm5+bGH2cLfhs69+eBrzhNRKm2o5iNdaR5zPgEZ58iKLcRmizMZ+lSm4SjXCjy8yfngM7 AC3Melo8GpFI8fi6vvVJ/kibI1TqtmY= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=qmJ2xFhN; dmarc=none; spf=pass (imf20.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679347799; a=rsa-sha256; cv=none; b=b0OvbrwGGAjy0CQbIPzanwr5VFAawlScGnNpMo2lpt35CRtJjCQ0FQFnHr7ukQ7t3Jr5RW OiyzLYq0bKznT0jIg7IZqqIgI6/9eDy2cso4OGc/NIHdeKD/If6z1Faxf7MvmhkcCT3nMl LYFGYkIwN9nzxv8VaY08b/nt4LRrkAw= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id EDAA3B810A7; Mon, 20 Mar 2023 21:29:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 54EAFC433D2; Mon, 20 Mar 2023 21:29:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1679347795; bh=xye89Jo0Go8cey4g9/6Jk9Xa2r3IpjAoyg0qZdZdGVo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=qmJ2xFhNLK+5qz/Untp24587hIyM5BUWFN7+XOzM4SYdJovYOmvfBopCxrtdVwIwQ So4yAFC0qRTMCYs80jd0YOkMq6EnkPK/mlHgrWY0PUnzw9Qxv80ghfx7lKP7KKigxb ZZloLRRwPNWPBZn7vwU3G8N05xVQvsFG/yaf8yYU= Date: Mon, 20 Mar 2023 14:29:54 -0700 From: Andrew Morton To: Muchun Song Cc: glider@google.com, elver@google.com, dvyukov@google.com, sjpark@amazon.de, jannh@google.com, muchun.song@linux.dev, roman.gushchin@linux.dev, kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: kfence: fix PG_slab and memcg_data clearing Message-Id: <20230320142954.fd314c5e46c1d18887ccf8cc@linux-foundation.org> In-Reply-To: <20230320030059.20189-1-songmuchun@bytedance.com> References: <20230320030059.20189-1-songmuchun@bytedance.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: D5C581C000D X-Stat-Signature: 6ccabmgjx6gfmk3zjgc16qu4jogz5ai4 X-HE-Tag: 1679347798-303191 X-HE-Meta: U2FsdGVkX1+I6QIR6LApqV9FztBaIIAB3ASqqUblnCGMo5/TZGNIlXIakTghlojG5yygDy9MLuqn7igtESV2GQ62NzLD6yc19IvyrqqN9oOL2km5EdkVtubwb/Mx2Dbajy/MCVYcCOQCOH3IHYeYdMNcMw/HBYM2wJPh/cbZcK+XG8Df9zyEOAMoOf4/l7Q1kPiNLiOgKh/1F0ut6YvDkb7ybfPHJajDvbuhFerWuP9wIAV818XfUp1DzKkZxtzcc9AKOWyHbFcFcDs/kmHatW3RG4ngXVuliS3ifFaT1aE41xwe0JmOvgZCs4u0RJpGZJ0teGcxkjgyueeorv8Qj0vfB2KfQyJl7E55KG7BXxyF7NzeIuZBHcbofa7cRqVyX84S6/VXZW7IBahCrhfX56yS/HlQ5Z2bsN/x9NJrxfEMC0jDuShVIbf+a0pyYsppoEKwBjGbBSkxL4x/EkYKobghZpdsJwVoH2CkeT9AyUoP0itD7ua+WKDOYajW6CFt8uuqxlYtwYi7Bpi//Yhrj9PV87jat/vRAoExTffAHsfuYXWxKLgCuJZFvHKvN00G8Cu1olPluPLSlQboc96z4h35o99vBd1X0q8S5v1IAW23YTwIG8hmsAAyRbYekSHJihNU9zlIsCHKA563Th0laBh3ZRgCjnH7QxoVIcwnIFxQnjanJQd+bHP3SDIvo/i85bbmFVvJscA3qqrPwDgg38jpKzY3VUu2Hp2aWCslOxxTWvgqTz7imrn9Hp5VQQ6IzN/xykiwm9hzrYIUVXpF3K85LG/ox+MtbMgi2pyF6kWOHeKYDP0zX4WS2U0D4Xk/InV3MniiJn9+ueeY1Kelz1gah5dx/KfkYr7gAMolLwG7kXt9SYSEklgi1BVTxAP5ZeuikOs8Hw/zNq49Vir26VWD8eSgSIR4iHRHMwpwHfzpJFckm7o7/kmewHSC8zJdMB7UV0hei58eGTFJAvm e6FPoJxQ f1OgK8A8iCk2nbxhOve3Z6kQqXBfqPw21nDa50hlO8JiTGc4xUkem/wyBgfdLpoBzT1d4JuE2bcbnYx7Zs4QksjM2z+M6t6z3xOWNJXf6ycKebAlbbsj62hgKnUQFIcoy1plDG2ZtXQFW91MgxmsMia0jwtrXLUgXEqHzhnSaT1B4Mmp7qQAeX8QmAuWJqh9I8HIVLJrKz6AssCD1abyM4Q5AJu8xktBfnsJrocBSp3eOZuG4FZpe3EkonZT1XTiXkjOMQ8BI9XNhWq1Py75NLIkFA6jRzXd+gEkabGw6MDJhkO6g7AEDZJsfR4kRAhK3ssMV9gMExKvK83Y/wMPd97zBg+Xtwi0QC/lMNuZt6IfntEtvoizGcRE2SVtE40j+sKkCspFJGELgkbZyjxH4KtIV6I1Svsl4KlRHEpNX5e6HHTMBexxpSATzksfePdHt1/v/jNNdvHnPPTrDkJKlZ2tlVRj6/broJl46 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 20 Mar 2023 11:00:59 +0800 Muchun Song wrote: > It does not reset PG_slab and memcg_data when KFENCE fails to initialize > kfence pool at runtime. It is reporting a "Bad page state" message when > kfence pool is freed to buddy. The checking of whether it is a compound > head page seems unnecessary sicne we already guarantee this when allocating > kfence pool, removing the check to simplify the code. > > Fixes: 0ce20dd84089 ("mm: add Kernel Electric-Fence infrastructure") > Fixes: 8f0b36497303 ("mm: kfence: fix objcgs vector allocation") > Signed-off-by: Muchun Song I'm not sure how the -stable maintainers are to handle two Fixes: tags. Can we narrow it down to one please? I assume 8f0b36497303 triggered the bad_page() warning?