From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F4ADC6FD1D for ; Mon, 20 Mar 2023 08:49:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 73F9F6B007E; Mon, 20 Mar 2023 04:49:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6EFCA6B0080; Mon, 20 Mar 2023 04:49:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5B6D06B0081; Mon, 20 Mar 2023 04:49:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 4A4DE6B007E for ; Mon, 20 Mar 2023 04:49:18 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 18FA8120703 for ; Mon, 20 Mar 2023 08:49:18 +0000 (UTC) X-FDA: 80588652396.06.DA7E36E Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) by imf08.hostedemail.com (Postfix) with ESMTP id 225E916001D for ; Mon, 20 Mar 2023 08:49:15 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=GwZx2zyJ; spf=none (imf08.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679302156; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XiB3x9LYyNFRNq8LCKvOIAldHQmBve44qL67iI3THCc=; b=xEHTDvYEIi3U8KmLRMQumQwQBs114RV0B+6fP/nyaC9Xrgz6BjN9TNnuU55JXBOrFENwJZ bLKLq78sSR5osi+qN08r8GN5f4Ucsn43D2h3dv8yg0BXIkxfdT8VgAYztJo+V41Q/yuulN UnhhxUSHq3zl/ZpddCSdkWXhZIfJvcc= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=GwZx2zyJ; spf=none (imf08.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679302156; a=rsa-sha256; cv=none; b=qc1yLHmc6fFMIYHf+tNqc2zV0xOF3P8X9498vRmlLvMWy6ILpDzTVntz/yMr5pnlhk9ztZ DUaZF7PTMiYFujo10cw/PYGvYfHZ95c+xRE3Wcs+QZOqtC2tVy8txBB4UZGAh38xfIFol6 gMu+wQMnL6220ccUz0Ed9hNwzOmBHH4= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=XiB3x9LYyNFRNq8LCKvOIAldHQmBve44qL67iI3THCc=; b=GwZx2zyJvzxlGQSxomJ78ma3vu 8PTRVPbqwuxw5KRR9qoFZH/9BIssKpXXSvM7e6dyKqx8BxvrXcFmfi0Q/84EZHQmEPJhc0W9OTiGd T1oak955zhY6FTvo4Un7iRcuVljJb/7y+5yhj+p6JODLwcWopY/X1zon6DzcRXxriQxQyVUFqiqUT 2nMP1djKwRrVp+w3IoD1gFL52pxfeeIDOwmTr2MO8xQ1TDpAdAJwtq6x7B06aBVN/ZdBbYpZnwdNM IOEjmsk8Xa5C5+Y16lzqtRbOW4LTztSf0fwxV/rGQL3KR1xIyRcFEEboo21HIlr+15VHjL4S3e0qi aFZgOv/g==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1peBCS-003s0L-0z; Mon, 20 Mar 2023 08:49:06 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id D7B41300137; Mon, 20 Mar 2023 09:49:02 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 88319202F7F65; Mon, 20 Mar 2023 09:49:02 +0100 (CET) Date: Mon, 20 Mar 2023 09:49:02 +0100 From: Peter Zijlstra To: Yair Podemsky Cc: will@kernel.org, aneesh.kumar@linux.ibm.com, akpm@linux-foundation.org, npiggin@gmail.com, arnd@arndb.de, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, mtosatti@redhat.com, ppandit@redhat.com, alougovs@redhat.com, David Hildenbrand Subject: Re: [PATCH] mm/mmu_gather: send tlb_remove_table_smp_sync IPI only to MM CPUs Message-ID: <20230320084902.GE2194297@hirez.programming.kicks-ass.net> References: <20230312080945.14171-1-ypodemsk@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230312080945.14171-1-ypodemsk@redhat.com> X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: 4e47k3gaodfabb95daxtqhz7iit9n7nd X-Rspamd-Queue-Id: 225E916001D X-HE-Tag: 1679302155-441879 X-HE-Meta: U2FsdGVkX1/rFAkYtSp8RZgDPhhD/f5WWmRzcd5ARILtKA8IkI0WWUulu4Rqus3e6AsbYOrntiX1JmNDTnMh6h+uhjRKxsj9EVcUd9OY1eFx3Jz6uS47dYNjNppaOSCDJn9v6cv2RTcmCyHleHv6IXH6/5mya+pzlrNqSfgoUYGQh5FqUJYF1oaoN8XmHIspWqr4CzrRt39ikeRRV+4zeo/SLoiT7wdaBovUasU+dctRBlnkL4WnsutXzbniDLxU8oDkoZJCq2JswBgn/M354MgJrHy/i84qQbpWmM13bLArDWl//CH8jg79BW29oBDYhGKG2VWPpenGnc6lnqpi/Xb+H/bAcYv7cg+QojiuE2XHGF6EGJZfULWZV2CzuutILfsmiDUdoAURKKTiG0wPW8a61QO/K78raVIIqRx78+EyPHtYNFDKmfGEaTvN81yuMLcFCKjQ4Hpft1TVY3Pi8r5W2XbOne6YMYBVxAw3opfKY9M0J9okWFJLIVM6W/M1YOpGTs4OwuuDWhqjqYLtJhNOmb2bf18xg+/6xyCV5ZaLcs1FIa5LwlPwGTSmA9HFsqHQ1lV+a2EBU5eATz+xdOI8xvQU2Vx8qRwHeWVjjIoAmUSC1pKmPej3mWz6l10pQGeKfVq8PDiwUsoTvHtMb3KeRdww+5YPk5RdZofhYctQWSFUSznrF+YNzzloM+OhAe+Dl9UmcKnyw8f9Vk1DDaLd+N3ZVCdOdq7fWngZMkITSfLlpK0n7cILcpPJ5Km96vBDmqP5m/5tzDbf8qohKaWdc0dD9XUWthrF1S1+hu2PiqejAvNbyimKJeaCZKcUwyIX+7xedZERNkcGJbXN96IO6/NkPOlYaC1+3MsNK+14DMFSKJOXzEi1bGnVXQt7eAgckjUxIrjHsI8pE6Cx07swWnX9K0RuAyD2+IsAewfBvb/zX8vnzOnOsoVbU8z6EZLVCT27lnx5sv/jhAT FdiheRRQ 5M+SKPOZny+yQaJIYXXXbDMqK6XYdmYyMhtiLrU9IozssTnQh4cQxqg41CVXyDuYClI73Ff4oY8rLul4+7LQUAI/qmNsyzNO70Vv3kZ/SFnCc92CLR4XHxz9ITjBef5YYeDxh9AhEyJtlVYg9lYRf9Ue7d6EREJsdVPlqFY/sYBdPNEH+rrmJy8e5X8MybE+Vr4kcCE+OZs4dFMo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Mar 12, 2023 at 10:09:45AM +0200, Yair Podemsky wrote: > Currently the tlb_remove_table_smp_sync IPI is sent to all CPUs > indiscriminately, this causes unnecessary work and delays notable in > real-time use-cases and isolated cpus, this patch will limit this IPI to > only be sent to cpus referencing the effected mm and are currently in > kernel space. Did you validate that all architectures for which this is relevant actually set bits in mm_cpumask() ?