From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C93B9C6FD1F for ; Sun, 19 Mar 2023 18:45:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C764D6B0075; Sun, 19 Mar 2023 14:45:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C26E56B0078; Sun, 19 Mar 2023 14:45:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AED4D6B007B; Sun, 19 Mar 2023 14:45:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 9D74D6B0075 for ; Sun, 19 Mar 2023 14:45:52 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 6EC2180901 for ; Sun, 19 Mar 2023 18:45:52 +0000 (UTC) X-FDA: 80586526944.06.6ADB663 Received: from elvis.franken.de (elvis.franken.de [193.175.24.41]) by imf13.hostedemail.com (Postfix) with ESMTP id 24D9120003 for ; Sun, 19 Mar 2023 18:45:49 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf13.hostedemail.com: domain of tsbogend@alpha.franken.de designates 193.175.24.41 as permitted sender) smtp.mailfrom=tsbogend@alpha.franken.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679251550; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IrnI2Ii3YwQCXK1o3WnVNkG4VGMfKS9Tjp7GpC9Qr0k=; b=NP0Ds22VVERx0u58yX/HEapknTZFz2AHPiEI5TWBRV0iZKD/p48pOqO2bag8VaaugK738w BtOGY8nZbnKnsCCjGBsLBIfW3e3TiDwaPYhSF9mGvdyoI5eBK06JlfRZosgPRWWlSdJSWO GdQwN4ARuwZbcOjqwGn58Y/WhW5aMZ8= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf13.hostedemail.com: domain of tsbogend@alpha.franken.de designates 193.175.24.41 as permitted sender) smtp.mailfrom=tsbogend@alpha.franken.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679251550; a=rsa-sha256; cv=none; b=Ie6x4CLbxokLLPchHRaJ+WC37Y//PxV4kSSwwQ7CM+A4l+up3qtITWzFkVjkXU1bQJQa+J aDTndWBWyAQHpS39+mkVAdZrh07DDBwE5jYDYz7QdTuHQ6uqFwaobbykkr8UO+DrD5LgSB 5Rhtm/YXbQpeE1Czg6VBQcDRiYJs+3E= Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1pdy2J-0000Vs-00; Sun, 19 Mar 2023 19:45:43 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id 9B5CAC1B09; Sun, 19 Mar 2023 19:45:36 +0100 (CET) Date: Sun, 19 Mar 2023 19:45:36 +0100 From: Thomas Bogendoerfer To: Matthew Wilcox Cc: linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org Subject: Re: [PATCH v4 16/36] mips: Implement the new page table range API Message-ID: <20230319184536.GA6491@alpha.franken.de> References: <20230315051444.3229621-1-willy@infradead.org> <20230315051444.3229621-17-willy@infradead.org> <20230315105022.GA9850@alpha.franken.de> <20230317152920.GA11653@alpha.franken.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230317152920.GA11653@alpha.franken.de> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Queue-Id: 24D9120003 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: eeuct9u49adkp37515kjfb85e8r6n7j8 X-HE-Tag: 1679251549-857248 X-HE-Meta: U2FsdGVkX189UkA8qwYmr2bJme7Sb/hzQYZjayu4NDsTe6nkxP/j8mkdCbyQxoelXCoHFLO9OAApaTbCiIv40IBe480I0cWFO3tdSbpDOA/izC+mCG/tN738GrlVpUZE/1qxOywXrfg47G4DC3jQrQjv8xQufXbQvicX8bSZRk66VC5jR5FUIHE+JF+SQmgZ4v0UNKXvcBKvC0hU5pr938C2EdZVt4zXuas5Mo7gLJWe986+1S4BL0tlE3quowPGEr66LVBObHcq12tPHHF4ulc7xMRlaTzwMBgvsMeT1VHq9HWsyMDr4OQoAjx18e28voSgC6NSusomK5fLXqW2VNhVoxqhFPl76pFfJTlZaE8OuMfqH7Tpgt9LPmWewRIrNWydR7oWvaw4eI47BP8YN3BLN1EPaZkK0cKxFL1dFC/fSeMrl6V80S4X9a2ATDjyZq4lMt99aJ60B3WmtULYXjBr352SblG8s5NhKPn53VPfe4laSvir20zDnDcgy708Zh+QuwepGT05o1g8SLqR7RgyiMWsZPv0qhjGwodMQzB4xAQpRASuhZna09AOjWOkFURFqgTQHwqwLjJfjs2Nj7UqQYKyzBMulTLN4iAtoOBxNULjm+PkesMmWwM/rcLoTg5bbZM5ITNYmLUVtaE3C+SXv6zhG1NCyfEMs/FVJq0Lbyl6czxA4q9O2bHB5VnT+aPztmjF20Vs7Yx+1ByvLG5s2p20oX8ZanATLdoLliyLQcuTxf586w7KSyWI4/V3S5H/G0PdlWMKqiFfn/NfY369EH+ft5AfUS8Uwl57MiIcu/2R25OVjf67iVWSxjt2IXUuSgxNyuAwhEv4IJx9pQmbGxhmteAt6DAT6LusP6LlkwgPjy1iq0Tju6odPv622rSpy2E4XhO/ge/nw9DLMPfvP3qoV/eUQ1GGfMPV3etNTwmWMgMKx7r5IPUJA+Y0CCKZs5GzVDyrBIw1X/Y rwCwhRVY FAQ59aXY3ubBYnlNnWIs6JNbKe5We3AyHnt3ztga9fXzPXiM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Mar 17, 2023 at 04:29:20PM +0100, Thomas Bogendoerfer wrote: > On Wed, Mar 15, 2023 at 08:33:21PM +0000, Matthew Wilcox wrote: > > On Wed, Mar 15, 2023 at 11:50:22AM +0100, Thomas Bogendoerfer wrote: > > > On Wed, Mar 15, 2023 at 05:14:24AM +0000, Matthew Wilcox (Oracle) wrote: > > > > Rename _PFN_SHIFT to PFN_PTE_SHIFT. Convert a few places > > > > to call set_pte() instead of set_pte_at(). Add set_ptes(), > > > > update_mmu_cache_range(), flush_icache_pages() and flush_dcache_folio(). > > > > > > /local/tbogendoerfer/korg/linux/mm/memory.c: In function ‘set_pte_range’: > > > /local/tbogendoerfer/korg/linux/mm/memory.c:4290:2: error: implicit declaration of function ‘update_mmu_cache_range’ [-Werror=implicit-function-declaration] > > > update_mmu_cache_range(vma, addr, vmf->pte, nr); > > > > > > update_mmu_cache_range() is missing in this patch. > > > > Oops. And mips was one of the arches I did a test build for! > > > > Looks like we could try to gain some efficiency by passing 'nr' to > > __update_tlb(), but as far as I can tell, that's only called for r3k and > > r4k, so maybe it's not worth optimising at this point? > > hmm, not sure if that would help. R4k style TLB has two PTEs mapped > per TLB entry. So by advancing per page __update_tlb() is called more > often than needed. btw. how big is nr going to be ? There are MIPS SoCs out there, which just have 16 TLBs... Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]