From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99FA3C6FD1D for ; Fri, 17 Mar 2023 22:23:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DB5776B0087; Fri, 17 Mar 2023 18:23:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D3DAB6B0088; Fri, 17 Mar 2023 18:23:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BDEC16B0089; Fri, 17 Mar 2023 18:23:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A80796B0087 for ; Fri, 17 Mar 2023 18:23:30 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 797FB1A0350 for ; Fri, 17 Mar 2023 22:23:30 +0000 (UTC) X-FDA: 80579817780.04.936594B Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by imf01.hostedemail.com (Postfix) with ESMTP id 451D44000E for ; Fri, 17 Mar 2023 22:23:27 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=TCf+nNkX; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf01.hostedemail.com: domain of lkp@intel.com designates 134.134.136.65 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679091808; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eq+KF+gPskwsJud9xc5VFFwhLXTwSVoVd7iodtXgrpI=; b=jlox0z54Vnvcd7+uteGeAMczybpZkwgA/wgIrrgUHRNgb1pzKivQV4ERAtGGlW7YApkmv0 Rr9NafHH/hEwUBJXYmReYDb2fPekG2G5nzfMvm6KKI7YE4ViDSyO1X+H84aVIDlum/49Bt htJ7Nlt9VjZl7Jo6/qAdelptjDNMSI0= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=TCf+nNkX; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf01.hostedemail.com: domain of lkp@intel.com designates 134.134.136.65 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679091808; a=rsa-sha256; cv=none; b=WNRuYsRIy8fmSTQI1D6ZtvrCXrME1hCZMQw7PM4aexnTwWQiHHuKYkK5Np7Ll8h5BttNt+ 2dlPlj/jlkiNNB/2iONok5Hz+csf5c0KA/cPpBfN6dC/D0t3GZ6Lxd1DB7+pm5wzSNGsbH 5sLw/KdfW+bXy5HA2y7zohhORfpQSUw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1679091807; x=1710627807; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=CxoqtRpgIYa299cxTvwVvIrPSLBWaBzvtQOQGfPiu+g=; b=TCf+nNkXeysGbN6BcgvoDr/+ZMtjiHEgBwIK21rMLdufYOTZxAXA+WKR sv6KCQ8CAaa9l8Aosm2n53871donavzzFXKcmlcvuLmBL6yXRbsGjulIT BqP34ReSbg1jrWIQBPnMb5FgP0n3oqYV/+PPuPH0FU1rryqH45CezjvIP TsBCFfKDjtss81phrB0DMqSThJNYIDCcLv0b695HlD5zwb1xB1EWi/RUG XA1Y7y29sU9apwMXqQ7NcV2lJpqMh3DZO1a1GjvyiQazPEO/wHUy6g2aN 53WeXZ9/hFPTlzJPJufYePVvLuZEeNDwWkRygEauMRBV2Ee9xjpVF+ddS w==; X-IronPort-AV: E=McAfee;i="6600,9927,10652"; a="340730372" X-IronPort-AV: E=Sophos;i="5.98,270,1673942400"; d="scan'208";a="340730372" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Mar 2023 15:23:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10652"; a="680434769" X-IronPort-AV: E=Sophos;i="5.98,270,1673942400"; d="scan'208";a="680434769" Received: from lkp-server01.sh.intel.com (HELO b613635ddfff) ([10.239.97.150]) by orsmga002.jf.intel.com with ESMTP; 17 Mar 2023 15:23:21 -0700 Received: from kbuild by b613635ddfff with local (Exim 4.96) (envelope-from ) id 1pdITo-0009bs-2K; Fri, 17 Mar 2023 22:23:20 +0000 Date: Sat, 18 Mar 2023 06:22:40 +0800 From: kernel test robot To: Michal Hocko , Andrew Morton , Leonardo Bras Cc: oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Frederic Weisbecker , Peter Zijlstra , Thomas Gleixner , Marcelo Tosatti , Johannes Weiner , Roman Gushchin , Shakeel Butt , Muchun Song , LKML , Michal Hocko Subject: Re: [PATCH 2/2] memcg: do not drain charge pcp caches on remote isolated cpus Message-ID: <202303180617.7E3aIlHf-lkp@intel.com> References: <20230317134448.11082-3-mhocko@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230317134448.11082-3-mhocko@kernel.org> X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 451D44000E X-Stat-Signature: x55ardj7w1c97yp9pmbfwuhx6zgpfjw7 X-HE-Tag: 1679091807-724212 X-HE-Meta: U2FsdGVkX19P/6YJFHRCmLvtpwaCenwMbriBmAK6IfLTkiAL3t3YSoLd+6JfK8p5PYCq9gMojnr00aAEfVLUXCExKEemxuRcIFMSJcdcdj3eWJidkHtZp8a08TZaevFwcsv+Z2GTi3ols0zkef1EBHT5tfKZAxIpkbGnVvwzJXljo1xXHnKj2GXogW3f7iY7oOqyAO1hlHHYONdYPhdF4FaJsRq8sh9jv0XlsrqblQj1jFTzJlNUoWk5Qgh0QM5d1kua0uunqeMOGiZZ1szUYpE8gFW4fkLExxHa3GzxjOAUF/DnwjMHeocNtxjM/Nhop/dLfLBPpqDJa3PCGk4gh++FFHuy4bEkfJz6vsjjx7vB601JZTHNxCbo4EqJlax7vlHRpgLHbCupHKR8GTtfNFMmX8CE7S/d2IjhwADLtrGzmmB0zgj64ijwi12Rvh18dlfcQd6chIGa8RxTzfLatiijpAFV+VhkpALG+NoKUU+JAM4kF0egIfYL00a57fL8Vl6+XjwmgOgc3xzZUCiovuxM2HxxGKDCc9noH6+S/bSrPAoNXkzloUa3ONS8MqY2Vuft2W24StmTaPA/2u/jPR5lAOWZswNXkkt7UlnzU/vTcMBbSOM/EbAGsDR7sPk2HH/EY7UzFcnlxA5utfUiYxh6DzKfTB1kLIUr27h1aTOWTeqyGq+H9X3XW7GXAmA6BGoh9On2ON8DFwpahoRxjbCI/KFBQKK2DDiQOiJMnQe3KWO/F6ud3l+FYVsAryrfOEskj11cO0iCzhzqWofGkY24wVkk064L11yhs2fm9zmPHe58z+RMAfZuRXgP5F2zJ4Bnwxg0tDd6+agQkGrJYNpT72zFSDjz6G2dl9bSmtU5Q6EXRoXpk5pPQL/EKjXvIph0fNMRC7ygPP9teKU1fwaGUc9hAYEGo/w2LxmxLqRCCro/a+Akz+Mwpl2pIB8wiORLMTewFgOqBVdy5pR A0VBxoyM qVN33day3xOY3UPIszaD0y0pag9WOWnskBJUZrENUZya6/DKIFsceYNHT3+RxXCM5FmJPwdOd5B+Fk1zqIpEfob9tq5xjTUiwLo3XlTCWtrWRyncJyHnKiBNpLRbZViG2Q7CIoDHRhvZLyVciWGMkXOMbazuJaIJ3liOkxZr7k1ONg2EA4qbxHQHXAOrZOjtist2uPro1H9d5+fAfJj6aORMyYgbYNf6f+JnouRzVChKDEp7jkDkn8H27YQeRHiLwiVOLDeOHtEj3DoZaOzYUw/TyZ7nVij9h9LTQgFV/lxXplgVKeIe0q2u+kEIcoQ7MkLXT1UCvOvf9qLc7X1gF0J0PfSebpK92IfhhAuSdGyYBWQw6qlhTugu5ZDZoIC85pYVT X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Michal, I love your patch! Yet something to improve: [auto build test ERROR on akpm-mm/mm-everything] [also build test ERROR on linus/master v6.3-rc2 next-20230317] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Michal-Hocko/sched-isolation-Add-cpu_is_isolated-API/20230317-214621 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything patch link: https://lore.kernel.org/r/20230317134448.11082-3-mhocko%40kernel.org patch subject: [PATCH 2/2] memcg: do not drain charge pcp caches on remote isolated cpus config: x86_64-randconfig-a013 (https://download.01.org/0day-ci/archive/20230318/202303180617.7E3aIlHf-lkp@intel.com/config) compiler: gcc-11 (Debian 11.3.0-8) 11.3.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/b376cfcf40a43276e1280950bb926fdf3521940a git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Michal-Hocko/sched-isolation-Add-cpu_is_isolated-API/20230317-214621 git checkout b376cfcf40a43276e1280950bb926fdf3521940a # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=x86_64 olddefconfig make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot | Link: https://lore.kernel.org/oe-kbuild-all/202303180617.7E3aIlHf-lkp@intel.com/ All errors (new ones prefixed by >>): mm/memcontrol.c: In function 'drain_all_stock': >> mm/memcontrol.c:2369:35: error: implicit declaration of function 'cpu_is_isolated' [-Werror=implicit-function-declaration] 2369 | else if (!cpu_is_isolated(cpu)) | ^~~~~~~~~~~~~~~ cc1: some warnings being treated as errors vim +/cpu_is_isolated +2369 mm/memcontrol.c 2331 2332 /* 2333 * Drains all per-CPU charge caches for given root_memcg resp. subtree 2334 * of the hierarchy under it. 2335 */ 2336 static void drain_all_stock(struct mem_cgroup *root_memcg) 2337 { 2338 int cpu, curcpu; 2339 2340 /* If someone's already draining, avoid adding running more workers. */ 2341 if (!mutex_trylock(&percpu_charge_mutex)) 2342 return; 2343 /* 2344 * Notify other cpus that system-wide "drain" is running 2345 * We do not care about races with the cpu hotplug because cpu down 2346 * as well as workers from this path always operate on the local 2347 * per-cpu data. CPU up doesn't touch memcg_stock at all. 2348 */ 2349 migrate_disable(); 2350 curcpu = smp_processor_id(); 2351 for_each_online_cpu(cpu) { 2352 struct memcg_stock_pcp *stock = &per_cpu(memcg_stock, cpu); 2353 struct mem_cgroup *memcg; 2354 bool flush = false; 2355 2356 rcu_read_lock(); 2357 memcg = stock->cached; 2358 if (memcg && stock->nr_pages && 2359 mem_cgroup_is_descendant(memcg, root_memcg)) 2360 flush = true; 2361 else if (obj_stock_flush_required(stock, root_memcg)) 2362 flush = true; 2363 rcu_read_unlock(); 2364 2365 if (flush && 2366 !test_and_set_bit(FLUSHING_CACHED_CHARGE, &stock->flags)) { 2367 if (cpu == curcpu) 2368 drain_local_stock(&stock->work); > 2369 else if (!cpu_is_isolated(cpu)) 2370 schedule_work_on(cpu, &stock->work); 2371 } 2372 } 2373 migrate_enable(); 2374 mutex_unlock(&percpu_charge_mutex); 2375 } 2376 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests