From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D784C6FD1D for ; Fri, 17 Mar 2023 21:52:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 05E8C6B007B; Fri, 17 Mar 2023 17:52:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 00EC26B007D; Fri, 17 Mar 2023 17:52:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E3FBA6B007E; Fri, 17 Mar 2023 17:52:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D32C16B007B for ; Fri, 17 Mar 2023 17:52:28 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id A2F1C80413 for ; Fri, 17 Mar 2023 21:52:28 +0000 (UTC) X-FDA: 80579739576.11.A0C6665 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by imf27.hostedemail.com (Postfix) with ESMTP id C6F3840005 for ; Fri, 17 Mar 2023 21:52:25 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=I9TvJqYK; spf=pass (imf27.hostedemail.com: domain of lkp@intel.com designates 192.55.52.93 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679089946; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TjNnV3kZsLb86K0F6PXTicGhg6ipPS/UUHK2UzvSgOQ=; b=8nCwRH/KvT4NzFEqjyNTHP+IxT4QMzI/hEuuwiF10wMbiAq1sOLW17FYvoHe6uoke6wfW9 QEjsM7cChUKcaqr8Air67iyav1JenrDJ0b61c4iFadAz3RgSEDFrMysXpPSULAaeC7zPH+ wZK+MKyWYuzXRBASIcEQKcdJWXu86lg= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=I9TvJqYK; spf=pass (imf27.hostedemail.com: domain of lkp@intel.com designates 192.55.52.93 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679089946; a=rsa-sha256; cv=none; b=6JqXzTukghOg5N0G8dxi2wP8vZq35Sk+TlIWznHuGuOt6xOACOQKueRP2Q84GLnPOTyohI 9cgrMSnUze4A7Q4864eY/4ucrrC6vZTU4/YSuZzHgpAZBlIc4KAo9dpGj1HJWxZ4bk4Lij SIMynNdjWtDpcghC8thT6Gvy6vuGk1M= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1679089945; x=1710625945; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=8eQMoQiTmuxn++Usa45XJwNDsrf1ZBPdDqy4GY4DSGw=; b=I9TvJqYKoMUazKUKiGOVuKdAx4khhq+mJOt32+mZHHeHimAJUlWbY9K8 wKmkEkH89rzXzZf65od4KjSz+VXJKS5aM0ZysPMHXU3yeAL1CrLCOi5c0 E80Lmn3jbHJzTnHRAjppRBkgKK98Wr/+YlaAQ48a5GCVQuk9YTKOYkr7l SNgaKxL25pAww6h2EeEj5SisDHvl3ngYjIxce+b23DhsabR3KMM6Eeeak yXtLL2PYp4+hZph+p/1VXhkq60UnQ13aGg0X/uIiFg1I/sJPJ7hQk5CEA l5z5HQL69FuurrUU3TScu+VRgQqrYbwo1d4Gp8u+Gqki102HFHkZ3nHGf g==; X-IronPort-AV: E=McAfee;i="6600,9927,10652"; a="335865458" X-IronPort-AV: E=Sophos;i="5.98,270,1673942400"; d="scan'208";a="335865458" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Mar 2023 14:52:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10652"; a="823802762" X-IronPort-AV: E=Sophos;i="5.98,270,1673942400"; d="scan'208";a="823802762" Received: from lkp-server01.sh.intel.com (HELO b613635ddfff) ([10.239.97.150]) by fmsmga001.fm.intel.com with ESMTP; 17 Mar 2023 14:52:20 -0700 Received: from kbuild by b613635ddfff with local (Exim 4.96) (envelope-from ) id 1pdHzn-0009ak-2W; Fri, 17 Mar 2023 21:52:19 +0000 Date: Sat, 18 Mar 2023 05:51:47 +0800 From: kernel test robot To: Michal Hocko , Andrew Morton , Leonardo Bras Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Frederic Weisbecker , Peter Zijlstra , Thomas Gleixner , Marcelo Tosatti , Johannes Weiner , Roman Gushchin , Shakeel Butt , Muchun Song , LKML , Michal Hocko Subject: Re: [PATCH 2/2] memcg: do not drain charge pcp caches on remote isolated cpus Message-ID: <202303180520.5lKAJwrg-lkp@intel.com> References: <20230317134448.11082-3-mhocko@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230317134448.11082-3-mhocko@kernel.org> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: C6F3840005 X-Stat-Signature: rigxnk3whbustshfs88ebe1nbnwki61m X-Rspam-User: X-HE-Tag: 1679089945-317427 X-HE-Meta: U2FsdGVkX18mDg4V9mkVrL2KM1MD/JXG8cwaIIboVLxToh6BHWKk2hDY7KOKknHzfW0jL5BrBDO6R/CGq811D9Irb2Auq7HlFKdnY3dHzs26SgoHZ2JFB0fWDvWyjG3xUL7MRPtLfZv8PHuCh8uQbJWMekdgeJOIjAiWc02/bZ8e3L+1NL5dPfmSG106WBFDrrJcIWMyAa120tVTPYzwgP5KfFElRrfH0/HHO2CFZd/cIfNpEzYbb1wNe8iI7ZUhg8Q0Or+F3G7OnKFjw/DJDFMni7+XK6GI2jpIBjtwdg8ae8Wjl7IdJabTnQODa1MbtkGSFMB8qTHe9V5pWwMw8/ALfygDDbQI7UlVxwBxBQqnF0YAb0bxuviZlpsmq3huPTJWvxc/0gAI3wnUqMbTQzXcOkkwIg8KvlbpxFC8GuqaLZU++LZUgCyo2ZUIWRehmsb9N9WcDLTvpVRjgtov9vYGjjQ0QMvCMjs4GTw5MHILJtP2LETaW4reU2uufVLFPeaKV1cXCtKpQ9YBArnjN0PACVmWrNtBl1RV8vL3+U/vgUdkGjUS6Z1YcG08MSJDyw9kSHQj6zEWtfgDSgAxXn/lE73V1WKV+sTjn8bYHkThxsXovlxWVE/8D50QJWWmu0Say4pF97pr3NcTGPk2P0wwKzFfK5K72pne6ThgDmPp7+O2CaL16tOBddQOM64fbmQqLETyy/RHMQPt5dZppDwCyGsO69HLd7y1olNPeTJrw3aJWiHsX4yilqMu6HAvx7YwWcmfLZF/Yzzj3OgpE+2let+cRJiw39wa+wPxkvxSfPddLk71mtl9ytucDsZZJiSjzLy2KR6XHuraQ+renqJLTKsdoD8hAb8NLyZhhkRqoJJKIFPg0qOXZBY6El+6RVKSaWNbmNgEDa+/4a8xbQRjH5krPy5oZF2kgTok9TFE+ZQD808DYEdM++U38d7HRL1PM1/hm1PdhL/T4MW ihwo1Qqm CXxTSTi8ezk2jTuyeNmZZX8XWIZzdoZ/uG1/BNvDKce5vYGY8RCHqOSRlOCMXNK7jWAZ28OyGm1y3Z7HpYxEst0ndjZjtTRXaclYHr9vHJ6isfQF7MlRxmox34h4UeIUnzOT3oX1mZeEAQjGVRzuTZbl8ld9npiAoOmZYMPEpKG+i1RM/loavsCcOKXiRurSSIb/zQnjmElLbqVRffxJW9zGqcf+v/rKBDAoz0gIOuIpiQZfDNxxS6ay5p2G36Q/MWxWbJOmtC8bbpab0mB/PMpWIflpNJdfrOZgJ9qehKtd6sSTyA0dOBNW3Q6Q2i1IorZ8ns/XiyqgwJJKQed7sovzH4lNomn3PPb0AvY+d840A/8hv5Puer4qqAP6Cr2dk0ccC3f+69DOnOweJ/9fb4dQo360d+FnmdvfZ7mVjxVJSZSDRrZpYxkQlq1Gkbw49lAoV X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Michal, I love your patch! Yet something to improve: [auto build test ERROR on akpm-mm/mm-everything] [also build test ERROR on linus/master v6.3-rc2 next-20230317] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Michal-Hocko/sched-isolation-Add-cpu_is_isolated-API/20230317-214621 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything patch link: https://lore.kernel.org/r/20230317134448.11082-3-mhocko%40kernel.org patch subject: [PATCH 2/2] memcg: do not drain charge pcp caches on remote isolated cpus config: x86_64-randconfig-a014 (https://download.01.org/0day-ci/archive/20230318/202303180520.5lKAJwrg-lkp@intel.com/config) compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/b376cfcf40a43276e1280950bb926fdf3521940a git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Michal-Hocko/sched-isolation-Add-cpu_is_isolated-API/20230317-214621 git checkout b376cfcf40a43276e1280950bb926fdf3521940a # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot | Link: https://lore.kernel.org/oe-kbuild-all/202303180520.5lKAJwrg-lkp@intel.com/ All errors (new ones prefixed by >>): >> mm/memcontrol.c:2369:14: error: implicit declaration of function 'cpu_is_isolated' is invalid in C99 [-Werror,-Wimplicit-function-declaration] else if (!cpu_is_isolated(cpu)) ^ 1 error generated. vim +/cpu_is_isolated +2369 mm/memcontrol.c 2331 2332 /* 2333 * Drains all per-CPU charge caches for given root_memcg resp. subtree 2334 * of the hierarchy under it. 2335 */ 2336 static void drain_all_stock(struct mem_cgroup *root_memcg) 2337 { 2338 int cpu, curcpu; 2339 2340 /* If someone's already draining, avoid adding running more workers. */ 2341 if (!mutex_trylock(&percpu_charge_mutex)) 2342 return; 2343 /* 2344 * Notify other cpus that system-wide "drain" is running 2345 * We do not care about races with the cpu hotplug because cpu down 2346 * as well as workers from this path always operate on the local 2347 * per-cpu data. CPU up doesn't touch memcg_stock at all. 2348 */ 2349 migrate_disable(); 2350 curcpu = smp_processor_id(); 2351 for_each_online_cpu(cpu) { 2352 struct memcg_stock_pcp *stock = &per_cpu(memcg_stock, cpu); 2353 struct mem_cgroup *memcg; 2354 bool flush = false; 2355 2356 rcu_read_lock(); 2357 memcg = stock->cached; 2358 if (memcg && stock->nr_pages && 2359 mem_cgroup_is_descendant(memcg, root_memcg)) 2360 flush = true; 2361 else if (obj_stock_flush_required(stock, root_memcg)) 2362 flush = true; 2363 rcu_read_unlock(); 2364 2365 if (flush && 2366 !test_and_set_bit(FLUSHING_CACHED_CHARGE, &stock->flags)) { 2367 if (cpu == curcpu) 2368 drain_local_stock(&stock->work); > 2369 else if (!cpu_is_isolated(cpu)) 2370 schedule_work_on(cpu, &stock->work); 2371 } 2372 } 2373 migrate_enable(); 2374 mutex_unlock(&percpu_charge_mutex); 2375 } 2376 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests