From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 746FFC7619A for ; Sat, 18 Mar 2023 05:13:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E2E7F6B00AA; Sat, 18 Mar 2023 01:13:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DB7C46B00AC; Sat, 18 Mar 2023 01:13:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C57B46B00AD; Sat, 18 Mar 2023 01:13:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B37956B00AA for ; Sat, 18 Mar 2023 01:13:27 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 72EA1806C4 for ; Sat, 18 Mar 2023 05:13:27 +0000 (UTC) X-FDA: 80580850854.13.961887E Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by imf02.hostedemail.com (Postfix) with ESMTP id A195080011 for ; Sat, 18 Mar 2023 05:13:25 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=bLjj9lGg; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf02.hostedemail.com: domain of isaku.yamahata@gmail.com designates 209.85.214.179 as permitted sender) smtp.mailfrom=isaku.yamahata@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679116405; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Vp4nrXm1X0DRjVSq3iwlTb4e7n7mV7oF4ktjLlYr7kI=; b=fYyBXJ88VpwaSr/zrJRXmNraEqdj93qedruq2MJKtyNudkpue/TWriYaRALsaQ7le5dJfO bTshR+w56drBhz0XDiIEnmiLw3ps524X9Htbua8V+XPHPLqpyOAnHOYWw2goftFcUOENo+ hCwLrRzcuaBV2YJFbRn28aGrc1Ch17A= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=bLjj9lGg; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf02.hostedemail.com: domain of isaku.yamahata@gmail.com designates 209.85.214.179 as permitted sender) smtp.mailfrom=isaku.yamahata@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679116405; a=rsa-sha256; cv=none; b=tTMIqBQOSkbDlHKE0jkXEA8IEKm4Qy8N1nX+OEcKgsrtKKRb/o5IuDFWEABvctoBXtGDqd Yb/LTS39nrhoRGDN8oBjnKrx92gNeXGONy7ZcKI5mTuh9o9AXBaXrQqZq2r4axevWCAx/v 3zvukcMMTbrg4hEC6oYBhXut2Pm7l/w= Received: by mail-pl1-f179.google.com with SMTP id bc12so6793312plb.0 for ; Fri, 17 Mar 2023 22:13:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679116404; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Vp4nrXm1X0DRjVSq3iwlTb4e7n7mV7oF4ktjLlYr7kI=; b=bLjj9lGgZpmi+5FdHB64/F5xCOboYww86flECThggnpLYmZZA5HqQTRQcFCfg+10a9 gaz0V+wmOBm7A4cV7oLOCRDbxttum/0tzDarTuJxSZ6b0oQFZkkdZCaIn52+gfS9b2Yf ts32C0rszSNrP3uxXG8IdM/ODszWZAHT7PALtVns+aiy/RgUeeDJACOY+FyFgOggJsCW 3jmRnpxXRZt66+1XPq+2yFozVuTkCwGg+SKIJkvcZ+kSuSwAEGRfREOmD8Z3OMxHC6Wp ED2E75u8Bob8l5+LtugWgjavAYlz579OG/4/c6aVO+NkY3Xv6UcxQ0mOKdJ/I/g3GwRF Zcow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679116404; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Vp4nrXm1X0DRjVSq3iwlTb4e7n7mV7oF4ktjLlYr7kI=; b=VLOFaSjXbYjbCwQfW5eoYeiEdvaYs8ne1I5/JsEZQHEujdqPctAsnYrDt+hg5yCOr9 6pJzOU0g1wMg8Jaa3ZebsLQrNF21jfWOSsQU3Hhd7lElNJ/0mWcZeKQdTonMVaHoORNf qdLkE2qMRKNxTgU6G91/9+943vI8twiguBL5ZpTtuJFhzYJ0T5XnjZysw//600msE0sV 9sm4gSfcOC9KGBW/EfNtX7sxNB7LCJ6czYjmlezP+u+tCvv61/IBGw0Dkuh6bd+Obv9o mqUdEe4/5kwYQ4B9TI0aGEWyMv17ludUOcn5UMCi6wqziKQx1gwHz4ehIjEk5SRpHzmn M7nQ== X-Gm-Message-State: AO0yUKX7P6229F6NDtJTf8c6O2ix/pqGNKuBB4DlojzNswq59bZr9Bqt +TVxXfNJmdeApd8Auh3se2GIlfN3NVaJVw== X-Google-Smtp-Source: AK7set/soYLT1CHxH7Zm0HB+kkpyXNgNLr1rZsO1BZXpOWuxHpdfWc2Pxx1BGwMWxRV9sT22pll0Hw== X-Received: by 2002:a17:903:1d0:b0:19d:1d32:fc7 with SMTP id e16-20020a17090301d000b0019d1d320fc7mr11937833plh.51.1679116404399; Fri, 17 Mar 2023 22:13:24 -0700 (PDT) Received: from localhost ([192.55.54.55]) by smtp.gmail.com with ESMTPSA id q20-20020a170902b11400b0019251e959b1sm2350530plr.262.2023.03.17.22.13.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Mar 2023 22:13:23 -0700 (PDT) Date: Fri, 17 Mar 2023 22:13:22 -0700 From: Isaku Yamahata To: Michael Roth Cc: kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, dovmurik@linux.ibm.com, tobin@ibm.com, bp@alien8.de, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, dgilbert@redhat.com, jarkko@kernel.org, ashish.kalra@amd.com, nikunj.dadhania@amd.com, isaku.yamahata@gmail.com Subject: Re: [PATCH RFC v8 03/56] KVM: x86: Add platform hooks for private memory invalidations Message-ID: <20230318051322.GF408922@ls.amr.corp.intel.com> References: <20230220183847.59159-1-michael.roth@amd.com> <20230220183847.59159-4-michael.roth@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230220183847.59159-4-michael.roth@amd.com> X-Rspamd-Queue-Id: A195080011 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: smxy3fkag6xq97fe1nx8icz5jr7gukbz X-HE-Tag: 1679116405-709869 X-HE-Meta: U2FsdGVkX18wBWl+9G7QiRricl+eHCUuqSLOKUG0gRvDNyNHxxIVyU2cBvBcmn+AJVBRFqv7tJuGmPAGHPU7ONDJq1tMx9ICWWuBpZTLQ1F00iFv4CS2I992NXvdkFcZbAkbs/50nkiT2r4iMZEj25o9GfHL1iAckVZjNa1x5y6Ujmw7UaobPHNCFDEAr2SfE/YBmeJK+6MlXDd1zB4tdslNVIwQx9YSupjp0r27XRgDCioofRXd+WDN2wqV6JTwCKqfo4Rdcq5p4+JiH1ffyhPmbymUqqLRWZ9ndfR6W7tN+R4c2qRT0rZlXaGHnbq+BG5ZeDEUi3YGUwjk/6ux5J1fzmfUXRDGB0MkhHhrjwaboQq2hwa76Ro6YwGDY26/IwzoQFTpsNcnrPSC4uVR+8T8C1DS+H3h8dv/HGfA8zM30NIigPRl23TBggWfoJ010vGDRlDvI/5OC7KMAqxLuhq7xxKuPBTRYtG045IGxltMI5WfxcL22dRljVBUxh//rD8TZv3mvbYYKHGxFcy6cZznSxo35Y/uzKDp9fP4StqP1VjVxn5SSoncnLYhFj93GojHCsyXpbvV90iKNoQ2hDYnxAP+RWuvXs8a/uXSxN2IM5YoxzrhpEbOnGsPvenRxqEepS+cvosjSkaUhHzHeu9lU+42M+jTEpR6+i/A+O58z61KTfBYZK+KwVTWrOjDR2xSJcx1XQT2ZVIoAm8cP7oi8TF+fFeCxao+d7TS9TQeirhkM0HpfcnOaGz5iT95sG0IeuMgOqKpjPKjt4/zJLGAMzJ1jHre546hi2+CC/fi3cyUebIzLg7V4qEpsxqneJ4UZYjWEpDNiRdJZffJ5Uo0NLOezo7uQFPS+XE5nfsJXvs3YxKAGLagSxGzbjACh+rLn4qjoWjPWlLDUCburSAaJcDiXu+0w8QqgYoPgb7vvGMRZ/IGvuAch5lyv8QsRdrDDNZwu+n1j8SoXaY kZPkEdCx 4ZbMqWHmJ+I7G2yD2rKL0BeRCrE6RrOZ/cCKQHMffF2VbEoknpy70tPvmX+1P4o8LzOalX8rVvpW/RzVSRHN9sih/fHCMnCsJzqTph8Lz9PRDU6W3A6tQBoBNuxRPjZTFOsmz1FriNgbp8RdL37OND2oNByFZUOBv6/OpokHfMiiXB/yNLPfPvTckFCeNYo+x5yupup4hHUbQDQVzHq/n07sqvsDT/iG7/UhUZnroVKjifKBSW3b0DLQ1dQHXY+t+6jIZa/eVpP9CAD4fJrS4Ab2PEgH4nVmrh5UsZg1ixPk1AW3DnOpP0jlAychrsSDqQ7Xh9xRKJO5OmVxu4aa9U+JMdHWW2sxqnNBOYF7b7CnCADNUw0nQFh8RDWMSk6GKhS2pSvu/d85eUb4hS43M0HdPB59l7JQdXu89ywlWLYIrQj8d3oEMsBYS6dqrUTw7pKN+iTDAW7UeErwHq38URd22ykbnNTSXgeccn9/oUtSSxe42qRJierZNQ3Y4gjoEJLr5IL48TTTYzEAJjD8W76ZSfZMHwkWf+SXvTlsc21zA5FRIyMjeYf/OV71MchoK1Erd+/5uWaVp5IU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.001109, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Feb 20, 2023 at 12:37:54PM -0600, Michael Roth wrote: > In some cases, like with SEV-SNP, guest memory needs to be updated in a > platform-specific manner before it can be safely freed back to the host. > Add hooks to wire up handling of this sort to the invalidation notifiers > for restricted memory. > > Also issue invalidations of all allocated pages during notifier/memslot > unbinding so that the pages are not left in an unusable state when > they eventually get freed back to the host upon FD release. I'm just curios. Could you please elaborate? Unbind is happen only when memory slot is delete or vm is destroyed. In the case of memory slot deletion, the gpa region is zapped via kvm_arch_commit_memory_region(). In the case of VM destroy, we have kvm_flush_shadow_all() which calls kvm_arch_flush_shadow_all() =>kvm_mmu_zap_all(). Doesn't it work? Thanks, -- Isaku Yamahata