From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01CA1C6FD1D for ; Fri, 17 Mar 2023 20:08:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0842B6B0075; Fri, 17 Mar 2023 16:08:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 034656B0078; Fri, 17 Mar 2023 16:08:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E17FB6B007B; Fri, 17 Mar 2023 16:08:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id CFCE36B0075 for ; Fri, 17 Mar 2023 16:08:56 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 7D5491604F8 for ; Fri, 17 Mar 2023 20:08:56 +0000 (UTC) X-FDA: 80579478672.03.213F8E0 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by imf14.hostedemail.com (Postfix) with ESMTP id 6044410001E for ; Fri, 17 Mar 2023 20:08:54 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=shutemov.name header.s=fm3 header.b="M GedoY5"; dkim=pass header.d=messagingengine.com header.s=fm2 header.b=IEBSeC5Y; spf=pass (imf14.hostedemail.com: domain of kirill@shutemov.name designates 66.111.4.29 as permitted sender) smtp.mailfrom=kirill@shutemov.name; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679083734; a=rsa-sha256; cv=none; b=dC5rsEYUuBW+kqQOZqJFhwq7MkAAr7lR/ARx6nAAm3SkvEYyZmNiwI2DAJOgV8i06BY2Wd kvq7MyyWGNwqz6kx+lpxMwL0hi/kBuOR9R75QU5CZJsc/7T0wTcUb8XSsTz8ETDlkigMkR m2oX4C0C0FKiXS5cVZfoJ2ah2hJADNA= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=shutemov.name header.s=fm3 header.b="M GedoY5"; dkim=pass header.d=messagingengine.com header.s=fm2 header.b=IEBSeC5Y; spf=pass (imf14.hostedemail.com: domain of kirill@shutemov.name designates 66.111.4.29 as permitted sender) smtp.mailfrom=kirill@shutemov.name; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679083734; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3QWgEiDb3A7ZhMIEvI0tzxFEGhvDtOx1RahjR/6QWNA=; b=B77QNhyX594+w44pDgE3zNv5ZfgV4PApLUyZWbclYEUr1n6qXtIDOZ7d71bGFToDALORJM KJIdpUhdDwIuIGNwD3X0rov6ExSld8g8dEx08tPxHxLwt9s9LgA3npRmxhJ6njFhkpFwZD 06fMKzoUyE/PIlwrk3zcjf2/2BkrR4U= Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id C932F5C006E; Fri, 17 Mar 2023 16:08:53 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 17 Mar 2023 16:08:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov.name; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1679083733; x= 1679170133; bh=3QWgEiDb3A7ZhMIEvI0tzxFEGhvDtOx1RahjR/6QWNA=; b=M GedoY5aaxFV/mxmaayuthUUl708xNdt3fmxwD8GMviApKv8EGOQ27s3VEMbrSc8A Mk3SW+nqtcMKZGul3h2VmMXpGqUEhpOJOrkASe/Dzm5o37oIXzDwdJpTkjDgM7f0 nY0QlEcXBVw7TZmWQ5hP76SE2wSAxomWiYpNKrCdyHM015TviE/5AKP4BgJcRo8p 1xehc70tD01HTWJATU/fcxKwsHeCyLwTnWKJyF4j42tla1KFUMCDUxbJhHKPvgP3 Qrai2nW/SYF70PHUSPBALw6ELzRTJ2oKvEdu6lqnnB+F34/eWdL3cO89kkSJz6lo CWgRQcnjzrd9/GtjgepCQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1679083733; x=1679170133; bh=3QWgEiDb3A7Zh MIEvI0tzxFEGhvDtOx1RahjR/6QWNA=; b=IEBSeC5Y04frThJ8YmLFURABMT5i/ v7iaesDsL4BNVRj3nNHDCejUjFlNW++QaLptLFf13aK0Gcn148RlM8Gsmb3KubwZ hM0OSiE0BdmQPBKrBptDfX9iaTdUL+Ob4aPClpkIEHOGk3SIhLRtzn/KiQDLyviK gqlqNBp8IsBmRj9Al6+jVmI1QjN6FmL/hvTqSdFJx/+qKUJBvlsxXrlmHi+46N0h xshyF15xOBgj/WUmXydXIVjdvP9ffyhyH7VZagS9U8SSfh8dqt0e1pXSFus8NLz7 Dk18k/9knbt/tyudCCflaNJYXZGqsFQAEDf4McBcpokwQIfdXUgB0mseQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdefvddgudefvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtuggjsehttddttddttddvnecuhfhrohhmpedfmfhi rhhilhhlucetrdcuufhhuhhtvghmohhvfdcuoehkihhrihhllhesshhhuhhtvghmohhvrd hnrghmvgeqnecuggftrfgrthhtvghrnhephfeigefhtdefhedtfedthefghedutddvueeh tedttdehjeeukeejgeeuiedvkedtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrg hmpehmrghilhhfrhhomhepkhhirhhilhhlsehshhhuthgvmhhovhdrnhgrmhgv X-ME-Proxy: Feedback-ID: ie3994620:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 17 Mar 2023 16:08:52 -0400 (EDT) Received: by box.shutemov.name (Postfix, from userid 1000) id 54A6410D47D; Fri, 17 Mar 2023 23:08:49 +0300 (+03) Date: Fri, 17 Mar 2023 23:08:49 +0300 From: "Kirill A. Shutemov" To: David Hildenbrand Cc: "Kirill A. Shutemov" , Andrew Morton , Mel Gorman , Vlastimil Babka , linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/page_alloc: Make deferred page init free pages in MAX_ORDER blocks Message-ID: <20230317200849.gjqezmeaiqkfz7so@box.shutemov.name> References: <20230317153501.19807-1-kirill.shutemov@linux.intel.com> <373b22c7-9162-eff0-1f0c-0a8d79a8b372@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <373b22c7-9162-eff0-1f0c-0a8d79a8b372@redhat.com> X-Rspam-User: X-Rspamd-Queue-Id: 6044410001E X-Rspamd-Server: rspam01 X-Stat-Signature: a1ujhdg1bzkgpiwdh5pkr8zxcuibtgoe X-HE-Tag: 1679083734-893306 X-HE-Meta: U2FsdGVkX1/UWVFBcjklGwYQtY8ztG/3C16ORvQpIGZcxxlQpD4Y19+5SZPsswvCKZ/buMicG+fjrgUMK9Is0Li6tMuom7++W9uXGULnYVyWKBfGH3EuTAyfEZv+4nhYeEs7jwZxVXTK8aKskV9PVtgDnrhC/0hQudArWuz3J4IB9az7u7g4dZ4wFmp5Jn6P3qkHqy19/BgjayDMo1DSEbpYSuMaTiDwtim8wSJlnSaYr4wdxQrCkSixlNwIyPB2tOQPFoK2rSDIi1YchLiYm1NgTgTGK2Fe+hmkAdkdt93pHMvT0UXz/K8wFX2nAy8CFG7U1lkNdDrKbT51le3CfpGqgRYWOcwq7bWBEKjNkMG/j6XyvZScgg2XbQaufhGsgEPeCgOYU0raMcfaQA4rsgckTHTvK0IF843Jp2gqeOs8JaeOsp6gpruHz0kB7HSIHD2jX8u0twQteeWkQ4c2CNzWuOkOeO7yONMBdYNTVzDXDj3Qu2cXDER1bNj4oLDa+uL2ZF7E3DhoPdJqQOUCeamfEKRWWce8Ly2YUcfpX/x2ecPAQ1W8q5AtDLOVzyynjlDphS8snUApVkoZHNIvFwshR/KlFHbFtVNc9npEWJZTotEQZD7zIdApLvYzk08DhmKsW0MgCwiCUAuKz4gx3szexRqW2SHrjASaCAgp+ri+54CkNbkmMGHk4L5tqAFNHn9sYosxb5eulkV+ToNIX9aqIbYi5EFBffyRp5bjjvC1gShiOnCFcJi1dsF0Qgt8L0tYfDvAzQlAylFn0r77+NwRwrHTarlkahDI7AuVhpX8g97UscFSCCbnpsa+qF6Bnh4Re1QgPv8whtF5v5kSaFp1zboaO/Mm8P0aSi/kSfaLc1DMo3TJj0mUzFAEzhiD5e8/SNBiVn7vxU+0KCRM/FcAf7KF3puECGr/ItxoRnkPomsfW6y6LFOdVJugcgpavLaL5r1vBlC55N2dZSK XFee784j B5BUmHV85lfCYlxlCVMBbnh5g+jlzBXEcSprnPHpBW4G5L50z5PFBQiturlEzbKxokFAvnELw226+JZfk+Ia6j7NC+ig+MBHpi+pCov3gS18CQXfiOA//rSyqKaLekVUDgPBjtwM5F8WBwoS2oLbKYil/zWVPaTaBXk+A6wrsZKoeKt9Ge6wdu9kXOLeJ3ebd5iTF+o2BdJblpqy/Gft2wIAfYxbbcHTKzzxa0LjGnAVhOS4GytIpWSkFrvmxQWfkeGK4PTsPWT2mtA/b7Sbgv6kI+/U6qtD8Tkk6uiP/7pjTKBgLi0o/sAjas9cDpet5KgfHqxWCbf+1ajf1AzykS3gXEukrLztTjWStdTNDsO9J8Pk2k3Il9Y/XENVuB0Z85yIt X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Mar 17, 2023 at 06:50:17PM +0100, David Hildenbrand wrote: > On 17.03.23 16:35, Kirill A. Shutemov wrote: > > Normal page init path frees pages during the boot in MAX_ORDER chunks, > > but deferred page init path does it in pageblock blocks. > > > > Change deferred page init path to work in MAX_ORDER blocks. > > > > For cases when pageblock is larger than MAX_ORDER, set migrate type to > > MIGRATE_MOVABLE for all pageblocks covered by the page. > > See > > commit b3d40a2b6d10c9d0424d2b398bf962fb6adad87e > Author: David Hildenbrand > Date: Tue Mar 22 14:43:20 2022 -0700 > > mm: enforce pageblock_order < MAX_ORDER > Some places in the kernel don't really expect pageblock_order >= > MAX_ORDER, and it looks like this is only possible in corner cases: > 1) CONFIG_DEFERRED_STRUCT_PAGE_INIT we'll end up freeing pageblock_order > pages via __free_pages_core(), which cannot possibly work. > > ... > > How should it still happen? I got the sentence backwards. It suppose to be For cases when MAX_ORDER is larger than pageblock, set migrate type to MIGRATE_MOVABLE for all pageblocks covered by the page. -- Kiryl Shutsemau / Kirill A. Shutemov