From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8370EC74A5B for ; Fri, 17 Mar 2023 23:59:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F1B266B009D; Fri, 17 Mar 2023 19:59:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EA3C56B009E; Fri, 17 Mar 2023 19:59:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D44D76B009F; Fri, 17 Mar 2023 19:59:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id C0B706B009D for ; Fri, 17 Mar 2023 19:59:11 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 833D0ABB45 for ; Fri, 17 Mar 2023 23:59:11 +0000 (UTC) X-FDA: 80580058902.28.C034B2E Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf16.hostedemail.com (Postfix) with ESMTP id ADBB4180004 for ; Fri, 17 Mar 2023 23:59:09 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=FPsyJDFf; spf=pass (imf16.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679097549; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=m6/a10CVnRU0DBLRiwVNu4MUaIUuwYZVNvRbzYhnpZ0=; b=io2Hd/Yo+vCv7ZB8MQggPlpNRdaeIioTeM8hpFcQ8PFF13XOyB3vqWltmGaBk2o/TSnRK4 ilpqxuctw5ENGnFHB8r8vBjRTg16s5riUb84bkiwcD1mo+N/sR1H85UlRGLlyKZK7C7AAg QBxl3SuXWwjYHb/PEUAodf9iY+CV/Qg= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=FPsyJDFf; spf=pass (imf16.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679097549; a=rsa-sha256; cv=none; b=fnZAkgY6qabI0KvlQNlpFy5Z4UdvruJDGXjnTPcO2+95kI+C4HwXGrglG8YNngRraBcYDS VRnDtVz405bsAeeytX+JO9m9W96k9ZT/GKuUFqaM3UvQs9HjCW9y240eOxvqf2U2t3kEtC uX02BAXH+obDTq3iyEJvzo3RPYHyoos= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id F15B4B825C1; Fri, 17 Mar 2023 23:59:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5C80CC433EF; Fri, 17 Mar 2023 23:59:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1679097546; bh=m6/a10CVnRU0DBLRiwVNu4MUaIUuwYZVNvRbzYhnpZ0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=FPsyJDFfTSUm3O8MS0sgG6du4oIaoVMYwrm0+V4kBhyekibpHRlAqdpu4UwWDpRem rd81GwY4ueWVBlJSlfRVF9+2KwSLV4dey1jbIweDOU/Cu/G7Jk4rTWu7WaGVUcsi6j PdRV76yi8fdf1nDNmUs0PNfQKhi+qZn3kLwmqSqM= Date: Fri, 17 Mar 2023 16:59:05 -0700 From: Andrew Morton To: Lorenzo Stoakes Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, David Hildenbrand , Matthew Wilcox , Vlastimil Babka Subject: Re: [PATCH 0/2] Refactor do_fault_around() Message-Id: <20230317165905.f4f90b125e459617fa19a3d5@linux-foundation.org> In-Reply-To: <98fc8545-6bd3-4c06-9b12-d781a19982ac@lucifer.local> References: <20230317163936.06d9c7d032a5c2296075caa1@linux-foundation.org> <98fc8545-6bd3-4c06-9b12-d781a19982ac@lucifer.local> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: ADBB4180004 X-Stat-Signature: y1y7xsjshh9wxi3jkmgawfohu7de67nm X-Rspam-User: X-HE-Tag: 1679097549-971732 X-HE-Meta: U2FsdGVkX1+qn0II5gch12MduC0/CxXHXQXovYDvkoxWfmoV+LXiMjN2h4Z1q6kqNs6rGBn0sm0CNFJ87AYVSWrFq/YZNm1riiN4jkhdqtW7TiPUPW1BwCGTMS53UwhpzkQbowPUpgoAS9eJahUMMqIG3Z3mfB/XYS9gjLzqx3sPLVg0VeBePwPH66pX+eaepN6eCV4A4qD8OyQXWrib0rjrBcES15vYvx7aQGbkEiAGWSabHghsvKOcVv7i24csre4qcBspYJqhV/HdliBUBY9uNi1vySRwHkca874+ezA7xRgyACV2uNA7Tqj79ez1FfOuBojFO8HFxygEE4VBOVRc/3/BKtzWxgEQWpVi3WnkpcZuq15hIeISAHswOlfNi1T76zVc6JfRnN8MJH6KSVPABocpSFiHVR3orFw60n40GdS40IEUOd4gmoTVcs8V/q65KHKeJMxe7wrNG4dTcaqa0ZzCXlgpMq/27nwWT9uaHzQ+UfJuQuvA0uYfnyJO6zNy8KOiLCHLQf0PyX3HplFp0gEFJ8eXTMSYidmycvgbBOYvsmVzZ3CvohOQtRq7hicdpDLnDpaaqwcdcsvYsHVCvydnA3IQ+eDLHk3KHvbZrgq9/azBzjexfzsHrcAxBeE/Itk5UyyIP0o2G8CzhCeNizvI+2gsw+ZfEyI9HKO97hD/5sXxUAG/Xe0ll3d+v1VhNMZo1PCKQuXVgRm0H9TtLnDhX7Q1SKRRGP+DwzuKrlOZrQnVdPglGJC6pK+9XfhGK+sI9N0JgdriR99ByQXBB+MUJf05KJqQQ+zTFGOWlBq4n1anqCM6jfAlTYabBf2q0U2J94ylA9TjF2yKx9kD5pXDTx4UZwUdXLJrIZnttA6zMHshOfUTUw6OJYaDtbwPwQAUtoMn8UB5F6wcP4p6DHWQBtodmoqf5V+fKNWGL40Qeuh/SITwpvHQ3x8dRaa1+SqphK+wPrx8pq5 zOv2p7p6 6Ec83jDpKUzsZau9KDxUXETXdjMVEBpVszWg/3VpCdeO8W7ZmmSLqtbOEyrMAukjilj+ekyFyALTellskMUGcQVgNtyizf5ur8QsnyEYXAUCBYtJNTlLiUehhQYRQ9/6w9ZuPNsOwCHTfPPcUiInzfFJbS1CKpZc+WorN1hJGBVpCNks53rv1pVMhMP1vVpmVuS59t/Rpw61DOblaEI6wkwjm3WNBmaUaESOW9V6yXWairq5TTkeC4vOHPaEs0VAdNQ10U9K8EytmuDdftf7dcuWYrrGQVzo0Ed5k1oOaseO5Oci3pdeu4BF3hDFt6qLOweXG7cBvE+2HcUk2TTs2o39i1cs3lgQRrR4KQ9CEGxETF86vgXQDtV6BY/MNan9VBD1KoeA21gopzcJrOFampdEbmtEi9WcTM/FY X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 17 Mar 2023 23:48:17 +0000 Lorenzo Stoakes wrote: > I went so far as to literally copy/paste > the existing code and my speculative change to a userland program, generate a > whole host of random sensible input data and compare output data with this and > the original logic en masse. Ah, great, all good, thanks.