From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 614DBC74A5B for ; Thu, 16 Mar 2023 23:30:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C1515900004; Thu, 16 Mar 2023 19:30:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BC4AD900002; Thu, 16 Mar 2023 19:30:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A8D4E900004; Thu, 16 Mar 2023 19:30:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 97AC8900002 for ; Thu, 16 Mar 2023 19:30:58 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 6DA7C1C6FAC for ; Thu, 16 Mar 2023 23:30:58 +0000 (UTC) X-FDA: 80576358996.16.9B17281 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by imf06.hostedemail.com (Postfix) with ESMTP id 66871180017 for ; Thu, 16 Mar 2023 23:30:56 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=shutemov.name header.s=fm3 header.b="C Y7m2Kt"; dkim=pass header.d=messagingengine.com header.s=fm2 header.b=KiE1iVJ3; dmarc=none; spf=pass (imf06.hostedemail.com: domain of kirill@shutemov.name designates 66.111.4.28 as permitted sender) smtp.mailfrom=kirill@shutemov.name ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679009456; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mWjnFNvzepxM90lSc+OOQwduG8sRnhr4PdJP/q1hvoQ=; b=x+Gh4yRitxJbsNrlWUXZJjf1fNg6LOeA+t6uVv89xO85B0ENAmwZaBhWihhWVFEnKasnVr ILMPTr4LB+IuFQC/Vo5At0iaIM87BLtBknnChTnesfIAHTNQUariWW4eHXMRACI+qXJ1QK 6WvYFbHjzKe50h4sh4qUTA9ZEMFDRGk= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=shutemov.name header.s=fm3 header.b="C Y7m2Kt"; dkim=pass header.d=messagingengine.com header.s=fm2 header.b=KiE1iVJ3; dmarc=none; spf=pass (imf06.hostedemail.com: domain of kirill@shutemov.name designates 66.111.4.28 as permitted sender) smtp.mailfrom=kirill@shutemov.name ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679009456; a=rsa-sha256; cv=none; b=5czFxW6mEUiJbpfXgxYQrUIWVOrRPNNRBA/yMpc1VGWNI6mughgFuk445vF5GIzYSBrFGJ Mpq8QTYCenaoRKucEApNFMqui7dDi+V+98P/8ZcoLzFIC36HyCGQlCxvZky3ZJWJhXcSyd ie/NIiA1/mzTgGYrihw7vDFwmykhAF0= Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id EE46D5C0003; Thu, 16 Mar 2023 19:30:55 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Thu, 16 Mar 2023 19:30:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov.name; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1679009455; x= 1679095855; bh=mWjnFNvzepxM90lSc+OOQwduG8sRnhr4PdJP/q1hvoQ=; b=C Y7m2Kt2AcPEeMIc9lF8vV7fzv8FuxtG1ugefnXwzUBQd4FEyQX24p0GZfctzEkaJ SCr+lF7u+Edq1Ao2utuvGI1ibzp/YfHTr0vqu418BFfQSmZbnyvpXii0IQrkfx7v N6PISxC8KmfFK7Us8H2CuHkO98BN6pb5CM+liuwgOiY6iUllAGSg1TsVA7dUAHe0 N+jXOUHqEepWaTc/wcRsIwKysEAsRPSwoJaveQs05Rsy6F06CJWYhZH3bD05w4EO Sac/ifu28oaHeqexZgieYwW6M7AOdhyQsPKFJiYDFWBGta9JkDFIfsMr4Nx3A26H 5Ohi5ddr4inW6xmRWuNlA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1679009455; x=1679095855; bh=mWjnFNvzepxM9 0lSc+OOQwduG8sRnhr4PdJP/q1hvoQ=; b=KiE1iVJ3JifNjDNCeVPeEhzreHnj3 LXVvywWxEhHfyMeQvna8NgxoUudcCQgxRM5G8jpUpFFQwKk4ye7AVc125mzBZdLr 10wa+IXcjBCQZ0JIi6J+loG+u93b4R+7EchczP/kPyPiKoLtstjJQ0vD7vKrV6CJ 9AQuqqPMURqIthmjxRtr2iQ0oPA/qivNRnGPFjR/MC/TQLx630pKNmImDuDE55E2 FjFN3akAfMhoPbGeoUThph6qY4UIviGAFWOr+EGCAm309wGwN9jSCNg4hjnE8vAw ukmyxiskbj1ty2LMnGjPR7xZmoF7sG08dwxUvjp3Pu9kjOe1ZBBdh6GnA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdefuddguddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesthdttddttddtvdenucfhrhhomhepfdfmihhr ihhllhcutedrucfuhhhuthgvmhhovhdfuceokhhirhhilhhlsehshhhuthgvmhhovhdrnh grmhgvqeenucggtffrrghtthgvrhhnpefhieeghfdtfeehtdeftdehgfehuddtvdeuheet tddtheejueekjeegueeivdektdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmh epmhgrihhlfhhrohhmpehkihhrihhllhesshhhuhhtvghmohhvrdhnrghmvg X-ME-Proxy: Feedback-ID: ie3994620:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 16 Mar 2023 19:30:54 -0400 (EDT) Received: by box.shutemov.name (Postfix, from userid 1000) id 4B65910C9F7; Fri, 17 Mar 2023 02:30:53 +0300 (+03) Date: Fri, 17 Mar 2023 02:30:53 +0300 From: "Kirill A. Shutemov" To: Mike Kravetz , Vineet Gupta Cc: "Kirill A. Shutemov" , Andrew Morton , Mel Gorman , Vlastimil Babka , David Hildenbrand , linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 10/10] mm, treewide: Redefine MAX_ORDER sanely Message-ID: <20230316233053.iwsffmfxzzacnkuy@box.shutemov.name> References: <20230315113133.11326-1-kirill.shutemov@linux.intel.com> <20230315113133.11326-11-kirill.shutemov@linux.intel.com> <20230316181547.GA6211@monkey> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230316181547.GA6211@monkey> X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 66871180017 X-Stat-Signature: msgm848ejy4xke5n5j87kwac8ofdezjo X-HE-Tag: 1679009456-782255 X-HE-Meta: U2FsdGVkX18Sdw7JOXydQPa5zh3yp3Ds2//2gLADrMt74fqBPS+bOsfOeI0xg3N3NsNc8A0DtjzlAF2pI0vFFeFaQwGOM7bgj99SvuaRe/ucgM2+UOn81vP1wHVzo+QF7P8Kjyf1fJu21yQ8a4dJaAxNVdaUCfDGH1sg1l+q1lI6XJamGFUBUbGXyd7CkymgWRsl7LKD4Ftlqi3gHriIKTfpqhD/A6Z63L+MCO39dVV8ga/xGts0iXcq3S5Em3cb6AqN3ONS0SIKbTVYMQNOYs0R2ypRv2MEKNjy5nl+/5V2oUNEpFqpsP5cDqqBA8/+FiId7VUv0T3HyegfJZK0ltV+JWQOZS2MopsSe6xqN1Ur4gKgIDqsZoBf0DQYz97I0IXp5sr7iahqQ3c/tkPvIRUSFbbxpk6WIDlnK4WbmrTuy5GqzMSr3ahIG2S5wJLwBiOcmnmKnfpcQTZlGkx8fFGCE/S7P575YknHIZQReR9Q3tQ+rmhBcRDuAB1nL6EP29NLpaFsXScML+l11SdZq0GOuXRu6z/YhMUvVWBCBz24z4BVvHOd/cjsbtQuZh/6Mmv653f9TNgF4pMcbmilvpCU2IypN1AX3AQGwSul55n7J+UTQBm1MvxQrGcuntHflj3/xi9Jcf42B2Cam04CjZhWMnIqZE5xqjcv6U6qXVKU+fOiMK9zZRUCMVe3DHaqSNckJutkrrH/FJldsoior7BEUpo37IWb7u2xzmkaxr9c0zB60D2SCqXAmfBX0EKrYsR21M2b1lPSCR/Vyz4eYfx5tajon3cyE5zSLwLk0xv9Cm4uj26VPnModUKf7SXgC37pcb0+RhDFOJyMkdHSpgd9GqGGEDmyUu9+vw95IISODuzhtboRhCPHQmp1oid0fSM92wov4sreohtii1+0ue4hVUzvKiegg3iRc+m/WEJ7onPaQ7x0Jl8AGWPS3q5fQ1nJ1LC8S3tf9hWgHLU KYh/F0l8 PCch2SyxfRlmOBNNDAXi09jQ8TRxtgNKF9Q0rCrxQQ8K0krmQgAucRj2xXDduTGVJ3J6T4Aa9tCFYOFn6VtfAJhSZGGbkqadC3W673bYImW/VK6JETaNMm+J/AuCAJpFfO5cjstfAct4Mii2ZQSUjFnddQUdxMiF+L+T5e/3lCI7PrIWGhStrZ/JhpB8iDJQsDmi0XB+jHIkkLDVGVRZlwr/LxWxypGujOeIuVXPl/GnHwpBRDJCGeFWh7aXj1X5lv2QX5nP9XV42qoQUeSAlzcdsD5tR1U4sbdlMjaK0IHwce7M4veC8L/kk8HZpXw+cPVsl+Gf56zU4Rw8Vd4pMfwJTRTAkcNDkJQTlQoYM3lDBvTA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 16, 2023 at 11:15:47AM -0700, Mike Kravetz wrote: > On 03/15/23 14:31, Kirill A. Shutemov wrote: > > MAX_ORDER currently defined as number of orders page allocator supports: > > user can ask buddy allocator for page order between 0 and MAX_ORDER-1. > > > > This definition is counter-intuitive and lead to number of bugs all over > > the kernel. > > > > Change the definition of MAX_ORDER to be inclusive: the range of orders > > user can ask from buddy allocator is 0..MAX_ORDER now. > > > > --- a/arch/arc/Kconfig > > +++ b/arch/arc/Kconfig > > @@ -556,7 +556,7 @@ endmenu # "ARC Architecture Configuration" > > > > config ARCH_FORCE_MAX_ORDER > > int "Maximum zone order" > > - default "12" if ARC_HUGEPAGE_16M > > - default "11" > > + default "11" if ARC_HUGEPAGE_16M > > + default "10" > > Is this Kconfig file wrong (off by 1) today? It seems like it wants MAX_ORDER > to be sufficiently large to allocate 16M if ARC_HUGEPAGE_16M. So, seems like > it should be 13 today? +Vineet. Hm. I think it is okay as long as CONFIG_ARC_PAGE_SIZE_8K=y which is default, but breaks for other PAGE_SIZE. Looks like ARCH_FORCE_MAX_ORDER calculation should involve selected page size. -- Kiryl Shutsemau / Kirill A. Shutemov