From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C685C6FD1F for ; Thu, 16 Mar 2023 16:05:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7E873900003; Thu, 16 Mar 2023 12:05:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 79805900002; Thu, 16 Mar 2023 12:05:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6864B900003; Thu, 16 Mar 2023 12:05:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 58345900002 for ; Thu, 16 Mar 2023 12:05:30 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id F17B21408D2 for ; Thu, 16 Mar 2023 16:05:29 +0000 (UTC) X-FDA: 80575236378.07.9CD28F5 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf15.hostedemail.com (Postfix) with ESMTP id 2D86CA0022 for ; Thu, 16 Mar 2023 16:05:26 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=H5XSWADr; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf15.hostedemail.com: domain of nathan@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=nathan@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678982727; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rBuZwIWk6njNYF6jYzQqSqcUyIQ/46OOkwIZJafnIAA=; b=Moz9l6uX6fd9idzNebfZIlRF7DwdWne5x1mzXtgl4WdPFHkix48u3cmM/bbHRwnEInU2na NBSYL/Sb/ZwvoxRuO6ef7GZWw6vNI0b0x1WusEc8Kf46WJs65iGwJ0BP+oggMepZtRZOyQ 3UnOl2C6YVIKK5eXTaKBdvpXq/ip4eI= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=H5XSWADr; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf15.hostedemail.com: domain of nathan@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=nathan@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678982727; a=rsa-sha256; cv=none; b=XMYuAG46y1pT33om91SpHdG1YQhedqTWL9gf1ca37UjakB7ScLX+IuuyKD6RiUWIK95VCZ 8ZiO5Jb7/nv6N+hvXmRJdbgoRn+eswV3m45XWvIIk1GHG22O+SPKriXzgFUIsYnvFua3ks 68kkJQnISGhEY0O8WlxE3v4VB4BqtRQ= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3070462091; Thu, 16 Mar 2023 16:05:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3393CC433EF; Thu, 16 Mar 2023 16:05:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678982725; bh=wCjMzefZYuq8Xl/D934vkQjE/JUkIvDeFrgX4FHEZYM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=H5XSWADrmTpAMmvxGsW/DVhOtBXey98Ad5sM7CNzp1/Y0ouOgenv1MpbGlY7BrAMx hp4PcaPGukGHin0W7lOB5rkOjlJmUiTXXmjtReh7O0c4Q3vzY+XJoeNwXC9/UksaaF +jpg9Gj7dU22mxU6PjDnJZzSHANcrmbjHS8PmNQwgF+eqhBCKXsd41ChuMA1tuuu4Y Vxn9FYOiXQdyPyRFiVvQqHbWSJDce4NtHsxn/SYmqSyB6h+HU7ZPuTQ4U6wGzE3q7g 6iV+XmzAxq9OyEVg+1zXHD4SZnXL84voHgzdDHS3pApkE6dvysdNt8emEcHzKN6J8u +CniMVLh7o9EQ== Date: Thu, 16 Mar 2023 09:05:23 -0700 From: Nathan Chancellor To: Marco Elver Cc: Andrew Morton , Alexander Potapenko , Dmitry Vyukov , kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] kfence, kcsan: avoid passing -g for tests Message-ID: <20230316160523.GA90073@dev-arch.thelio-3990X> References: <20230316155104.594662-1-elver@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230316155104.594662-1-elver@google.com> X-Rspamd-Queue-Id: 2D86CA0022 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: i9qu9hgzm4nkuxa7q6t4dxhd161uajkp X-HE-Tag: 1678982726-689805 X-HE-Meta: U2FsdGVkX1+NoEoTET/6RKO9Uz7A+xesMGirWkhae7gqPauVEpc8Ft0yDk2X7S5zBk3juacWl4X3G8G1I+UlvoKyVVCp4cyT/7CPJffwemv/sDSctn+LvNc5HLnitPIM8r4uMoR7qBXl7ZpYqDGGs3f68ed+gWjXdKGBmLFXb4ZdE13T06agWgZaomiwS98kdNJyFyhHDRh3XtrjayDCzgYp/EhRJ0LNBekLry1ZCEKeeSUptVC8kmRggL/aExJleK9m3nSg3Q9xrs9HNWCXbxf39DXflO1LvSUe8hSBRQZslLNbrXRbm+cPL9gTjRfMfMdWkfxUW11WV3/gPLxtHXBncvE9wOjf+/DJGzlAWj2UU5x6kKmiWoc6NzSH49WJRhX2d2HEISG/qvyaksozv8PFsPup6D4MYy1KGci93OWlFIW3qDfwVGcS4Kf0vyebUQFyJkm8mH+qMo/n4g+3KAdGvOdBQovLOL5gFiIk9bXw1j69ILRY+PHD9EFq53EJL729bdharT3q8WLb6+LRjE62DKq817SWhXXB+IIxLFBPX6QgLSt8Y6eyNZRCH0+h2Vib87ua2Jv/GxR3cM7GAdADuT6GZWDl/V86smFCgynXgpxd4cQ+2aMa4jf+mfKFJ9HS99FIfl99UbOawF3pnikn6aFkJ3DYHJFbgpbWCmwvNJOwEl44T8gm6gLbl/JIs1Tih2UqlOX3dGUy4Ingn1fvCLlE7qzMQVRppIkjE416KGn9w+oYx/WnpkRohvXx8SfJxKlzoDAeSzx8PTz+J2HgsT3styXygeFY2vRNbJHbA7L9OxsWycCj9qzCibUUx8dqFOkAH5QUqjEKnUilIZ1aVkEq6gKL84RIsugqMpcY5CrPrqxzy4KGXj2oQGMo4/i3ovQYmoWDbPdqAflOUnJBysaVpTySRXerWKRxZm0pUc3+7Fqsml3V6uPv60kDiVFc4or/JAMd5ckHVjz 1aoF/4LT Q13xkjkRnpogSVSPbgwN7uDsg4wffjfUDesP1oEUVhWTS6YBhy2NGI3qiogtM8a4TglWGhWTv481SnBXY/d4BEyW1sP2NvxiHkNtytIA2Z32m3I4C/6apJKtcBDX7n/v/n6+AS+11dSTIcUmMylBjQgCEm4SEeYQq0kdfR2YRoIEtb7+bJ4CsNV4tgxfVA3OXOelJfQUUn6GfcIhY789dKNHDNn68+d6M34VF3TyelIW2sEi8j2xEETqYesc5y+O+j9AKKC1tW5o19vLEv7jXQ3uTEfa+0dEJWRpP8cT88Xu4HsmyxS1dmGqy8MFwYejrbZXExuSuHxImc7It0NJ//wV+a3G5Kj6I3tap5jk6aulrsy3zSJK06+MmEuRlrlVlG6G3 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 16, 2023 at 04:51:04PM +0100, Marco Elver wrote: > Nathan reported that when building with GNU as and a version of clang > that defaults to DWARF5: > > $ make -skj"$(nproc)" ARCH=riscv CROSS_COMPILE=riscv64-linux-gnu- \ > LLVM=1 LLVM_IAS=0 O=build \ > mrproper allmodconfig mm/kfence/kfence_test.o > /tmp/kfence_test-08a0a0.s: Assembler messages: > /tmp/kfence_test-08a0a0.s:14627: Error: non-constant .uleb128 is not supported > /tmp/kfence_test-08a0a0.s:14628: Error: non-constant .uleb128 is not supported > /tmp/kfence_test-08a0a0.s:14632: Error: non-constant .uleb128 is not supported > /tmp/kfence_test-08a0a0.s:14633: Error: non-constant .uleb128 is not supported > /tmp/kfence_test-08a0a0.s:14639: Error: non-constant .uleb128 is not supported > ... > > This is because `-g` defaults to the compiler debug info default. If the > assembler does not support some of the directives used, the above errors > occur. To fix, remove the explicit passing of `-g`. > > All these tests want is that stack traces print valid function names, > and debug info is not required for that. I currently cannot recall why I > added the explicit `-g`. > > Reported-by: Nathan Chancellor > Signed-off-by: Marco Elver Thanks for the quick patch! Reviewed-by: Nathan Chancellor > --- > kernel/kcsan/Makefile | 2 +- > mm/kfence/Makefile | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/kernel/kcsan/Makefile b/kernel/kcsan/Makefile > index 8cf70f068d92..a45f3dfc8d14 100644 > --- a/kernel/kcsan/Makefile > +++ b/kernel/kcsan/Makefile > @@ -16,6 +16,6 @@ obj-y := core.o debugfs.o report.o > KCSAN_INSTRUMENT_BARRIERS_selftest.o := y > obj-$(CONFIG_KCSAN_SELFTEST) += selftest.o > > -CFLAGS_kcsan_test.o := $(CFLAGS_KCSAN) -g -fno-omit-frame-pointer > +CFLAGS_kcsan_test.o := $(CFLAGS_KCSAN) -fno-omit-frame-pointer > CFLAGS_kcsan_test.o += $(DISABLE_STRUCTLEAK_PLUGIN) > obj-$(CONFIG_KCSAN_KUNIT_TEST) += kcsan_test.o > diff --git a/mm/kfence/Makefile b/mm/kfence/Makefile > index 0bb95728a784..2de2a58d11a1 100644 > --- a/mm/kfence/Makefile > +++ b/mm/kfence/Makefile > @@ -2,5 +2,5 @@ > > obj-y := core.o report.o > > -CFLAGS_kfence_test.o := -g -fno-omit-frame-pointer -fno-optimize-sibling-calls > +CFLAGS_kfence_test.o := -fno-omit-frame-pointer -fno-optimize-sibling-calls > obj-$(CONFIG_KFENCE_KUNIT_TEST) += kfence_test.o > -- > 2.40.0.rc1.284.g88254d51c5-goog >