From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B09DC74A5B for ; Thu, 16 Mar 2023 22:34:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CB457900004; Thu, 16 Mar 2023 18:34:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C6489900002; Thu, 16 Mar 2023 18:34:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B2C2D900004; Thu, 16 Mar 2023 18:34:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id A13CD900002 for ; Thu, 16 Mar 2023 18:34:01 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 75BAC12010A for ; Thu, 16 Mar 2023 22:34:01 +0000 (UTC) X-FDA: 80576215482.04.E25680E Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf05.hostedemail.com (Postfix) with ESMTP id AAB1C100014 for ; Thu, 16 Mar 2023 22:33:58 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=fYPeQi0l; dmarc=none; spf=pass (imf05.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679006038; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uyFd85UNzU7sYn9+aS07IUk5elz8iS2M6TGrZaSrwgk=; b=5wX39M/LGaJWWi5uFqrt5lq/S1srVPvBvWAIzkPCK2Yig7qEwd8aVOaeTghvAwhlxmCKUq 23hYXL9qYnFyzkl25nop+FRgXMaT1h5vAwlrKiln5p6SphzvrulnH5T9rmuYFKbcZnXDC0 hfM1OZd9+z2RHdtovyIqgTB522o9mxA= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=fYPeQi0l; dmarc=none; spf=pass (imf05.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679006038; a=rsa-sha256; cv=none; b=hmKAmbu7hVL49+QYcPwYsgsFZEqP0f0jMGLoLbwEI5M1A+NcVCFaPcJAByhDKT0mr9yvQr DeJcq1jyP3YYlwmP7qUz7stdgtI5hsQc7POHhv01LKNFkPdovzw+MryOJS1O13JK3Zf7A1 2yTqKNDnzdeellm5dcv2I7F9bVxVgns= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id F2E28B82347; Thu, 16 Mar 2023 22:33:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7BB5EC433EF; Thu, 16 Mar 2023 22:33:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1679006035; bh=w4XOX2cU6kWPrGSypzqJwl9GB+zrKQD9lnQHI4Vl09k=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=fYPeQi0lFmGdWl4DBx4G6g2x06lt+UllisB6eaiCfgpDsIJaR6iuwkjfZ63XzfFWk XxN/v5bJKwA8EpKZoNo7q50Uk7mKzDgRu2e5slOMiHgJwYr1IAua+3Y2UyR6Gj8Tsa ee8XNhC4z2vWNbadrjRjy5CyyN6mgXHAgxfUmTWA= Date: Thu, 16 Mar 2023 15:33:54 -0700 From: Andrew Morton To: Marco Elver Cc: Alexander Potapenko , Dmitry Vyukov , kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Nathan Chancellor Subject: Re: [PATCH] kfence, kcsan: avoid passing -g for tests Message-Id: <20230316153354.bc31b9583eae6a79a1789de0@linux-foundation.org> In-Reply-To: <20230316155104.594662-1-elver@google.com> References: <20230316155104.594662-1-elver@google.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: AAB1C100014 X-Stat-Signature: c11mqnuir7n8ibz3rtczso7wkyedsen9 X-HE-Tag: 1679006038-270100 X-HE-Meta: U2FsdGVkX18WB288ZIyh0inUvBtCKlksoXsfQPeI4GmM2NmLtBn2Og5/sOiE8pndt8auvCQ4Be9H+gXugR5PwoGNJ1tBj4hTwEd7TOmjQe0i2oXA5jh+ZkRLEZXatVh2/aFx1qOppOEe8EQU20/a1wZv8tciK3jH/zvHfE8URNT3cDN8nGJyJfxsGFM5VIcyJlwCQSneK0j1wSJ+zB3SGtwPim9LmJOgKMP7dhvI2H38a6TaZZwG7rejtcyLratnJClDWlGGbd2iXRW54m7JKa1RC3BRRErsh+msYD1wfvqdH4GBslUVSClwHzEVK38vb7E93ozYlVvLCWxl6kVWV90u7WBxjD5z+4OMB0w5ElUSysH/ZrdXpRwrG8eQSO9/grlTq6Y+EggyR+NDnvbAfSYq2d5GQzLcy7hrQgrodBqNXsxWejtFhNgDp/MP9p2SHSGjUmLVTDVGPATJQI0XQaY+gJCaIXxSDjK0VyYmLJ9W7qF0ZwaKMWrVfa5JH36ERG+ddgHPME0wU29Q5TPoiJ4+hhhxaqRd4MEOUf+eL0O02zjy6EsZ3bfT12akAylfFuz4+yxhJu/eyv+8gPsEdEGG+vn5z6Q9yxwx+JSpCit5yt9+B5TEi4HsiO3+R0kQv3KdRsJrm5V5fvMabqYH5r55L4dHdCDXzD+10dljHXnGf8QTn6fC9ENOgdtro5+5cPYEwH/K497PeCgNpVhAZh8jAOJ/Gs8VwiVLp88VjSlIeDB3RS9Jyko17pLCotF4hlMywHYiPY/xIufc62cW3plO+0sugoExo1EZNcWr8o/hiovD6Yn8C5QUYNsT3nTHibzSQltOwyn7oZe6dsBtuTW7/u0MULHlU9ZlSfpqMmB36mPFYG/2wxCADRm1SuA0wMWQHxuxp4qYxkIz5IrP+kE7wkeEpns4iQ5yMhU3WG3GBtW4EUppR9n5AA5RCL5kr1uWHLXVLu0npVyBgvM wGLz9CX9 J2OhGxD3kqcjrB6paXxdZhxkNexzu6yZ65udnFj/L44esGNSc7R1MJ4XpqzVZrFA24XTYHdljrVRLb/QntyfYXhPUD24ECtlaCdCu7i4orqcbDUPfhHmWxUEKdUZA+DmNBPnKtqtesA2WngjWBwmVM+s0eLiWGctNqbTDW0bgRJh/KYjVoxdiqbIvmq0B5+Xv8bond8nlRAJQf6pXKP6p63jQi3MkIiIvwSFBndCbght+G1KAAeYmGIoeOw+Nf/izJwCrRsBIG/otHVY1+CHmBwJDNdPRlE0/v8w+Pk7V5akzP2/cS5kN03jsofp5IUmZ616mVm4LhJyJumEJxD3y+0+/LX7vP3qT9vLpvYNRyleYZeNNBLMTZotasg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 16 Mar 2023 16:51:04 +0100 Marco Elver wrote: > Nathan reported that when building with GNU as and a version of clang > that defaults to DWARF5: > > $ make -skj"$(nproc)" ARCH=riscv CROSS_COMPILE=riscv64-linux-gnu- \ > LLVM=1 LLVM_IAS=0 O=build \ > mrproper allmodconfig mm/kfence/kfence_test.o > /tmp/kfence_test-08a0a0.s: Assembler messages: > /tmp/kfence_test-08a0a0.s:14627: Error: non-constant .uleb128 is not supported > /tmp/kfence_test-08a0a0.s:14628: Error: non-constant .uleb128 is not supported > /tmp/kfence_test-08a0a0.s:14632: Error: non-constant .uleb128 is not supported > /tmp/kfence_test-08a0a0.s:14633: Error: non-constant .uleb128 is not supported > /tmp/kfence_test-08a0a0.s:14639: Error: non-constant .uleb128 is not supported > ... > > This is because `-g` defaults to the compiler debug info default. If the > assembler does not support some of the directives used, the above errors > occur. To fix, remove the explicit passing of `-g`. > > All these tests want is that stack traces print valid function names, > and debug info is not required for that. I currently cannot recall why I > added the explicit `-g`. Does this need to be backported into earlier kernels? If so, we'd need to do it as two patches, each with the relevant Fixes:, which appear to be a146fed56f8 and bc8fbc5f30.